android_kernel_motorola_sm6375/fs/f2fs
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Qi Han ac8aaf78bd f2fs: fix f2fs_bug_on when uninstalling filesystem call f2fs_evict_inode.
[ Upstream commit d5c367ef8287fb4d235c46a2f8c8d68715f3a0ca ]

creating a large files during checkpoint disable until it runs out of
space and then delete it, then remount to enable checkpoint again, and
then unmount the filesystem triggers the f2fs_bug_on as below:

------------[ cut here ]------------
kernel BUG at fs/f2fs/inode.c:896!
CPU: 2 UID: 0 PID: 1286 Comm: umount Not tainted 6.11.0-rc7-dirty #360
Oops: invalid opcode: 0000 [#1] PREEMPT SMP NOPTI
RIP: 0010:f2fs_evict_inode+0x58c/0x610
Call Trace:
 __die_body+0x15/0x60
 die+0x33/0x50
 do_trap+0x10a/0x120
 f2fs_evict_inode+0x58c/0x610
 do_error_trap+0x60/0x80
 f2fs_evict_inode+0x58c/0x610
 exc_invalid_op+0x53/0x60
 f2fs_evict_inode+0x58c/0x610
 asm_exc_invalid_op+0x16/0x20
 f2fs_evict_inode+0x58c/0x610
 evict+0x101/0x260
 dispose_list+0x30/0x50
 evict_inodes+0x140/0x190
 generic_shutdown_super+0x2f/0x150
 kill_block_super+0x11/0x40
 kill_f2fs_super+0x7d/0x140
 deactivate_locked_super+0x2a/0x70
 cleanup_mnt+0xb3/0x140
 task_work_run+0x61/0x90

The root cause is: creating large files during disable checkpoint
period results in not enough free segments, so when writing back root
inode will failed in f2fs_enable_checkpoint. When umount the file
system after enabling checkpoint, the root inode is dirty in
f2fs_evict_inode function, which triggers BUG_ON. The steps to
reproduce are as follows:

dd if=/dev/zero of=f2fs.img bs=1M count=55
mount f2fs.img f2fs_dir -o checkpoint=disable:10%
dd if=/dev/zero of=big bs=1M count=50
sync
rm big
mount -o remount,checkpoint=enable f2fs_dir
umount f2fs_dir

Let's redirty inode when there is not free segments during checkpoint
is disable.

Signed-off-by: Qi Han <hanqi@vivo.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-12-14 19:44:54 +01:00
..
acl.c f2fs: enhance to update i_mode and acl atomically in f2fs_setattr() 2024-11-08 16:20:32 +01:00
acl.h
checkpoint.c f2fs: fix to drop all dirty pages during umount() if cp_error is set 2023-05-30 12:44:03 +01:00
data.c f2fs: fix to drop all dirty pages during umount() if cp_error is set 2023-05-30 12:44:03 +01:00
debug.c
dir.c f2fs: prevent possible int overflow in dir_block_index() 2024-11-08 16:20:34 +01:00
extent_cache.c
f2fs.h f2fs: reduce expensive checkpoint trigger frequency 2024-11-08 16:20:32 +01:00
file.c f2fs: Require FMODE_WRITE for atomic write ioctls 2024-11-08 16:20:36 +01:00
gc.c f2fs: fix to do sanity check on inode type during garbage collection 2023-11-08 11:23:38 +01:00
gc.h
hash.c
inline.c
inode.c f2fs: fix f2fs_bug_on when uninstalling filesystem call f2fs_evict_inode. 2024-12-14 19:44:54 +01:00
Kconfig
Makefile
namei.c f2fs: fix to avoid dirent corruption 2024-01-25 14:34:27 -08:00
node.c f2fs: fix to release node block count in error path of f2fs_new_node_page() 2024-06-16 13:28:43 +02:00
node.h
recovery.c f2fs: fix to check return value of f2fs_reserve_new_block() 2024-02-23 08:25:00 +01:00
segment.c f2fs: fix to do sanity check in update_sit_entry 2024-09-04 13:14:56 +02:00
segment.h
shrinker.c
super.c f2fs: avoid potential int overflow in sanity_check_area_boundary() 2024-11-08 16:20:34 +01:00
sysfs.c
trace.c
trace.h
verity.c
xattr.c f2fs: reduce expensive checkpoint trigger frequency 2024-11-08 16:20:32 +01:00
xattr.h