Repository files (latest commit first)

Filename	Latest commit message	Latest commit date
Daniel Borkmann 81d947e2b8 net, sched: fix panic when updating miniq {b,q}stats ... While working on fixing another bug, I ran into the following panic on arm64 by simply attaching clsact qdisc, adding a filter and running traffic on ingress to it: [...] [ 178.188591] Unable to handle kernel read from unreadable memory at virtual address 810fb501f000 [ 178.197314] Mem abort info: [ 178.200121] ESR = 0x96000004 [ 178.203168] Exception class = DABT (current EL), IL = 32 bits [ 178.209095] SET = 0, FnV = 0 [ 178.212157] EA = 0, S1PTW = 0 [ 178.215288] Data abort info: [ 178.218175] ISV = 0, ISS = 0x00000004 [ 178.222019] CM = 0, WnR = 0 [ 178.224997] user pgtable: 4k pages, 48-bit VAs, pgd = 0000000023cb3f33 [ 178.231531] [0000810fb501f000] *pgd=0000000000000000 [ 178.236508] Internal error: Oops: 96000004 [#1] SMP [...] [ 178.311855] CPU: 73 PID: 2497 Comm: ping Tainted: G W 4.15.0-rc7+ #5 [ 178.319413] Hardware name: FOXCONN R2-1221R-A4/C2U4N_MB, BIOS G31FB18A 03/31/2017 [ 178.326887] pstate: 60400005 (nZCv daif +PAN -UAO) [ 178.331685] pc : __netif_receive_skb_core+0x49c/0xac8 [ 178.336728] lr : __netif_receive_skb+0x28/0x78 [ 178.341161] sp : ffff00002344b750 [ 178.344465] x29: ffff00002344b750 x28: ffff810fbdfd0580 [ 178.349769] x27: 0000000000000000 x26: ffff000009378000 [...] [ 178.418715] x1 : 0000000000000054 x0 : 0000000000000000 [ 178.424020] Process ping (pid: 2497, stack limit = 0x000000009f0a3ff4) [ 178.430537] Call trace: [ 178.432976] __netif_receive_skb_core+0x49c/0xac8 [ 178.437670] __netif_receive_skb+0x28/0x78 [ 178.441757] process_backlog+0x9c/0x160 [ 178.445584] net_rx_action+0x2f8/0x3f0 [...] Reason is that sch_ingress and sch_clsact are doing mini_qdisc_pair_init() which sets up miniq pointers to cpu_{b,q}stats from the underlying qdisc. Problem is that this cannot work since they are actually set up right after the qdisc ->init() callback in qdisc_create(), so first packet going into sch_handle_ingress() tries to call mini_qdisc_bstats_cpu_update() and we therefore panic. In order to fix this, allocation of {b,q}stats needs to happen before we call into ->init(). In net-next, there's already such option through commit d59f5ffa59 ("net: sched: a dflt qdisc may be used with per cpu stats"). However, the bug needs to be fixed in net still for 4.15. Thus, include these bits to reduce any merge churn and reuse the static_flags field to set TCQ_F_CPUSTATS, and remove the allocation from qdisc_create() since there is no other user left. Prashant Bhole ran into the same issue but for net-next, thus adding him below as well as co-author. Same issue was also reported by Sandipan Das when using bcc. Fixes: 46209401f8 ("net: core: introduce mini_Qdisc and eliminate usage of tp->q for clsact fastpath") Reference: https://lists.iovisor.org/pipermail/iovisor-dev/2018-January/001190.html Reported-by: Sandipan Das <sandipan@linux.vnet.ibm.com> Co-authored-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp> Co-authored-by: John Fastabend <john.fastabend@gmail.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Cc: Jiri Pirko <jiri@resnulli.us> Signed-off-by: David S. Miller <davem@davemloft.net>		2018-01-16 15:02:36 -05:00
..
9p	9p: Implement show_options	2017-07-11 06:08:58 -04:00
bluetooth	Bluetooth: Use bt_dev_err and bt_dev_info when possible	2017-10-30 12:25:45 +02:00
caif
iucv	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
netfilter	Modules updates for v4.15	2017-11-15 13:46:33 -08:00
netns	tcp: Namespace-ify sysctl_tcp_default_congestion_control	2017-11-15 14:09:52 +09:00
nfc
phonet	net: phonet: mark phonet_protocol as const	2017-10-07 23:15:08 +01:00
sctp	sctp: fix the handling of ICMP Frag Needed for too small MTUs	2018-01-08 14:19:13 -05:00
tc_act	act_sample: get rid of tcf_sample_cleanup_rcu()	2017-11-30 10:19:17 -05:00
6lowpan.h
act_api.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-11-10 10:00:18 +09:00
addrconf.h	ipv6: remove IN6_ADDR_HSIZE from addrconf.h	2017-11-05 09:17:27 +09:00
af_ieee802154.h
af_rxrpc.h	rxrpc: Provide functions for allowing cleaner handling of signals	2017-10-18 11:42:48 +01:00
af_unix.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
af_vsock.h	VSOCK: use TCP state constants for sk_state	2017-10-05 18:44:17 -07:00
ah.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
arp.h	ipv4: Make neigh lookup keys for loopback/point-to-point devices be INADDR_ANY	2018-01-15 14:53:43 -05:00
atmclip.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ax25.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ax88796.h
bond_3ad.h
bond_alb.h
bond_options.h
bonding.h	bonding: remove rtmsg_ifinfo called after bond_lower_state_changed	2017-10-25 10:54:39 +09:00
busy_poll.h	net: fix compilation when busy poll is not enabled	2017-08-11 14:59:24 -07:00
calipso.h	net, calipso: convert calipso_doi.refcount from atomic_t to refcount_t	2017-07-04 22:35:16 +01:00
cfg80211-wext.h
cfg80211.h	mac80211_hwsim: validate number of different channels	2018-01-15 09:34:45 +01:00
cfg802154.h
checksum.h
cipso_ipv4.h	net, ipv4: convert cipso_v4_doi.refcount from atomic_t to refcount_t	2017-07-04 01:29:04 -07:00
cls_cgroup.h
codel.h
codel_impl.h
codel_qdisc.h
compat.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
datalink.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
dcbevent.h
dcbnl.h
devlink.h	devlink: Add IPv6 header for dpipe	2017-08-31 14:42:19 -07:00
dn.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-11-04 09:26:51 +09:00
dn_dev.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
dn_fib.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
dn_neigh.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
dn_nsp.h	net/decnet: Convert timers to use timer_setup()	2017-10-18 12:39:36 +01:00
dn_route.h
dsa.h	net: dsa: Support prepended Broadcom tag	2017-11-13 10:34:54 +09:00
dsfield.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
dst.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-11-04 09:26:51 +09:00
dst_cache.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
dst_metadata.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-11-04 09:26:51 +09:00
dst_ops.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
erspan.h	gre: introduce native tunnel support for ERSPAN	2017-08-22 14:29:30 -07:00
esp.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ethoc.h
fib_notifier.h	net: Add extack to fib_notifier_info	2017-11-01 11:50:43 +09:00
fib_rules.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
firewire.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
flow.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
flow_dissector.h	tipc: improve link resiliency when rps is activated	2017-11-11 15:36:05 +09:00
fou.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
fq.h	fq: support filtering a given tin	2017-10-11 09:49:34 +02:00
fq_impl.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-10-30 21:09:24 +09:00
garp.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
gen_stats.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
genetlink.h	genetlink: fix genlmsg_nlhdr()	2017-11-16 10:49:00 +09:00
geneve.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
gre.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
gro_cells.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
gtp.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
gue.h	fou: fix some member types in guehdr	2017-12-11 14:10:06 -05:00
hwbm.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
icmp.h
ieee80211_radiotap.h
ieee802154_netdev.h
if_inet6.h	net, ipv6: convert ifacaddr6.aca_refcnt from atomic_t to refcount_t	2017-07-04 01:29:04 -07:00
ife.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ila.h
inet6_connection_sock.h
inet6_hashtables.h	net: ipv6: add second dif to inet6 socket lookups	2017-08-07 11:39:22 -07:00
inet_common.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
inet_connection_sock.h	inet/connection_sock: Convert timers to use timer_setup()	2017-10-18 12:39:55 +01:00
inet_ecn.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-11-04 09:26:51 +09:00
inet_frag.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-11-04 09:26:51 +09:00
inet_hashtables.h	net: ipv4: add second dif to inet socket lookups	2017-08-07 11:39:21 -07:00
inet_sock.h	Merge branch 'akpm' (patches from Andrew)	2017-11-15 19:42:40 -08:00
inet_timewait_sock.h	kmemcheck: remove annotations	2017-11-15 18:21:04 -08:00
inetpeer.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ip.h	ipv4: igmp: guard against silly MTU values	2017-12-13 13:13:58 -05:00
ip6_checksum.h
ip6_fib.h	ipv6: take care of rt6_stats	2017-10-07 21:22:58 +01:00
ip6_route.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-11-04 09:26:51 +09:00
ip6_tunnel.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ip_fib.h	net: ipv4: remove fib_weight	2017-09-29 06:19:32 +01:00
ip_tunnels.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-11-04 09:26:51 +09:00
ip_vs.h	Merge branch 'linus' into locking/core, to resolve conflicts	2017-11-07 10:32:44 +01:00
ipcomp.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ipconfig.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ipv6.h	net: accept UFO datagrams from tuntap and packet	2017-11-24 01:37:35 +09:00
ipx.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
iw_handler.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
kcm.h
l3mdev.h
lapb.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
lib80211.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
llc.h	net, llc: convert llc_sap.refcnt from atomic_t to refcount_t	2017-07-04 22:35:15 +01:00
llc_c_ac.h	net: LLC: Convert timers to use timer_setup()	2017-10-25 12:06:25 +09:00
llc_c_ev.h
llc_c_st.h
llc_conn.h
llc_if.h
llc_pdu.h
llc_s_ac.h
llc_s_ev.h
llc_s_st.h
llc_sap.h
lwtunnel.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
mac80211.h	mac80211: use QoS NDP for AP probing	2017-11-27 11:23:20 +01:00
mac802154.h
mip6.h
mld.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
mpls.h
mpls_iptunnel.h
mrp.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ncsi.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ndisc.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
neighbour.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-11-04 09:26:51 +09:00
net_namespace.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
net_ratelimit.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
netevent.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-11-04 09:26:51 +09:00
netlabel.h
netlink.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
netprio_cgroup.h
netrom.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nexthop.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
nl802154.h
nsh.h	openvswitch: enable NSH support	2017-11-08 16:12:33 +09:00
p8022.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ping.h
pkt_cls.h	cls_bpf: fix offload assumptions after callback conversion	2017-12-20 13:08:18 -05:00
pkt_sched.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-11-04 09:26:51 +09:00
pptp.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
protocol.h	IPv4: early demux can return an error code	2017-10-01 03:55:47 +01:00
psample.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
psnap.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
raw.h	net: ipv4: add second dif to raw socket lookups	2017-08-07 11:39:21 -07:00
rawv6.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
red.h	net_sched: red: Avoid illegal values	2017-12-05 14:37:13 -05:00
regulatory.h
request_sock.h	tcp: socket option to set TCP fast open key	2017-10-20 13:21:36 +01:00
rose.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
route.h	udp: perform source validation for mcast early demux	2017-10-01 03:55:47 +01:00
rtnetlink.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-11-04 09:26:51 +09:00
sch_generic.h	net, sched: fix panic when updating miniq {b,q}stats	2018-01-16 15:02:36 -05:00
scm.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
secure_seq.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
seg6.h	ipv6: sr: add support for ip4ip6 encapsulation	2017-08-25 17:10:23 -07:00
seg6_hmac.h
slhc_vj.h
smc.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
snmp.h
sock.h	sock: Add sock_owned_by_user_nocheck	2017-12-28 14:28:22 -05:00
sock_reuseport.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
Space.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
stp.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
strparser.h	strparser: Use delayed work instead of timer for msg timeout	2017-10-25 10:37:11 +09:00
switchdev.h	net: bridge: Add/del switchdev object on host join/leave	2017-11-10 13:41:40 +09:00
tcp.h	tcp: invalidate rate samples during SACK reneging	2017-12-08 10:07:02 -05:00
tcp_states.h
timewait_sock.h
tipc.h	tipc: improve link resiliency when rps is activated	2017-11-11 15:36:05 +09:00
tls.h	net/tls: Fix inverted error codes to avoid endless loop	2018-01-15 14:21:57 -05:00
transp_v6.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
tso.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
tun_proto.h	vxlan: factor out VXLAN-GPE next protocol	2017-08-29 15:16:52 -07:00
udp.h	IPv4: early demux can return an error code	2017-10-01 03:55:47 +01:00
udp_tunnel.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
udplite.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
vsock_addr.h
vxlan.h	vxlan: trivial indenting fix.	2018-01-03 11:33:37 -05:00
wext.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
wimax.h
x25.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
x25device.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xfrm.h	xfrm: Reinject transport-mode packets through tasklet	2017-12-19 08:23:21 +01:00