Samir Virmani
aff9cf5955
uart: Fix crash in uart_write and uart_put_char
...
We were experiencing a crash similar to the one reported as part of
commit:a5ba1d95e46e ("uart: fix race between uart_put_char() and
uart_shutdown()") in our testbed as well. We continue to observe the same
crash after integrating the commit a5ba1d95e4 ("uart: fix race between
uart_put_char() and uart_shutdown()")
On reviewing the change, the port lock should be taken prior to checking for
if (!circ->buf) in fn. __uart_put_char and other fns. that update the buffer
uart_state->xmit.
Traceback:
[11/27/2018 06:24:32.4870] Unable to handle kernel NULL pointer dereference
at virtual address 0000003b
[11/27/2018 06:24:32.4950] PC is at memcpy+0x48/0x180
[11/27/2018 06:24:32.4950] LR is at uart_write+0x74/0x120
[11/27/2018 06:24:32.4950] pc : [<ffffffc0002e6808>]
lr : [<ffffffc0003747cc>] pstate: 000001c5
[11/27/2018 06:24:32.4950] sp : ffffffc076433d30
[11/27/2018 06:24:32.4950] x29: ffffffc076433d30 x28: 0000000000000140
[11/27/2018 06:24:32.4950] x27: ffffffc0009b9d5e x26: ffffffc07ce36580
[11/27/2018 06:24:32.4950] x25: 0000000000000000 x24: 0000000000000140
[11/27/2018 06:24:32.4950] x23: ffffffc000891200 x22: ffffffc01fc34000
[11/27/2018 06:24:32.4950] x21: 0000000000000fff x20: 0000000000000076
[11/27/2018 06:24:32.4950] x19: 0000000000000076 x18: 0000000000000000
[11/27/2018 06:24:32.4950] x17: 000000000047cf08 x16: ffffffc000099e68
[11/27/2018 06:24:32.4950] x15: 0000000000000018 x14: 776d726966205948
[11/27/2018 06:24:32.4950] x13: 50203a6c6974755f x12: 74647075205d3333
[11/27/2018 06:24:32.4950] x11: 3a35323a36203831 x10: 30322f37322f3131
[11/27/2018 06:24:32.4950] x9 : 5b205d303638342e x8 : 746164206f742070
[11/27/2018 06:24:32.4950] x7 : 7520736920657261 x6 : 000000000000003b
[11/27/2018 06:24:32.4950] x5 : 000000000000817a x4 : 0000000000000008
[11/27/2018 06:24:32.4950] x3 : 2f37322f31312a5b x2 : 000000000000006e
[11/27/2018 06:24:32.4950] x1 : ffffffc0009b9cf0 x0 : 000000000000003b
[11/27/2018 06:24:32.4950] CPU2: stopping
[11/27/2018 06:24:32.4950] CPU: 2 PID: 0 Comm: swapper/2 Tainted: P D O 4.1.51 #3
[11/27/2018 06:24:32.4950] Hardware name: Broadcom-v8A (DT)
[11/27/2018 06:24:32.4950] Call trace:
[11/27/2018 06:24:32.4950] [<ffffffc0000883b8>] dump_backtrace+0x0/0x150
[11/27/2018 06:24:32.4950] [<ffffffc00008851c>] show_stack+0x14/0x20
[11/27/2018 06:24:32.4950] [<ffffffc0005ee810>] dump_stack+0x90/0xb0
[11/27/2018 06:24:32.4950] [<ffffffc00008e844>] handle_IPI+0x18c/0x1a0
[11/27/2018 06:24:32.4950] [<ffffffc000080c68>] gic_handle_irq+0x88/0x90
Fixes: a5ba1d95e4 ("uart: fix race between uart_put_char() and uart_shutdown()")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Samir Virmani <samir@embedur.com>
Acked-by: Tycho Andersen <tycho@tycho.ws>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-01-18 13:03:47 +01:00
arch
ARM: SoC fixes
2019-01-14 10:34:14 +12:00
block
block: fix kerneldoc comment for blk_attempt_plug_merge()
2019-01-09 15:29:08 -07:00
certs
kbuild: remove redundant target cleaning on failure
2019-01-06 09:46:51 +09:00
crypto
Kconfig updates for v4.21
2018-12-29 13:03:29 -08:00
Documentation
ARM: SoC fixes
2019-01-14 10:34:14 +12:00
drivers
uart: Fix crash in uart_write and uart_put_char
2019-01-18 13:03:47 +01:00
firmware
kbuild: change filechk to surround the given command with { }
2019-01-06 09:46:51 +09:00
fs
for-5.0-rc1-tag
2019-01-14 05:55:51 +12:00
include
ARM: SoC fixes
2019-01-14 10:34:14 +12:00
init
jump_label: move 'asm goto' support test to Kconfig
2019-01-06 09:46:51 +09:00
ipc
ipc: IPCMNI limit check for semmni
2018-10-31 08:54:14 -07:00
kernel
kernel/sys.c: Clarify that UNAME26 does not generate unique versions anymore
2019-01-14 10:38:03 +12:00
lib
Kbuild late updates for v4.21
2019-01-06 16:33:10 -08:00
LICENSES
This is a fairly typical cycle for documentation. There's some welcome
2018-10-24 18:01:11 +01:00
mm
mm/mmu_notifier: mm/rmap.c: Fix a mmu_notifier range bug in try_to_unmap_one
2019-01-10 02:58:21 -08:00
net
libceph: allow setting abort_on_full for rbd
2019-01-07 22:47:48 +01:00
samples
samples/seccomp: Fix 32-bit build
2019-01-08 07:45:01 +01:00
scripts
remove dma_zalloc_coherent
2019-01-12 10:52:40 -08:00
security
Merge branch 'mount.part1' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2019-01-05 13:25:58 -08:00
sound
remove dma_zalloc_coherent
2019-01-12 10:52:40 -08:00
tools
Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-01-11 09:44:05 -08:00
usr
user/Makefile: Fix typo and capitalization in comment section
2018-12-11 00:18:03 +09:00
virt
KVM: validate userspace input in kvm_clear_dirty_log_protect()
2019-01-11 18:38:07 +01:00
.clang-format
page cache: Convert find_get_pages_contig to XArray
2018-10-21 10:46:34 -04:00
.cocciconfig
.get_maintainer.ignore
.gitattributes
.gitattributes: set git diff driver for C source code files
2016-10-07 18:46:30 -07:00
.gitignore
kbuild: Add support for DT binding schema checks
2018-12-13 09:41:32 -06:00
.mailmap
A few early MIPS fixes for 4.21:
2019-01-05 12:48:25 -08:00
COPYING
COPYING: use the new text with points to the license files
2018-03-23 12:41:45 -06:00
CREDITS
Add CREDITS entry for Shaohua Li
2019-01-04 14:27:09 -07:00
Kbuild
kbuild: use assignment instead of define ... endef for filechk_* rules
2019-01-06 10:22:35 +09:00
Kconfig
kconfig: move the "Executable file formats" menu to fs/Kconfig.binfmt
2018-08-02 08:06:55 +09:00
MAINTAINERS
Staging driver fixes for 5.0-rc2
2019-01-14 05:49:35 +12:00
Makefile
Linux 5.0-rc2
2019-01-14 10:41:12 +12:00
README
Drop all 00-INDEX files from Documentation/
2018-09-09 15:08:58 -06:00