android_kernel_motorola_sm6375/fs/afs
Repository files (latest commit first)
Filename Latest commit message Latest commit date
David Howells 47ae524229 afs: Fix overwriting of result of DNS query
[ Upstream commit a9e01ac8c5ff32669119c40dfdc9e80eb0b7d7aa ]

In afs_update_cell(), ret is the result of the DNS lookup and the errors
are to be handled by a switch - however, the value gets clobbered in
between by setting it to -ENOMEM in case afs_alloc_vlserver_list()
fails.

Fix this by moving the setting of -ENOMEM into the error handling for
OOM failure.  Further, only do it if we don't have an alternative error
to return.

Found by Linux Verification Center (linuxtesting.org) with SVACE.  Based
on a patch from Anastasia Belova [1].

Fixes: d5c32c89b2 ("afs: Fix cell DNS lookup")
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Jeffrey Altman <jaltman@auristor.com>
cc: Anastasia Belova <abelova@astralinux.ru>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
cc: lvc-project@linuxtesting.org
Link: https://lore.kernel.org/r/20231221085849.1463-1-abelova@astralinux.ru/ [1]
Link: https://lore.kernel.org/r/1700862.1703168632@warthog.procyon.org.uk/ # v1
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-01-08 11:29:44 +01:00
..
addr_list.c
afs.h
afs_cm.h
afs_fs.h
afs_vl.h
cache.c
callback.c
cell.c afs: Fix overwriting of result of DNS query 2024-01-08 11:29:44 +01:00
cmservice.c
dir.c treewide: Remove uninitialized_var() usage 2023-06-09 10:29:01 +02:00
dir_edit.c
dir_silly.c
dynroot.c afs: Fix dynamic root lookup DNS check 2024-01-08 11:29:44 +01:00
file.c
flock.c afs: Use the operation issue time instead of the reply time for callbacks 2022-09-15 12:04:55 +02:00
fs_probe.c afs: Fix fileserver probe RTT handling 2022-12-08 11:23:03 +01:00
fsclient.c afs: Use the operation issue time instead of the reply time for callbacks 2022-09-15 12:04:55 +02:00
inode.c afs: Fix updating of i_size with dv jump from server 2023-05-17 11:35:54 +02:00
internal.h afs: Use the operation issue time instead of the reply time for callbacks 2022-09-15 12:04:55 +02:00
Kconfig
main.c
Makefile
misc.c afs: Return -EAGAIN, not -EREMOTEIO, when a file already locked 2022-09-28 11:03:59 +02:00
mntpt.c
proc.c
protocol_uae.h
protocol_yfs.h
rotate.c
rxrpc.c afs: Fix refcount underflow from error handling race 2023-12-20 15:41:13 +01:00
security.c treewide: Remove uninitialized_var() usage 2023-06-09 10:29:01 +02:00
server.c
server_list.c
super.c afs: Fix file locking on R/O volumes to operate in local mode 2023-12-08 08:44:23 +01:00
vl_list.c
vl_probe.c afs: Fix vlserver probe RTT handling 2023-06-21 15:44:12 +02:00
vl_rotate.c afs: Return ENOENT if no cell DNS record can be found 2023-12-08 08:44:23 +01:00
vlclient.c
volume.c
write.c
xattr.c
xdr_fs.h
yfsclient.c afs: Use the operation issue time instead of the reply time for callbacks 2022-09-15 12:04:55 +02:00