Kuniyuki Iwashima
b33ca18c3a
nfs: Handle error of rpc_proc_register() in nfs_net_init().
[ Upstream commit 24457f1be29f1e7042e50a7749f5c2dde8c433c8 ]
syzkaller reported a warning [0] triggered while destroying immature
netns.
rpc_proc_register() was called in init_nfs_fs(), but its error
has been ignored since at least the initial commit 1da177e4c3
("Linux-2.6.12-rc2").
Recently, commit d47151b79e32 ("nfs: expose /proc/net/sunrpc/nfs
in net namespaces") converted the procfs to per-netns and made
the problem more visible.
Even when rpc_proc_register() fails, nfs_net_init() could succeed,
and thus nfs_net_exit() will be called while destroying the netns.
Then, remove_proc_entry() will be called for non-existing proc
directory and trigger the warning below.
Let's handle the error of rpc_proc_register() properly in nfs_net_init().
[0]:
name 'nfs'
WARNING: CPU: 1 PID: 1710 at fs/proc/generic.c:711 remove_proc_entry+0x1bb/0x2d0 fs/proc/generic.c:711
Modules linked in:
CPU: 1 PID: 1710 Comm: syz-executor.2 Not tainted 6.8.0-12822-gcd51db110a7e #12
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.16.0-0-gd239552ce722-prebuilt.qemu.org 04/01/2014
RIP: 0010:remove_proc_entry+0x1bb/0x2d0 fs/proc/generic.c:711
Code: 41 5d 41 5e c3 e8 85 09 b5 ff 48 c7 c7 88 58 64 86 e8 09 0e 71 02 e8 74 09 b5 ff 4c 89 e6 48 c7 c7 de 1b 80 84 e8 c5 ad 97 ff <0f> 0b eb b1 e8 5c 09 b5 ff 48 c7 c7 88 58 64 86 e8 e0 0d 71 02 eb
RSP: 0018:ffffc9000c6d7ce0 EFLAGS: 00010286
RAX: 0000000000000000 RBX: ffff8880422b8b00 RCX: ffffffff8110503c
RDX: ffff888030652f00 RSI: ffffffff81105045 RDI: 0000000000000001
RBP: 0000000000000000 R08: 0000000000000001 R09: 0000000000000000
R10: 0000000000000001 R11: ffffffff81bb62cb R12: ffffffff84807ffc
R13: ffff88804ad6fcc0 R14: ffffffff84807ffc R15: ffffffff85741ff8
FS: 00007f30cfba8640(0000) GS:ffff88807dd00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007ff51afe8000 CR3: 000000005a60a005 CR4: 0000000000770ef0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
PKRU: 55555554
Call Trace:
<TASK>
rpc_proc_unregister+0x64/0x70 net/sunrpc/stats.c:310
nfs_net_exit+0x1c/0x30 fs/nfs/inode.c:2438
ops_exit_list+0x62/0xb0 net/core/net_namespace.c:170
setup_net+0x46c/0x660 net/core/net_namespace.c:372
copy_net_ns+0x244/0x590 net/core/net_namespace.c:505
create_new_namespaces+0x2ed/0x770 kernel/nsproxy.c:110
unshare_nsproxy_namespaces+0xae/0x160 kernel/nsproxy.c:228
ksys_unshare+0x342/0x760 kernel/fork.c:3322
__do_sys_unshare kernel/fork.c:3393 [inline]
__se_sys_unshare kernel/fork.c:3391 [inline]
__x64_sys_unshare+0x1f/0x30 kernel/fork.c:3391
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0x4f/0x110 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x46/0x4e
RIP: 0033:0x7f30d0febe5d
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 73 9f 1b 00 f7 d8 64 89 01 48
RSP: 002b:00007f30cfba7cc8 EFLAGS: 00000246 ORIG_RAX: 0000000000000110
RAX: ffffffffffffffda RBX: 00000000004bbf80 RCX: 00007f30d0febe5d
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 000000006c020600
RBP: 00000000004bbf80 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000002
R13: 000000000000000b R14: 00007f30d104c530 R15: 0000000000000000
</TASK>
Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Reported-by: syzkaller <syzkaller@googlegroups.com>
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
|
2024-05-17 11:43:48 +02:00 |
| .. |
|
9p
|
|
|
|
adfs
|
|
|
|
affs
|
affs: initialize fsdata in affs_truncate()
|
2023-02-06 07:52:36 +01:00 |
|
afs
|
afs: Revert "afs: Hide silly-rename files from userspace"
|
2024-03-26 18:22:24 -04:00 |
|
autofs
|
autofs: fix memory leak of waitqueues in autofs_catatonic_mode
|
2023-09-23 11:00:02 +02:00 |
|
befs
|
|
|
|
bfs
|
|
|
|
btrfs
|
btrfs: fix information leak in btrfs_ioctl_logical_to_ino()
|
2024-05-02 16:18:36 +02:00 |
|
cachefiles
|
cachefiles: fix memory leak in cachefiles_add_cache()
|
2024-03-06 14:36:10 +00:00 |
|
ceph
|
ceph: fix deadlock or deadcode of misusing dget()
|
2024-02-23 08:25:03 +01:00 |
|
cifs
|
smb: client: fix OOB in smbCalcSize()
|
2024-01-08 11:29:47 +01:00 |
|
coda
|
coda: Avoid partial allocation of sig_inputArgs
|
2023-03-11 16:43:56 +01:00 |
|
configfs
|
configfs: fix possible memory leak in configfs_create_dir()
|
2023-01-18 11:41:09 +01:00 |
|
cramfs
|
|
|
|
crypto
|
|
|
|
debugfs
|
new helper: lookup_positive_unlocked()
|
2023-09-23 10:59:40 +02:00 |
|
devpts
|
|
|
|
dlm
|
dlm: fix plock lookup when using multiple lockspaces
|
2023-09-23 10:59:55 +02:00 |
|
ecryptfs
|
ecryptfs: Reject casefold directory inodes
|
2024-02-23 08:24:56 +01:00 |
|
efivarfs
|
|
|
|
efs
|
|
|
|
erofs
|
erofs: ensure that the post-EOF tails are all zeroed
|
2023-09-23 10:59:36 +02:00 |
|
exportfs
|
|
|
|
ext2
|
ext2: fix datatype of block number in ext2_xattr_set2()
|
2023-09-23 11:00:04 +02:00 |
|
ext4
|
ext4: fix corruption during on-line resize
|
2024-04-13 12:51:26 +02:00 |
|
f2fs
|
f2fs: fix to check return value of f2fs_reserve_new_block()
|
2024-02-23 08:25:00 +01:00 |
|
fat
|
fat: fix uninitialized field in nostale filehandles
|
2024-04-13 12:51:23 +02:00 |
|
freevxfs
|
|
|
|
fscache
|
|
|
|
fuse
|
fuse: don't unhash root
|
2024-04-13 12:51:25 +02:00 |
|
gfs2
|
gfs2: Fix kernel NULL pointer dereference in gfs2_rgrp_dump
|
2024-01-25 14:34:24 -08:00 |
|
hfs
|
hfs: fix missing hfs_bnode_get() in __hfs_bnode_create
|
2023-03-11 16:43:59 +01:00 |
|
hfsplus
|
treewide: Remove uninitialized_var() usage
|
2023-06-09 10:29:01 +02:00 |
|
hostfs
|
|
|
|
hpfs
|
|
|
|
hugetlbfs
|
fs,hugetlb: fix NULL pointer dereference in hugetlbs_fill_super
|
2024-03-06 14:36:10 +00:00 |
|
iomap
|
iomap: Set all uptodate bits for an Uptodate page
|
2024-03-01 13:13:35 +01:00 |
|
isofs
|
isofs: handle CDs with bad root inode but good Joliet root directory
|
2024-04-13 12:51:38 +02:00 |
|
jbd2
|
jbd2: correct the printing of write_flags in jbd2_write_superblock()
|
2024-01-25 14:34:20 -08:00 |
|
jffs2
|
jffs2: reduce stack usage in jffs2_build_xattr_subsystem()
|
2023-07-27 08:37:25 +02:00 |
|
jfs
|
jfs: fix array-index-out-of-bounds in diNewExt
|
2024-02-23 08:24:55 +01:00 |
|
kernfs
|
fs/kernfs/dir: obey S_ISGID
|
2024-02-23 08:25:03 +01:00 |
|
lockd
|
fs: lockd: avoid possible wrong NULL parameter
|
2023-09-23 10:59:48 +02:00 |
|
minix
|
|
|
|
nfs
|
nfs: Handle error of rpc_proc_register() in nfs_net_init().
|
2024-05-17 11:43:48 +02:00 |
|
nfs_common
|
|
|
|
nfsd
|
nfsd: fix file memleak on client_opens_release
|
2023-11-28 16:50:21 +00:00 |
|
nilfs2
|
nilfs2: fix OOB in nilfs_set_de_type
|
2024-05-02 16:18:32 +02:00 |
|
nls
|
fs/nls: make load_nls() take a const parameter
|
2023-09-23 10:59:38 +02:00 |
|
notify
|
fanotify: disallow mount/sb marks on kernel internal pseudo fs
|
2023-07-27 08:37:26 +02:00 |
|
ntfs
|
|
|
|
ocfs2
|
fs: move S_ISGID stripping into the vfs_*() helpers
|
2024-02-23 08:24:49 +01:00 |
|
omfs
|
treewide: Remove uninitialized_var() usage
|
2023-06-09 10:29:01 +02:00 |
|
openpromfs
|
|
|
|
orangefs
|
orangefs: Fix kmemleak in orangefs_{kernel,client}_debug_init()
|
2023-01-18 11:41:39 +01:00 |
|
overlayfs
|
ovl: skip overlayfs superblocks at global sync
|
2023-12-08 08:44:27 +01:00 |
|
proc
|
procfs: block chmod on /proc/thread-self/comm
|
2023-09-23 10:59:55 +02:00 |
|
pstore
|
pstore/ram: Fix crash when setting number of cpus to an odd number
|
2024-02-23 08:24:55 +01:00 |
|
qnx4
|
|
|
|
qnx6
|
|
|
|
quota
|
quota: Fix rcu annotations of inode dquot pointers
|
2024-03-26 18:22:20 -04:00 |
|
ramfs
|
|
|
|
reiserfs
|
reiserfs: Check the return value from __getblk()
|
2023-09-23 10:59:40 +02:00 |
|
romfs
|
|
|
|
squashfs
|
revert "squashfs: harden sanity check in squashfs_read_xattr_id_table"
|
2023-02-22 12:50:39 +01:00 |
|
sysfs
|
fs: sysfs: Fix reference leak in sysfs_break_active_protection()
|
2024-05-02 16:18:32 +02:00 |
|
sysv
|
sysv: don't call sb_bread() with pointers_lock held
|
2024-04-13 12:51:38 +02:00 |
|
tracefs
|
tracefs: Add missing lockdown check to tracefs_create_dir()
|
2023-09-23 11:00:06 +02:00 |
|
ubifs
|
ubifs: Set page uptodate in the correct place
|
2024-04-13 12:51:23 +02:00 |
|
udf
|
udf: initialize newblock to 0
|
2023-09-23 10:59:56 +02:00 |
|
ufs
|
|
|
|
unicode
|
|
|
|
verity
|
fsverity: skip PKCS#7 parser when keyring is empty
|
2023-09-23 10:59:55 +02:00 |
|
xfs
|
xfs: verify buffer contents when we skip log replay
|
2023-06-28 10:18:42 +02:00 |
|
aio.c
|
fs/aio: Check IOCB_AIO_RW before the struct aio_kiocb conversion
|
2024-04-13 12:51:29 +02:00 |
|
anon_inodes.c
|
|
|
|
attr.c
|
attr: block mode changes of symlinks
|
2023-09-23 11:00:06 +02:00 |
|
bad_inode.c
|
|
|
|
binfmt_aout.c
|
binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf
|
2023-01-18 11:41:46 +01:00 |
|
binfmt_elf.c
|
|
|
|
binfmt_elf_fdpic.c
|
fs: binfmt_elf_efpic: fix personality for ELF-FDPIC
|
2023-10-10 21:46:42 +02:00 |
|
binfmt_em86.c
|
|
|
|
binfmt_flat.c
|
binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf
|
2023-01-18 11:41:46 +01:00 |
|
binfmt_misc.c
|
binfmt_misc: fix shift-out-of-bounds in check_special_flags
|
2023-01-18 11:41:33 +01:00 |
|
binfmt_script.c
|
|
|
|
block_dev.c
|
block: Don't invalidate pagecache for invalid falloc modes
|
2024-01-08 11:29:48 +01:00 |
|
buffer.c
|
|
|
|
char_dev.c
|
chardev: fix error handling in cdev_device_add()
|
2023-01-18 11:41:25 +01:00 |
|
compat.c
|
|
|
|
compat_binfmt_elf.c
|
|
|
|
compat_ioctl.c
|
lsm: new security_file_ioctl_compat() hook
|
2024-02-23 08:25:15 +01:00 |
|
coredump.c
|
|
|
|
d_path.c
|
|
|
|
dax.c
|
|
|
|
dcache.c
|
fast_dput(): handle underflows gracefully
|
2024-02-23 08:25:00 +01:00 |
|
dcookies.c
|
|
|
|
direct-io.c
|
|
|
|
drop_caches.c
|
|
|
|
eventfd.c
|
eventfd: prevent underflow for eventfd semaphores
|
2023-09-23 10:59:40 +02:00 |
|
eventpoll.c
|
epoll: ep_autoremove_wake_function should use list_del_init_careful
|
2023-06-28 10:18:35 +02:00 |
|
exec.c
|
exec: Fix NOMMU linux_binprm::exec in transfer_args_to_stack()
|
2024-04-13 12:51:31 +02:00 |
|
fcntl.c
|
|
|
|
fhandle.c
|
do_sys_name_to_handle(): use kzalloc() to fix kernel-infoleak
|
2024-03-26 18:22:13 -04:00 |
|
file.c
|
fs: prevent out-of-bounds array speculation when closing a file descriptor
|
2023-03-17 08:32:47 +01:00 |
|
file_table.c
|
|
|
|
filesystems.c
|
|
|
|
fs-writeback.c
|
writeback: fix call of incorrect macro
|
2023-05-17 11:35:58 +02:00 |
|
fs_context.c
|
fs: avoid empty option when generating legacy mount string
|
2023-07-27 08:37:25 +02:00 |
|
fs_parser.c
|
|
|
|
fs_pin.c
|
|
|
|
fs_struct.c
|
|
|
|
fs_types.c
|
|
|
|
fsopen.c
|
|
|
|
inode.c
|
fs: move S_ISGID stripping into the vfs_*() helpers
|
2024-02-23 08:24:49 +01:00 |
|
internal.h
|
fs: Establish locking order for unrelated directories
|
2023-07-27 08:37:26 +02:00 |
|
io_uring.c
|
io_uring: drop any code related to SCM_RIGHTS
|
2024-03-26 18:22:12 -04:00 |
|
ioctl.c
|
|
|
|
Kconfig
|
|
|
|
Kconfig.binfmt
|
|
|
|
libfs.c
|
libfs: add DEFINE_SIMPLE_ATTRIBUTE_SIGNED for signed value
|
2023-01-18 11:40:55 +01:00 |
|
locks.c
|
locks: fix KASAN: use-after-free in trace_event_raw_event_filelock_lock
|
2023-09-23 11:00:02 +02:00 |
|
Makefile
|
|
|
|
mbcache.c
|
mbcache: Avoid nesting of cache->c_list_lock under bit locks
|
2023-01-18 11:41:59 +01:00 |
|
mount.h
|
|
|
|
mpage.c
|
|
|
|
namei.c
|
fs: move S_ISGID stripping into the vfs_*() helpers
|
2024-02-23 08:24:49 +01:00 |
|
namespace.c
|
|
|
|
no-block.c
|
|
|
|
nsfs.c
|
|
|
|
open.c
|
fs: add a vfs_fchmod helper
|
2024-04-13 12:51:35 +02:00 |
|
pipe.c
|
|
|
|
pnode.c
|
pnode: terminate at peers of source
|
2023-01-18 11:41:44 +01:00 |
|
pnode.h
|
|
|
|
posix_acl.c
|
|
|
|
proc_namespace.c
|
|
|
|
read_write.c
|
|
|
|
readdir.c
|
|
|
|
select.c
|
fs/select: rework stack allocation hack for clang
|
2024-03-26 18:22:13 -04:00 |
|
seq_file.c
|
|
|
|
signalfd.c
|
|
|
|
splice.c
|
|
|
|
stack.c
|
|
|
|
stat.c
|
|
|
|
statfs.c
|
statfs: enforce statfs[64] structure initialization
|
2023-05-30 12:44:07 +01:00 |
|
super.c
|
fs: Protect reconfiguration of sb read-write from racing writes
|
2023-08-11 11:53:59 +02:00 |
|
sync.c
|
ovl: skip overlayfs superblocks at global sync
|
2023-12-08 08:44:27 +01:00 |
|
timerfd.c
|
|
|
|
userfaultfd.c
|
|
|
|
utimes.c
|
|
|
|
xattr.c
|
|
|