android_kernel_motorola_sm6375/drivers/target
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Dmitry Bogdanov 571ce6b6f5 scsi: target: iscsi: Fix timeout on deleted connection
[ Upstream commit 7f533cc5ee4c4436cee51dc58e81dfd9c3384418 ]

NOPIN response timer may expire on a deleted connection and crash with
such logs:

Did not receive response to NOPIN on CID: 0, failing connection for I_T Nexus (null),i,0x00023d000125,iqn.2017-01.com.iscsi.target,t,0x3d

BUG: Kernel NULL pointer dereference on read at 0x00000000
NIP  strlcpy+0x8/0xb0
LR iscsit_fill_cxn_timeout_err_stats+0x5c/0xc0 [iscsi_target_mod]
Call Trace:
 iscsit_handle_nopin_response_timeout+0xfc/0x120 [iscsi_target_mod]
 call_timer_fn+0x58/0x1f0
 run_timer_softirq+0x740/0x860
 __do_softirq+0x16c/0x420
 irq_exit+0x188/0x1c0
 timer_interrupt+0x184/0x410

That is because nopin response timer may be re-started on nopin timer
expiration.

Stop nopin timer before stopping the nopin response timer to be sure
that no one of them will be re-started.

Signed-off-by: Dmitry Bogdanov <d.bogdanov@yadro.com>
Link: https://lore.kernel.org/r/20241224101757.32300-1-d.bogdanov@yadro.com
Reviewed-by: Maurizio Lombardi <mlombard@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2025-06-04 14:32:29 +02:00
..
iscsi scsi: target: iscsi: Fix timeout on deleted connection 2025-06-04 14:32:29 +02:00
loopback
sbp
tcm_fc
Kconfig
Makefile
target_core_alua.c
target_core_alua.h
target_core_configfs.c scsi: target: Fix SELinux error when systemd-modules loads the target module 2024-05-17 11:43:51 +02:00
target_core_device.c scsi: target: core: Add TMF to tmr_list handling 2024-03-01 13:13:33 +01:00
target_core_fabric_configfs.c
target_core_fabric_lib.c
target_core_file.c scsi: target: Fix WRITE_SAME No Data Buffer crash 2025-06-04 14:32:26 +02:00
target_core_file.h
target_core_hba.c
target_core_iblock.c scsi: target: Fix WRITE_SAME No Data Buffer crash 2025-06-04 14:32:26 +02:00
target_core_iblock.h
target_core_internal.h
target_core_pr.c
target_core_pr.h
target_core_pscsi.c
target_core_pscsi.h
target_core_rd.c
target_core_rd.h
target_core_sbc.c scsi: target: Fix WRITE_SAME No Data Buffer crash 2025-06-04 14:32:26 +02:00
target_core_spc.c
target_core_stat.c
target_core_tmr.c
target_core_tpg.c
target_core_transport.c scsi: target: core: Add TMF to tmr_list handling 2024-03-01 13:13:33 +01:00
target_core_ua.c
target_core_ua.h
target_core_user.c genetlink: hold RCU in genlmsg_mcast() 2024-11-08 16:20:50 +01:00
target_core_xcopy.c
target_core_xcopy.h