Paolo Abeni
a864e70eef
udp: fix race between close() and udp_abort()
...
Kaustubh reported and diagnosed a panic in udp_lib_lookup().
The root cause is udp_abort() racing with close(). Both
racing functions acquire the socket lock, but udp{v6}_destroy_sock()
release it before performing destructive actions.
We can't easily extend the socket lock scope to avoid the race,
instead use the SOCK_DEAD flag to prevent udp_abort from doing
any action when the critical race happens.
Change-Id: I8ec3f73ed5f8324722b29450c37b4ae23a81c0f3
Diagnosed-and-tested-by: Kaustubh Pandey <kapandey@codeaurora.org>
Fixes: 5d77dca828 ("net: diag: support SOCK_DESTROY for UDP sockets")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Git-Commit: a8b897c7bcd47f4147d066e22cc01d1026d7640e
Git-repo: https://kernel.googlesource.com/pub/scm/linux/kernel/git/netdev/net.git
Signed-off-by: Kaustubh Pandey <kapandey@codeaurora.org>
2021-07-14 05:28:07 -07:00
..
bpfilter
netfilter
Merge "netfilter: Port Trigger: Support added for Port Trigger Feature"
2021-05-05 01:22:05 -07:00
af_inet.c
ah4.c
arp.c
Revert "Exempt multicast addresses from five-second neighbor lifetime"
2020-11-25 17:38:41 +01:00
cipso_ipv4.c
netlabel: cope with NULL catmap
2020-05-20 08:20:08 +02:00
datagram.c
devinet.c
devinet: fix memleak in inetdev_init()
2020-06-10 20:24:54 +02:00
esp4.c
esp4_offload.c
xfrm: remove the xfrm_state_put call becofe going to out_reset
2020-06-03 08:21:32 +02:00
fib_frontend.c
ipv4: fix error return code in rtm_to_fib_config()
2020-12-21 13:27:03 +01:00
fib_lookup.h
fib_notifier.c
fib_rules.c
fib_semantics.c
net: Fix the arp error in some cases
2020-06-30 15:36:44 -04:00
fib_trie.c
ipv4: Silence suspicious RCU usage warning
2020-09-12 14:18:54 +02:00
fou.c
fou: Fix IPv6 netlink policy
2020-01-29 16:45:22 +01:00
gre_demux.c
gre: fix uninit-value in __iptunnel_pull_header
2020-03-18 07:17:38 +01:00
gre_offload.c
net: gre: recompute gre csum for sctp over gre tunnels
2020-08-11 15:33:40 +02:00
icmp.c
UPSTREAM: net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending
2021-03-05 06:50:46 +01:00
igmp.c
inet_connection_sock.c
net: refactor bind_bucket fastreuse into helper
2020-08-19 08:16:23 +02:00
inet_diag.c
inet_diag: Fix error path to cancel the meseage in inet_req_diag_fill()
2020-11-24 13:28:56 +01:00
inet_fragment.c
inet_hashtables.c
net: initialize fastreuse on inet_inherit_port
2020-08-19 08:16:23 +02:00
inet_timewait_sock.c
inetpeer.c
ip_forward.c
ip_fragment.c
ip_gre.c
ip_gre: set dev->hard_header_len and dev->needed_headroom properly
2020-10-29 09:58:04 +01:00
ip_input.c
ip_options.c
ip_output.c
ip: fix tos reflection in ack and reset packets
2020-09-26 18:03:12 +02:00
ip_sockglue.c
ip_tunnel.c
ip_tunnel: fix over-mtu packet send fail without TUNNEL_DONT_FRAGMENT flags
2020-11-10 12:37:25 +01:00
ip_tunnel_core.c
ip_vti.c
ip_vti: receive ipip packet by calling ip_tunnel_rcv
2020-06-03 08:21:34 +02:00
ipcomp.c
ipconfig.c
ipip.c
net: ipip: fix wrong address family in init error path
2020-06-03 08:20:52 +02:00
ipmr.c
net: don't return invalid table id error when we fall back to PF_UNSPEC
2020-06-03 08:20:41 +02:00
ipmr_base.c
Kconfig
vti[6]: fix packet tx through bpf_redirect() in XinY cases
2020-04-01 11:02:05 +02:00
Makefile
metrics.c
netfilter.c
netfilter: use actual socket sk rather than skb sk when routing harder
2020-11-18 19:20:17 +01:00
netlink.c
nexthop.c
nexthop: Fix performance regression in nexthop deletion
2020-10-29 09:57:26 +01:00
ping.c
ipv4: fill fl4_icmp_{type,code} in ping_v4_sendmsg
2020-07-22 09:32:47 +02:00
proc.c
protocol.c
raw.c
raw_diag.c
inet_diag: return classid for all socket types
2020-03-18 07:17:38 +01:00
route.c
ipv4: Fix tos mask in inet_rtm_getroute()
2020-12-08 10:40:25 +01:00
syncookies.c
net: Update window_clamp if SOCK_RCVBUF is set
2020-11-18 19:20:32 +01:00
sysctl_net_ipv4.c
WLAN subsystem: Sysctl support for key TCP/IP parameters
2021-01-29 16:50:05 +05:30
tcp.c
Merge android11-5.4.86+ ( 75c93eb) into msm-5.4
2021-04-22 09:44:51 +05:30
tcp_bbr.c
tcp: only postpone PROBE_RTT if RTT is < current min_rtt estimate
2020-11-24 13:28:59 +01:00
tcp_bic.c
tcp_bpf.c
bpf, sockmap: Ensure SO_RCVBUF memory is observed on ingress redirect
2020-11-24 13:29:08 +01:00
tcp_cdg.c
tcp_cong.c
tcp: Set INET_ECN_xmit configuration in tcp_reinit_congestion_control
2020-12-08 10:40:24 +01:00
tcp_cubic.c
tcp_cubic: fix spurious HYSTART_DELAY exit upon drop in min RTT
2020-06-30 15:36:47 -04:00
tcp_dctcp.c
tcp_dctcp.h
tcp_diag.c
tcp_fastopen.c
tcp: correct read of TFO keys on big endian systems
2020-08-19 08:16:23 +02:00
tcp_highspeed.c
tcp_htcp.c
tcp_hybla.c
tcp_illinois.c
tcp_input.c
Merge android11-5.4.86+ ( 75c93eb) into msm-5.4
2021-04-22 09:44:51 +05:30
tcp_ipv4.c
Merge android11-5.4.86+ ( 75c93eb) into msm-5.4
2021-04-22 09:44:51 +05:30
tcp_lp.c
tcp_metrics.c
tcp_minisocks.c
tcp_nv.c
tcp_offload.c
tcp_output.c
net: tcp: check for NULL send head during MTU probe
2021-06-28 23:15:45 -07:00
tcp_rate.c
tcp_recovery.c
tcp_scalable.c
tcp_timer.c
WLAN subsystem: Sysctl support for key TCP/IP parameters
2021-01-29 16:50:05 +05:30
tcp_ulp.c
bpf: Sockmap/tls, push write_space updates through ulp updates
2020-01-23 08:22:45 +01:00
tcp_vegas.c
tcp_vegas.h
tcp_veno.c
tcp_westwood.c
tcp_yeah.c
tunnel4.c
udp.c
udp: fix race between close() and udp_abort()
2021-07-14 05:28:07 -07:00
udp_diag.c
inet_diag: return classid for all socket types
2020-03-18 07:17:38 +01:00
udp_impl.h
udp_offload.c
UPSTREAM: udp: ipv4: manipulate network header of NATed UDP GRO fraglist
2021-05-04 15:19:30 -07:00
udp_tunnel.c
udplite.c
xfrm4_input.c
xfrm4_output.c
xfrm: Always set XFRM_TRANSFORMED in xfrm{4,6}_output_finish
2020-04-29 16:33:11 +02:00
xfrm4_policy.c
xfrm4_protocol.c
xfrm4_state.c
xfrm4_tunnel.c