Ido Schimmel
a1ef12540e
rtnetlink: Reject negative ifindexes in RTM_NEWLINK
commit 30188bd7838c16a98a520db1fe9df01ffc6ed368 upstream.
Negative ifindexes are illegal, but the kernel does not validate the
ifindex in the ancillary header of RTM_NEWLINK messages, resulting in
the kernel generating a warning [1] when such an ifindex is specified.
Fix by rejecting negative ifindexes.
[1]
WARNING: CPU: 0 PID: 5031 at net/core/dev.c:9593 dev_index_reserve+0x1a2/0x1c0 net/core/dev.c:9593
[...]
Call Trace:
<TASK>
register_netdevice+0x69a/0x1490 net/core/dev.c:10081
br_dev_newlink+0x27/0x110 net/bridge/br_netlink.c:1552
rtnl_newlink_create net/core/rtnetlink.c:3471 [inline]
__rtnl_newlink+0x115e/0x18c0 net/core/rtnetlink.c:3688
rtnl_newlink+0x67/0xa0 net/core/rtnetlink.c:3701
rtnetlink_rcv_msg+0x439/0xd30 net/core/rtnetlink.c:6427
netlink_rcv_skb+0x16b/0x440 net/netlink/af_netlink.c:2545
netlink_unicast_kernel net/netlink/af_netlink.c:1342 [inline]
netlink_unicast+0x536/0x810 net/netlink/af_netlink.c:1368
netlink_sendmsg+0x93c/0xe40 net/netlink/af_netlink.c:1910
sock_sendmsg_nosec net/socket.c:728 [inline]
sock_sendmsg+0xd9/0x180 net/socket.c:751
____sys_sendmsg+0x6ac/0x940 net/socket.c:2538
___sys_sendmsg+0x135/0x1d0 net/socket.c:2592
__sys_sendmsg+0x117/0x1e0 net/socket.c:2621
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
Fixes: 38f7b870d4 ("[RTNETLINK]: Link creation API")
Reported-by: syzbot+5ba06978f34abb058571@syzkaller.appspotmail.com
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Link: https://lore.kernel.org/r/20230823064348.2252280-1-idosch@nvidia.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
2023-08-30 16:27:26 +02:00 |
| .. |
|
6lowpan
|
|
|
|
9p
|
9p/xen : Fix use after free bug in xen_9pfs_front_remove due to race condition
|
2023-04-20 12:07:36 +02:00 |
|
802
|
mrp: introduce active flags to prevent UAF when applicant uninit
|
2023-01-18 11:41:37 +01:00 |
|
8021q
|
vlan: fix a potential uninit-value in vlan_dev_hard_start_xmit()
|
2023-05-30 12:44:06 +01:00 |
|
appletalk
|
|
|
|
atm
|
atm: hide unused procfs functions
|
2023-06-09 10:28:59 +02:00 |
|
ax25
|
|
|
|
batman-adv
|
batman-adv: Hold rtnl lock during MTU update via netlink
|
2023-08-30 16:27:25 +02:00 |
|
bluetooth
|
Bluetooth: L2CAP: Fix use-after-free
|
2023-08-30 16:27:11 +02:00 |
|
bpf
|
bpf: Move skb->len == 0 checks into __bpf_redirect
|
2023-01-18 11:41:04 +01:00 |
|
bpfilter
|
|
|
|
bridge
|
net: bridge: keep ports without IFF_UNICAST_FLT in BR_PROMISC mode
|
2023-07-27 08:37:23 +02:00 |
|
caif
|
net: caif: Fix use-after-free in cfusbl_device_notify()
|
2023-03-17 08:32:51 +01:00 |
|
can
|
can: bcm: Fix UAF in bcm_proc_show()
|
2023-07-27 08:37:40 +02:00 |
|
ceph
|
libceph: fix potential hang in ceph_osdc_notify()
|
2023-08-11 11:53:58 +02:00 |
|
core
|
rtnetlink: Reject negative ifindexes in RTM_NEWLINK
|
2023-08-30 16:27:26 +02:00 |
|
dcb
|
net: dcb: choose correct policy to parse DCB_ATTR_BCN
|
2023-08-11 11:53:57 +02:00 |
|
dccp
|
dccp: annotate data-races in dccp_poll()
|
2023-08-30 16:27:23 +02:00 |
|
decnet
|
Remove DECnet support from kernel
|
2023-06-21 15:44:10 +02:00 |
|
dns_resolver
|
|
|
|
dsa
|
net: dsa: tag_sja1105: fix MAC DA patching from meta frames
|
2023-07-27 08:37:24 +02:00 |
|
ethernet
|
|
|
|
hsr
|
hsr: Avoid double remove of a node.
|
2023-01-18 11:41:09 +01:00 |
|
ieee802154
|
|
|
|
ife
|
|
|
|
ipv4
|
net: fix the RTO timer retransmitting skb every 1ms if linear option is enabled
|
2023-08-30 16:27:19 +02:00 |
|
ipv6
|
ip6_vti: fix slab-use-after-free in decode_session6
|
2023-08-30 16:27:16 +02:00 |
|
iucv
|
treewide: Replace DECLARE_TASKLET() with DECLARE_TASKLET_OLD()
|
2023-04-20 12:07:32 +02:00 |
|
kcm
|
|
|
|
key
|
net: af_key: fix sadb_x_filter validation
|
2023-08-30 16:27:16 +02:00 |
|
l2tp
|
inet6: Remove inet6_destroy_sock() in sk->sk_prot->destroy().
|
2023-04-26 11:24:05 +02:00 |
|
l3mdev
|
|
|
|
lapb
|
|
|
|
llc
|
llc: Don't drop packet from non-root netns.
|
2023-07-27 08:37:44 +02:00 |
|
mac80211
|
wifi: mac80211: fix invalid drv_sta_pre_rcu_remove calls for non-uploaded sta
|
2023-04-20 12:07:33 +02:00 |
|
mac802154
|
|
|
|
mpls
|
net: mpls: fix stale pointer if allocation fails during device rename
|
2023-02-22 12:50:41 +01:00 |
|
ncsi
|
net/ncsi: Fix gma flag setting after response
|
2023-08-30 16:27:14 +02:00 |
|
netfilter
|
netfilter: set default timeout to 3 secs for sctp shutdown send and recv state
|
2023-08-30 16:27:19 +02:00 |
|
netlabel
|
|
|
|
netlink
|
netlink: Add __sock_i_ino() for __netlink_diag_dump().
|
2023-07-27 08:37:12 +02:00 |
|
netrom
|
netrom: fix info-leak in nr_write_internal()
|
2023-06-09 10:28:52 +02:00 |
|
nfc
|
net: nfc: Fix use-after-free caused by nfc_llcp_find_local
|
2023-07-27 08:37:11 +02:00 |
|
nsh
|
net: nsh: Use correct mac_offset to unwind gso skb in nsh_gso_segment()
|
2023-05-30 12:44:05 +01:00 |
|
openvswitch
|
net: openvswitch: fix flow memory leak in ovs_flow_cmd_new
|
2023-02-22 12:50:25 +01:00 |
|
packet
|
net/packet: annotate data-races around tp->status
|
2023-08-16 18:19:23 +02:00 |
|
phonet
|
|
|
|
psample
|
|
|
|
qrtr
|
|
|
|
rds
|
rds: rds_rm_zerocopy_callback() correct order for list_add_tail()
|
2023-03-11 16:43:41 +01:00 |
|
rfkill
|
|
|
|
rose
|
net/rose: Fix to not accept on connected socket
|
2023-02-22 12:50:34 +01:00 |
|
rxrpc
|
rxrpc: Fix hard call timeout units
|
2023-05-17 11:35:59 +02:00 |
|
sched
|
net/sched: fix a qdisc modification with ambiguous command request
|
2023-08-30 16:27:24 +02:00 |
|
sctp
|
sock: annotate data-races around prot->memory_pressure
|
2023-08-30 16:27:23 +02:00 |
|
smc
|
net/smc: fix fallback failed while sendmsg with fastopen
|
2023-03-17 08:32:51 +01:00 |
|
strparser
|
|
|
|
sunrpc
|
SUNRPC: Fix UAF in svc_tcp_listen_data_ready()
|
2023-07-27 08:37:35 +02:00 |
|
switchdev
|
|
|
|
tipc
|
net: tipc: resize nlattr array to correct size
|
2023-06-21 15:44:12 +02:00 |
|
tls
|
treewide: Remove uninitialized_var() usage
|
2023-06-09 10:29:01 +02:00 |
|
unix
|
af_unix: Fix null-ptr-deref in unix_stream_sendpage().
|
2023-08-30 16:27:19 +02:00 |
|
vmw_vsock
|
vsock: avoid to close connected socket after the timeout
|
2023-05-30 12:44:05 +01:00 |
|
wimax
|
|
|
|
wireless
|
wifi: wext-core: Fix -Wstringop-overflow warning in ioctl_standard_iw_point()
|
2023-07-27 08:37:42 +02:00 |
|
x25
|
net/x25: Fix to not accept on connected socket
|
2023-02-22 12:50:26 +01:00 |
|
xdp
|
xsk: Honor SO_BINDTODEVICE on bind
|
2023-07-27 08:37:23 +02:00 |
|
xfrm
|
net: xfrm: Amend XFRMA_SEC_CTX nla_policy structure
|
2023-08-30 16:27:20 +02:00 |
|
compat.c
|
|
|
|
Kconfig
|
Remove DECnet support from kernel
|
2023-06-21 15:44:10 +02:00 |
|
Makefile
|
Remove DECnet support from kernel
|
2023-06-21 15:44:10 +02:00 |
|
socket.c
|
net: annotate sk->sk_err write from do_recvmmsg()
|
2023-05-30 12:44:01 +01:00 |
|
sysctl_net.c
|
|
|