Hou Tao
b9a41d21dc
dm: fix race between dm_get_from_kobject() and __dm_destroy() ...
The following BUG_ON was hit when testing repeat creation and removal of
DM devices:
kernel BUG at drivers/md/dm.c:2919!
CPU: 7 PID: 750 Comm: systemd-udevd Not tainted 4.1.44
Call Trace:
[<ffffffff81649e8b>] dm_get_from_kobject+0x34/0x3a
[<ffffffff81650ef1>] dm_attr_show+0x2b/0x5e
[<ffffffff817b46d1>] ? mutex_lock+0x26/0x44
[<ffffffff811df7f5>] sysfs_kf_seq_show+0x83/0xcf
[<ffffffff811de257>] kernfs_seq_show+0x23/0x25
[<ffffffff81199118>] seq_read+0x16f/0x325
[<ffffffff811de994>] kernfs_fop_read+0x3a/0x13f
[<ffffffff8117b625>] __vfs_read+0x26/0x9d
[<ffffffff8130eb59>] ? security_file_permission+0x3c/0x44
[<ffffffff8117bdb8>] ? rw_verify_area+0x83/0xd9
[<ffffffff8117be9d>] vfs_read+0x8f/0xcf
[<ffffffff81193e34>] ? __fdget_pos+0x12/0x41
[<ffffffff8117c686>] SyS_read+0x4b/0x76
[<ffffffff817b606e>] system_call_fastpath+0x12/0x71
The bug can be easily triggered, if an extra delay (e.g. 10ms) is added
between the test of DMF_FREEING & DMF_DELETING and dm_get() in
dm_get_from_kobject().
To fix it, we need to ensure the test of DMF_FREEING & DMF_DELETING and
dm_get() are done in an atomic way, so _minor_lock is used.
The other callers of dm_get() have also been checked to be OK: some
callers invoke dm_get() under _minor_lock, some callers invoke it under
_hash_lock, and dm_start_request() invoke it after increasing
md->open_count.
Cc: stable@vger.kernel.org
Signed-off-by: Hou Tao <houtao1@huawei.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
2017-11-10 15:44:56 -05:00
bcache: use llist_for_each_entry_safe() in __closure_wake_up()
2017-09-27 14:54:49 -06:00
dm space map metadata: use ARRAY_SIZE
2017-11-10 15:44:52 -05:00
md/bitmap: disable bitmap_resize for file-backed bitmaps.
2017-08-31 22:57:03 -07:00
block: replace bi_bdev with a gendisk pointer and partitions index
2017-08-23 12:49:55 -06:00
- Some request-based DM core and DM multipath fixes and cleanups
2017-09-14 13:43:16 -07:00
dm integrity: optimize writing dm-bufio buffers that are partially changed
2017-08-28 11:47:17 -04:00
dm cache: convert dm_cache_metadata.ref_count from atomic_t to refcount_t
2017-10-24 15:09:51 -04:00
dm cache: simplify get_per_bio_data() by removing data_size argument
2017-11-10 15:44:49 -05:00
dm: allocate struct mapped_device with kvzalloc
2017-11-10 15:44:55 -05:00
dm crypt: reject sector_size feature if device length is not aligned to it
2017-10-04 10:49:58 -04:00
block: replace bi_bdev with a gendisk pointer and partitions index
2017-08-23 12:49:55 -06:00
block: replace bi_bdev with a gendisk pointer and partitions index
2017-08-23 12:49:55 -06:00
- Some request-based DM core and DM multipath fixes and cleanups
2017-09-14 13:43:16 -07:00
- Some request-based DM core and DM multipath fixes and cleanups
2017-09-14 13:43:16 -07:00
block: replace bi_bdev with a gendisk pointer and partitions index
2017-08-23 12:49:55 -06:00
dm ioctl: fix alignment of event number in the device list
2017-09-25 11:18:29 -04:00
dm kcopyd: add sequential write feature
2017-06-19 11:03:51 -04:00
- Some request-based DM core and DM multipath fixes and cleanups
2017-09-14 13:43:16 -07:00
dm log writes: add support for DAX
2017-11-10 15:44:51 -05:00
- Some request-based DM core and DM multipath fixes and cleanups
2017-09-14 13:43:16 -07:00
- A stable fix for the alignment of the event number reported at the
2017-10-05 15:17:40 -07:00
block: replace bi_bdev with a gendisk pointer and partitions index
2017-08-23 12:49:55 -06:00
dm rq: do not update rq partially in each ending bio
2017-08-28 10:23:28 -04:00
dm rq: do not update rq partially in each ending bio
2017-08-28 10:23:28 -04:00
block: replace bi_bdev with a gendisk pointer and partitions index
2017-08-23 12:49:55 -06:00
- Some request-based DM core and DM multipath fixes and cleanups
2017-09-14 13:43:16 -07:00
- Some request-based DM core and DM multipath fixes and cleanups
2017-09-14 13:43:16 -07:00
dm: convert dm_dev_internal.count from atomic_t to refcount_t
2017-10-24 15:09:51 -04:00
- Some request-based DM core and DM multipath fixes and cleanups
2017-09-14 13:43:16 -07:00
dm verity fec: fix GFP flags used with mempool_alloc()
2017-07-26 15:55:44 -04:00
- Some request-based DM core and DM multipath fixes and cleanups
2017-09-14 13:43:16 -07:00
block: replace bi_bdev with a gendisk pointer and partitions index
2017-08-23 12:49:55 -06:00
dm zoned: use GFP_NOIO in I/O path
2017-07-26 15:55:43 -04:00
dm zoned: ignore last smaller runt zone
2017-11-10 15:44:53 -05:00
dm zoned: drive-managed zoned block device target
2017-06-19 11:05:20 -04:00
dm: fix race between dm_get_from_kobject() and __dm_destroy()
2017-11-10 15:44:56 -05:00
dm: convert dm_dev_internal.count from atomic_t to refcount_t
2017-10-24 15:09:51 -04:00
block: replace bi_bdev with a gendisk pointer and partitions index
2017-08-23 12:49:55 -06:00
dm zoned: drive-managed zoned block device target
2017-06-19 11:05:20 -04:00
block: replace bi_bdev with a gendisk pointer and partitions index
2017-08-23 12:49:55 -06:00
dm zoned: drive-managed zoned block device target
2017-06-19 11:05:20 -04:00
md: fix a race condition for flush request handling
2017-09-27 20:08:18 -07:00
md: separate request handling
2017-09-27 20:07:40 -07:00
block: replace bi_bdev with a gendisk pointer and partitions index
2017-08-23 12:49:55 -06:00
Merge tag 'md/4.14-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/shli/md
2017-09-07 12:41:48 -07:00
md: raid1-10: move raid1/raid10 common code into raid1-10.c
2017-07-21 12:47:20 -07:00
Merge tag 'md/4.14-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/shli/md
2017-09-07 12:41:48 -07:00
Merge tag 'md/4.14-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/shli/md
2017-09-07 12:41:48 -07:00
Merge tag 'md/4.14-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/shli/md
2017-09-07 12:41:48 -07:00
md/raid5: cap worker count
2017-09-27 20:08:44 -07:00
Merge tag 'md/4.14-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/shli/md
2017-09-07 12:41:48 -07:00
b9a41d21dc