Grzegorz Sluja
bbdc74dc19
mmc: block: Prevent new req entering queue after its cleanup
The commit 304419d8a7 ("mmc: core: Allocate per-request data using the
block layer core"), refactored the mechanism of queue handling, but also
made mmc_init_request() to be called after mmc_cleanup_queue(). This
triggers a null pointer dereference:
[ 683.123791] BUG: unable to handle kernel NULL pointer dereference at (null)
[ 683.123801] IP: mmc_init_request+0x2c/0xf0 [mmc_block]
...
[ 683.123905] Call Trace:
[ 683.123913] alloc_request_size+0x4f/0x70
[ 683.123919] mempool_alloc+0x5f/0x150
[ 683.123925] ? __enqueue_entity+0x6c/0x70
[ 683.123928] get_request+0x3ad/0x720
[ 683.123933] ? prepare_to_wait_event+0x110/0x110
[ 683.123937] blk_queue_bio+0xc1/0x3a0
[ 683.123940] generic_make_request+0xf8/0x2a0
[ 683.123942] submit_bio+0x75/0x150
[ 683.123947] submit_bio_wait+0x51/0x70
[ 683.123951] blkdev_issue_flush+0x5c/0x90
[ 683.123956] ext4_sync_fs+0x171/0x1b0
[ 683.123961] sync_filesystem+0x73/0x90
[ 683.123965] fsync_bdev+0x24/0x50
[ 683.123971] invalidate_partition+0x24/0x50
[ 683.123973] del_gendisk+0xb2/0x2a0
[ 683.123977] mmc_blk_remove_req.part.38+0x71/0xa0 [mmc_block]
[ 683.123980] mmc_blk_remove+0xba/0x190 [mmc_block]
[ 683.123990] mmc_bus_remove+0x1a/0x20 [mmc_core]
[ 683.123995] device_release_driver_internal+0x141/0x200
[ 683.123999] device_release_driver+0x12/0x20
[ 683.124001] bus_remove_device+0xfd/0x170
[ 683.124004] device_del+0x1e8/0x330
[ 683.124012] mmc_remove_card+0x60/0xc0 [mmc_core]
[ 683.124019] mmc_remove+0x19/0x30 [mmc_core]
[ 683.124025] mmc_stop_host+0xfb/0x1a0 [mmc_core]
[ 683.124032] mmc_remove_host+0x1a/0x40 [mmc_core]
[ 683.124037] sdhci_remove_host+0x2e/0x1c0 [mmc_sdhci]
[ 683.124042] sdhci_pci_remove_slot+0x3f/0x80 [sdhci_pci]
[ 683.124045] sdhci_pci_remove+0x39/0x70 [sdhci_pci]
[ 683.124049] pci_device_remove+0x39/0xc0
[ 683.124052] device_release_driver_internal+0x141/0x200
[ 683.124056] driver_detach+0x3f/0x80
[ 683.124059] bus_remove_driver+0x55/0xd0
[ 683.124062] driver_unregister+0x2c/0x50
[ 683.124065] pci_unregister_driver+0x29/0x90
[ 683.124069] sdhci_driver_exit+0x10/0x4f3 [sdhci_pci]
[ 683.124073] SyS_delete_module+0x171/0x250
[ 683.124078] entry_SYSCALL_64_fastpath+0x1e/0xa9
Fix this by setting the queue DYING flag before cleanup the queue, as it
prevents new reqs from entering the queue.
Signed-off-by: Grzegorz Sluja <grzegorzx.sluja@intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Fixes: 304419d8a7 ("mmc: core: Allocate per-request data using the...")
[Ulf: Updated the changelog]
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
|
2017-07-13 11:44:01 +02:00 |
| .. |
|
accessibility
|
|
|
|
acpi
|
Device properties framework updates for v4.13-rc1
|
2017-07-10 15:23:45 -07:00 |
|
amba
|
|
|
|
android
|
|
|
|
ata
|
Merge branch 'for-4.13' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata
|
2017-07-06 09:41:58 -07:00 |
|
atm
|
net: convert sock.sk_wmem_alloc from atomic_t to refcount_t
|
2017-07-01 07:39:08 -07:00 |
|
auxdisplay
|
|
|
|
base
|
Merge branch 'akpm' (patches from Andrew)
|
2017-07-10 16:58:42 -07:00 |
|
bcma
|
|
|
|
block
|
ARM: fix rd_size declaration
|
2017-07-10 16:32:34 -07:00 |
|
bluetooth
|
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
|
2017-07-05 12:31:59 -07:00 |
|
bus
|
main drm pull for v4.13
|
2017-07-09 18:48:37 -07:00 |
|
cdrom
|
|
|
|
char
|
Some small fixes for IPMI, and one medium sized changed.
|
2017-07-10 10:59:29 -07:00 |
|
clk
|
ARM: Device-tree updates
|
2017-07-04 14:37:25 -07:00 |
|
clocksource
|
ARM: SoC driver updates
|
2017-07-04 14:47:47 -07:00 |
|
connector
|
|
|
|
cpufreq
|
More power management updates for v4.13-rc1
|
2017-07-10 15:16:21 -07:00 |
|
cpuidle
|
powerpc updates for 4.13
|
2017-07-07 13:55:45 -07:00 |
|
crypto
|
This is the first pull request for the new dma-mapping subsystem
|
2017-07-06 19:20:54 -07:00 |
|
dax
|
Writeback error handling fixes (pile #2)
|
2017-07-07 19:38:17 -07:00 |
|
dca
|
|
|
|
devfreq
|
|
|
|
dio
|
|
|
|
dma
|
dmaengine updates for 4.13-rc1
|
2017-07-08 12:36:50 -07:00 |
|
dma-buf
|
|
|
|
edac
|
|
|
|
eisa
|
|
|
|
extcon
|
|
|
|
firewire
|
|
|
|
firmware
|
This is the first pull request for the new dma-mapping subsystem
|
2017-07-06 19:20:54 -07:00 |
|
fmc
|
|
|
|
fpga
|
|
|
|
fsi
|
|
|
|
gpio
|
Merge (most of) tag 'mfd-next-4.13' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd
|
2017-07-07 13:30:05 -07:00 |
|
gpu
|
main drm pull for v4.13
|
2017-07-09 18:48:37 -07:00 |
|
hid
|
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid
|
2017-07-10 09:22:48 -07:00 |
|
hsi
|
HSI changes for the v4.13 series
|
2017-07-04 14:28:22 -07:00 |
|
hv
|
SCSI misc on 20170704
|
2017-07-06 12:10:33 -07:00 |
|
hwmon
|
|
|
|
hwspinlock
|
|
|
|
hwtracing
|
Char/Misc patches for 4.13-rc1
|
2017-07-03 20:55:59 -07:00 |
|
i2c
|
Char/Misc patches for 4.13-rc1
|
2017-07-03 20:55:59 -07:00 |
|
ide
|
|
|
|
idle
|
intel_idle: Use more common logging style
|
2017-06-29 22:58:35 +02:00 |
|
iio
|
hwmon updates for v4.13:
|
2017-07-04 11:48:27 -07:00 |
|
infiniband
|
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security
|
2017-07-07 17:06:28 -07:00 |
|
input
|
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input
|
2017-07-08 12:39:37 -07:00 |
|
iommu
|
This is the first pull request for the new dma-mapping subsystem
|
2017-07-06 19:20:54 -07:00 |
|
ipack
|
|
|
|
irqchip
|
arm64 updates for 4.13:
|
2017-07-05 17:09:27 -07:00 |
|
isdn
|
Merge branch 'work.misc-set_fs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
|
2017-07-05 13:13:32 -07:00 |
|
leds
|
LED updates for 4.13
|
2017-07-06 11:32:40 -07:00 |
|
lguest
|
|
|
|
lightnvm
|
lightnvm: pblk: set line bitmap check under debug
|
2017-06-30 11:08:18 -06:00 |
|
macintosh
|
Merge branch 'work.misc-set_fs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
|
2017-07-05 13:13:32 -07:00 |
|
mailbox
|
Merge branch 'mailbox-for-next' of git://git.linaro.org/landing-teams/working/fujitsu/integration
|
2017-07-07 10:24:07 -07:00 |
|
mcb
|
|
|
|
md
|
Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/shli/md
|
2017-07-08 12:50:18 -07:00 |
|
media
|
main drm pull for v4.13
|
2017-07-09 18:48:37 -07:00 |
|
memory
|
ARM: SoC driver updates
|
2017-07-04 14:47:47 -07:00 |
|
memstick
|
|
|
|
message
|
|
|
|
mfd
|
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input
|
2017-07-08 12:39:37 -07:00 |
|
misc
|
powerpc updates for 4.13
|
2017-07-07 13:55:45 -07:00 |
|
mmc
|
mmc: block: Prevent new req entering queue after its cleanup
|
2017-07-13 11:44:01 +02:00 |
|
mtd
|
This is the big bulk of pin control changes for the v4.13 series:
|
2017-07-06 11:38:59 -07:00 |
|
mux
|
|
|
|
net
|
pci-v4.13-changes
|
2017-07-08 15:51:57 -07:00 |
|
nfc
|
NFC 4.13 pull request
|
2017-07-01 14:30:39 -07:00 |
|
ntb
|
|
|
|
nubus
|
|
|
|
nvdimm
|
libnvdimm for 4.13
|
2017-07-07 09:44:06 -07:00 |
|
nvme
|
pci-v4.13-changes
|
2017-07-08 15:51:57 -07:00 |
|
nvmem
|
|
|
|
of
|
Device properties framework updates for v4.13-rc1
|
2017-07-10 15:23:45 -07:00 |
|
oprofile
|
|
|
|
parisc
|
parisc: ->mapping_error
|
2017-07-05 21:46:42 +02:00 |
|
parport
|
|
|
|
pci
|
pci-v4.13-changes
|
2017-07-08 15:51:57 -07:00 |
|
pcmcia
|
|
|
|
perf
|
|
|
|
phy
|
|
|
|
pinctrl
|
This is the big bulk of pin control changes for the v4.13 series:
|
2017-07-06 11:38:59 -07:00 |
|
platform
|
Merge (most of) tag 'mfd-next-4.13' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd
|
2017-07-07 13:30:05 -07:00 |
|
pnp
|
This is the bulk of GPIO changes for the v4.13 series:
|
2017-07-07 12:40:27 -07:00 |
|
power
|
power supply and reset changes for the v4.13 series
|
2017-07-04 14:25:14 -07:00 |
|
powercap
|
|
|
|
pps
|
|
|
|
ps3
|
|
|
|
ptp
|
ptp: dte: Use LL suffix for 64-bit constants
|
2017-07-06 11:40:58 +01:00 |
|
pwm
|
|
|
|
rapidio
|
|
|
|
ras
|
arm64 updates for 4.13:
|
2017-07-05 17:09:27 -07:00 |
|
regulator
|
Merge remote-tracking branches 'regulator/topic/settle', 'regulator/topic/tps65910' and 'regulator/topic/tps65917' into regulator-next
|
2017-07-03 16:52:21 +01:00 |
|
remoteproc
|
|
|
|
reset
|
ARM: SoC driver updates
|
2017-07-04 14:47:47 -07:00 |
|
rpmsg
|
rpmsg updates for v4.13
|
2017-07-06 15:38:31 -07:00 |
|
rtc
|
|
|
|
s390
|
libnvdimm for 4.13
|
2017-07-07 09:44:06 -07:00 |
|
sbus
|
|
|
|
scsi
|
SCSI misc on 20170704
|
2017-07-06 12:10:33 -07:00 |
|
sfi
|
|
|
|
sh
|
drivers/sh/intc/virq.c: delete an error message for a failed memory allocation in add_virq_to_pirq()
|
2017-07-06 16:24:30 -07:00 |
|
sn
|
|
|
|
soc
|
ARM: SoC driver updates
|
2017-07-04 14:47:47 -07:00 |
|
spi
|
Merge branch 'for-spi' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
|
2017-07-08 10:41:53 -07:00 |
|
spmi
|
|
|
|
ssb
|
|
|
|
staging
|
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid
|
2017-07-10 09:22:48 -07:00 |
|
target
|
Merge branch 'work.read_write' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
|
2017-07-05 14:35:57 -07:00 |
|
tc
|
|
|
|
tee
|
|
|
|
thermal
|
Merge (most of) tag 'mfd-next-4.13' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd
|
2017-07-07 13:30:05 -07:00 |
|
thunderbolt
|
|
|
|
tty
|
This is the bulk of GPIO changes for the v4.13 series:
|
2017-07-07 12:40:27 -07:00 |
|
uio
|
|
|
|
usb
|
USB fixes for 4.13-rc1
|
2017-07-07 13:42:04 -07:00 |
|
uwb
|
driver core patches for 4.13-rc1
|
2017-07-03 20:27:48 -07:00 |
|
vfio
|
|
|
|
vhost
|
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
|
2017-07-05 12:31:59 -07:00 |
|
video
|
main drm pull for v4.13
|
2017-07-09 18:48:37 -07:00 |
|
virt
|
|
|
|
virtio
|
|
|
|
vlynq
|
|
|
|
vme
|
|
|
|
w1
|
|
|
|
watchdog
|
|
|
|
xen
|
This is the first pull request for the new dma-mapping subsystem
|
2017-07-06 19:20:54 -07:00 |
|
zorro
|
|
|
|
Kconfig
|
|
|
|
Makefile
|
|
|