Repository files (latest commit first)

Filename	Latest commit message	Latest commit date
Zhang Zhengming bc0905a765 relayfs: fix out-of-bounds access in relay_file_read ... [ Upstream commit 43ec16f1450f4936025a9bdf1a273affdb9732c1 ] There is a crash in relay_file_read, as the var from point to the end of last subbuf. The oops looks something like: pc : __arch_copy_to_user+0x180/0x310 lr : relay_file_read+0x20c/0x2c8 Call trace: __arch_copy_to_user+0x180/0x310 full_proxy_read+0x68/0x98 vfs_read+0xb0/0x1d0 ksys_read+0x6c/0xf0 __arm64_sys_read+0x20/0x28 el0_svc_common.constprop.3+0x84/0x108 do_el0_svc+0x74/0x90 el0_svc+0x1c/0x28 el0_sync_handler+0x88/0xb0 el0_sync+0x148/0x180 We get the condition by analyzing the vmcore: 1). The last produced byte and last consumed byte both at the end of the last subbuf 2). A softirq calls function(e.g __blk_add_trace) to write relay buffer occurs when an program is calling relay_file_read_avail(). relay_file_read relay_file_read_avail relay_file_read_consume(buf, 0, 0); //interrupted by softirq who will write subbuf .... return 1; //read_start point to the end of the last subbuf read_start = relay_file_read_start_pos //avail is equal to subsize avail = relay_file_read_subbuf_avail //from points to an invalid memory address from = buf->start + read_start //system is crashed copy_to_user(buffer, from, avail) Link: https://lkml.kernel.org/r/20230419040203.37676-1-zhang.zhengming@h3c.com Fixes: 8d62fdebda ("relay file read: start-pos fix") Signed-off-by: Zhang Zhengming <zhang.zhengming@h3c.com> Reviewed-by: Zhao Lei <zhao_lei1@hoperun.com> Reviewed-by: Zhou Kete <zhou.kete@h3c.com> Reviewed-by: Pengcheng Yang <yangpc@wangsu.com> Cc: Jens Axboe <axboe@kernel.dk> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-05-17 11:35:58 +02:00
..
bpf	bpf: Don't EFAULT for getsockopt with optval=NULL	2023-05-17 11:35:44 +02:00
cgroup	cgroup/cpuset: Wake up cpuset_attach_wq tasks in cpuset_cancel_attach()	2023-04-20 12:07:32 +02:00
configs
debug	treewide: Replace DECLARE_TASKLET() with DECLARE_TASKLET_OLD()	2023-04-20 12:07:32 +02:00
dma	dma-mapping: drop the dev argument to arch_sync_dma_for_*	2023-04-05 11:16:43 +02:00
events	perf/core: Fix hardlockup failure caused by perf throttle	2023-05-17 11:35:50 +02:00
gcov	gcov: add support for checksum field	2023-01-18 11:41:42 +01:00
irq	genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()	2023-05-17 11:35:46 +02:00
livepatch	livepatch: fix race between fork and KLP transition	2022-10-26 13:22:18 +02:00
locking	locking/lockdep: Avoid RCU-induced noinstr fail	2021-11-17 09:48:28 +01:00
power	PM: hibernate: Fix mistake in kerneldoc comment	2023-01-18 11:40:53 +01:00
printk	printk: fix return value of printk.devkmsg __setup handler	2022-04-15 14:18:08 +02:00
rcu	rcu: Suppress smp_processor_id() complaint in synchronize_rcu_expedited_wait()	2023-03-11 16:43:54 +01:00
sched	sched_getaffinity: don't assume 'cpumask_size()' is fully initialized	2023-04-05 11:16:42 +02:00
time	tick/nohz: Fix cpu_is_hotpluggable() by checking with nohz subsystem	2023-05-17 11:35:57 +02:00
trace	ring-buffer: Sync IRQ works before buffer destruction	2023-05-17 11:35:33 +02:00
.gitignore	kbuild: update config_data.gz only when the content of .config is changed	2021-05-11 14:04:16 +02:00
acct.c	acct: fix potential integer overflow in encode_comp_t()	2023-01-18 11:41:34 +01:00
async.c	Revert "module, async: async_synchronize_full() on module init iff async is used"	2022-02-23 11:59:56 +01:00
audit.c	audit: improve audit queue handling when "audit=1" on cmdline	2022-02-08 18:24:26 +01:00
audit.h	audit: log AUDIT_TIME_* records only from rules	2022-04-15 14:18:04 +02:00
audit_fsnotify.c	audit: fix potential double free on error path from fsnotify_add_inode_mark	2022-09-05 10:27:38 +02:00
audit_tree.c	audit: move put_tree() to avoid trim_trees refcount underflow and UAF	2021-09-03 10:08:16 +02:00
audit_watch.c
auditfilter.c
auditsc.c	audit: log AUDIT_TIME_* records only from rules	2022-04-15 14:18:04 +02:00
backtracetest.c	treewide: Replace DECLARE_TASKLET() with DECLARE_TASKLET_OLD()	2023-04-20 12:07:32 +02:00
bounds.c
capability.c
compat.c	sched_getaffinity: don't assume 'cpumask_size()' is fully initialized	2023-04-05 11:16:42 +02:00
configs.c
context_tracking.c
cpu.c	random: clear fast pool, crng, and batches in cpuhp bring up	2022-06-22 14:11:12 +02:00
cpu_pm.c
crash_core.c
crash_dump.c
cred.c
delayacct.c
dma.c
exec_domain.c
exit.c	exit: Use READ_ONCE() for all oops/warn limit reads	2023-02-06 07:52:50 +01:00
extable.c
fail_function.c	kernel/fail_function: fix memory leak with using debugfs_lookup()	2023-03-11 16:44:15 +01:00
fork.c	copy_process(): Move fd_install() out of sighand->siglock critical section	2022-02-23 12:00:00 +01:00
freezer.c
futex.c	mm, futex: fix shared futex pgoff on shmem huge page	2021-06-30 08:47:55 -04:00
gen_kheaders.sh
groups.c
hung_task.c
iomem.c
irq_work.c
jump_label.c
kallsyms.c
kcmp.c
Kconfig.freezer
Kconfig.hz
Kconfig.locks
Kconfig.preempt
kcov.c
kexec.c
kexec_core.c
kexec_elf.c
kexec_file.c	kexec_file: drop weak attribute from arch_kexec_apply_relocations[_add]	2022-07-02 16:28:50 +02:00
kexec_internal.h
kheaders.c	kheaders: Use array declaration instead of char	2023-05-17 11:35:33 +02:00
kmod.c
kprobes.c	x86/kprobes: Fix arch_check_optimized_kprobe check within optimized_kprobe range	2023-03-11 16:44:02 +01:00
ksysfs.c
kthread.c	kthread: Fix PF_KTHREAD vs to_kthread() race	2021-09-12 08:56:39 +02:00
latencytop.c
Makefile	kbuild: update config_data.gz only when the content of .config is changed	2021-05-11 14:04:16 +02:00
module-internal.h
module.c	module: Don't wait for GOING modules	2023-02-06 07:52:43 +01:00
module_signature.c	module: harden ELF info handling	2021-04-07 14:47:38 +02:00
module_signing.c	module: harden ELF info handling	2021-04-07 14:47:38 +02:00
notifier.c
nsproxy.c
padata.c
panic.c	exit: Use READ_ONCE() for all oops/warn limit reads	2023-02-06 07:52:50 +01:00
params.c
pid.c
pid_namespace.c	memcg: enable accounting for pids in nested pid namespaces	2021-09-22 12:26:37 +02:00
profile.c	profiling: fix shift too large makes kernel panic	2022-08-25 11:18:02 +02:00
ptrace.c	ptrace: Reimplement PTRACE_KILL by always sending SIGKILL	2022-06-14 18:11:24 +02:00
range.c
reboot.c
relay.c	relayfs: fix out-of-bounds access in relay_file_read	2023-05-17 11:35:58 +02:00
resource.c
rseq.c
seccomp.c	seccomp: Invalidate seccomp mode to catch death failures	2022-02-16 12:52:53 +01:00
signal.c	signal handling: don't use BUG_ON() for debugging	2022-07-21 20:59:27 +02:00
smp.c	smp: Fix offline cpu check in flush_smp_call_function_queue()	2022-04-20 09:19:39 +02:00
smpboot.c
smpboot.h
softirq.c
stackleak.c
stacktrace.c
stop_machine.c
sys.c	prlimit: do_prlimit needs to have a speculation check	2023-01-24 07:17:59 +01:00
sys_ni.c	kernel/sys_ni: add compat entry for fadvise64_64	2022-09-05 10:27:38 +02:00
sysctl-test.c
sysctl.c	proc: proc_skip_spaces() shouldn't think it is working on C strings	2022-12-08 11:23:06 +01:00
sysctl_binary.c
task_work.c
taskstats.c
test_kprobes.c
torture.c
tracepoint.c	tracepoint: Add tracepoint_probe_register_may_exist() for BPF tracing	2021-07-14 16:53:08 +02:00
tsacct.c	taskstats: Cleanup the use of task->exit_code	2022-02-23 11:59:57 +01:00
ucount.c
uid16.c
uid16.h
umh.c
up.c	smp: Fix smp_call_function_single_async prototype	2021-05-14 09:44:33 +02:00
user-return-notifier.c
user.c
user_namespace.c
utsname.c
utsname_sysctl.c
watchdog.c	watchdog: export lockup_detector_reconfigure	2022-08-25 11:18:37 +02:00
watchdog_hld.c
workqueue.c	workqueue: don't skip lockdep work dependency in cancel_work_sync()	2022-09-28 11:04:09 +02:00
workqueue_internal.h