disconnect3d
a1081413e8
perf map: Fix off by one in strncpy() size argument
...
commit db2c549407d4a76563c579e4768f7d6d32afefba upstream.
This patch fixes an off-by-one error in strncpy size argument in
tools/perf/util/map.c. The issue is that in:
strncmp(filename, "/system/lib/", 11)
the passed string literal: "/system/lib/" has 12 bytes (without the NULL
byte) and the passed size argument is 11. As a result, the logic won't
match the ending "/" byte and will pass filepaths that are stored in
other directories e.g. "/system/libmalicious/bin" or just
"/system/libmalicious".
This functionality seems to be present only on Android. I assume the
/system/ directory is only writable by the root user, so I don't think
this bug has much (or any) security impact.
Fixes: eca8183699 ("perf tools: Add automatic remapping of Android libraries")
Signed-off-by: disconnect3d <dominik.b.czarnota@gmail.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Changbin Du <changbin.du@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: John Keeping <john@metanate.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Michael Lentine <mlentine@google.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Song Liu <songliubraving@fb.com>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lore.kernel.org/lkml/20200309104855.3775-1-dominik.b.czarnota@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-04-02 15:11:02 +02:00
..
arch
perf arm-spe: Fix endless record after being terminated
2020-03-12 13:00:22 +01:00
bench
perf bench futex-wake: Restore thread count default to online CPU count
2020-03-18 07:17:57 +01:00
Documentation
perf docs: Correct and clarify jitdump spec
2019-09-30 17:29:51 -03:00
examples /bpf
include /bpf
jvmti
perf jvmti: Link against tools/lib/ctype.h to have weak strlcpy()
2019-10-15 11:47:38 -03:00
lib
libperf: Add perf_evlist__poll() function
2019-09-25 09:51:49 -03:00
pmu-events
perf vendor events s390: Remove name from L1D_RO_EXCL_WRITES description
2020-01-17 19:48:30 +01:00
python
scripts
perf scripts python: exported-sql-viewer.py: Fix use of TRUE with SQLite
2019-12-13 08:42:16 +01:00
tests
perf tests: Disable bp_signal testing for arm64
2019-12-31 16:44:12 +01:00
trace
ui
perf ui gtk: Add missing zalloc object
2020-03-05 16:43:50 +01:00
util
perf map: Fix off by one in strncpy() size argument
2020-04-02 15:11:02 +02:00
.gitignore
perf: Update .gitignore file
2019-08-31 22:27:52 -03:00
Build
builtin-annotate.c
perf session: Return error code for perf_session__new() function on failure
2019-09-20 15:58:11 -03:00
builtin-bench.c
perf tools: Remove perf.h from source files not needing it
2019-08-29 17:38:32 -03:00
builtin-buildid-cache.c
perf session: Return error code for perf_session__new() function on failure
2019-09-20 15:58:11 -03:00
builtin-buildid-list.c
perf session: Return error code for perf_session__new() function on failure
2019-09-20 15:58:11 -03:00
builtin-c2c.c
perf c2c: Fix return type for histogram sorting comparision functions
2020-02-05 21:22:40 +00:00
builtin-config.c
perf tools: Remove util.h from where it is not needed
2019-09-20 09:19:20 -03:00
builtin-data.c
perf debug: Remove needless include directives from debug.h
2019-08-31 19:10:19 -03:00
builtin-diff.c
perf diff: Use llabs() with 64-bit values
2020-01-04 19:18:26 +01:00
builtin-evlist.c
perf evsel: Introduce evsel_fprintf.h
2019-09-25 16:26:34 -03:00
builtin-ftrace.c
perf auxtrace: Uninline functions that touch perf_session
2019-08-31 22:24:10 -03:00
builtin-help.c
perf debug: Remove needless include directives from debug.h
2019-08-31 19:10:19 -03:00
builtin-inject.c
perf session: Return error code for perf_session__new() function on failure
2019-09-20 15:58:11 -03:00
builtin-kallsyms.c
perf dsos: Move the dsos struct and its methods to separate source files
2019-08-31 22:24:10 -03:00
builtin-kmem.c
perf kmem: Fix memory leak in compact_gfp_flags()
2019-10-16 10:08:32 -03:00
builtin-kvm.c
perf tools: Propagate get_cpuid() error
2019-09-30 17:29:54 -03:00
builtin-list.c
perf list: Allow plurals for metric, metricgroup
2019-09-25 09:51:42 -03:00
builtin-lock.c
perf session: Return error code for perf_session__new() function on failure
2019-09-20 15:58:11 -03:00
builtin-mem.c
perf session: Return error code for perf_session__new() function on failure
2019-09-20 15:58:11 -03:00
builtin-probe.c
perf probe: No need for symbol.h, symbol_conf is enough
2019-08-31 22:24:10 -03:00
builtin-record.c
libperf: Add perf_evlist__poll() function
2019-09-25 09:51:49 -03:00
builtin-report.c
perf report: Fix no libunwind compiled warning break s390 issue
2020-02-05 21:22:53 +00:00
builtin-sched.c
perf evsel: Introduce evsel_fprintf.h
2019-09-25 16:26:34 -03:00
builtin-script.c
perf script: Fix --reltime with --time
2020-01-23 08:23:01 +01:00
builtin-stat.c
libperf: Move 'sample_id' from 'struct evsel' to 'struct perf_evsel'
2019-09-25 09:51:47 -03:00
builtin-timechart.c
perf session: Return error code for perf_session__new() function on failure
2019-09-20 15:58:11 -03:00
builtin-top.c
perf evsel: Move config terms to a separate header
2019-09-25 16:26:40 -03:00
builtin-trace.c
perf evsel: Introduce evsel_fprintf.h
2019-09-25 16:26:34 -03:00
builtin-version.c
perf symbols: Move mem_info and branch_info out of symbol.h
2019-08-31 22:27:48 -03:00
builtin.h
check-headers.sh
tools headers uapi: Sync linux/fs.h with the kernel sources
2019-09-30 17:29:22 -03:00
command-list.txt
CREDITS
design.txt
Makefile
tools: Let O= makes handle a relative path with -C option
2020-04-01 11:02:00 +02:00
Makefile.config
perf build: Add detection of java-11-openjdk-devel package
2019-09-25 16:26:41 -03:00
Makefile.perf
libtraceevent: Move traceevent plugins in its own subdirectory
2019-09-25 09:51:43 -03:00
MANIFEST
perf-archive.sh
perf-completion.sh
perf-read-vdso.c
perf-sys.h
perf tools: Make usage of test_attr__* optional for perf-sys.h
2019-10-31 21:38:41 +01:00
perf-with-kcore.sh
perf.c
libperf: Merge libperf_set_print() into libperf_init()
2019-09-25 09:51:49 -03:00
perf.h
perf time-utils: Adopt rdclock() from perf.h
2019-08-29 17:38:32 -03:00