Eiichi Tsukata
becf33f694
tracing: Fix out-of-range read in trace_stack_print()
Puts range check before dereferencing the pointer.
Reproducer:
# echo stacktrace > trace_options
# echo 1 > events/enable
# cat trace > /dev/null
KASAN report:
==================================================================
BUG: KASAN: use-after-free in trace_stack_print+0x26b/0x2c0
Read of size 8 at addr ffff888069d20000 by task cat/1953
CPU: 0 PID: 1953 Comm: cat Not tainted 5.2.0-rc3+ #5
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-2.fc30 04/01/2014
Call Trace:
dump_stack+0x8a/0xce
print_address_description+0x60/0x224
? trace_stack_print+0x26b/0x2c0
? trace_stack_print+0x26b/0x2c0
__kasan_report.cold+0x1a/0x3e
? trace_stack_print+0x26b/0x2c0
kasan_report+0xe/0x20
trace_stack_print+0x26b/0x2c0
print_trace_line+0x6ea/0x14d0
? tracing_buffers_read+0x700/0x700
? trace_find_next_entry_inc+0x158/0x1d0
s_show+0xea/0x310
seq_read+0xaa7/0x10e0
? seq_escape+0x230/0x230
__vfs_read+0x7c/0x100
vfs_read+0x16c/0x3a0
ksys_read+0x121/0x240
? kernel_write+0x110/0x110
? perf_trace_sys_enter+0x8a0/0x8a0
? syscall_slow_exit_work+0xa9/0x410
do_syscall_64+0xb7/0x390
? prepare_exit_to_usermode+0x165/0x200
entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x7f867681f910
Code: b6 fe ff ff 48 8d 3d 0f be 08 00 48 83 ec 08 e8 06 db 01 00 66 0f 1f 44 00 00 83 3d f9 2d 2c 00 00 75 10 b8 00 00 00 00 04
RSP: 002b:00007ffdabf23488 EFLAGS: 00000246 ORIG_RAX: 0000000000000000
RAX: ffffffffffffffda RBX: 0000000000020000 RCX: 00007f867681f910
RDX: 0000000000020000 RSI: 00007f8676cde000 RDI: 0000000000000003
RBP: 00007f8676cde000 R08: ffffffffffffffff R09: 0000000000000000
R10: 0000000000000871 R11: 0000000000000246 R12: 00007f8676cde000
R13: 0000000000000003 R14: 0000000000020000 R15: 0000000000000ec0
Allocated by task 1214:
save_stack+0x1b/0x80
__kasan_kmalloc.constprop.0+0xc2/0xd0
kmem_cache_alloc+0xaf/0x1a0
getname_flags+0xd2/0x5b0
do_sys_open+0x277/0x5a0
do_syscall_64+0xb7/0x390
entry_SYSCALL_64_after_hwframe+0x44/0xa9
Freed by task 1214:
save_stack+0x1b/0x80
__kasan_slab_free+0x12c/0x170
kmem_cache_free+0x8a/0x1c0
putname+0xe1/0x120
do_sys_open+0x2c5/0x5a0
do_syscall_64+0xb7/0x390
entry_SYSCALL_64_after_hwframe+0x44/0xa9
The buggy address belongs to the object at ffff888069d20000
which belongs to the cache names_cache of size 4096
The buggy address is located 0 bytes inside of
4096-byte region [ffff888069d20000, ffff888069d21000)
The buggy address belongs to the page:
page:ffffea0001a74800 refcount:1 mapcount:0 mapping:ffff88806ccd1380 index:0x0 compound_mapcount: 0
flags: 0x100000000010200(slab|head)
raw: 0100000000010200 dead000000000100 dead000000000200 ffff88806ccd1380
raw: 0000000000000000 0000000000070007 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
Memory state around the buggy address:
ffff888069d1ff00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
ffff888069d1ff80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>ffff888069d20000: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
^
ffff888069d20080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
ffff888069d20100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================
Link: http://lkml.kernel.org/r/20190610040016.5598-1-devel@etsukata.com
Fixes: 4285f2fcef ("tracing: Remove the ULONG_MAX stack trace hackery")
Signed-off-by: Eiichi Tsukata <devel@etsukata.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
|
2019-06-14 16:28:42 -04:00 |
| .. |
|
bpf
|
bpf: fix undefined behavior in narrow load handling
|
2019-05-13 02:05:50 +02:00 |
|
cgroup
|
kernel/sched/psi.c: expose pressure metrics on root cgroup
|
2019-05-14 19:52:48 -07:00 |
|
configs
|
|
|
|
debug
|
kdb: Fix bound check compiler warning
|
2019-05-14 13:44:24 +01:00 |
|
dma
|
DMA mapping updates for 5.2
|
2019-05-09 08:40:55 -07:00 |
|
events
|
mm/mmu_notifier: use correct mmu_notifier events for each invalidation
|
2019-05-14 09:47:49 -07:00 |
|
gcov
|
gcov: clang support
|
2019-05-14 19:52:51 -07:00 |
|
irq
|
Merge branch 'irq-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
|
2019-05-19 10:58:45 -07:00 |
|
livepatch
|
The major changes in this tracing update includes:
|
2019-05-15 16:05:47 -07:00 |
|
locking
|
locking/rwsem: Prevent decrement of reader count before increment
|
2019-05-07 08:46:46 +02:00 |
|
power
|
Power management updates for 5.2-rc1
|
2019-05-06 19:40:31 -07:00 |
|
printk
|
panic: add an option to replay all the printk message in buffer
|
2019-05-18 15:52:26 -07:00 |
|
rcu
|
The major changes in this tracing update includes:
|
2019-05-15 16:05:47 -07:00 |
|
sched
|
kernel/sched/psi.c: expose pressure metrics on root cgroup
|
2019-05-14 19:52:48 -07:00 |
|
time
|
Merge branch 'timers-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
|
2019-05-16 11:00:20 -07:00 |
|
trace
|
tracing: Fix out-of-range read in trace_stack_print()
|
2019-06-14 16:28:42 -04:00 |
|
.gitignore
|
Provide in-kernel headers to make extending kernel easier
|
2019-04-29 16:48:03 +02:00 |
|
acct.c
|
acct_on(): don't mess with freeze protection
|
2019-04-04 21:04:13 -04:00 |
|
async.c
|
treewide: Switch printk users from %pf and %pF to %ps and %pS, respectively
|
2019-04-09 14:19:06 +02:00 |
|
audit.c
|
audit: connect LOGIN record to its syscall record
|
2019-03-20 20:57:48 -04:00 |
|
audit.h
|
audit_compare_dname_path(): switch to const struct qstr *
|
2019-04-28 20:33:43 -04:00 |
|
audit_fsnotify.c
|
audit_compare_dname_path(): switch to const struct qstr *
|
2019-04-28 20:33:43 -04:00 |
|
audit_tree.c
|
fsnotify: switch send_to_group() and ->handle_event to const struct qstr *
|
2019-04-26 13:51:03 -04:00 |
|
audit_watch.c
|
audit_compare_dname_path(): switch to const struct qstr *
|
2019-04-28 20:33:43 -04:00 |
|
auditfilter.c
|
Merge branch 'work.dcache' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
|
2019-05-07 20:03:32 -07:00 |
|
auditsc.c
|
Merge branch 'work.dcache' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
|
2019-05-07 20:03:32 -07:00 |
|
backtracetest.c
|
backtrace-test: Simplify stack trace handling
|
2019-04-29 12:37:47 +02:00 |
|
bounds.c
|
|
|
|
capability.c
|
|
|
|
compat.c
|
kernel/compat.c: mark expected switch fall-throughs
|
2019-05-15 08:16:14 -07:00 |
|
configs.c
|
kernel/configs: use .incbin directive to embed config_data.gz
|
2019-03-07 18:32:02 -08:00 |
|
context_tracking.c
|
|
|
|
cpu.c
|
Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
|
2019-05-06 14:50:46 -07:00 |
|
cpu_pm.c
|
|
|
|
crash_core.c
|
kexec: export PG_offline to VMCOREINFO
|
2019-03-05 21:07:14 -08:00 |
|
crash_dump.c
|
|
|
|
cred.c
|
|
|
|
delayacct.c
|
|
|
|
dma.c
|
|
|
|
elfcore.c
|
|
|
|
exec_domain.c
|
|
|
|
exit.c
|
mm: change mm_update_next_owner() to update mm->owner with WRITE_ONCE
|
2019-05-14 19:52:47 -07:00 |
|
extable.c
|
|
|
|
fail_function.c
|
treewide: Switch printk users from %pf and %pF to %ps and %pS, respectively
|
2019-04-09 14:19:06 +02:00 |
|
fork.c
|
kernel/latencytop.c: rename clear_all_latency_tracing to clear_tsk_latency_tracing
|
2019-05-14 19:52:49 -07:00 |
|
freezer.c
|
|
|
|
futex.c
|
mm/gup: change GUP fast to use flags rather than a write 'bool'
|
2019-05-14 09:47:46 -07:00 |
|
gen_ikh_data.sh
|
Provide in-kernel headers to make extending kernel easier
|
2019-04-29 16:48:03 +02:00 |
|
groups.c
|
|
|
|
hung_task.c
|
kernel/hung_task.c: Use continuously blocked time when reporting.
|
2019-03-07 18:31:59 -08:00 |
|
iomem.c
|
mm/resource: Use resource_overlaps() to simplify region_intersects()
|
2019-04-19 12:59:36 +02:00 |
|
irq_work.c
|
irq_work: Do not raise an IPI when queueing work on the local CPU
|
2019-04-18 14:07:52 +02:00 |
|
jump_label.c
|
locking/static_key: Don't take sleeping locks in __static_key_slow_dec_deferred()
|
2019-04-29 08:29:21 +02:00 |
|
kallsyms.c
|
|
|
|
kcmp.c
|
|
|
|
Kconfig.freezer
|
|
|
|
Kconfig.hz
|
|
|
|
Kconfig.locks
|
Remove Mysterious Macro Intended to Obscure Weird Behaviours (mmiowb())
|
2019-05-06 16:57:52 -07:00 |
|
Kconfig.preempt
|
|
|
|
kcov.c
|
kcov: convert kcov.refcount to refcount_t
|
2019-03-07 18:32:02 -08:00 |
|
kexec.c
|
|
|
|
kexec_core.c
|
power/suspend: Add function to disable secondaries for suspend
|
2019-05-03 19:42:41 +02:00 |
|
kexec_file.c
|
mm: memblock: make keeping memblock memory opt-in rather than opt-out
|
2019-05-14 09:47:50 -07:00 |
|
kexec_internal.h
|
|
|
|
kheaders.c
|
Provide in-kernel headers to make extending kernel easier
|
2019-04-29 16:48:03 +02:00 |
|
kmod.c
|
|
|
|
kprobes.c
|
kprobes: Fix error check when reusing optimized probes
|
2019-04-16 09:38:16 +02:00 |
|
ksysfs.c
|
|
|
|
kthread.c
|
include/: refactor headers to allow kthread.h inclusion in psi_types.h
|
2019-05-14 19:52:48 -07:00 |
|
latencytop.c
|
kernel/latencytop.c: rename clear_all_latency_tracing to clear_tsk_latency_tracing
|
2019-05-14 19:52:49 -07:00 |
|
Makefile
|
kernel/Makefile: don't assume that kernel/gen_ikh_data.sh is executable
|
2019-05-14 19:52:47 -07:00 |
|
memremap.c
|
kernel/memremap.c: remove the unused device_private_entry_fault() export
|
2019-05-14 09:47:51 -07:00 |
|
module-internal.h
|
kallsyms: store type information in its own array
|
2019-03-28 15:00:37 +01:00 |
|
module.c
|
Modules updates for v5.2
|
2019-05-14 10:55:54 -07:00 |
|
module_signing.c
|
|
|
|
notifier.c
|
kernel/notifier.c: double register detection
|
2019-05-14 19:52:49 -07:00 |
|
nsproxy.c
|
|
|
|
padata.c
|
padata: Replace padata_attr_type default_attrs field with groups
|
2019-04-25 22:06:11 +02:00 |
|
panic.c
|
panic: add an option to replay all the printk message in buffer
|
2019-05-18 15:52:26 -07:00 |
|
params.c
|
|
|
|
pid.c
|
kernel/pid.c: remove unneeded hash header file
|
2019-05-14 19:52:51 -07:00 |
|
pid_namespace.c
|
|
|
|
profile.c
|
|
|
|
ptrace.c
|
ptrace: take into account saved_sigmask in PTRACE{GET,SET}SIGMASK
|
2019-03-29 10:01:37 -07:00 |
|
range.c
|
|
|
|
reboot.c
|
panic/reboot: allow specifying reboot_mode for panic only
|
2019-05-14 19:52:51 -07:00 |
|
relay.c
|
Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
|
2019-03-12 13:27:20 -07:00 |
|
resource.c
|
mm/resource: Use resource_overlaps() to simplify region_intersects()
|
2019-04-19 12:59:36 +02:00 |
|
rseq.c
|
rseq: Remove superfluous rseq_len from task_struct
|
2019-04-19 12:39:32 +02:00 |
|
seccomp.c
|
audit/stable-5.2 PR 20190507
|
2019-05-07 19:06:04 -07:00 |
|
signal.c
|
signal: unconditionally leave the frozen state in ptrace_stop()
|
2019-05-16 10:43:58 -07:00 |
|
smp.c
|
|
|
|
smpboot.c
|
|
|
|
smpboot.h
|
|
|
|
softirq.c
|
softirq: Remove tasklet_hrtimer
|
2019-03-22 14:36:02 +01:00 |
|
stackleak.c
|
|
|
|
stacktrace.c
|
stacktrace: Provide common infrastructure
|
2019-04-29 12:37:57 +02:00 |
|
stop_machine.c
|
treewide: Switch printk users from %pf and %pF to %ps and %pS, respectively
|
2019-04-09 14:19:06 +02:00 |
|
sys.c
|
kernel/sys.c: prctl: fix false positive in validate_prctl_map()
|
2019-05-14 09:47:44 -07:00 |
|
sys_ni.c
|
signal: support CLONE_PIDFD with pidfd_send_signal
|
2019-05-07 14:31:03 +02:00 |
|
sysctl.c
|
kernel/sysctl.c: fix proc_do_large_bitmap for large input buffers
|
2019-05-14 19:52:51 -07:00 |
|
sysctl_binary.c
|
|
|
|
task_work.c
|
|
|
|
taskstats.c
|
genetlink: optionally validate strictly/dumps
|
2019-04-27 17:07:22 -04:00 |
|
test_kprobes.c
|
|
|
|
torture.c
|
torture: Don't try to offline the last CPU
|
2019-03-26 14:42:53 -07:00 |
|
tracepoint.c
|
|
|
|
tsacct.c
|
|
|
|
ucount.c
|
|
|
|
uid16.c
|
|
|
|
uid16.h
|
|
|
|
umh.c
|
|
|
|
up.c
|
|
|
|
user-return-notifier.c
|
|
|
|
user.c
|
kernel/user.c: clean up some leftover code
|
2019-05-14 19:52:49 -07:00 |
|
user_namespace.c
|
|
|
|
utsname.c
|
|
|
|
utsname_sysctl.c
|
|
|
|
watchdog.c
|
watchdog: Fix typo in comment
|
2019-04-18 14:05:51 +02:00 |
|
watchdog_hld.c
|
kernel/watchdog_hld.c: hard lockup message should end with a newline
|
2019-04-19 09:46:05 -07:00 |
|
workqueue.c
|
Merge branch 'for-5.2' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq
|
2019-05-09 13:48:52 -07:00 |
|
workqueue_internal.h
|
sched/core, workqueues: Distangle worker accounting from rq lock
|
2019-04-16 16:55:15 +02:00 |