Even Xu
c118ae56a5
hid: intel-ish-hid: ishtp: Fix ishtp client sending disordered message ...
[ Upstream commit e1fa076706209cc447d7a2abd0843a18277e5ef7 ]
There is a timing issue captured during ishtp client sending stress tests.
It was observed during stress tests that ISH firmware is getting out of
ordered messages. This is a rare scenario as the current set of ISH client
drivers don't send much data to firmware. But this may not be the case
going forward.
When message size is bigger than IPC MTU, ishtp splits the message into
fragments and uses serialized async method to send message fragments.
The call stack:
ishtp_cl_send_msg_ipc->ipc_tx_callback(first fregment)->
ishtp_send_msg(with callback)->write_ipc_to_queue->
write_ipc_from_queue->callback->ipc_tx_callback(next fregment)......
When an ipc write complete interrupt is received, driver also calls
write_ipc_from_queue->ipc_tx_callback in ISR to start sending of next fragment.
Through ipc_tx_callback uses spin_lock to protect message splitting, as the
serialized sending method will call back to ipc_tx_callback again, so it doesn't
put sending under spin_lock, it causes driver cannot guarantee all fragments
be sent in order.
Considering this scenario:
ipc_tx_callback just finished a fragment splitting, and not call ishtp_send_msg
yet, there is a write complete interrupt happens, then ISR->write_ipc_from_queue
->ipc_tx_callback->ishtp_send_msg->write_ipc_to_queue......
Because ISR has higher exec priority than normal thread, this causes the new
fragment be sent out before previous fragment. This disordered message causes
invalid message to firmware.
The solution is, to send fragments synchronously:
Use ishtp_write_message writing fragments into tx queue directly one by one,
instead of ishtp_send_msg only writing one fragment with completion callback.
As no completion callback be used, so change ipc_tx_callback to ipc_tx_send.
Signed-off-by: Even Xu <even.xu@intel.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-09-20 12:27:59 +02:00
HID: i2c-hid: fix GET/SET_REPORT for unnumbered reports
2022-04-15 14:18:12 +02:00
hid: intel-ish-hid: ishtp: Fix ishtp client sending disordered message
2022-09-20 12:27:59 +02:00
HID: usbhid: free raw_report buffers in usbhid_stop
2021-10-06 15:42:39 +02:00
HID: alps: Declare U1_UNICORN_LEGACY support
2022-08-25 11:17:57 +02:00
HID: apple: Do not reset quirks when the Fn key is not found
2022-01-27 09:19:41 +01:00
HID: add hid_is_usb() function to make it simpler for USB detection
2021-12-14 14:48:58 +01:00
HID: betop: fix slab-out-of-bounds Write in betop_probe
2021-10-06 15:42:39 +02:00
HID: bigben: fix slab-out-of-bounds Write in bigben_probe
2022-06-14 18:11:27 +02:00
HID: check for valid USB device for many HID drivers
2021-12-14 14:48:59 +01:00
HID: do not use down_interruptible() when unbinding devices
2021-07-14 16:53:16 +02:00
HID: check for valid USB device for many HID drivers
2021-12-14 14:48:59 +01:00
HID: cp2112: prevent a buffer overflow in cp2112_xfer()
2022-08-25 11:17:50 +02:00
HID: cypress: Support Varmilo Keyboards' media hotkeys
2020-12-02 08:49:47 +01:00
HID: add mapping for KEY_ALL_APPLICATIONS
2022-03-08 19:07:50 +01:00
HID: elan: Fix potential double free in elan_input_configured
2022-06-14 18:11:33 +02:00
HID: check for valid USB device for many HID drivers
2021-12-14 14:48:59 +01:00
HID: google: add eel USB id
2021-12-14 14:48:58 +01:00
HID: gt683r: add missing MODULE_DEVICE_TABLE
2021-06-18 09:58:58 +02:00
HID: check for valid USB device for many HID drivers
2021-12-14 14:48:59 +01:00
HID: holtek: fix mouse probing
2021-12-29 12:23:33 +01:00
HID:Add support for UGTABLET WP5540
2022-02-23 11:59:54 +01:00
HID: add mapping for KEY_ALL_APPLICATIONS
2022-03-08 19:07:50 +01:00
HID: ite: Replace ABS_MISC 120/121 events with touchpad on/off keypresses
2020-12-02 08:49:47 +01:00
HID: hid-led: fix maximum brightness for Dream Cheeky
2022-06-14 18:11:33 +02:00
HID: check for valid USB device for many HID drivers
2021-12-14 14:48:59 +01:00
HID: logitech-dj: add new lightspeed receiver id
2022-04-15 14:17:56 +02:00
HID: logitech-hidpp: Add HIDPP_CONSUMER_VENDOR_KEYS quirk for the Dinovo Edge
2020-12-02 08:49:48 +01:00
HID: magicmouse: fix NULL-deref on disconnect
2021-06-10 13:37:10 +02:00
HID: mf: add support for 0079:1846 Mayflash/Dragonrise USB Gamecube Adapter
2021-03-11 14:06:50 +01:00
HID: microsoft: Add rumble support for the 8bitdo SN30 Pro+ controller
2020-09-17 13:47:48 +02:00
HID: multitouch: Add support for Google Whiskers Touchpad
2022-06-06 08:33:51 +02:00
HID: plantronics: Workaround for double volume key presses
2021-05-14 09:44:26 +02:00
HID: check for valid USB device for many HID drivers
2021-12-14 14:48:59 +01:00
HID:Add support for UGTABLET WP5540
2022-02-23 11:59:54 +01:00
HID: check for valid USB device for many HID drivers
2021-12-14 14:48:59 +01:00
HID: check for valid USB device for many HID drivers
2021-12-14 14:48:59 +01:00
HID: check for valid USB device for many HID drivers
2021-12-14 14:48:59 +01:00
HID: check for valid USB device for many HID drivers
2021-12-14 14:48:59 +01:00
HID: check for valid USB device for many HID drivers
2021-12-14 14:48:59 +01:00
HID: check for valid USB device for many HID drivers
2021-12-14 14:48:59 +01:00
HID: check for valid USB device for many HID drivers
2021-12-14 14:48:59 +01:00
HID: check for valid USB device for many HID drivers
2021-12-14 14:48:59 +01:00
HID: check for valid USB device for many HID drivers
2021-12-14 14:48:59 +01:00
HID: check for valid USB device for many HID drivers
2021-12-14 14:48:59 +01:00
HID: check for valid USB device for many HID drivers
2021-12-14 14:48:59 +01:00
HID: hid-sensor-hub: Return error for hid_set_field() failure
2021-06-18 09:58:58 +02:00
HID: steam: Prevent NULL pointer dereference in steam_{recv,send}_report
2022-09-05 10:27:45 +02:00
HID: add hid_is_usb() function to make it simpler for USB detection
2021-12-14 14:48:58 +01:00
HID: check for valid USB device for many HID drivers
2021-12-14 14:48:59 +01:00
HID: hid-uclogic-params: Invalid parameter check in uclogic_params_frame_init_v1_buttonpad
2022-01-27 09:19:36 +01:00
HID: hidraw: fix memory leak in hidraw_release()
2022-09-05 10:27:45 +02:00
HID: asus: Add depends on USB_HID to HID_ASUS Kconfig option
2022-01-05 12:37:43 +01:00
HID: uhid: Fix worker destroying device without any protection
2022-01-27 09:19:26 +01:00
HID: wacom: Don't register pad_input for touch switch
2022-08-25 11:17:19 +02:00
HID: wacom: Don't register pad_input for touch switch
2022-08-25 11:17:19 +02:00
HID: wacom: Use "Confidence" flag to prevent reporting invalid contacts
2021-12-01 09:23:28 +01:00
c118ae56a5