Laurence de Bruxelles
967ec4b059
rtc: pxa: fix null pointer dereference ...
commit 34127b3632b21e5c391756e724b1198eb9917981 upstream.
With the latest stable kernel versions the rtc on the PXA based
Zaurus does not work, when booting I see the following kernel messages:
pxa-rtc pxa-rtc: failed to find rtc clock source
pxa-rtc pxa-rtc: Unable to init SA1100 RTC sub-device
pxa-rtc: probe of pxa-rtc failed with error -2
hctosys: unable to open rtc device (rtc0)
I think this is because commit f2997775b111 ("rtc: sa1100: fix possible
race condition") moved the allocation of the rtc_device struct out of
sa1100_rtc_init and into sa1100_rtc_probe. This means that pxa_rtc_probe
also needs to do allocation for the rtc_device struct, otherwise
sa1100_rtc_init will try to dereference a null pointer. This patch adds
that allocation by copying how sa1100_rtc_probe in
drivers/rtc/rtc-sa1100.c does it; after the IRQs are set up a managed
rtc_device is allocated.
I've tested this patch with `qemu-system-arm -machine akita` and with a
real Zaurus SL-C1000 applied to 4.19, 5.4, and 5.10.
Signed-off-by: Laurence de Bruxelles <lfdebrux@gmail.com>
Fixes: f2997775b111 ("rtc: sa1100: fix possible race condition")
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20220101154149.12026-1-lfdebrux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-01-27 09:19:53 +01:00
rtc: rx8010: select REGMAP_I2C
2021-09-26 14:07:14 +02:00
rtc: fix snprintf() checking in is_rtc_hctosys()
2021-07-20 16:10:51 +02:00
rtc: 88pm860x: fix possible race condition
2020-04-23 10:36:31 +02:00
rtc: cmos: take rtc_lock while reading from CMOS
2022-01-27 09:19:27 +01:00
rtc: ds1307: Fix wday settings for rx8130
2021-05-19 10:08:26 +02:00
rtc: ds1374: fix possible race condition
2020-10-01 13:17:43 +02:00
rtc: ep93xx: Fix NULL pointer dereference in ep93xx_rtc_read_time
2020-12-30 11:51:47 +01:00
rtc: fsl-ftm-alarm: add MODULE_TABLE()
2021-05-19 10:08:25 +02:00
rtc: goldfish: Enable interrupt in set_alarm() when necessary
2020-08-26 10:40:54 +02:00
rtc: max77686: Do not enforce (incorrect) interrupt trigger type
2021-07-25 14:35:12 +02:00
rtc: mc13xxx: fix a double-unlock issue
2020-06-24 17:50:12 +02:00
rtc: mxc_v2: add missing MODULE_DEVICE_TABLE
2021-07-25 14:35:11 +02:00
rtc: pcf2127: fix pcf2127_nvmem_read/write() returns
2020-12-30 11:51:02 +01:00
rtc: pl031: fix resource leak in pl031_probe
2021-01-06 14:48:39 +01:00
rtc: pxa: fix null pointer dereference
2022-01-27 09:19:53 +01:00
rtc: rv3028: Add missed check for devm_regmap_init_i2c()
2020-06-24 17:50:36 +02:00
rtc: rx8010: don't modify the global rtc ops
2020-11-05 11:43:33 +01:00
rtc: sa1100: fix possible race condition
2020-10-01 13:17:43 +02:00
rtc: stm32: Fix unbalanced clk_disable_unprepare() on probe error path
2021-07-14 16:53:05 +02:00
rtc: sun6i: Fix memleak in sun6i_rtc_clk_init
2021-01-06 14:48:39 +01:00
rtc: tps65910: Correct driver module alias
2021-09-22 12:26:19 +02:00
