Pavel Tatashin
13ae9eaae0
mm: call cond_resched() from deferred_init_memmap()
commit da97f2d56bbd880b4138916a7ef96f9881a551b2 upstream.
Now that deferred pages are initialized with interrupts enabled we can
replace touch_nmi_watchdog() with cond_resched(), as it was before
3a2d7fa8a3.
For now, we cannot do the same in deferred_grow_zone() as it is still
initializes pages with interrupts disabled.
This change fixes RCU problem described in
https://lkml.kernel.org/r/20200401104156.11564-2-david@redhat.com
[ 60.474005] rcu: INFO: rcu_sched detected stalls on CPUs/tasks:
[ 60.475000] rcu: 1-...0: (0 ticks this GP) idle=02a/1/0x4000000000000000 softirq=1/1 fqs=15000
[ 60.475000] rcu: (detected by 0, t=60002 jiffies, g=-1199, q=1)
[ 60.475000] Sending NMI from CPU 0 to CPUs 1:
[ 1.760091] NMI backtrace for cpu 1
[ 1.760091] CPU: 1 PID: 20 Comm: pgdatinit0 Not tainted 4.18.0-147.9.1.el8_1.x86_64 #1
[ 1.760091] Hardware name: Red Hat KVM, BIOS 1.13.0-1.module+el8.2.0+5520+4e5817f3 04/01/2014
[ 1.760091] RIP: 0010:__init_single_page.isra.65+0x10/0x4f
[ 1.760091] Code: 48 83 cf 63 48 89 f8 0f 1f 40 00 48 89 c6 48 89 d7 e8 6b 18 80 ff 66 90 5b c3 31 c0 b9 10 00 00 00 49 89 f8 48 c1 e6 33 f3 ab <b8> 07 00 00 00 48 c1 e2 36 41 c7 40 34 01 00 00 00 48 c1 e0 33 41
[ 1.760091] RSP: 0000:ffffba783123be40 EFLAGS: 00000006
[ 1.760091] RAX: 0000000000000000 RBX: fffffad34405e300 RCX: 0000000000000000
[ 1.760091] RDX: 0000000000000000 RSI: 0010000000000000 RDI: fffffad34405e340
[ 1.760091] RBP: 0000000033f3177e R08: fffffad34405e300 R09: 0000000000000002
[ 1.760091] R10: 000000000000002b R11: ffff98afb691a500 R12: 0000000000000002
[ 1.760091] R13: 0000000000000000 R14: 000000003f03ea00 R15: 000000003e10178c
[ 1.760091] FS: 0000000000000000(0000) GS:ffff9c9ebeb00000(0000) knlGS:0000000000000000
[ 1.760091] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 1.760091] CR2: 00000000ffffffff CR3: 000000a1cf20a001 CR4: 00000000003606e0
[ 1.760091] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 1.760091] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 1.760091] Call Trace:
[ 1.760091] deferred_init_pages+0x8f/0xbf
[ 1.760091] deferred_init_memmap+0x184/0x29d
[ 1.760091] ? deferred_free_pages.isra.97+0xba/0xba
[ 1.760091] kthread+0x112/0x130
[ 1.760091] ? kthread_flush_work_fn+0x10/0x10
[ 1.760091] ret_from_fork+0x35/0x40
[ 89.123011] node 0 initialised, 1055935372 pages in 88650ms
Fixes: 3a2d7fa8a3 ("mm: disable interrupts while initializing deferred pages")
Reported-by: Yiqian Wei <yiwei@redhat.com>
Signed-off-by: Pavel Tatashin <pasha.tatashin@soleen.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Tested-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Daniel Jordan <daniel.m.jordan@oracle.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: James Morris <jmorris@namei.org>
Cc: Kirill Tkhai <ktkhai@virtuozzo.com>
Cc: Sasha Levin <sashal@kernel.org>
Cc: Shile Zhang <shile.zhang@linux.alibaba.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: <stable@vger.kernel.org> [4.17+]
Link: http://lkml.kernel.org/r/20200403140952.17177-4-pasha.tatashin@soleen.com
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
2020-06-22 09:31:14 +02:00 |
| .. |
|
kasan
|
kasan: disable branch tracing for core runtime
|
2020-05-27 17:46:48 +02:00 |
|
backing-dev.c
|
bdi: add a ->dev_name field to struct backing_dev_info
|
2020-05-14 07:58:30 +02:00 |
|
balloon_compaction.c
|
|
|
|
cleancache.c
|
|
|
|
cma.c
|
|
|
|
cma.h
|
|
|
|
cma_debug.c
|
|
|
|
compaction.c
|
|
|
|
debug.c
|
mm/debug.c: always print flags in dump_page()
|
2020-03-05 16:43:51 +01:00 |
|
debug_page_ref.c
|
|
|
|
dmapool.c
|
|
|
|
early_ioremap.c
|
|
|
|
fadvise.c
|
|
|
|
failslab.c
|
|
|
|
filemap.c
|
|
|
|
frame_vector.c
|
|
|
|
frontswap.c
|
|
|
|
gup.c
|
gup: document and work around "COW can break either way" issue
|
2020-06-17 16:40:30 +02:00 |
|
gup_benchmark.c
|
|
|
|
highmem.c
|
|
|
|
hmm.c
|
|
|
|
huge_memory.c
|
mm: thp: make the THP mapcount atomic against __split_huge_pmd_locked()
|
2020-06-22 09:31:14 +02:00 |
|
hugetlb.c
|
mm/hugetlb: fix a addressing exception caused by huge_pte_offset
|
2020-04-29 16:33:14 +02:00 |
|
hugetlb_cgroup.c
|
|
|
|
hwpoison-inject.c
|
|
|
|
init-mm.c
|
|
|
|
internal.h
|
|
|
|
interval_tree.c
|
|
|
|
Kconfig
|
|
|
|
Kconfig.debug
|
|
|
|
khugepaged.c
|
mm,thp: stop leaking unreleased file pages
|
2020-06-03 08:21:26 +02:00 |
|
kmemleak-test.c
|
|
|
|
kmemleak.c
|
|
|
|
ksm.c
|
mm/ksm: fix NULL pointer dereference when KSM zero page is enabled
|
2020-04-29 16:33:15 +02:00 |
|
list_lru.c
|
|
|
|
maccess.c
|
|
|
|
madvise.c
|
mm: do not allow MADV_PAGEOUT for CoW pages
|
2020-03-25 08:25:57 +01:00 |
|
Makefile
|
|
|
|
memblock.c
|
|
|
|
memcontrol.c
|
mm, memcg: fix error return value of mem_cgroup_css_alloc()
|
2020-05-14 07:58:30 +02:00 |
|
memfd.c
|
|
|
|
memory-failure.c
|
|
|
|
memory.c
|
|
|
|
memory_hotplug.c
|
mm, hotplug: fix page online with DEBUG_PAGEALLOC compiled but not enabled
|
2020-03-12 13:00:19 +01:00 |
|
mempolicy.c
|
mm: mempolicy: require at least one nodeid for MPOL_PREFERRED
|
2020-04-08 09:08:47 +02:00 |
|
mempool.c
|
|
|
|
memremap.c
|
|
|
|
memtest.c
|
|
|
|
migrate.c
|
|
|
|
mincore.c
|
|
|
|
mlock.c
|
|
|
|
mm_init.c
|
|
|
|
mmap.c
|
|
|
|
mmu_context.c
|
|
|
|
mmu_gather.c
|
|
|
|
mmu_notifier.c
|
|
|
|
mmzone.c
|
|
|
|
mprotect.c
|
mm, numa: fix bad pmd by atomically check for pmd_trans_huge when marking page tables prot_numa
|
2020-03-12 13:00:19 +01:00 |
|
mremap.c
|
mm: Fix mremap not considering huge pmd devmap
|
2020-06-07 13:18:46 +02:00 |
|
msync.c
|
|
|
|
nommu.c
|
x86/mm: split vmalloc_sync_all()
|
2020-03-25 08:25:58 +01:00 |
|
oom_kill.c
|
|
|
|
page-writeback.c
|
|
|
|
page_alloc.c
|
mm: call cond_resched() from deferred_init_memmap()
|
2020-06-22 09:31:14 +02:00 |
|
page_counter.c
|
|
|
|
page_ext.c
|
|
|
|
page_idle.c
|
|
|
|
page_io.c
|
|
|
|
page_isolation.c
|
|
|
|
page_owner.c
|
|
|
|
page_poison.c
|
|
|
|
page_vma_mapped.c
|
|
|
|
pagewalk.c
|
|
|
|
percpu-internal.h
|
|
|
|
percpu-km.c
|
|
|
|
percpu-stats.c
|
|
|
|
percpu-vm.c
|
|
|
|
percpu.c
|
|
|
|
pgtable-generic.c
|
|
|
|
process_vm_access.c
|
|
|
|
readahead.c
|
|
|
|
rmap.c
|
|
|
|
rodata_test.c
|
|
|
|
shmem.c
|
shmem: fix possible deadlocks on shmlock_user_lock
|
2020-05-20 08:20:03 +02:00 |
|
shuffle.c
|
|
|
|
shuffle.h
|
|
|
|
slab.c
|
|
|
|
slab.h
|
|
|
|
slab_common.c
|
|
|
|
slob.c
|
|
|
|
slub.c
|
mm/slub: fix a memory leak in sysfs_slab_add()
|
2020-06-17 16:40:36 +02:00 |
|
sparse-vmemmap.c
|
|
|
|
sparse.c
|
mm/sparse: fix kernel crash with pfn_section_valid check
|
2020-04-01 11:02:03 +02:00 |
|
swap.c
|
|
|
|
swap_cgroup.c
|
|
|
|
swap_slots.c
|
|
|
|
swap_state.c
|
|
|
|
swapfile.c
|
mm/swapfile.c: move inode_lock out of claim_swapfile
|
2020-04-01 11:02:02 +02:00 |
|
truncate.c
|
|
|
|
usercopy.c
|
|
|
|
userfaultfd.c
|
|
|
|
util.c
|
mm: add kvfree_sensitive() for freeing sensitive data objects
|
2020-06-17 16:40:23 +02:00 |
|
vmacache.c
|
|
|
|
vmalloc.c
|
vmalloc: fix remap_vmalloc_range() bounds checks
|
2020-04-29 16:33:14 +02:00 |
|
vmpressure.c
|
|
|
|
vmscan.c
|
|
|
|
vmstat.c
|
|
|
|
workingset.c
|
|
|
|
z3fold.c
|
|
|
|
zbud.c
|
|
|
|
zpool.c
|
|
|
|
zsmalloc.c
|
|
|
|
zswap.c
|
|
|