Julia Lawall
5daf47bb4e
net/rds: Add missing mutex_unlock
...
Add a mutex_unlock missing on the error path. In each case, whenever the
label out is reached from elsewhere in the function, mutex is not locked.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/ )
// <smpl>
@@
expression E1;
@@
* mutex_lock(E1);
<+... when != E1
if (...) {
... when != E1
* return ...;
}
...+>
* mutex_unlock(E1);
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Reviewed-by: Zach Brown <zach.brown@oracle.com>
Acked-by: Andy Grover <andy.grover@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2010-05-29 00:18:48 -07:00
..
af_rds.c
net: sk_sleep() helper
2010-04-20 16:37:13 -07:00
bind.c
cong.c
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6
2010-04-11 14:53:53 -07:00
connection.c
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
2010-03-30 22:02:32 +09:00
ib.c
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
2010-03-30 22:02:32 +09:00
ib.h
RDS/IB+IW: Move recv processing to a tasklet
2009-10-30 15:06:39 -07:00
ib_cm.c
net/rds: Add missing mutex_unlock
2010-05-29 00:18:48 -07:00
ib_rdma.c
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6
2010-04-11 14:53:53 -07:00
ib_recv.c
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6
2010-04-11 14:53:53 -07:00
ib_ring.c
ib_send.c
RDS: Properly unmap when getting a remote access error
2010-03-16 21:17:00 -07:00
ib_stats.c
ib_sysctl.c
sysctl: Drop & in front of every proc_handler.
2009-11-18 08:37:40 -08:00
info.c
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
2010-03-30 22:02:32 +09:00
info.h
iw.c
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
2010-03-30 22:02:32 +09:00
iw.h
RDS/IB+IW: Move recv processing to a tasklet
2009-10-30 15:06:39 -07:00
iw_cm.c
net/rds: Add missing mutex_unlock
2010-05-29 00:18:48 -07:00
iw_rdma.c
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
2010-03-30 22:02:32 +09:00
iw_recv.c
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6
2010-04-11 14:53:53 -07:00
iw_ring.c
iw_send.c
RDS: Do not BUG() on error returned from ib_post_send
2010-03-16 21:16:53 -07:00
iw_stats.c
iw_sysctl.c
sysctl: Drop & in front of every proc_handler.
2009-11-18 08:37:40 -08:00
Kconfig
loop.c
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6
2010-04-11 14:53:53 -07:00
loop.h
Makefile
message.c
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
2010-03-30 22:02:32 +09:00
page.c
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
2010-03-30 22:02:32 +09:00
rdma.c
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6
2010-04-11 14:53:53 -07:00
rdma.h
rdma_transport.c
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6
2010-04-27 12:49:13 -07:00
rdma_transport.h
rds.h
net: sk_sleep() helper
2010-04-20 16:37:13 -07:00
recv.c
net: sk_sleep() helper
2010-04-20 16:37:13 -07:00
send.c
net: sk_sleep() helper
2010-04-20 16:37:13 -07:00
stats.c
sysctl.c
sysctl: Drop & in front of every proc_handler.
2009-11-18 08:37:40 -08:00
tcp.c
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
2010-03-30 22:02:32 +09:00
tcp.h
tcp_connect.c
net: Remove unnecessary semicolons after switch statements
2010-05-17 17:44:35 -07:00
tcp_listen.c
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
2010-03-30 22:02:32 +09:00
tcp_recv.c
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6
2010-04-11 14:53:53 -07:00
tcp_send.c
RDS/TCP: Wait to wake thread when write space available
2010-03-16 21:16:55 -07:00
tcp_stats.c
threads.c
RDS: Enable per-cpu workqueue threads
2010-03-16 21:17:02 -07:00
transport.c