Toke Høiland-Jørgensen
21e5fa4688
bpf: Fix stackmap overflow check on 32-bit arches ...
[ Upstream commit 7a4b21250bf79eef26543d35bd390448646c536b ]
The stackmap code relies on roundup_pow_of_two() to compute the number
of hash buckets, and contains an overflow check by checking if the
resulting value is 0. However, on 32-bit arches, the roundup code itself
can overflow by doing a 32-bit left-shift of an unsigned long value,
which is undefined behaviour, so it is not guaranteed to truncate
neatly. This was triggered by syzbot on the DEVMAP_HASH type, which
contains the same check, copied from the hashtab code.
The commit in the fixes tag actually attempted to fix this, but the fix
did not account for the UB, so the fix only works on CPUs where an
overflow does result in a neat truncation to zero, which is not
guaranteed. Checking the value before rounding does not have this
problem.
Fixes: 6183f4d3a0a2 ("bpf: Check for integer overflow when using roundup_pow_of_two()")
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Reviewed-by: Bui Quang Minh <minhquangbui99@gmail.com>
Message-ID: <20240307120340.99577-4-toke@redhat.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-03-26 18:22:17 -04:00
bpf: Fix stackmap overflow check on 32-bit arches
2024-03-26 18:22:17 -04:00
cgroup: Remove duplicates in cgroup v1 tasks file
2023-10-25 11:53:19 +02:00
kdb: Fix a potential buffer overflow in kdb_local()
2024-01-25 14:34:32 -08:00
dma-mapping: clear dev->dma_mem to NULL after freeing it
2024-01-25 14:34:25 -08:00
perf: Fix the nr_addr_filters fix
2024-02-23 08:25:03 +01:00
gcov: add support for checksum field
2023-01-18 11:41:42 +01:00
genirq/generic_chip: Make irq_remove_generic_chip() irqdomain aware
2023-11-28 16:50:18 +00:00
livepatch: fix race between fork and KLP transition
2022-10-26 13:22:18 +02:00
locking/ww_mutex/test: Fix potential workqueue corruption
2023-11-28 16:50:13 +00:00
PM: hibernate: Enforce ordering during image compression/decompression
2024-02-23 08:24:48 +01:00
printk: fix return value of printk.devkmsg __setup handler
2022-04-15 14:18:08 +02:00
rcu: Suppress smp_processor_id() complaint in synchronize_rcu_expedited_wait()
2023-03-11 16:43:54 +01:00
sched/rt: Disallow writing invalid values to sched_rt_period_us
2024-03-01 13:13:33 +01:00
timekeeping: Fix cross-timestamp interpolation for non-x86
2024-03-26 18:22:14 -04:00
tracing: Inform kmemleak of saved_cmdlines allocation
2024-02-23 08:25:13 +01:00
kbuild: update config_data.gz only when the content of .config is changed
2021-05-11 14:04:16 +02:00
acct: fix potential integer overflow in encode_comp_t()
2023-01-18 11:41:34 +01:00
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
audit: Send netlink ACK before setting connection in auditd_set
2024-02-23 08:24:54 +01:00
audit: log AUDIT_TIME_* records only from rules
2022-04-15 14:18:04 +02:00
audit: fix potential double free on error path from fsnotify_add_inode_mark
2022-09-05 10:27:38 +02:00
audit: move put_tree() to avoid trim_trees refcount underflow and UAF
2021-09-03 10:08:16 +02:00
audit: don't WARN_ON_ONCE(!current->mm) in audit_exe_compare()
2023-11-28 16:50:18 +00:00
audit: fix a net reference leak in audit_list_rules_send()
2020-06-22 09:30:59 +02:00
audit: fix possible soft lockup in __audit_inode_child()
2023-09-23 10:59:46 +02:00
treewide: Replace DECLARE_TASKLET() with DECLARE_TASKLET_OLD()
2023-04-20 12:07:32 +02:00
sched_getaffinity: don't assume 'cpumask_size()' is fully initialized
2023-04-05 11:16:42 +02:00
hrtimers: Push pending hrtimers away from outgoing CPU earlier
2023-12-13 18:18:09 +01:00
kernel/cpu_pm: Fix uninitted local in cpu_pm
2020-06-22 09:31:22 +02:00
cred: switch to using atomic_long_t
2023-12-20 15:41:18 +01:00
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
kernel/extable.c: use address-of operator on section symbols
2023-06-09 10:29:01 +02:00
kernel/fail_function: fix memory leak with using debugfs_lookup()
2023-03-11 16:44:15 +01:00
kernel/fork: beware of __put_task_struct() calling context
2023-09-23 11:00:03 +02:00
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
kbuild: add variables for compression tools
2020-09-03 11:27:10 +02:00
kallsyms: Refactor kallsyms_show_value() to take cred
2020-07-16 08:16:44 +02:00
exec: Transform exec_update_mutex into a rw_semaphore
2021-01-09 13:44:55 +01:00
kexec: fix a memory leak in crash_shrink_memory()
2023-07-27 08:37:10 +02:00
kexec: support purgatories with .text.hot sections
2023-06-21 15:44:10 +02:00
kheaders: Use array declaration instead of char
2023-05-17 11:35:33 +02:00
x86/kprobes: Fix arch_check_optimized_kprobe check within optimized_kprobe range
2023-03-11 16:44:02 +01:00
kthread: Fix PF_KTHREAD vs to_kthread() race
2021-09-12 08:56:39 +02:00
kbuild: update config_data.gz only when the content of .config is changed
2021-05-11 14:04:16 +02:00
modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules
2023-09-23 10:59:36 +02:00
module: harden ELF info handling
2021-04-07 14:47:38 +02:00
module: harden ELF info handling
2021-04-07 14:47:38 +02:00
kernel/notifier.c: intercept duplicate registrations to avoid infinite loops
2020-10-01 13:17:23 +02:00
crypto: pcrypt - Fix hungtask for PADATA_RESET
2023-11-28 16:50:14 +00:00
exit: Use READ_ONCE() for all oops/warn limit reads
2023-02-06 07:52:50 +01:00
memcg: enable accounting for pids in nested pid namespaces
2021-09-22 12:26:37 +02:00
profiling: fix shift too large makes kernel panic
2022-08-25 11:18:02 +02:00
ptrace: Reimplement PTRACE_KILL by always sending SIGKILL
2022-06-14 18:11:24 +02:00
kernel/reboot: emergency_restart: Set correct system_state
2023-11-28 16:50:19 +00:00
relayfs: fix out-of-bounds access in relay_file_read
2023-05-17 11:35:58 +02:00
/dev/mem: Revoke mappings when a driver claims the region
2020-06-24 17:50:35 +02:00
seccomp: Invalidate seccomp mode to catch death failures
2022-02-16 12:52:53 +01:00
signal handling: don't use BUG_ON() for debugging
2022-07-21 20:59:27 +02:00
smp: Fix offline cpu check in flush_smp_call_function_queue()
2022-04-20 09:19:39 +02:00
kthread: Extract KTHREAD_IS_PER_CPU
2021-02-07 15:35:49 +01:00
getrusage: use sig->stats_lock rather than lock_task_sighand()
2024-03-15 10:48:19 -04:00
kernel/sys_ni: add compat entry for fadvise64_64
2022-09-05 10:27:38 +02:00
kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()
2020-10-01 13:17:10 +02:00
sched/rt: Disallow writing invalid values to sched_rt_period_us
2024-03-01 13:13:33 +01:00
tracepoint: Add tracepoint_probe_register_may_exist() for BPF tracing
2021-07-14 16:53:08 +02:00
taskstats: Cleanup the use of task->exit_code
2022-02-23 11:59:57 +01:00
usermodehelper: reset umask to default before executing user process
2020-10-14 10:32:58 +02:00
smp: Fix smp_call_function_single_async prototype
2021-05-14 09:44:33 +02:00
watchdog: export lockup_detector_reconfigure
2022-08-25 11:18:37 +02:00
watchdog/perf: more properly prevent false positives with turbo modes
2023-07-27 08:37:10 +02:00
workqueue: Override implicit ordered attribute in workqueue_apply_unbound_cpumask()
2023-10-25 11:53:18 +02:00
21e5fa4688