Eric Dumazet
4ffcbfac60
batman-adv: fix uninit-value in batadv_interface_tx()
KMSAN reported batadv_interface_tx() was possibly using a
garbage value [1]
batadv_get_vid() does have a pskb_may_pull() call
but batadv_interface_tx() does not actually make sure
this did not fail.
[1]
BUG: KMSAN: uninit-value in batadv_interface_tx+0x908/0x1e40 net/batman-adv/soft-interface.c:231
CPU: 0 PID: 10006 Comm: syz-executor469 Not tainted 4.20.0-rc7+ #5
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x173/0x1d0 lib/dump_stack.c:113
kmsan_report+0x12e/0x2a0 mm/kmsan/kmsan.c:613
__msan_warning+0x82/0xf0 mm/kmsan/kmsan_instr.c:313
batadv_interface_tx+0x908/0x1e40 net/batman-adv/soft-interface.c:231
__netdev_start_xmit include/linux/netdevice.h:4356 [inline]
netdev_start_xmit include/linux/netdevice.h:4365 [inline]
xmit_one net/core/dev.c:3257 [inline]
dev_hard_start_xmit+0x607/0xc40 net/core/dev.c:3273
__dev_queue_xmit+0x2e42/0x3bc0 net/core/dev.c:3843
dev_queue_xmit+0x4b/0x60 net/core/dev.c:3876
packet_snd net/packet/af_packet.c:2928 [inline]
packet_sendmsg+0x8306/0x8f30 net/packet/af_packet.c:2953
sock_sendmsg_nosec net/socket.c:621 [inline]
sock_sendmsg net/socket.c:631 [inline]
__sys_sendto+0x8c4/0xac0 net/socket.c:1788
__do_sys_sendto net/socket.c:1800 [inline]
__se_sys_sendto+0x107/0x130 net/socket.c:1796
__x64_sys_sendto+0x6e/0x90 net/socket.c:1796
do_syscall_64+0xbc/0xf0 arch/x86/entry/common.c:291
entry_SYSCALL_64_after_hwframe+0x63/0xe7
RIP: 0033:0x441889
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 bb 10 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ffdda6fd468 EFLAGS: 00000216 ORIG_RAX: 000000000000002c
RAX: ffffffffffffffda RBX: 0000000000000002 RCX: 0000000000441889
RDX: 000000000000000e RSI: 00000000200000c0 RDI: 0000000000000003
RBP: 0000000000000003 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000216 R12: 00007ffdda6fd4c0
R13: 00007ffdda6fd4b0 R14: 0000000000000000 R15: 0000000000000000
Uninit was created at:
kmsan_save_stack_with_flags mm/kmsan/kmsan.c:204 [inline]
kmsan_internal_poison_shadow+0x92/0x150 mm/kmsan/kmsan.c:158
kmsan_kmalloc+0xa6/0x130 mm/kmsan/kmsan_hooks.c:176
kmsan_slab_alloc+0xe/0x10 mm/kmsan/kmsan_hooks.c:185
slab_post_alloc_hook mm/slab.h:446 [inline]
slab_alloc_node mm/slub.c:2759 [inline]
__kmalloc_node_track_caller+0xe18/0x1030 mm/slub.c:4383
__kmalloc_reserve net/core/skbuff.c:137 [inline]
__alloc_skb+0x309/0xa20 net/core/skbuff.c:205
alloc_skb include/linux/skbuff.h:998 [inline]
alloc_skb_with_frags+0x1c7/0xac0 net/core/skbuff.c:5220
sock_alloc_send_pskb+0xafd/0x10e0 net/core/sock.c:2083
packet_alloc_skb net/packet/af_packet.c:2781 [inline]
packet_snd net/packet/af_packet.c:2872 [inline]
packet_sendmsg+0x661a/0x8f30 net/packet/af_packet.c:2953
sock_sendmsg_nosec net/socket.c:621 [inline]
sock_sendmsg net/socket.c:631 [inline]
__sys_sendto+0x8c4/0xac0 net/socket.c:1788
__do_sys_sendto net/socket.c:1800 [inline]
__se_sys_sendto+0x107/0x130 net/socket.c:1796
__x64_sys_sendto+0x6e/0x90 net/socket.c:1796
do_syscall_64+0xbc/0xf0 arch/x86/entry/common.c:291
entry_SYSCALL_64_after_hwframe+0x63/0xe7
Fixes: c6c8fea297 ("net: Add batman-adv meshing protocol")
Signed-off-by: Eric Dumazet <[email protected]>
Reported-by: syzbot <[email protected]>
Cc: Marek Lindner <[email protected]>
Cc: Simon Wunderlich <[email protected]>
Cc: Antonio Quartulli <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
|
2019-02-12 13:30:43 -05:00 |
| .. |
|
bat_algo.c
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
bat_algo.h
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
bat_iv_ogm.c
|
batman-adv: Add inconsistent gateway netlink dump detection
|
2018-11-12 10:41:51 +01:00 |
|
bat_iv_ogm.h
|
batman-adv: Unify include guards style
|
2018-07-07 22:02:17 +02:00 |
|
bat_v.c
|
batman-adv: Add inconsistent gateway netlink dump detection
|
2018-11-12 10:41:51 +01:00 |
|
bat_v.h
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
bat_v_elp.c
|
batman-adv: release station info tidstats
|
2019-01-25 09:04:41 +01:00 |
|
bat_v_elp.h
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
bat_v_ogm.c
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
bat_v_ogm.h
|
batman-adv: Unify include guards style
|
2018-07-07 22:02:17 +02:00 |
|
bitarray.c
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
bitarray.h
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
bridge_loop_avoidance.c
|
batman-adv: Add inconsistent claim netlink dump detection
|
2018-11-12 10:41:51 +01:00 |
|
bridge_loop_avoidance.h
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
debugfs.c
|
batman-adv: Add includes for deprecation warning
|
2018-11-12 10:41:50 +01:00 |
|
debugfs.h
|
batman-adv: Mark debugfs functionality as deprecated
|
2018-09-14 10:50:26 +02:00 |
|
distributed-arp-table.c
|
batman-adv: Add inconsistent dat netlink dump detection
|
2018-11-12 10:41:51 +01:00 |
|
distributed-arp-table.h
|
batman-adv: add DAT cache netlink support
|
2018-03-14 10:15:08 +01:00 |
|
fragmentation.c
|
batman-adv: Expand merged fragment buffer for full packet
|
2018-11-12 10:41:29 +01:00 |
|
fragmentation.h
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
gateway_client.c
|
batman-adv: Add inconsistent gateway netlink dump detection
|
2018-11-12 10:41:51 +01:00 |
|
gateway_client.h
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
gateway_common.c
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
gateway_common.h
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
hard-interface.c
|
batman-adv: Avoid WARN on net_device without parent in netns
|
2018-12-30 13:34:12 +01:00 |
|
hard-interface.h
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
hash.c
|
batman-adv: Store modification counter via hash helpers
|
2018-11-12 10:41:51 +01:00 |
|
hash.h
|
batman-adv: Store modification counter via hash helpers
|
2018-11-12 10:41:51 +01:00 |
|
icmp_socket.c
|
Remove 'type' argument from access_ok() function
|
2019-01-03 18:57:57 -08:00 |
|
icmp_socket.h
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
Kconfig
|
batman-adv: enable MCAST by default at compile time
|
2018-11-12 10:41:51 +01:00 |
|
log.c
|
Remove 'type' argument from access_ok() function
|
2019-01-03 18:57:57 -08:00 |
|
log.h
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
main.c
|
batman-adv: Add inconsistent hardif netlink dump detection
|
2018-11-12 10:41:51 +01:00 |
|
main.h
|
batman-adv: Add inconsistent hardif netlink dump detection
|
2018-11-12 10:41:51 +01:00 |
|
Makefile
|
batman-adv: Provide debug messages as trace events
|
2018-09-15 09:51:08 +02:00 |
|
multicast.c
|
batman-adv: Add inconsistent multicast netlink dump detection
|
2018-11-12 10:41:51 +01:00 |
|
multicast.h
|
batman-adv: add multicast flags netlink support
|
2018-03-14 10:15:34 +01:00 |
|
netlink.c
|
batman-adv: Add inconsistent hardif netlink dump detection
|
2018-11-12 10:41:51 +01:00 |
|
netlink.h
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
network-coding.c
|
batman-adv: Prevent duplicated nc_node entry
|
2018-09-06 13:55:58 +02:00 |
|
network-coding.h
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
originator.c
|
batman-adv: Move OGM rebroadcast stats to orig_ifinfo
|
2018-09-15 09:51:10 +02:00 |
|
originator.h
|
batman-adv: Move OGM rebroadcast stats to orig_ifinfo
|
2018-09-15 09:51:10 +02:00 |
|
routing.c
|
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
|
2018-03-23 11:31:58 -04:00 |
|
routing.h
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
send.c
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
send.h
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
soft-interface.c
|
batman-adv: fix uninit-value in batadv_interface_tx()
|
2019-02-12 13:30:43 -05:00 |
|
soft-interface.h
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
sysfs.c
|
batman-adv: Fix segfault when writing to sysfs elp_interval
|
2018-09-06 13:54:48 +02:00 |
|
sysfs.h
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
tp_meter.c
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
tp_meter.h
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
trace.c
|
batman-adv: Improve includes for trace functionality
|
2018-11-12 10:41:50 +01:00 |
|
trace.h
|
batman-adv: Improve includes for trace functionality
|
2018-11-12 10:41:50 +01:00 |
|
translation-table.c
|
batman-adv: Add inconsistent local TT netlink dump detection
|
2018-11-12 10:41:51 +01:00 |
|
translation-table.h
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
tvlv.c
|
batman-adv: Prevent duplicated tvlv handler
|
2018-09-06 14:37:13 +02:00 |
|
tvlv.h
|
batman-adv: Update copyright years for 2018
|
2018-02-26 17:57:39 +01:00 |
|
types.h
|
batman-adv: Add inconsistent gateway netlink dump detection
|
2018-11-12 10:41:51 +01:00 |