Dave Wysochanski
cb248819d2
cifs: use cifsInodeInfo->open_file_lock while iterating to avoid a panic
...
Commit 487317c994 ("cifs: add spinlock for the openFileList to
cifsInodeInfo") added cifsInodeInfo->open_file_lock spin_lock to protect
the openFileList, but missed a few places where cifs_inode->openFileList
was enumerated. Change these remaining tcon->open_file_lock to
cifsInodeInfo->open_file_lock to avoid panic in is_size_safe_to_change.
[17313.245641] RIP: 0010:is_size_safe_to_change+0x57/0xb0 [cifs]
[17313.245645] Code: 68 40 48 89 ef e8 19 67 b7 f1 48 8b 43 40 48 8d 4b 40 48 8d 50 f0 48 39 c1 75 0f eb 47 48 8b 42 10 48 8d 50 f0 48 39 c1 74 3a <8b> 80 88 00 00 00 83 c0 01 a8 02 74 e6 48 89 ef c6 07 00 0f 1f 40
[17313.245649] RSP: 0018:ffff94ae1baefa30 EFLAGS: 00010202
[17313.245654] RAX: dead000000000100 RBX: ffff88dc72243300 RCX: ffff88dc72243340
[17313.245657] RDX: dead0000000000f0 RSI: 00000000098f7940 RDI: ffff88dd3102f040
[17313.245659] RBP: ffff88dd3102f040 R08: 0000000000000000 R09: ffff94ae1baefc40
[17313.245661] R10: ffffcdc8bb1c4e80 R11: ffffcdc8b50adb08 R12: 00000000098f7940
[17313.245663] R13: ffff88dc72243300 R14: ffff88dbc8f19600 R15: ffff88dc72243428
[17313.245667] FS: 00007fb145485700(0000) GS:ffff88dd3e000000(0000) knlGS:0000000000000000
[17313.245670] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[17313.245672] CR2: 0000026bb46c6000 CR3: 0000004edb110003 CR4: 00000000007606e0
[17313.245753] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[17313.245756] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[17313.245759] PKRU: 55555554
[17313.245761] Call Trace:
[17313.245803] cifs_fattr_to_inode+0x16b/0x580 [cifs]
[17313.245838] cifs_get_inode_info+0x35c/0xa60 [cifs]
[17313.245852] ? kmem_cache_alloc_trace+0x151/0x1d0
[17313.245885] cifs_open+0x38f/0x990 [cifs]
[17313.245921] ? cifs_revalidate_dentry_attr+0x3e/0x350 [cifs]
[17313.245953] ? cifsFileInfo_get+0x30/0x30 [cifs]
[17313.245960] ? do_dentry_open+0x132/0x330
[17313.245963] do_dentry_open+0x132/0x330
[17313.245969] path_openat+0x573/0x14d0
[17313.245974] do_filp_open+0x93/0x100
[17313.245979] ? __check_object_size+0xa3/0x181
[17313.245986] ? audit_alloc_name+0x7e/0xd0
[17313.245992] do_sys_open+0x184/0x220
[17313.245999] do_syscall_64+0x5b/0x1b0
Fixes: 487317c994 ("cifs: add spinlock for the openFileList to cifsInodeInfo")
CC: Stable <stable@vger.kernel.org>
Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
2019-10-06 22:04:57 -05:00
arch
ARM: SoC fixes
2019-10-05 17:18:43 -07:00
block
block: sed-opal: fix sparse warning: convert __be64 data
2019-10-03 14:21:32 -06:00
certs
PKCS#7: Refactor verify_pkcs7_signature()
2019-08-05 18:40:18 -04:00
crypto
Merge branch 'next-lockdown' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security
2019-09-28 08:14:15 -07:00
Documentation
Kbuild fixes for v5.4
2019-10-05 12:56:59 -07:00
drivers
ARM: SoC fixes
2019-10-05 17:18:43 -07:00
fs
cifs: use cifsInodeInfo->open_file_lock while iterating to avoid a panic
2019-10-06 22:04:57 -05:00
include
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2019-10-05 08:50:15 -07:00
init
Merge branch 'next-lockdown' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security
2019-09-28 08:14:15 -07:00
ipc
ipc/sem.c: convert to use built-in RCU list checking
2019-09-25 17:51:41 -07:00
kernel
dma-mapping regression fix for 5.4-rc2
2019-10-06 11:10:15 -07:00
lib
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2019-10-05 08:50:15 -07:00
LICENSES
mm
Merge branch 'hugepage-fallbacks' (hugepatch patches from David Rientjes)
2019-09-28 14:26:47 -07:00
net
nfc: fix memory leak in llcp_sock_bind()
2019-10-04 18:31:36 -07:00
samples
rpmsg updates for v5.4
2019-09-22 10:58:15 -07:00
scripts
scripts/setlocalversion: clear local variable to make it work for sh
2019-10-05 15:29:49 +09:00
security
integrity: remove pointless subdir-$(CONFIG_...)
2019-10-05 15:29:49 +09:00
sound
sound fixes for 5.4-rc1
2019-09-24 16:46:16 -07:00
tools
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2019-10-05 08:50:15 -07:00
usr
kbuild: update compile-test header list for v5.4-rc2
2019-10-05 15:29:49 +09:00
virt
KVM/arm fixes for 5.4, take #1
2019-10-03 12:08:50 +02:00
.clang-format
clang-format: Update with the latest for_each macro list
2019-08-31 10:00:51 +02:00
.cocciconfig
.get_maintainer.ignore
.gitattributes
.gitignore
Modules updates for v5.4
2019-09-22 10:34:46 -07:00
.mailmap
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
2019-09-18 12:34:53 -07:00
COPYING
CREDITS
CREDITS: Update email address
2019-09-13 17:21:38 +03:00
Kbuild
kbuild: do not descend to ./Kbuild when cleaning
2019-08-21 21:03:58 +09:00
Kconfig
MAINTAINERS
kgdb patches for 5.4-rc2
2019-10-03 11:17:57 -07:00
Makefile
Linux 5.4-rc2
2019-10-06 14:27:30 -07:00
README