Daniel Jordan
77db4e1d40
padata: add separate cpuhp node for CPUHP_PADATA_DEAD ...
[ Upstream commit 3c2214b6027ff37945799de717c417212e1a8c54 ]
Removing the pcrypt module triggers this:
general protection fault, probably for non-canonical
address 0xdead000000000122
CPU: 5 PID: 264 Comm: modprobe Not tainted 5.6.0+ #2
Hardware name: QEMU Standard PC
RIP: 0010:__cpuhp_state_remove_instance+0xcc/0x120
Call Trace:
padata_sysfs_release+0x74/0xce
kobject_put+0x81/0xd0
padata_free+0x12/0x20
pcrypt_exit+0x43/0x8ee [pcrypt]
padata instances wrongly use the same hlist node for the online and dead
states, so __padata_free()'s second cpuhp remove call chokes on the node
that the first poisoned.
cpuhp multi-instance callbacks only walk forward in cpuhp_step->list and
the same node is linked in both the online and dead lists, so the list
corruption that results from padata_alloc() adding the node to a second
list without removing it from the first doesn't cause problems as long
as no instances are freed.
Avoid the issue by giving each state its own node.
Fixes: 894c9ef9780c ("padata: validate cpumask without removed CPU during offline")
Signed-off-by: Daniel Jordan <daniel.m.jordan@oracle.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Steffen Klassert <steffen.klassert@secunet.com>
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org # v5.4+
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-06-17 16:40:22 +02:00
bpf: Support llvm-objcopy for vmlinux BTF
2020-06-17 16:40:20 +02:00
Revert "cgroup: Add memory barriers to plug cgroup_rstat_updated() race window"
2020-06-07 13:18:46 +02:00
kgdb: don't use a notifier to enter kgdb at panic; call directly
2019-09-25 17:51:40 -07:00
dma-direct: fix data truncation in dma_direct_get_required_mask()
2020-04-29 16:33:00 +02:00
uprobes: ensure that uprobe->offset and ->ref_ctr_offset are properly aligned
2020-06-10 20:24:58 +02:00
kernel/gcov/fs.c: gcov_seq_next() should increase position index
2020-04-29 16:33:00 +02:00
genirq/debugfs: Add missing sanity checks to interrupt injection
2020-04-17 10:50:11 +02:00
livepatch: Nullify obj->mod in klp_module_coming()'s error path
2019-08-19 13:03:37 +02:00
locktorture: Print ratio of acquisitions, not failures
2020-04-23 10:36:44 +02:00
PM: hibernate: Freeze kernel threads in software_resume()
2020-05-06 08:15:09 +02:00
printk: queue wake_up_klogd irq_work only if per-CPU areas are ready
2020-05-02 08:48:42 +02:00
rcu: Allow only one expedited GP to run concurrently with wakeups
2020-03-05 16:43:50 +01:00
sched/fair: Don't NUMA balance for kthreads
2020-06-17 16:40:21 +02:00
time/sched_clock: Expire timer in hardirq context
2020-04-17 10:50:02 +02:00
Stop the ad-hoc games with -Wno-maybe-initialized
2020-05-20 08:20:28 +02:00
audit: check the length of userspace generated audit records
2020-04-29 16:33:18 +02:00
audit_get_nd(): don't unlock parent too early
2019-11-10 11:56:55 -05:00
audit: fix error handling in audit_data_to_entry()
2020-03-05 16:43:42 +01:00
kernel/configs: Replace GPL boilerplate code with SPDX identifier
2019-07-30 18:34:15 +02:00
cpu/hotplug: Ignore pm_wakeup_pending() for disable_nonboot_cpus()
2020-04-17 10:50:11 +02:00
keys: Fix request_key() cache
2020-01-17 19:48:42 +01:00
kernel/elfcore.c: include proper prototypes
2019-09-25 17:51:39 -07:00
exit: panic before exit_mm() on global init exit
2020-01-09 10:20:01 +01:00
extable: Add function to search only kernel exception table
2019-08-21 22:23:48 +10:00
fork: prevent accidental access to clone3 features
2020-05-20 08:20:22 +02:00
Revert "libata, freezer: avoid block device removal while system is frozen"
2019-10-06 09:11:37 -06:00
futex: Unbreak futex hashing
2020-03-25 08:25:58 +01:00
kheaders: substituting --sort in archive creation
2019-10-17 09:08:19 +09:00
jump_label: Don't warn on __exit jump entries
2019-08-29 15:10:10 +01:00
kallsyms: Don't let kallsyms_lookup_size_offset() fail on retrieving the first symbol
2019-08-27 16:19:56 +01:00
sched/rt, Kconfig: Unbreak def/oldconfig with CONFIG_PREEMPT=y
2019-07-22 18:05:11 +02:00
kexec_load: Disable at runtime if the kernel is locked down
2019-08-19 21:54:15 -07:00
kexec: bail out upon SIGKILL when allocating memory.
2019-09-25 17:51:40 -07:00
kexec_elf: support 32 bit ELF files
2019-09-06 23:58:44 +02:00
Merge branch 'next-lockdown' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security
2019-09-28 08:14:15 -07:00
kmod: make request_module() return an error when autoloading is disabled
2020-04-17 10:50:22 +02:00
kprobes: Fix optimize_kprobe()/unoptimize_kprobe() cancellation logic
2020-03-12 13:00:09 +01:00
kthread: make __kthread_queue_delayed_work static
2019-10-16 09:20:58 -07:00
Merge branch 'next-integrity' of git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity
2019-09-27 19:37:27 -07:00
module: avoid setting info->name early in case we can fall back to info->mod->name
2020-02-24 08:36:54 +01:00
MODSIGN: Export module signature definitions
2019-08-05 18:39:56 -04:00
MODSIGN: Export module signature definitions
2019-08-05 18:39:56 -04:00
x86/mm: split vmalloc_sync_all()
2020-03-25 08:25:58 +01:00
padata: add separate cpuhp node for CPUHP_PADATA_DEAD
2020-06-17 16:40:22 +02:00
panic: ensure preemption is disabled during panic()
2019-10-07 15:47:19 -07:00
lockdown: Lock down module params that specify hardware parameters (eg. ioport)
2019-08-19 21:54:16 -07:00
ptrace: reintroduce usage of subjective credentials in ptrace_has_cap()
2020-01-23 08:22:36 +01:00
kernel/relay.c: handle alloc_percpu returning NULL in relay_open
2020-06-07 13:18:47 +02:00
mm/memory_hotplug.c: use PFN_UP / PFN_DOWN in walk_system_ram_range()
2019-09-24 15:54:09 -07:00
seccomp: Add missing compat_ioctl for notify
2020-04-17 10:50:09 +02:00
signal: check sig before setting info in kill_pid_usb_asyncio
2020-05-02 08:48:55 +02:00
stacktrace: Don't skip first entry on noncurrent tasks
2019-11-04 21:19:25 +01:00
stop_machine: Avoid potential race behaviour
2019-10-17 12:47:12 +02:00
Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-09-17 12:35:15 -07:00
kernel: sysctl: make drop_caches write-only
2020-01-04 19:18:32 +01:00
taskstats: fix data-race
2020-01-09 10:19:54 +01:00
torture: Remove exporting of internal functions
2019-08-01 14:30:22 -07:00
umh: fix memory leak on execve failure
2020-05-20 08:20:13 +02:00
watchdog/softlockup: Enforce that timestamp is valid on boot
2020-02-24 08:36:52 +01:00
workqueue: don't use wq_select_unbound_cpu() for bound works
2020-03-18 07:17:50 +01:00
77db4e1d40