Steven Rostedt (Google)
60e092289c
tracing: Inform kmemleak of saved_cmdlines allocation
commit 2394ac4145ea91b92271e675a09af2a9ea6840b7 upstream.
The allocation of the struct saved_cmdlines_buffer structure changed from:
s = kmalloc(sizeof(*s), GFP_KERNEL);
s->saved_cmdlines = kmalloc_array(TASK_COMM_LEN, val, GFP_KERNEL);
to:
orig_size = sizeof(*s) + val * TASK_COMM_LEN;
order = get_order(orig_size);
size = 1 << (order + PAGE_SHIFT);
page = alloc_pages(GFP_KERNEL, order);
if (!page)
return NULL;
s = page_address(page);
memset(s, 0, sizeof(*s));
s->saved_cmdlines = kmalloc_array(TASK_COMM_LEN, val, GFP_KERNEL);
Where that s->saved_cmdlines allocation looks to be a dangling allocation
to kmemleak. That's because kmemleak only keeps track of kmalloc()
allocations. For allocations that use page_alloc() directly, the kmemleak
needs to be explicitly informed about it.
Add kmemleak_alloc() and kmemleak_free() around the page allocation so
that it doesn't give the following false positive:
unreferenced object 0xffff8881010c8000 (size 32760):
comm "swapper", pid 0, jiffies 4294667296
hex dump (first 32 bytes):
ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
backtrace (crc ae6ec1b9):
[<ffffffff86722405>] kmemleak_alloc+0x45/0x80
[<ffffffff8414028d>] __kmalloc_large_node+0x10d/0x190
[<ffffffff84146ab1>] __kmalloc+0x3b1/0x4c0
[<ffffffff83ed7103>] allocate_cmdlines_buffer+0x113/0x230
[<ffffffff88649c34>] tracer_alloc_buffers.isra.0+0x124/0x460
[<ffffffff8864a174>] early_trace_init+0x14/0xa0
[<ffffffff885dd5ae>] start_kernel+0x12e/0x3c0
[<ffffffff885f5758>] x86_64_start_reservations+0x18/0x30
[<ffffffff885f582b>] x86_64_start_kernel+0x7b/0x80
[<ffffffff83a001c3>] secondary_startup_64_no_verify+0x15e/0x16b
Link: https://lore.kernel.org/linux-trace-kernel/87r0hfnr9r.fsf@kernel.org/
Link: https://lore.kernel.org/linux-trace-kernel/20240214112046.09a322d6@gandalf.local.home
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Fixes: 44dc5c41b5b1 ("tracing: Fix wasted memory in saved_cmdlines logic")
Reported-by: Kalle Valo <kvalo@kernel.org>
Tested-by: Kalle Valo <kvalo@kernel.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
2024-02-23 08:25:13 +01:00 |
| .. |
|
bpf
|
bpf: Add map and need_defer parameters to .map_fd_put_ptr()
|
2024-02-23 08:24:57 +01:00 |
|
cgroup
|
cgroup: Remove duplicates in cgroup v1 tasks file
|
2023-10-25 11:53:19 +02:00 |
|
configs
|
|
|
|
debug
|
kdb: Fix a potential buffer overflow in kdb_local()
|
2024-01-25 14:34:32 -08:00 |
|
dma
|
dma-mapping: clear dev->dma_mem to NULL after freeing it
|
2024-01-25 14:34:25 -08:00 |
|
events
|
perf: Fix the nr_addr_filters fix
|
2024-02-23 08:25:03 +01:00 |
|
gcov
|
gcov: add support for checksum field
|
2023-01-18 11:41:42 +01:00 |
|
irq
|
genirq/generic_chip: Make irq_remove_generic_chip() irqdomain aware
|
2023-11-28 16:50:18 +00:00 |
|
livepatch
|
livepatch: fix race between fork and KLP transition
|
2022-10-26 13:22:18 +02:00 |
|
locking
|
locking/ww_mutex/test: Fix potential workqueue corruption
|
2023-11-28 16:50:13 +00:00 |
|
power
|
PM: hibernate: Enforce ordering during image compression/decompression
|
2024-02-23 08:24:48 +01:00 |
|
printk
|
printk: fix return value of printk.devkmsg __setup handler
|
2022-04-15 14:18:08 +02:00 |
|
rcu
|
rcu: Suppress smp_processor_id() complaint in synchronize_rcu_expedited_wait()
|
2023-03-11 16:43:54 +01:00 |
|
sched
|
sched/fair: Don't balance task to its current running CPU
|
2023-07-27 08:37:42 +02:00 |
|
time
|
hrtimer: Report offline hrtimer enqueue
|
2024-02-23 08:25:08 +01:00 |
|
trace
|
tracing: Inform kmemleak of saved_cmdlines allocation
|
2024-02-23 08:25:13 +01:00 |
|
.gitignore
|
|
|
|
acct.c
|
acct: fix potential integer overflow in encode_comp_t()
|
2023-01-18 11:41:34 +01:00 |
|
async.c
|
treewide: Remove uninitialized_var() usage
|
2023-06-09 10:29:01 +02:00 |
|
audit.c
|
audit: Send netlink ACK before setting connection in auditd_set
|
2024-02-23 08:24:54 +01:00 |
|
audit.h
|
audit: log AUDIT_TIME_* records only from rules
|
2022-04-15 14:18:04 +02:00 |
|
audit_fsnotify.c
|
audit: fix potential double free on error path from fsnotify_add_inode_mark
|
2022-09-05 10:27:38 +02:00 |
|
audit_tree.c
|
|
|
|
audit_watch.c
|
audit: don't WARN_ON_ONCE(!current->mm) in audit_exe_compare()
|
2023-11-28 16:50:18 +00:00 |
|
auditfilter.c
|
|
|
|
auditsc.c
|
audit: fix possible soft lockup in __audit_inode_child()
|
2023-09-23 10:59:46 +02:00 |
|
backtracetest.c
|
treewide: Replace DECLARE_TASKLET() with DECLARE_TASKLET_OLD()
|
2023-04-20 12:07:32 +02:00 |
|
bounds.c
|
|
|
|
capability.c
|
|
|
|
compat.c
|
sched_getaffinity: don't assume 'cpumask_size()' is fully initialized
|
2023-04-05 11:16:42 +02:00 |
|
configs.c
|
|
|
|
context_tracking.c
|
|
|
|
cpu.c
|
hrtimers: Push pending hrtimers away from outgoing CPU earlier
|
2023-12-13 18:18:09 +01:00 |
|
cpu_pm.c
|
|
|
|
crash_core.c
|
|
|
|
crash_dump.c
|
|
|
|
cred.c
|
cred: switch to using atomic_long_t
|
2023-12-20 15:41:18 +01:00 |
|
delayacct.c
|
|
|
|
dma.c
|
|
|
|
exec_domain.c
|
|
|
|
exit.c
|
treewide: Remove uninitialized_var() usage
|
2023-06-09 10:29:01 +02:00 |
|
extable.c
|
kernel/extable.c: use address-of operator on section symbols
|
2023-06-09 10:29:01 +02:00 |
|
fail_function.c
|
kernel/fail_function: fix memory leak with using debugfs_lookup()
|
2023-03-11 16:44:15 +01:00 |
|
fork.c
|
kernel/fork: beware of __put_task_struct() calling context
|
2023-09-23 11:00:03 +02:00 |
|
freezer.c
|
|
|
|
futex.c
|
treewide: Remove uninitialized_var() usage
|
2023-06-09 10:29:01 +02:00 |
|
gen_kheaders.sh
|
|
|
|
groups.c
|
|
|
|
hung_task.c
|
|
|
|
iomem.c
|
|
|
|
irq_work.c
|
|
|
|
jump_label.c
|
|
|
|
kallsyms.c
|
|
|
|
kcmp.c
|
|
|
|
Kconfig.freezer
|
|
|
|
Kconfig.hz
|
|
|
|
Kconfig.locks
|
|
|
|
Kconfig.preempt
|
|
|
|
kcov.c
|
|
|
|
kexec.c
|
|
|
|
kexec_core.c
|
kexec: fix a memory leak in crash_shrink_memory()
|
2023-07-27 08:37:10 +02:00 |
|
kexec_elf.c
|
|
|
|
kexec_file.c
|
kexec: support purgatories with .text.hot sections
|
2023-06-21 15:44:10 +02:00 |
|
kexec_internal.h
|
|
|
|
kheaders.c
|
kheaders: Use array declaration instead of char
|
2023-05-17 11:35:33 +02:00 |
|
kmod.c
|
|
|
|
kprobes.c
|
x86/kprobes: Fix arch_check_optimized_kprobe check within optimized_kprobe range
|
2023-03-11 16:44:02 +01:00 |
|
ksysfs.c
|
|
|
|
kthread.c
|
|
|
|
latencytop.c
|
|
|
|
Makefile
|
|
|
|
module-internal.h
|
|
|
|
module.c
|
modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules
|
2023-09-23 10:59:36 +02:00 |
|
module_signature.c
|
|
|
|
module_signing.c
|
|
|
|
notifier.c
|
|
|
|
nsproxy.c
|
|
|
|
padata.c
|
crypto: pcrypt - Fix hungtask for PADATA_RESET
|
2023-11-28 16:50:14 +00:00 |
|
panic.c
|
exit: Use READ_ONCE() for all oops/warn limit reads
|
2023-02-06 07:52:50 +01:00 |
|
params.c
|
|
|
|
pid.c
|
|
|
|
pid_namespace.c
|
memcg: enable accounting for pids in nested pid namespaces
|
2021-09-22 12:26:37 +02:00 |
|
profile.c
|
profiling: fix shift too large makes kernel panic
|
2022-08-25 11:18:02 +02:00 |
|
ptrace.c
|
ptrace: Reimplement PTRACE_KILL by always sending SIGKILL
|
2022-06-14 18:11:24 +02:00 |
|
range.c
|
|
|
|
reboot.c
|
kernel/reboot: emergency_restart: Set correct system_state
|
2023-11-28 16:50:19 +00:00 |
|
relay.c
|
relayfs: fix out-of-bounds access in relay_file_read
|
2023-05-17 11:35:58 +02:00 |
|
resource.c
|
|
|
|
rseq.c
|
|
|
|
seccomp.c
|
seccomp: Invalidate seccomp mode to catch death failures
|
2022-02-16 12:52:53 +01:00 |
|
signal.c
|
signal handling: don't use BUG_ON() for debugging
|
2022-07-21 20:59:27 +02:00 |
|
smp.c
|
smp: Fix offline cpu check in flush_smp_call_function_queue()
|
2022-04-20 09:19:39 +02:00 |
|
smpboot.c
|
|
|
|
smpboot.h
|
|
|
|
softirq.c
|
|
|
|
stackleak.c
|
|
|
|
stacktrace.c
|
|
|
|
stop_machine.c
|
|
|
|
sys.c
|
prlimit: do_prlimit needs to have a speculation check
|
2023-01-24 07:17:59 +01:00 |
|
sys_ni.c
|
kernel/sys_ni: add compat entry for fadvise64_64
|
2022-09-05 10:27:38 +02:00 |
|
sysctl-test.c
|
|
|
|
sysctl.c
|
mm: allow a controlled amount of unfairness in the page lock
|
2023-08-30 16:27:26 +02:00 |
|
sysctl_binary.c
|
|
|
|
task_work.c
|
|
|
|
taskstats.c
|
|
|
|
test_kprobes.c
|
|
|
|
torture.c
|
|
|
|
tracepoint.c
|
|
|
|
tsacct.c
|
taskstats: Cleanup the use of task->exit_code
|
2022-02-23 11:59:57 +01:00 |
|
ucount.c
|
|
|
|
uid16.c
|
|
|
|
uid16.h
|
|
|
|
umh.c
|
|
|
|
up.c
|
|
|
|
user-return-notifier.c
|
|
|
|
user.c
|
|
|
|
user_namespace.c
|
|
|
|
utsname.c
|
|
|
|
utsname_sysctl.c
|
|
|
|
watchdog.c
|
watchdog: export lockup_detector_reconfigure
|
2022-08-25 11:18:37 +02:00 |
|
watchdog_hld.c
|
watchdog/perf: more properly prevent false positives with turbo modes
|
2023-07-27 08:37:10 +02:00 |
|
workqueue.c
|
workqueue: Override implicit ordered attribute in workqueue_apply_unbound_cpumask()
|
2023-10-25 11:53:18 +02:00 |
|
workqueue_internal.h
|
|
|