Ryusuke Konishi
cb74e8fd6b
nilfs2: prevent WARNING in nilfs_sufile_set_segment_usage() ...
commit 675abf8df1353e0e3bde314993e0796c524cfbf0 upstream.
If nilfs2 reads a disk image with corrupted segment usage metadata, and
its segment usage information is marked as an error for the segment at the
write location, nilfs_sufile_set_segment_usage() can trigger WARN_ONs
during log writing.
Segments newly allocated for writing with nilfs_sufile_alloc() will not
have this error flag set, but this unexpected situation will occur if the
segment indexed by either nilfs->ns_segnum or nilfs->ns_nextnum (active
segment) was marked in error.
Fix this issue by inserting a sanity check to treat it as a file system
corruption.
Since error returns are not allowed during the execution phase where
nilfs_sufile_set_segment_usage() is used, this inserts the sanity check
into nilfs_sufile_mark_dirty() which pre-reads the buffer containing the
segment usage record to be updated and sets it up in a dirty state for
writing.
In addition, nilfs_sufile_set_segment_usage() is also called when
canceling log writing and undoing segment usage update, so in order to
avoid issuing the same kernel warning in that case, in case of
cancellation, avoid checking the error flag in
nilfs_sufile_set_segment_usage().
Link: https://lkml.kernel.org/r/20231205085947.4431-1-konishi.ryusuke@gmail.com
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Reported-by: syzbot+14e9f834f6ddecece094@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=14e9f834f6ddecece094
Tested-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-12-13 18:18:14 +01:00
9p: missing chunk of "fs/9p: Don't update file type when updating file attributes"
2022-06-22 14:11:02 +02:00
affs: initialize fsdata in affs_truncate()
2023-02-06 07:52:36 +01:00
afs: Fix file locking on R/O volumes to operate in local mode
2023-12-08 08:44:23 +01:00
autofs: fix memory leak of waitqueues in autofs_catatonic_mode
2023-09-23 11:00:02 +02:00
btrfs: make error messages more clear when getting a chunk map
2023-12-08 08:44:26 +01:00
ceph: fix incorrect revoked caps assert in ceph_fill_file_size()
2023-10-25 11:53:19 +02:00
smb3: fix touch -h of symlink
2023-12-08 08:44:27 +01:00
coda: Avoid partial allocation of sig_inputArgs
2023-03-11 16:43:56 +01:00
configfs: fix possible memory leak in configfs_create_dir()
2023-01-18 11:41:09 +01:00
new helper: lookup_positive_unlocked()
2023-09-23 10:59:40 +02:00
dlm: fix plock lookup when using multiple lockspaces
2023-09-23 10:59:55 +02:00
erofs: ensure that the post-EOF tails are all zeroed
2023-09-23 10:59:36 +02:00
ext2: fix datatype of block number in ext2_xattr_set2()
2023-09-23 11:00:04 +02:00
ext4: make sure allocate pending entry not fail
2023-12-08 08:44:24 +01:00
f2fs: fix to initialize map.m_pblk in f2fs_precache_extents()
2023-11-20 10:30:14 +01:00
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
fuse: nlookup missing decrement in fuse_direntplus_link
2023-09-23 11:00:00 +02:00
gfs2: ignore negated quota changes
2023-11-28 16:50:15 +00:00
hfs: fix missing hfs_bnode_get() in __hfs_bnode_create
2023-03-11 16:43:59 +01:00
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
hugetlbfs: fix null-ptr-deref in hugetlbfs_parse_param()
2023-01-18 11:41:38 +01:00
iomap: iomap_write_failed fix
2022-06-14 18:11:36 +02:00
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
jbd2: fix potential data lost in recovering journal raced with synchronizing fs bdev
2023-11-28 16:50:19 +00:00
jffs2: reduce stack usage in jffs2_build_xattr_subsystem()
2023-07-27 08:37:25 +02:00
jfs: fix array-index-out-of-bounds in diAlloc
2023-11-28 16:50:15 +00:00
new helper: lookup_positive_unlocked()
2023-09-23 10:59:40 +02:00
fs: lockd: avoid possible wrong NULL parameter
2023-09-23 10:59:48 +02:00
NFSv4.1: fix SP4_MACH_CRED protection for pnfs IO
2023-11-28 16:50:16 +00:00
nfsd: fix file memleak on client_opens_release
2023-11-28 16:50:21 +00:00
nilfs2: prevent WARNING in nilfs_sufile_set_segment_usage()
2023-12-13 18:18:14 +01:00
fs/nls: make load_nls() take a const parameter
2023-09-23 10:59:38 +02:00
fanotify: disallow mount/sb marks on kernel internal pseudo fs
2023-07-27 08:37:26 +02:00
ntfs: check overflow when iterating ATTR_RECORDs
2022-11-25 17:42:22 +01:00
fs: ocfs2: namei: check return value of ocfs2_add_entry()
2023-09-23 10:59:42 +02:00
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
orangefs: Fix kmemleak in orangefs_{kernel,client}_debug_init()
2023-01-18 11:41:39 +01:00
ovl: skip overlayfs superblocks at global sync
2023-12-08 08:44:27 +01:00
procfs: block chmod on /proc/thread-self/comm
2023-09-23 10:59:55 +02:00
pstore/ram: Check start of empty przs during init
2023-09-23 10:59:55 +02:00
quota: explicitly forbid quota files from being encrypted
2023-11-28 16:50:19 +00:00
reiserfs: Check the return value from __getblk()
2023-09-23 10:59:40 +02:00
revert "squashfs: harden sanity check in squashfs_read_xattr_id_table"
2023-02-22 12:50:39 +01:00
fs/sysv: Null check to prevent null-ptr-deref bug
2023-08-11 11:53:59 +02:00
tracefs: Add missing lockdown check to tracefs_create_dir()
2023-09-23 11:00:06 +02:00
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
udf: initialize newblock to 0
2023-09-23 10:59:56 +02:00
fsverity: skip PKCS#7 parser when keyring is empty
2023-09-23 10:59:55 +02:00
xfs: verify buffer contents when we skip log replay
2023-06-28 10:18:42 +02:00
aio: fix mremap after fork null-deref
2023-02-22 12:50:35 +01:00
attr: block mode changes of symlinks
2023-09-23 11:00:06 +02:00
binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf
2023-01-18 11:41:46 +01:00
fs: binfmt_elf_efpic: fix personality for ELF-FDPIC
2023-10-10 21:46:42 +02:00
binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf
2023-01-18 11:41:46 +01:00
binfmt_misc: fix shift-out-of-bounds in check_special_flags
2023-01-18 11:41:33 +01:00
mm: fs: initialize fsdata passed to write_begin/write_end interface
2022-11-25 17:42:22 +01:00
chardev: fix error handling in cdev_device_add()
2023-01-18 11:41:25 +01:00
compat_ioctl: remove /dev/random commands
2022-06-22 14:11:03 +02:00
dax: fix cache flush on PMD-mapped pages
2022-06-14 18:11:41 +02:00
eventfd: prevent underflow for eventfd semaphores
2023-09-23 10:59:40 +02:00
epoll: ep_autoremove_wake_function should use list_del_init_careful
2023-06-28 10:18:35 +02:00
exec: Force single empty string when argv is empty
2022-06-06 08:33:50 +02:00
fs: prevent out-of-bounds array speculation when closing a file descriptor
2023-03-17 08:32:47 +01:00
SUNRPC: Ensure we flush any closed sockets before xs_xprt_free()
2022-05-25 09:14:34 +02:00
writeback: fix call of incorrect macro
2023-05-17 11:35:58 +02:00
fs: avoid empty option when generating legacy mount string
2023-07-27 08:37:25 +02:00
fs: Establish locking order for unrelated directories
2023-07-27 08:37:26 +02:00
fs: Establish locking order for unrelated directories
2023-07-27 08:37:26 +02:00
io_uring: fix off-by one bvec index
2023-12-08 08:44:26 +01:00
libfs: add DEFINE_SIMPLE_ATTRIBUTE_SIGNED for signed value
2023-01-18 11:40:55 +01:00
locks: fix KASAN: use-after-free in trace_event_raw_event_filelock_lock
2023-09-23 11:00:02 +02:00
mbcache: Avoid nesting of cache->c_list_lock under bit locks
2023-01-18 11:41:59 +01:00
fs: Fix error checking for d_hash_and_lookup()
2023-09-23 10:59:40 +02:00
pnode: terminate at peers of source
2023-01-18 11:41:44 +01:00
io_uring: disable polling pollfree files
2022-09-05 10:27:47 +02:00
Revert "fs: check FMODE_LSEEK to control internal pipe splicing"
2022-10-17 17:24:32 +02:00
statfs: enforce statfs[64] structure initialization
2023-05-30 12:44:07 +01:00
fs: Protect reconfiguration of sb read-write from racing writes
2023-08-11 11:53:59 +02:00
ovl: skip overlayfs superblocks at global sync
2023-12-08 08:44:27 +01:00
userfaultfd: open userfaultfds with O_RDONLY
2022-10-26 13:22:21 +02:00
fs: don't audit the capability check in simple_xattr_list()
2023-01-18 11:40:53 +01:00
cb74e8fd6b