Linus Torvalds
ce8432912f
usermodehelper: reset umask to default before executing user process ...
commit 4013c1496c49615d90d36b9d513eee8e369778e9 upstream.
Kernel threads intentionally do CLONE_FS in order to follow any changes
that 'init' does to set up the root directory (or cwd).
It is admittedly a bit odd, but it avoids the situation where 'init'
does some extensive setup to initialize the system environment, and then
we execute a usermode helper program, and it uses the original FS setup
from boot time that may be very limited and incomplete.
[ Both Al Viro and Eric Biederman point out that 'pivot_root()' will
follow the root regardless, since it fixes up other users of root (see
chroot_fs_refs() for details), but overmounting root and doing a
chroot() would not. ]
However, Vegard Nossum noticed that the CLONE_FS not only means that we
follow the root and current working directories, it also means we share
umask with whatever init changed it to. That wasn't intentional.
Just reset umask to the original default (0022) before actually starting
the usermode helper program.
Reported-by: Vegard Nossum <vegard.nossum@oracle.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-10-14 10:32:58 +02:00
bpf: Fix a rcu warning for bpffs map pretty-print
2020-10-01 13:18:19 +02:00
cgroup: fix cgroup_sk_alloc() for sk_clone_lock()
2020-07-22 09:32:49 +02:00
kgdb: Avoid suspicious RCU usage warning
2020-07-09 09:37:51 +02:00
dma-direct: fix data truncation in dma_direct_get_required_mask()
2020-04-29 16:33:00 +02:00
perf: Use new infrastructure to fix deadlocks in execve
2020-10-01 13:17:48 +02:00
gcov: add support for GCC 10.1
2020-09-17 13:47:56 +02:00
genirq/matrix: Deal with the sillyness of for_each_cpu() on UP
2020-09-03 11:27:06 +02:00
livepatch: Nullify obj->mod in klp_module_coming()'s error path
2019-08-19 13:03:37 +02:00
locking/lockdep: Decrement IRQ context counters when removing lock chain
2020-10-01 13:17:33 +02:00
PM: hibernate: Freeze kernel threads in software_resume()
2020-05-06 08:15:09 +02:00
printk: handle blank console arguments passed in.
2020-10-01 13:18:04 +02:00
rcu: Allow only one expedited GP to run concurrently with wakeups
2020-03-05 16:43:50 +01:00
sched/fair: Eliminate bandwidth race between throttling and distribution
2020-10-01 13:17:57 +02:00
timekeeping: Prevent 32bit truncation in scale64_check_overflow()
2020-10-01 13:17:38 +02:00
tracing: Make the space reserved for the pid wider
2020-10-07 08:01:27 +02:00
audit: fix a net reference leak in audit_list_rules_send()
2020-06-22 09:30:59 +02:00
audit: fix a net reference leak in audit_list_rules_send()
2020-06-22 09:30:59 +02:00
audit: CONFIG_CHANGE don't log internal bookkeeping as an event
2020-10-01 13:17:32 +02:00
audit: fix a net reference leak in audit_list_rules_send()
2020-06-22 09:30:59 +02:00
kernel/configs: Replace GPL boilerplate code with SPDX identifier
2019-07-30 18:34:15 +02:00
sched/core: Fix illegal RCU from offline CPUs
2020-06-22 09:31:01 +02:00
kernel/cpu_pm: Fix uninitted local in cpu_pm
2020-06-22 09:31:22 +02:00
keys: Fix request_key() cache
2020-01-17 19:48:42 +01:00
kernel/elfcore.c: include proper prototypes
2019-09-25 17:51:39 -07:00
exit: Move preemption fixup up, move blocking operations down
2020-06-22 09:31:01 +02:00
extable: Add function to search only kernel exception table
2019-08-21 22:23:48 +10:00
exec: Fix a deadlock in strace
2020-10-01 13:17:47 +02:00
Revert "libata, freezer: avoid block device removal while system is frozen"
2019-10-06 09:11:37 -06:00
futex: Unbreak futex hashing
2020-03-25 08:25:58 +01:00
kbuild: add variables for compression tools
2020-09-03 11:27:10 +02:00
jump_label: Don't warn on __exit jump entries
2019-08-29 15:10:10 +01:00
kallsyms: Refactor kallsyms_show_value() to take cred
2020-07-16 08:16:44 +02:00
kernel/kcmp.c: Use new infrastructure to fix deadlocks in execve
2020-10-01 13:17:48 +02:00
sched/rt, Kconfig: Unbreak def/oldconfig with CONFIG_PREEMPT=y
2019-07-22 18:05:11 +02:00
kexec_load: Disable at runtime if the kernel is locked down
2019-08-19 21:54:15 -07:00
kexec: bail out upon SIGKILL when allocating memory.
2019-09-25 17:51:40 -07:00
kexec_elf: support 32 bit ELF files
2019-09-06 23:58:44 +02:00
Merge branch 'next-lockdown' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security
2019-09-28 08:14:15 -07:00
kmod: make request_module() return an error when autoloading is disabled
2020-04-17 10:50:22 +02:00
kprobes: Fix compiler warning for !CONFIG_KPROBES_ON_FTRACE
2020-10-01 13:18:25 +02:00
kthread: Do not preempt current task if it is going to call schedule()
2020-08-26 10:40:53 +02:00
kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()
2020-10-01 13:17:10 +02:00
module: Remove accidental change of module_enable_x()
2020-10-01 13:17:24 +02:00
MODSIGN: Export module signature definitions
2019-08-05 18:39:56 -04:00
MODSIGN: Export module signature definitions
2019-08-05 18:39:56 -04:00
kernel/notifier.c: intercept duplicate registrations to avoid infinite loops
2020-10-01 13:17:23 +02:00
padata: add separate cpuhp node for CPUHP_PADATA_DEAD
2020-06-17 16:40:22 +02:00
panic: ensure preemption is disabled during panic()
2019-10-07 15:47:19 -07:00
lockdown: Lock down module params that specify hardware parameters (eg. ioport)
2019-08-19 21:54:16 -07:00
proc/sysctl: add shared variables for range check
2019-07-18 17:08:07 -07:00
ptrace: reintroduce usage of subjective credentials in ptrace_has_cap()
2020-01-23 08:22:36 +01:00
kernel/relay.c: fix memleak on destroy relay channel
2020-08-26 10:40:51 +02:00
/dev/mem: Revoke mappings when a driver claims the region
2020-06-24 17:50:35 +02:00
seccomp: Fix ioctl number for SECCOMP_IOCTL_NOTIF_ID_VALID
2020-08-19 08:15:58 +02:00
signal: check sig before setting info in kill_pid_usb_asyncio
2020-05-02 08:48:55 +02:00
smp: Warn on function calls from softirq context
2019-07-20 11:27:16 +02:00
stacktrace: Don't skip first entry on noncurrent tasks
2019-11-04 21:19:25 +01:00
stop_machine: Avoid potential race behaviour
2019-10-17 12:47:12 +02:00
kernel/sys.c: avoid copying possible padding bytes in copy_to_user
2020-10-01 13:17:23 +02:00
kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()
2020-10-01 13:17:10 +02:00
kernel: sysctl: make drop_caches write-only
2020-01-04 19:18:32 +01:00
taskstats: fix data-race
2020-01-09 10:19:54 +01:00
torture: Remove exporting of internal functions
2019-08-01 14:30:22 -07:00
proc/sysctl: add shared variables for range check
2019-07-18 17:08:07 -07:00
usermodehelper: reset umask to default before executing user process
2020-10-14 10:32:58 +02:00
watchdog/softlockup: Enforce that timestamp is valid on boot
2020-02-24 08:36:52 +01:00
workqueue: Remove the warning in wq_worker_sleeping()
2020-10-01 13:17:54 +02:00
ce8432912f