Tony Battersby
f135c65085
scsi: sg: Allow waiting for commands to complete on removed device ...
commit 3455607fd7be10b449f5135c00dc306b85dc0d21 upstream.
When a SCSI device is removed while in active use, currently sg will
immediately return -ENODEV on any attempt to wait for active commands that
were sent before the removal. This is problematic for commands that use
SG_FLAG_DIRECT_IO since the data buffer may still be in use by the kernel
when userspace frees or reuses it after getting ENODEV, leading to
corrupted userspace memory (in the case of READ-type commands) or corrupted
data being sent to the device (in the case of WRITE-type commands). This
has been seen in practice when logging out of a iscsi_tcp session, where
the iSCSI driver may still be processing commands after the device has been
marked for removal.
Change the policy to allow userspace to wait for active sg commands even
when the device is being removed. Return -ENODEV only when there are no
more responses to read.
Link: https://lore.kernel.org/r/5ebea46f-fe83-2d0b-233d-d0dcb362dd0a@cybernetics.com
Cc: <stable@vger.kernel.org>
Acked-by: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-08-25 11:18:17 +02:00
scsi: aacraid: Fix error handling paths in aac_probe_one()
2020-10-01 13:17:56 +02:00
scsi: aic7xxx: Fix unintentional sign extension issue on left shift of u8
2021-07-25 14:35:12 +02:00
scsi: libsas: Add LUN number check in .slave_alloc callback
2021-07-25 14:35:13 +02:00
scsi: eesox: Fix different dev_id between request_irq() and free_irq()
2020-08-19 08:16:09 +02:00
scsi: be2iscsi: Fix an error handling path in beiscsi_dev_probe()
2021-07-20 16:10:53 +02:00
scsi: bfa: Replace snprintf() with sysfs_emit()
2022-04-15 14:18:32 +02:00
scsi: bnx2fc: Make bnx2fc_recv_frame() mp safe
2022-02-08 18:24:33 +01:00
scsi: iscsi: Fix shost->max_id use
2021-07-20 16:10:43 +02:00
scsi: csiostor: Uninitialized data in csio_ln_vnp_read_cbfn()
2021-11-17 09:48:43 +01:00
scsi: iscsi: Fix shost->max_id use
2021-07-20 16:10:43 +02:00
scsi: cxlflash: Fix error return code in cxlflash_probe()
2020-10-01 13:18:02 +02:00
scsi: scsi_dh_rdac: Avoid crash during rdac_bus_attach()
2021-08-26 08:36:14 -04:00
scsi: fcoe: Fix Wstringop-overflow warnings in fcoe_wwn_from_mac()
2022-06-14 18:11:40 +02:00
scsi: fnic: Fix memleak in vnic_dev_init_devcmd2
2021-02-07 15:35:48 +01:00
scsi: hisi_sas: Change permission of parameter prot_mask
2022-04-15 14:18:14 +02:00
scsi: ibmvfc: Fix invalid state machine BUG_ON()
2021-05-14 09:44:25 +02:00
scsi: ibmvscsis: Increase INITIAL_SRP_LIMIT to 1024
2022-04-20 09:19:36 +02:00
scsi: libsas: Add LUN number check in .slave_alloc callback
2021-07-25 14:35:13 +02:00
scsi: libfc: Fix use after free in fc_exch_abts_resp()
2022-04-15 14:18:34 +02:00
scsi: libsas: Fix sas_ata_qc_issue() handling of NCQ NON DATA commands
2022-04-15 14:18:00 +02:00
scsi: lpfc: Allow reduced polling rate for nvme_admin_async_event cmd completion
2022-06-22 14:11:20 +02:00
scsi: megaraid_sas: Target with invalid LUN ID is deleted during scan
2022-04-20 09:19:37 +02:00
scsi: mpt3sas: Fix kernel panic during drive powercycle test
2021-12-01 09:23:32 +01:00
scsi: mvsas: Add PCI ID of RocketRaid 2640
2022-04-20 09:19:37 +02:00
scsi: fdomain: Fix error return code in fdomain_probe()
2021-09-22 12:26:24 +02:00
scsi: pm8001: Fix pm8001_mpi_task_abort_resp()
2022-04-15 14:18:33 +02:00
scsi: qedf: Fix refcount issue when LOGO is received during TMF
2022-02-16 12:52:48 +01:00
scsi: qedi: Fix failed disconnect handling
2022-04-27 13:50:48 +02:00
scsi: qla2xxx: Fix erroneous mailbox timeout after PCI error injection
2022-08-25 11:18:10 +02:00
scsi: qla4xxx: Fix an error handling path in 'qla4xxx_get_host_stats()'
2020-10-29 09:57:36 +01:00
scsi: smartpqi: Fix DMA direction for RAID requests
2022-08-25 11:17:56 +02:00
scsi: ufs: host: Hold reference returned by of_parse_phandle()
2022-08-03 11:59:38 +02:00
scsi: advansys: Fix kernel pointer leak
2021-11-26 10:47:15 +01:00
scsi: aha152x: Fix aha152x_setup() __setup handler return value
2022-04-15 14:18:34 +02:00
scsi: BusLogic: Fix missing pr_cont() use
2021-09-22 12:26:37 +02:00
scsi: BusLogic: Fix 64-bit system enumeration error for Buslogic
2021-06-03 08:59:11 +02:00
scsi: dc395x: Fix a missing check on list iterator
2022-06-14 18:11:46 +02:00
scsi: FlashPoint: Rename si_flags field
2021-07-14 16:53:41 +02:00
scsi: core: Fix shost->cmd_per_lun calculation in scsi_add_host_with_dma()
2021-10-27 09:54:29 +02:00
scsi: hpsa: Fix memory leak in hpsa_init_one()
2020-11-18 19:20:22 +01:00
scsi: ipr: Fix missing/incorrect resource cleanup in error case
2022-06-22 14:11:20 +02:00
scsi: iscsi: Fix reference count leak in iscsi_boot_create_kobj
2020-06-24 17:50:37 +02:00
scsi: jazz_esp: Add IRQ check
2021-05-14 09:44:25 +02:00
scsi: sr: remove references to BLK_DEV_SR_VENDOR, leave it enabled
2020-07-22 09:32:57 +02:00
scsi: libiscsi: Fix UAF in iscsi_conn_get_param()/iscsi_conn_teardown()
2022-01-11 15:23:33 +01:00
scsi: megaraid: Fix error check return value of register_chrdev()
2022-06-14 18:11:26 +02:00
scsi: mesh: Fix panic after host or bus reset
2020-08-19 08:16:15 +02:00
scsi: mvumi: Fix error return in mvumi_io_attach()
2020-10-29 09:58:04 +01:00
scsi: myrb: Fix up null pointer access on myrb_cleanup()
2022-06-14 18:12:00 +02:00
scsi: myrs: Fix crash in error case
2022-02-16 12:52:49 +01:00
scsi: pmcraid: Fix missing resource cleanup in error case
2022-06-22 14:11:20 +02:00
scsi: core: Put LLD module refcnt after SCSI device is released
2021-11-06 13:59:44 +01:00
scsi: scsi_debug: Sanity check block descriptor length in resp_mode_select()
2021-12-22 09:29:40 +01:00
scsi: core: Show SCMD_LAST in text form
2022-01-27 09:19:52 +01:00
scsi: scsi_devinfo: Add blacklist entry for HPE OPEN-V
2021-06-18 09:58:59 +02:00
scsi: dh: Add Fujitsu device to devinfo and dh lists
2020-07-29 10:18:27 +02:00
scsi: core: Fix race between handling STS_RESOURCE and completion
2022-08-03 11:59:41 +02:00
scsi: pm: Balance pm_only counter of request queue during system resume
2020-06-07 13:18:50 +02:00
scsi: core: Avoid printing an error if target_alloc() returns -ENXIO
2021-08-26 08:36:14 -04:00
scsi: core: sysfs: Fix setting device state to SDEV_RUNNING
2021-12-01 09:23:33 +01:00
scsi: iscsi: Unblock session then wake up error handler
2021-12-08 09:01:09 +01:00
scsi: scsi_transport_spi: Set RQF_PM for domain validation commands
2021-01-12 20:16:09 +01:00
scsi: scsi_transport_srp: Don't block target in SRP_PORT_LOST state
2021-04-21 12:56:14 +02:00
scsi: sd: Free scsi_disk device via put_device()
2021-10-09 14:39:49 +02:00
scsi: ses: Fix unsigned comparison with less than zero
2021-10-17 10:42:34 +02:00
scsi: sg: Allow waiting for commands to complete on removed device
2022-08-25 11:18:17 +02:00
scsi: sni_53c710: Add IRQ check
2021-05-14 09:44:25 +02:00
scsi: sr: Don't use GFP_DMA
2022-01-27 09:19:48 +01:00
scsi: sr: Don't use GFP_DMA
2022-01-27 09:19:48 +01:00
scsi: st: Fix a use after free in st_open()
2021-04-07 14:47:39 +02:00
scsi: sun3x_esp: Add IRQ check
2021-05-14 09:44:25 +02:00
scsi: virtio_scsi: Fix spelling mistake "Unsupport" -> "Unsupported"
2021-10-17 10:42:34 +02:00
scsi: vmw_pvscsi: Set residual data length conditionally
2022-01-05 12:37:46 +01:00
scsi: vmw_pvscsi: Expand vcpuHint to 16 bits
2022-06-22 14:11:20 +02:00
xen/scsifront: don't use gnttab_query_foreign_access() for mapped status
2022-03-11 11:22:39 +01:00
scsi: zorro7xx: Fix a resource leak in zorro7xx_remove_one()
2022-04-15 14:18:37 +02:00
f135c65085