Johannes Berg
d136f1bd36
genetlink: fix netns vs. netlink table locking ...
Since my commits introducing netns awareness into
genetlink we can get this problem:
BUG: scheduling while atomic: modprobe/1178/0x00000002
2 locks held by modprobe/1178:
#0 : (genl_mutex){+.+.+.}, at: [<ffffffff8135ee1a>] genl_register_mc_grou
#1 : (rcu_read_lock){.+.+..}, at: [<ffffffff8135eeb5>] genl_register_mc_g
Pid: 1178, comm: modprobe Not tainted 2.6.31-rc8-wl-34789-g95cb731-dirty #
Call Trace:
[<ffffffff8103e285>] __schedule_bug+0x85/0x90
[<ffffffff81403138>] schedule+0x108/0x588
[<ffffffff8135b131>] netlink_table_grab+0xa1/0xf0
[<ffffffff8135c3a7>] netlink_change_ngroups+0x47/0x100
[<ffffffff8135ef0f>] genl_register_mc_group+0x12f/0x290
because I overlooked that netlink_table_grab() will
schedule, thinking it was just the rwlock. However,
in the contention case, that isn't actually true.
Fix this by letting the code grab the netlink table
lock first and then the RCU for netns protection.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
2009-09-14 17:02:50 -07:00
net/9p: insulate the client against an invalid error code sent by a 9p server
2009-08-17 16:39:54 -05:00
vlan: adds drops accounting
2009-09-03 20:02:17 -07:00
Have atalk_route_packet() return NET_RX_SUCCESS not NET_XMIT_SUCCESS
2009-09-14 17:02:47 -07:00
atm/br2684: netif_stop_queue() when atm device busy and netif_wake_queue() when we can send packets again.
2009-09-02 23:46:10 -07:00
net: Add DEVTYPE support for Ethernet based devices
2009-09-11 12:54:55 -07:00
net: Add DEVTYPE support for Ethernet based devices
2009-09-11 12:54:55 -07:00
can: use correct NET_RX_ return values
2009-08-30 22:13:18 -07:00
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6
2009-09-14 10:37:28 -07:00
dcbnl: Add implementations of dcbnl setapp/getapp commands
2009-09-01 01:24:36 -07:00
inet: inet_connection_sock_af_ops const
2009-09-02 01:03:49 -07:00
net: make neigh_ops constant
2009-09-01 17:40:57 -07:00
netdev: convert pseudo-devices to netdev_tx_t
2009-09-01 01:13:07 -07:00
Drop ARPHRD_IEEE802154_PHY
2009-08-19 23:08:24 +04:00
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6
2009-09-14 10:37:28 -07:00
ipv6: Add IFA_F_DADFAILED flag
2009-09-11 12:54:58 -07:00
net: file_operations should be const
2009-09-02 01:03:53 -07:00
net: file_operations should be const
2009-09-02 01:03:53 -07:00
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6
2009-09-02 00:32:56 -07:00
net: Add DEVTYPE support for Ethernet based devices
2009-09-11 12:54:55 -07:00
Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/kaber/nf-next-2.6
2009-09-10 18:17:09 -07:00
genetlink: fix netns vs. netlink table locking
2009-09-14 17:02:50 -07:00
Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6
2009-09-02 00:32:56 -07:00
Phonet: back-end for autoconfigured addresses
2009-09-11 12:55:06 -07:00
RDS: Add a debug message suggesting to load transport modules
2009-08-23 19:13:14 -07:00
convert hamradio drivers to netdev_txreturnt_t
2009-09-01 01:13:12 -07:00
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next-2.6
2009-09-14 10:37:28 -07:00
sctp: Catch bogus stream sequence numbers
2009-09-04 18:21:03 -04:00
Merge branch 'nfs-for-2.6.32'
2009-09-11 14:59:37 -04:00
tipc: fix test of bearer_priority range in tipc_register_media()
2009-08-29 00:19:42 -07:00
net: unix: fix sending fds in multiple buffers
2009-09-11 11:31:45 -07:00
cfg80211: allow scanning on specified frequencies when using wext-compatibility
2009-09-09 11:25:27 -04:00
net: file_operations should be const
2009-09-02 01:03:53 -07:00
d136f1bd36