Repository files (latest commit first)

Filename	Latest commit message	Latest commit date
Filipe Manana 0e0f324c25 btrfs: fix race between quota disable and quota assign ioctls ... commit 2f1a6be12ab6c8470d5776e68644726c94257c54 upstream. The quota assign ioctl can currently run in parallel with a quota disable ioctl call. The assign ioctl uses the quota root, while the disable ioctl frees that root, and therefore we can have a use-after-free triggered in the assign ioctl, leading to a trace like the following when KASAN is enabled: [672.723][T736] BUG: KASAN: slab-use-after-free in btrfs_search_slot+0x2962/0x2db0 [672.723][T736] Read of size 8 at addr ffff888022ec0208 by task btrfs_search_sl/27736 [672.724][T736] [672.725][T736] CPU: 1 PID: 27736 Comm: btrfs_search_sl Not tainted 6.3.0-rc3 #37 [672.723][T736] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.15.0-1 04/01/2014 [672.727][T736] Call Trace: [672.728][T736] <TASK> [672.728][T736] dump_stack_lvl+0xd9/0x150 [672.725][T736] print_report+0xc1/0x5e0 [672.720][T736] ? __virt_addr_valid+0x61/0x2e0 [672.727][T736] ? __phys_addr+0xc9/0x150 [672.725][T736] ? btrfs_search_slot+0x2962/0x2db0 [672.722][T736] kasan_report+0xc0/0xf0 [672.729][T736] ? btrfs_search_slot+0x2962/0x2db0 [672.724][T736] btrfs_search_slot+0x2962/0x2db0 [672.723][T736] ? fs_reclaim_acquire+0xba/0x160 [672.722][T736] ? split_leaf+0x13d0/0x13d0 [672.726][T736] ? rcu_is_watching+0x12/0xb0 [672.723][T736] ? kmem_cache_alloc+0x338/0x3c0 [672.722][T736] update_qgroup_status_item+0xf7/0x320 [672.724][T736] ? add_qgroup_rb+0x3d0/0x3d0 [672.739][T736] ? do_raw_spin_lock+0x12d/0x2b0 [672.730][T736] ? spin_bug+0x1d0/0x1d0 [672.737][T736] btrfs_run_qgroups+0x5de/0x840 [672.730][T736] ? btrfs_qgroup_rescan_worker+0xa70/0xa70 [672.738][T736] ? __del_qgroup_relation+0x4ba/0xe00 [672.738][T736] btrfs_ioctl+0x3d58/0x5d80 [672.735][T736] ? tomoyo_path_number_perm+0x16a/0x550 [672.737][T736] ? tomoyo_execute_permission+0x4a0/0x4a0 [672.731][T736] ? btrfs_ioctl_get_supported_features+0x50/0x50 [672.737][T736] ? __sanitizer_cov_trace_switch+0x54/0x90 [672.734][T736] ? do_vfs_ioctl+0x132/0x1660 [672.730][T736] ? vfs_fileattr_set+0xc40/0xc40 [672.730][T736] ? _raw_spin_unlock_irq+0x2e/0x50 [672.732][T736] ? sigprocmask+0xf2/0x340 [672.737][T736] ? __fget_files+0x26a/0x480 [672.732][T736] ? bpf_lsm_file_ioctl+0x9/0x10 [672.738][T736] ? btrfs_ioctl_get_supported_features+0x50/0x50 [672.736][T736] __x64_sys_ioctl+0x198/0x210 [672.736][T736] do_syscall_64+0x39/0xb0 [672.731][T736] entry_SYSCALL_64_after_hwframe+0x63/0xcd [672.739][T736] RIP: 0033:0x4556ad [672.742][T736] </TASK> [672.743][T736] [672.748][T736] Allocated by task 27677: [672.743][T736] kasan_save_stack+0x22/0x40 [672.741][T736] kasan_set_track+0x25/0x30 [672.741][T736] __kasan_kmalloc+0xa4/0xb0 [672.749][T736] btrfs_alloc_root+0x48/0x90 [672.746][T736] btrfs_create_tree+0x146/0xa20 [672.744][T736] btrfs_quota_enable+0x461/0x1d20 [672.743][T736] btrfs_ioctl+0x4a1c/0x5d80 [672.747][T736] __x64_sys_ioctl+0x198/0x210 [672.749][T736] do_syscall_64+0x39/0xb0 [672.744][T736] entry_SYSCALL_64_after_hwframe+0x63/0xcd [672.756][T736] [672.757][T736] Freed by task 27677: [672.759][T736] kasan_save_stack+0x22/0x40 [672.759][T736] kasan_set_track+0x25/0x30 [672.756][T736] kasan_save_free_info+0x2e/0x50 [672.751][T736] ____kasan_slab_free+0x162/0x1c0 [672.758][T736] slab_free_freelist_hook+0x89/0x1c0 [672.752][T736] __kmem_cache_free+0xaf/0x2e0 [672.752][T736] btrfs_put_root+0x1ff/0x2b0 [672.759][T736] btrfs_quota_disable+0x80a/0xbc0 [672.752][T736] btrfs_ioctl+0x3e5f/0x5d80 [672.756][T736] __x64_sys_ioctl+0x198/0x210 [672.753][T736] do_syscall_64+0x39/0xb0 [672.765][T736] entry_SYSCALL_64_after_hwframe+0x63/0xcd [672.769][T736] [672.768][T736] The buggy address belongs to the object at ffff888022ec0000 [672.768][T736] which belongs to the cache kmalloc-4k of size 4096 [672.769][T736] The buggy address is located 520 bytes inside of [672.769][T736] freed 4096-byte region [ffff888022ec0000, ffff888022ec1000) [672.760][T736] [672.764][T736] The buggy address belongs to the physical page: [672.761][T736] page:ffffea00008bb000 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x22ec0 [672.766][T736] head:ffffea00008bb000 order:3 entire_mapcount:0 nr_pages_mapped:0 pincount:0 [672.779][T736] flags: 0xfff00000010200(slab|head|node=0|zone=1|lastcpupid=0x7ff) [672.770][T736] raw: 00fff00000010200 ffff888012842140 ffffea000054ba00 dead000000000002 [672.770][T736] raw: 0000000000000000 0000000000040004 00000001ffffffff 0000000000000000 [672.771][T736] page dumped because: kasan: bad access detected [672.778][T736] page_owner tracks the page as allocated [672.777][T736] page last allocated via order 3, migratetype Unmovable, gfp_mask 0xd2040(__GFP_IO|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP|__GFP_NOMEMALLOC), pid 88 [672.779][T736] get_page_from_freelist+0x119c/0x2d50 [672.779][T736] __alloc_pages+0x1cb/0x4a0 [672.776][T736] alloc_pages+0x1aa/0x270 [672.773][T736] allocate_slab+0x260/0x390 [672.771][T736] ___slab_alloc+0xa9a/0x13e0 [672.778][T736] __slab_alloc.constprop.0+0x56/0xb0 [672.771][T736] __kmem_cache_alloc_node+0x136/0x320 [672.789][T736] __kmalloc+0x4e/0x1a0 [672.783][T736] tomoyo_realpath_from_path+0xc3/0x600 [672.781][T736] tomoyo_path_perm+0x22f/0x420 [672.782][T736] tomoyo_path_unlink+0x92/0xd0 [672.780][T736] security_path_unlink+0xdb/0x150 [672.788][T736] do_unlinkat+0x377/0x680 [672.788][T736] __x64_sys_unlink+0xca/0x110 [672.789][T736] do_syscall_64+0x39/0xb0 [672.783][T736] entry_SYSCALL_64_after_hwframe+0x63/0xcd [672.784][T736] page last free stack trace: [672.787][T736] free_pcp_prepare+0x4e5/0x920 [672.787][T736] free_unref_page+0x1d/0x4e0 [672.784][T736] __unfreeze_partials+0x17c/0x1a0 [672.797][T736] qlist_free_all+0x6a/0x180 [672.796][T736] kasan_quarantine_reduce+0x189/0x1d0 [672.797][T736] __kasan_slab_alloc+0x64/0x90 [672.793][T736] kmem_cache_alloc+0x17c/0x3c0 [672.799][T736] getname_flags.part.0+0x50/0x4e0 [672.799][T736] getname_flags+0x9e/0xe0 [672.792][T736] vfs_fstatat+0x77/0xb0 [672.791][T736] __do_sys_newlstat+0x84/0x100 [672.798][T736] do_syscall_64+0x39/0xb0 [672.796][T736] entry_SYSCALL_64_after_hwframe+0x63/0xcd [672.790][T736] [672.791][T736] Memory state around the buggy address: [672.799][T736] ffff888022ec0100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb [672.805][T736] ffff888022ec0180: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb [672.802][T736] >ffff888022ec0200: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb [672.809][T736] ^ [672.809][T736] ffff888022ec0280: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb [672.809][T736] ffff888022ec0300: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb Fix this by having the qgroup assign ioctl take the qgroup ioctl mutex before calling btrfs_run_qgroups(), which is what all qgroup ioctls should call. Reported-by: butt3rflyh4ck <butterflyhuangxx@gmail.com> Link: https://lore.kernel.org/linux-btrfs/CAFcO6XN3VD8ogmHwqRk4kbiwtpUSNySu2VAxN8waEPciCHJvMA@mail.gmail.com/ CC: stable@vger.kernel.org # 5.10+ Reviewed-by: Qu Wenruo <wqu@suse.com> Signed-off-by: Filipe Manana <fdmanana@suse.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com> Signed-off-by: Harshvardhan Jha <harshvardhan.j.jha@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-08-11 11:53:54 +02:00
..
9p
adfs
affs	affs: initialize fsdata in affs_truncate()	2023-02-06 07:52:36 +01:00
afs	afs: Fix vlserver probe RTT handling	2023-06-21 15:44:12 +02:00
autofs
befs
bfs
btrfs	btrfs: fix race between quota disable and quota assign ioctls	2023-08-11 11:53:54 +02:00
cachefiles
ceph	ceph: don't let check_caps skip sending responses for revoke msgs	2023-07-27 08:37:38 +02:00
cifs	cifs: Fix potential deadlock when updating vol in cifs_reconnect()	2023-06-28 10:18:37 +02:00
coda	coda: Avoid partial allocation of sig_inputArgs	2023-03-11 16:43:56 +01:00
configfs	configfs: fix possible memory leak in configfs_create_dir()	2023-01-18 11:41:09 +01:00
cramfs
crypto
debugfs	debugfs: regset32: Add Runtime PM support	2023-05-17 11:35:32 +02:00
devpts
dlm	fs: dlm: interrupt posix locks only when process is killed	2023-08-11 11:53:45 +02:00
ecryptfs
efivarfs
efs
erofs	erofs: fix compact 4B support for 16k block size	2023-07-27 08:37:35 +02:00
exportfs
ext2	ext2: Check block size validity during mount	2023-05-30 12:44:02 +01:00
ext4	ext4: fix to check return value of freeze_bdev() in ext4_shutdown()	2023-08-11 11:53:47 +02:00
f2fs	Revert "f2fs: fix potential corruption when moving a directory"	2023-07-27 08:37:26 +02:00
fat	treewide: Remove uninitialized_var() usage	2023-06-09 10:29:01 +02:00
freevxfs
fscache
fuse	fuse: revalidate: don't invalidate if interrupted	2023-07-27 08:37:40 +02:00
gfs2	gfs2: Don't deref jdesc in evict	2023-07-27 08:37:03 +02:00
hfs	hfs: fix missing hfs_bnode_get() in __hfs_bnode_create	2023-03-11 16:43:59 +01:00
hfsplus	treewide: Remove uninitialized_var() usage	2023-06-09 10:29:01 +02:00
hostfs
hpfs
hugetlbfs	hugetlbfs: fix null-ptr-deref in hugetlbfs_parse_param()	2023-01-18 11:41:38 +01:00
iomap
isofs	treewide: Remove uninitialized_var() usage	2023-06-09 10:29:01 +02:00
jbd2	jbd2: Fix wrongly judgement for buffer head removing while doing checkpoint	2023-08-11 11:53:43 +02:00
jffs2	jffs2: reduce stack usage in jffs2_build_xattr_subsystem()	2023-07-27 08:37:25 +02:00
jfs	jfs: jfs_dmap: Validate db_l2nbperpage while mounting	2023-07-27 08:37:35 +02:00
kernfs
lockd
minix
nfs	NFSv4.1: freeze the session table upon receiving NFS4ERR_BADSESSION	2023-07-27 08:37:18 +02:00
nfs_common
nfsd	NFSD: add encoding of op_recall flag for write delegation	2023-07-27 08:37:24 +02:00
nilfs2	nilfs2: prevent general protection fault in nilfs_clear_dirty_page()	2023-06-28 10:18:37 +02:00
nls
notify	fanotify: disallow mount/sb marks on kernel internal pseudo fs	2023-07-27 08:37:26 +02:00
ntfs
ocfs2	ocfs2: check new file size on fallocate call	2023-06-21 15:44:10 +02:00
omfs	treewide: Remove uninitialized_var() usage	2023-06-09 10:29:01 +02:00
openpromfs
orangefs	orangefs: Fix kmemleak in orangefs_{kernel,client}_debug_init()	2023-01-18 11:41:39 +01:00
overlayfs	treewide: Remove uninitialized_var() usage	2023-06-09 10:29:01 +02:00
proc	mm: hugetlb: proc: check for hugetlb shared PMD in /proc/PID/smaps	2023-02-22 12:50:28 +01:00
pstore	pstore/ram: Add check for kstrdup	2023-07-27 08:37:06 +02:00
qnx4
qnx6
quota	ext4: fix bug_on in __es_tree_search caused by bad quota inode	2023-01-18 11:42:02 +01:00
ramfs
reiserfs	reiserfs: Add security prefix to xattr name in reiserfs_security_write()	2023-05-17 11:35:33 +02:00
romfs
squashfs	revert "squashfs: harden sanity check in squashfs_read_xattr_id_table"	2023-02-22 12:50:39 +01:00
sysfs
sysv	fs: sysv: Fix sysv_nblocks() returns wrong value	2023-01-18 11:40:58 +01:00
tracefs
ubifs	treewide: Remove uninitialized_var() usage	2023-06-09 10:29:01 +02:00
udf	treewide: Remove uninitialized_var() usage	2023-06-09 10:29:01 +02:00
ufs
unicode
verity	fsverity: don't drop pagecache at end of FS_IOC_ENABLE_VERITY	2023-04-05 11:16:42 +02:00
xfs	xfs: verify buffer contents when we skip log replay	2023-06-28 10:18:42 +02:00
aio.c	aio: fix mremap after fork null-deref	2023-02-22 12:50:35 +01:00
anon_inodes.c
attr.c
bad_inode.c
binfmt_aout.c	binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf	2023-01-18 11:41:46 +01:00
binfmt_elf.c
binfmt_elf_fdpic.c	binfmt: Fix error return code in load_elf_fdpic_binary()	2023-01-18 11:41:46 +01:00
binfmt_em86.c
binfmt_flat.c	binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf	2023-01-18 11:41:46 +01:00
binfmt_misc.c	binfmt_misc: fix shift-out-of-bounds in check_special_flags	2023-01-18 11:41:33 +01:00
binfmt_script.c
block_dev.c
buffer.c
char_dev.c	chardev: fix error handling in cdev_device_add()	2023-01-18 11:41:25 +01:00
compat.c
compat_binfmt_elf.c
compat_ioctl.c
coredump.c
d_path.c
dax.c
dcache.c
dcookies.c
direct-io.c
drop_caches.c
eventfd.c
eventpoll.c	epoll: ep_autoremove_wake_function should use list_del_init_careful	2023-06-28 10:18:35 +02:00
exec.c
fcntl.c
fhandle.c
file.c	fs: prevent out-of-bounds array speculation when closing a file descriptor	2023-03-17 08:32:47 +01:00
file_table.c
filesystems.c
fs-writeback.c	writeback: fix call of incorrect macro	2023-05-17 11:35:58 +02:00
fs_context.c	fs: avoid empty option when generating legacy mount string	2023-07-27 08:37:25 +02:00
fs_parser.c
fs_pin.c
fs_struct.c
fs_types.c
fsopen.c
inode.c	fs: Establish locking order for unrelated directories	2023-07-27 08:37:26 +02:00
internal.h	fs: Establish locking order for unrelated directories	2023-07-27 08:37:26 +02:00
io_uring.c	io_uring: have io_kill_timeout() honor the request references	2023-06-05 08:17:32 +02:00
ioctl.c
Kconfig
Kconfig.binfmt
libfs.c
locks.c
Makefile
mbcache.c	mbcache: Avoid nesting of cache->c_list_lock under bit locks	2023-01-18 11:41:59 +01:00
mount.h
mpage.c
namei.c	fs: no need to check source	2023-07-27 08:37:26 +02:00
namespace.c
no-block.c
nsfs.c
open.c
pipe.c
pnode.c	pnode: terminate at peers of source	2023-01-18 11:41:44 +01:00
pnode.h
posix_acl.c
proc_namespace.c
read_write.c
readdir.c
select.c
seq_file.c
signalfd.c
splice.c
stack.c
stat.c
statfs.c	statfs: enforce statfs[64] structure initialization	2023-05-30 12:44:07 +01:00
super.c
sync.c
timerfd.c
userfaultfd.c
utimes.c
xattr.c