Alok Tiwari
b076002838
scsi: iscsi: Fix incorrect error path labels for flashnode operations
...
[ Upstream commit 9b17621366d210ffee83262a8754086ebbde5e55 ]
Correct the error handling goto labels used when host lookup fails in
various flashnode-related event handlers:
- iscsi_new_flashnode()
- iscsi_del_flashnode()
- iscsi_login_flashnode()
- iscsi_logout_flashnode()
- iscsi_logout_flashnode_sid()
scsi_host_put() is not required when shost is NULL, so jumping to the
correct label avoids unnecessary operations. These functions previously
jumped to the wrong goto label (put_host), which did not match the
intended cleanup logic.
Use the correct exit labels (exit_new_fnode, exit_del_fnode, etc.) to
ensure proper error handling. Also remove the unused put_host label
under iscsi_new_flashnode() as it is no longer needed.
No functional changes beyond accurate error path correction.
Fixes: c6a4bb2ef5 ("[SCSI] scsi_transport_iscsi: Add flash node mgmt support")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Link: https://lore.kernel.org/r/20250530193012.3312911-1-alok.a.tiwari@oracle.com
Reviewed-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2025-06-27 11:02:49 +01:00
..
aacraid
scsi: aacraid: Rearrange order of struct aac_srb_unit
2024-11-08 16:20:39 +01:00
aic7xxx
aic94xx
arcmsr
arm
be2iscsi
scsi: be2iscsi: Fix a memleak in beiscsi_init_wrb_handle()
2023-12-13 18:18:13 +01:00
bfa
scsi: bfa: Fix use-after-free in bfad_im_module_exit()
2024-12-14 19:44:29 +01:00
bnx2fc
scsi: bnx2fc: Remove spin_lock_bh while releasing resources after upload
2024-05-17 11:43:50 +02:00
bnx2i
csiostor
scsi: csiostor: Avoid function pointer casts
2024-03-26 18:22:23 -04:00
cxgbi
cxlflash
device_handler
dpt
esas2r
fcoe
scsi: Revert "scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock"
2024-02-23 08:25:10 +01:00
fnic
scsi: fnic: Return error if vmalloc() failed
2024-01-25 14:34:25 -08:00
hisi_sas
scsi: hisi_sas: Replace with standard error code return value
2024-01-25 14:34:25 -08:00
ibmvscsi
ibmvscsi_tgt
isci
scsi: isci: Fix an error code problem in isci_io_request_build()
2024-02-23 08:25:04 +01:00
libfc
scsi: libfc: Fix up timeout error in fc_fcp_rec_error()
2024-02-23 08:24:58 +01:00
libsas
scsi: libsas: Fix exp-attached device scan after probe failure scanned in again after probe failed
2024-07-27 10:38:31 +02:00
lpfc
scsi: lpfc: Handle duplicate D_IDs in ndlp search-by D_ID routine
2025-06-04 14:32:34 +02:00
megaraid
scsi: megaraid_sas: Fix for a potential deadlock
2025-01-09 13:23:31 +01:00
mpt3sas
scsi: mpt3sas: Send a diag reset if target reset fails
2025-06-04 14:32:33 +02:00
mvsas
pcmcia
pm8001
scsi: pm80xx: Set phy_attached to zero when device is gone
2025-05-02 07:39:29 +02:00
qedf
scsi: qedf: Fix a possible memory leak in qedf_alloc_and_init_sb()
2024-12-14 19:44:30 +01:00
qedi
scsi: qedi: Fix a possible memory leak in qedi_alloc_and_init_sb()
2024-12-14 19:44:30 +01:00
qla2xxx
scsi: qla2xxx: Remove check req_sg_cnt should be equal to rsp_sg_cnt
2024-12-14 19:44:49 +01:00
qla4xxx
scsi: qla4xxx: Add length check when parsing nlattrs
2023-09-23 10:59:49 +02:00
smartpqi
snic
scsi: snic: Fix double free in snic_tgt_create()
2023-08-30 16:27:27 +02:00
sym53c8xx_2
ufs
scsi: ufs: bsg: Delete bsg_dev when setting up bsg fails
2025-03-13 12:42:58 +01:00
.gitignore
3w-9xxx.c
3w-9xxx.h
3w-sas.c
3w-sas.h
3w-xxxx.c
scsi: 3w-xxxx: Add error handling for initialization failure in tw_probe()
2023-07-27 08:37:16 +02:00
3w-xxxx.h
53c700.c
scsi: 53c700: Check that command slot is not NULL
2023-08-16 18:19:25 +02:00
53c700.h
53c700.scr
53c700_d.h_shipped
a100u2w.c
a100u2w.h
a2091.c
a2091.h
a3000.c
a3000.h
a4000t.c
advansys.c
aha152x.c
aha152x.h
aha1542.c
aha1542.h
aha1740.c
aha1740.h
am53c974.c
atari_scsi.c
atp870u.c
atp870u.h
BusLogic.c
BusLogic.h
bvme6000_scsi.c
ch.c
constants.c
dc395x.c
treewide: Remove uninitialized_var() usage
2023-06-09 10:29:01 +02:00
dc395x.h
dmx3191d.c
dpt_i2o.c
scsi: dpt_i2o: Do not process completions with invalid addresses
2023-06-09 10:29:04 +02:00
dpti.h
scsi: dpt_i2o: Remove broken pass-through ioctl (I2OUSERCMD)
2023-06-09 10:29:03 +02:00
esp_scsi.c
esp_scsi.h
fdomain.c
fdomain.h
fdomain_isa.c
fdomain_pci.c
FlashPoint.c
g_NCR5380.c
gdth.c
gdth.h
gdth_ioctl.h
gdth_proc.c
gdth_proc.h
gvp11.c
gvp11.h
hosts.c
scsi: core: Fix unremoved procfs host directory regression
2024-04-13 12:51:32 +02:00
hpsa.c
scsi: hpsa: Fix allocation size for Scsi_Host private data
2024-06-16 13:28:35 +02:00
hpsa.h
hpsa_cmd.h
hptiop.c
hptiop.h
imm.c
imm.h
initio.c
initio.h
ipr.c
ipr.h
ips.c
ips.h
iscsi_boot_sysfs.c
iscsi_tcp.c
iscsi_tcp.h
jazz_esp.c
Kconfig
scsi: jazz_esp: Only build if SCSI core is builtin
2024-03-01 13:13:37 +01:00
lasi700.c
libiscsi.c
libiscsi_tcp.c
mac53c94.c
mac53c94.h
mac_esp.c
mac_scsi.c
Makefile
megaraid.c
megaraid.h
mesh.c
mesh.h
mvme16x_scsi.c
mvme147.c
mvme147.h
mvumi.c
mvumi.h
myrb.c
scsi: mylex: Fix sysfs buffer lengths
2024-04-13 12:51:36 +02:00
myrb.h
myrs.c
scsi: mylex: Fix sysfs buffer lengths
2024-04-13 12:51:36 +02:00
myrs.h
ncr53c8xx.c
ncr53c8xx.h
NCR5380.c
NCR5380.h
nsp32.c
nsp32.h
nsp32_debug.c
nsp32_io.h
pmcraid.c
pmcraid.h
ppa.c
ppa.h
ps3rom.c
qla1280.c
scsi: qla1280: Fix kernel oops when debug level > 2
2025-04-10 14:29:36 +02:00
qla1280.h
scsi: qla1280: Fix hw revision numbering for ISP1020/1040
2025-01-09 13:23:31 +01:00
qlogicfas.c
qlogicfas408.c
qlogicfas408.h
qlogicpti.c
qlogicpti.h
raid_class.c
scsi: core: raid_class: Remove raid_component_add()
2023-08-30 16:27:27 +02:00
script_asm.pl
scsi.c
scsi.h
scsi_common.c
scsi_debug.c
scsi_debugfs.c
scsi_debugfs.h
scsi_devinfo.c
scsi_dh.c
scsi_error.c
scsi_ioctl.c
scsi_lib.c
scsi_lib_dma.c
scsi_logging.c
scsi_logging.h
scsi_netlink.c
scsi_pm.c
scsi_priv.h
scsi_proc.c
scsi: core: Fix legacy /proc parsing buffer overflow
2023-08-16 18:19:24 +02:00
scsi_sas_internal.h
scsi_scan.c
scsi_sysctl.c
scsi_sysfs.c
scsi_trace.c
scsi_transport_api.h
scsi_transport_fc.c
scsi_transport_iscsi.c
scsi: iscsi: Fix incorrect error path labels for flashnode operations
2025-06-27 11:02:49 +01:00
scsi_transport_sas.c
scsi_transport_spi.c
scsi: spi: Fix sshdr use
2024-09-04 13:14:53 +02:00
scsi_transport_srp.c
scsicam.c
sd.c
sd.h
sd_dif.c
sd_zbc.c
sense_codes.h
ses.c
sg.c
scsi: sg: Fix slab-use-after-free read in sg_release()
2025-02-01 18:18:51 +01:00
sgiwd93.c
sim710.c
sni_53c710.c
sr.c
sr.h
sr_ioctl.c
sr_vendor.c
st.c
scsi: st: Restore some drive settings after reset
2025-06-04 14:32:34 +02:00
st.h
scsi: st: Restore some drive settings after reset
2025-06-04 14:32:34 +02:00
st_options.h
stex.c
storvsc_drv.c
scsi: storvsc: Set correct data length for sending SCSI command without payload
2025-03-13 12:43:20 +01:00
sun3_scsi.c
sun3_scsi_vme.c
sun3x_esp.c
sun_esp.c
virtio_scsi.c
vmw_pvscsi.c
vmw_pvscsi.h
wd33c93.c
wd33c93.h
wd719x.c
wd719x.h
xen-scsifront.c
zalon.c
zorro7xx.c
zorro_esp.c