Mikulas Patocka
1e1110c43b
target: fix memory leak on XCOPY ...
On each processed XCOPY command, two "kmalloc-512" memory objects are
leaked. These represent two allocations of struct xcopy_pt_cmd in
target_core_xcopy.c.
The reason for the memory leak is that the cmd_kref field is not
initialized (thus, it is zero because the allocations were done with
kzalloc). When we decrement zero kref in target_put_sess_cmd, the result
is not zero, thus target_release_cmd_kref is not called.
This patch fixes the bug by moving kref initialization from
target_get_sess_cmd to transport_init_se_cmd (this function is called from
target_core_xcopy.c, so it will correctly initialize cmd_kref). It can be
easily verified that all code that calls target_get_sess_cmd also calls
transport_init_se_cmd earlier, thus moving kref_init shouldn't introduce
any new problems.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Cc: stable@vger.kernel.org # 3.12+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
2014-05-17 15:49:40 -07:00
iscsi-target: Disable Immediate + Unsolicited Data with ISER Protection
2014-05-15 17:09:12 -07:00
target: Pass in transport supported PI at session initialization
2014-04-07 01:48:54 -07:00
target: Pass in transport supported PI at session initialization
2014-04-07 01:48:54 -07:00
tcm_fc: Fix free-after-use regression in ft_free_cmd
2014-05-15 17:09:12 -07:00
target/iblock: Add blk_integrity + BIP passthrough support
2014-01-18 10:14:22 +00:00
target: silence GCC warning in target_alua_state_check
2014-03-13 12:02:05 -07:00
target_core_alua: Referrals configfs integration
2014-01-09 21:48:35 -08:00
target: Add TFO->abort_task for aborted task resources release
2014-04-07 01:48:51 -07:00
target: Don't allow setting WC emulation if device doesn't support
2014-05-15 17:09:17 -07:00
target: Fix sizeof in kmalloc for some default_groups arrays
2013-12-16 12:42:20 -08:00
target: Update copyright ownership/year information to 2013
2013-09-10 20:23:36 -07:00
Target/file: place escape values for protection information format
2014-04-07 01:48:39 -07:00
Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending
2014-01-31 15:31:23 -08:00
target: Update copyright ownership/year information to 2013
2013-09-10 20:23:36 -07:00
target/iblock: Fix double bioset_integrity_free bug
2014-04-07 01:48:54 -07:00
target/configfs: Expose protection device attributes
2014-01-18 09:57:47 +00:00
target: Fix free-after-use regression in PR unregister
2014-02-12 15:11:01 -08:00
drivers: target: Move prototype declaration of function to header file target_core_pr.h
2014-01-09 21:48:36 -08:00
target/pscsi: fix return value check
2013-10-25 10:42:09 -07:00
target/rd: T10-Dif: RAM disk is allocating more space than required.
2014-04-07 01:48:53 -07:00
target/rd: Add support for protection SGL setup + release
2014-01-19 02:22:05 +00:00
target/sbc: Add sbc_dif_read_strip software emulation
2014-04-07 01:48:57 -07:00
target/spc: Only expose PI mode page bits when supported by fabric
2014-04-07 01:48:55 -07:00
target: Convert se_device statistics to atomic_long_t
2013-11-13 18:34:55 -08:00
target: Add check to prevent Abort Task from aborting itself
2014-04-11 15:27:15 -07:00
Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending
2014-01-31 15:31:23 -08:00
target: fix memory leak on XCOPY
2014-05-17 15:49:40 -07:00
target: Remove unused ua_dev_list member in struct se_ua
2013-12-16 12:39:04 -08:00
target core: rename (ex,im)plict -> (ex,im)plicit
2013-11-20 11:24:40 -08:00
drivers: target: Move prototype declaration of function to header file target_core_pr.h
2014-01-09 21:48:36 -08:00
1e1110c43b