Vamshi K Sthambamkadi
bacf98ee00
tracing: Fix memory leaks in trace_events_hist.c
[ Upstream commit 9da73974eb9c965dd9989befb593b8c8da9e4bdc ]
kmemleak report 1:
[<9092c50b>] kmem_cache_alloc_trace+0x138/0x270
[<05a2c9ed>] create_field_var+0xcf/0x180
[<528a2d68>] action_create+0xe2/0xc80
[<63f50b61>] event_hist_trigger_func+0x15b5/0x1920
[<28ea5d3d>] trigger_process_regex+0x7b/0xc0
[<3138e86f>] event_trigger_write+0x4d/0xb0
[<ffd66c19>] __vfs_write+0x30/0x200
[<4f424a0d>] vfs_write+0x96/0x1b0
[<da59a290>] ksys_write+0x53/0xc0
[<3717101a>] __ia32_sys_write+0x15/0x20
[<c5f23497>] do_fast_syscall_32+0x70/0x250
[<46e2629c>] entry_SYSENTER_32+0xaf/0x102
This is because save_vars[] of struct hist_trigger_data are
not destroyed
kmemleak report 2:
[<9092c50b>] kmem_cache_alloc_trace+0x138/0x270
[<6e5e97c5>] create_var+0x3c/0x110
[<de82f1b9>] create_field_var+0xaf/0x180
[<528a2d68>] action_create+0xe2/0xc80
[<63f50b61>] event_hist_trigger_func+0x15b5/0x1920
[<28ea5d3d>] trigger_process_regex+0x7b/0xc0
[<3138e86f>] event_trigger_write+0x4d/0xb0
[<ffd66c19>] __vfs_write+0x30/0x200
[<4f424a0d>] vfs_write+0x96/0x1b0
[<da59a290>] ksys_write+0x53/0xc0
[<3717101a>] __ia32_sys_write+0x15/0x20
[<c5f23497>] do_fast_syscall_32+0x70/0x250
[<46e2629c>] entry_SYSENTER_32+0xaf/0x102
struct hist_field allocated through create_var() do not initialize
"ref" field to 1. The code in __destroy_hist_field() does not destroy
object if "ref" is initialized to zero, the condition
if (--hist_field->ref > 1) always passes since unsigned int wraps.
kmemleak report 3:
[<f8666fcc>] __kmalloc_track_caller+0x139/0x2b0
[<bb7f80a5>] kstrdup+0x27/0x50
[<39d70006>] init_var_ref+0x58/0xd0
[<8ca76370>] create_var_ref+0x89/0xe0
[<f045fc39>] action_create+0x38f/0xc80
[<7c146821>] event_hist_trigger_func+0x15b5/0x1920
[<07de3f61>] trigger_process_regex+0x7b/0xc0
[<e87daf8f>] event_trigger_write+0x4d/0xb0
[<19bf1512>] __vfs_write+0x30/0x200
[<64ce4d27>] vfs_write+0x96/0x1b0
[<a6f34170>] ksys_write+0x53/0xc0
[<7d4230cd>] __ia32_sys_write+0x15/0x20
[<8eadca00>] do_fast_syscall_32+0x70/0x250
[<235cf985>] entry_SYSENTER_32+0xaf/0x102
hist_fields (system & event_name) are not freed
Link: http://lkml.kernel.org/r/20200422061503.GA5151@cosmos
Signed-off-by: Vamshi K Sthambamkadi <vamshi.k.sthambamkadi@gmail.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
|
2020-05-10 10:31:28 +02:00 |
| .. |
|
bpf
|
cpumap: Avoid warning when CONFIG_DEBUG_PER_CPU_MAPS is enabled
|
2020-05-02 08:48:51 +02:00 |
|
cgroup
|
cgroup1: don't call release_agent when it is ""
|
2020-04-01 11:01:51 +02:00 |
|
configs
|
|
|
|
debug
|
kgdb: don't use a notifier to enter kgdb at panic; call directly
|
2019-09-25 17:51:40 -07:00 |
|
dma
|
dma-direct: fix data truncation in dma_direct_get_required_mask()
|
2020-04-29 16:33:00 +02:00 |
|
events
|
perf/core: fix parent pid/tid in task exit events
|
2020-05-02 08:48:52 +02:00 |
|
gcov
|
kernel/gcov/fs.c: gcov_seq_next() should increase position index
|
2020-04-29 16:33:00 +02:00 |
|
irq
|
genirq/debugfs: Add missing sanity checks to interrupt injection
|
2020-04-17 10:50:11 +02:00 |
|
livepatch
|
livepatch: Nullify obj->mod in klp_module_coming()'s error path
|
2019-08-19 13:03:37 +02:00 |
|
locking
|
locktorture: Print ratio of acquisitions, not failures
|
2020-04-23 10:36:44 +02:00 |
|
power
|
PM: hibernate: Freeze kernel threads in software_resume()
|
2020-05-06 08:15:09 +02:00 |
|
printk
|
printk: queue wake_up_klogd irq_work only if per-CPU areas are ready
|
2020-05-02 08:48:42 +02:00 |
|
rcu
|
rcu: Allow only one expedited GP to run concurrently with wakeups
|
2020-03-05 16:43:50 +01:00 |
|
sched
|
sched/core: Fix reset-on-fork from RT with uclamp
|
2020-05-02 08:48:52 +02:00 |
|
time
|
time/sched_clock: Expire timer in hardirq context
|
2020-04-17 10:50:02 +02:00 |
|
trace
|
tracing: Fix memory leaks in trace_events_hist.c
|
2020-05-10 10:31:28 +02:00 |
|
.gitignore
|
|
|
|
acct.c
|
|
|
|
async.c
|
|
|
|
audit.c
|
audit: check the length of userspace generated audit records
|
2020-04-29 16:33:18 +02:00 |
|
audit.h
|
|
|
|
audit_fsnotify.c
|
|
|
|
audit_tree.c
|
|
|
|
audit_watch.c
|
audit_get_nd(): don't unlock parent too early
|
2019-11-10 11:56:55 -05:00 |
|
auditfilter.c
|
audit: fix error handling in audit_data_to_entry()
|
2020-03-05 16:43:42 +01:00 |
|
auditsc.c
|
|
|
|
backtracetest.c
|
|
|
|
bounds.c
|
|
|
|
capability.c
|
|
|
|
compat.c
|
|
|
|
configs.c
|
kernel/configs: Replace GPL boilerplate code with SPDX identifier
|
2019-07-30 18:34:15 +02:00 |
|
context_tracking.c
|
|
|
|
cpu.c
|
cpu/hotplug: Ignore pm_wakeup_pending() for disable_nonboot_cpus()
|
2020-04-17 10:50:11 +02:00 |
|
cpu_pm.c
|
|
|
|
crash_core.c
|
|
|
|
crash_dump.c
|
|
|
|
cred.c
|
keys: Fix request_key() cache
|
2020-01-17 19:48:42 +01:00 |
|
delayacct.c
|
|
|
|
dma.c
|
|
|
|
elfcore.c
|
kernel/elfcore.c: include proper prototypes
|
2019-09-25 17:51:39 -07:00 |
|
exec_domain.c
|
|
|
|
exit.c
|
exit: panic before exit_mm() on global init exit
|
2020-01-09 10:20:01 +01:00 |
|
extable.c
|
extable: Add function to search only kernel exception table
|
2019-08-21 22:23:48 +10:00 |
|
fail_function.c
|
|
|
|
fork.c
|
mm: fork: fix kernel_stack memcg stats for various stack implementations
|
2020-04-01 11:02:03 +02:00 |
|
freezer.c
|
Revert "libata, freezer: avoid block device removal while system is frozen"
|
2019-10-06 09:11:37 -06:00 |
|
futex.c
|
futex: Unbreak futex hashing
|
2020-03-25 08:25:58 +01:00 |
|
gen_kheaders.sh
|
kheaders: substituting --sort in archive creation
|
2019-10-17 09:08:19 +09:00 |
|
groups.c
|
|
|
|
hung_task.c
|
|
|
|
iomem.c
|
|
|
|
irq_work.c
|
|
|
|
jump_label.c
|
jump_label: Don't warn on __exit jump entries
|
2019-08-29 15:10:10 +01:00 |
|
kallsyms.c
|
kallsyms: Don't let kallsyms_lookup_size_offset() fail on retrieving the first symbol
|
2019-08-27 16:19:56 +01:00 |
|
kcmp.c
|
|
|
|
Kconfig.freezer
|
|
|
|
Kconfig.hz
|
|
|
|
Kconfig.locks
|
|
|
|
Kconfig.preempt
|
sched/rt, Kconfig: Unbreak def/oldconfig with CONFIG_PREEMPT=y
|
2019-07-22 18:05:11 +02:00 |
|
kcov.c
|
|
|
|
kexec.c
|
kexec_load: Disable at runtime if the kernel is locked down
|
2019-08-19 21:54:15 -07:00 |
|
kexec_core.c
|
kexec: bail out upon SIGKILL when allocating memory.
|
2019-09-25 17:51:40 -07:00 |
|
kexec_elf.c
|
kexec_elf: support 32 bit ELF files
|
2019-09-06 23:58:44 +02:00 |
|
kexec_file.c
|
Merge branch 'next-lockdown' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security
|
2019-09-28 08:14:15 -07:00 |
|
kexec_internal.h
|
|
|
|
kheaders.c
|
|
|
|
kmod.c
|
kmod: make request_module() return an error when autoloading is disabled
|
2020-04-17 10:50:22 +02:00 |
|
kprobes.c
|
kprobes: Fix optimize_kprobe()/unoptimize_kprobe() cancellation logic
|
2020-03-12 13:00:09 +01:00 |
|
ksysfs.c
|
|
|
|
kthread.c
|
kthread: make __kthread_queue_delayed_work static
|
2019-10-16 09:20:58 -07:00 |
|
latencytop.c
|
|
|
|
Makefile
|
Merge branch 'next-integrity' of git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity
|
2019-09-27 19:37:27 -07:00 |
|
module-internal.h
|
|
|
|
module.c
|
module: avoid setting info->name early in case we can fall back to info->mod->name
|
2020-02-24 08:36:54 +01:00 |
|
module_signature.c
|
MODSIGN: Export module signature definitions
|
2019-08-05 18:39:56 -04:00 |
|
module_signing.c
|
MODSIGN: Export module signature definitions
|
2019-08-05 18:39:56 -04:00 |
|
notifier.c
|
x86/mm: split vmalloc_sync_all()
|
2020-03-25 08:25:58 +01:00 |
|
nsproxy.c
|
|
|
|
padata.c
|
padata: always acquire cpu_hotplug_lock before pinst->lock
|
2020-04-08 09:08:47 +02:00 |
|
panic.c
|
panic: ensure preemption is disabled during panic()
|
2019-10-07 15:47:19 -07:00 |
|
params.c
|
lockdown: Lock down module params that specify hardware parameters (eg. ioport)
|
2019-08-19 21:54:16 -07:00 |
|
pid.c
|
|
|
|
pid_namespace.c
|
proc/sysctl: add shared variables for range check
|
2019-07-18 17:08:07 -07:00 |
|
profile.c
|
|
|
|
ptrace.c
|
ptrace: reintroduce usage of subjective credentials in ptrace_has_cap()
|
2020-01-23 08:22:36 +01:00 |
|
range.c
|
|
|
|
reboot.c
|
|
|
|
relay.c
|
|
|
|
resource.c
|
mm/memory_hotplug.c: use PFN_UP / PFN_DOWN in walk_system_ram_range()
|
2019-09-24 15:54:09 -07:00 |
|
rseq.c
|
|
|
|
seccomp.c
|
seccomp: Add missing compat_ioctl for notify
|
2020-04-17 10:50:09 +02:00 |
|
signal.c
|
signal: check sig before setting info in kill_pid_usb_asyncio
|
2020-05-02 08:48:55 +02:00 |
|
smp.c
|
smp: Warn on function calls from softirq context
|
2019-07-20 11:27:16 +02:00 |
|
smpboot.c
|
|
|
|
smpboot.h
|
|
|
|
softirq.c
|
|
|
|
stackleak.c
|
|
|
|
stacktrace.c
|
stacktrace: Don't skip first entry on noncurrent tasks
|
2019-11-04 21:19:25 +01:00 |
|
stop_machine.c
|
stop_machine: Avoid potential race behaviour
|
2019-10-17 12:47:12 +02:00 |
|
sys.c
|
Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
|
2019-09-17 12:35:15 -07:00 |
|
sys_ni.c
|
|
|
|
sysctl.c
|
kernel: sysctl: make drop_caches write-only
|
2020-01-04 19:18:32 +01:00 |
|
sysctl_binary.c
|
|
|
|
task_work.c
|
|
|
|
taskstats.c
|
taskstats: fix data-race
|
2020-01-09 10:19:54 +01:00 |
|
test_kprobes.c
|
|
|
|
torture.c
|
torture: Remove exporting of internal functions
|
2019-08-01 14:30:22 -07:00 |
|
tracepoint.c
|
|
|
|
tsacct.c
|
|
|
|
ucount.c
|
proc/sysctl: add shared variables for range check
|
2019-07-18 17:08:07 -07:00 |
|
uid16.c
|
|
|
|
uid16.h
|
|
|
|
umh.c
|
|
|
|
up.c
|
|
|
|
user-return-notifier.c
|
|
|
|
user.c
|
|
|
|
user_namespace.c
|
|
|
|
utsname.c
|
|
|
|
utsname_sysctl.c
|
|
|
|
watchdog.c
|
watchdog/softlockup: Enforce that timestamp is valid on boot
|
2020-02-24 08:36:52 +01:00 |
|
watchdog_hld.c
|
|
|
|
workqueue.c
|
workqueue: don't use wq_select_unbound_cpu() for bound works
|
2020-03-18 07:17:50 +01:00 |
|
workqueue_internal.h
|
|
|