Repository files (latest commit first)

Filename	Latest commit message	Latest commit date
Mathieu Desnoyers dc102a8fae Markers - remove extra format argument ... Denys Vlasenko <vda.linux@googlemail.com> : > Not in this patch, but I noticed: > > #define __trace_mark(name, call_private, format, args...) \ > do { \ > static const char __mstrtab_##name[] \ > __attribute__((section("__markers_strings"))) \ > = #name "\0" format; \ > static struct marker __mark_##name \ > __attribute__((section("__markers"), aligned(8))) = \ > { __mstrtab_##name, &__mstrtab_##name[sizeof(#name)], \ > 0, 0, marker_probe_cb, \ > { __mark_empty_function, NULL}, NULL }; \ > __mark_check_format(format, ## args); \ > if (unlikely(__mark_##name.state)) { \ > (*__mark_##name.call) \ > (&__mark_##name, call_private, \ > format, ## args); \ > } \ > } while (0) > > In this call: > > (*__mark_##name.call) \ > (&__mark_##name, call_private, \ > format, ## args); \ > > you make gcc allocate duplicate format string. You can use > &__mstrtab_##name[sizeof(#name)] instead since it holds the same string, > or drop ", format," above and "const char *fmt" from here: > > void (*call)(const struct marker *mdata, /* Probe wrapper */ > void *call_private, const char *fmt, ...); > > since mdata->format is the same and all callees which need it can take it there. Very good point. I actually thought about dropping it, since it would remove an unnecessary argument from the stack. And actually, since I now have the marker_probe_cb sitting between the marker site and the callbacks, there is no API change required. Thanks :) Mathieu Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> CC: Denys Vlasenko <vda.linux@googlemail.com> Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>		2008-05-23 22:25:27 +02:00
..
irq	genirq: reenable a nobody cared disabled irq when a new driver arrives	2008-05-02 13:40:34 +02:00
power	Merge branches 'release', 'acpica', 'bugzilla-10224', 'bugzilla-9772', 'bugzilla-9916', 'ec', 'eeepc', 'idle', 'misc', 'pm-legacy', 'sysfs-links-2.6.26', 'thermal', 'thinkpad' and 'video' into release	2008-04-30 13:58:00 -04:00
time	clocksource: allow read access to available/current_clocksource	2008-05-03 18:11:48 +02:00
trace	ftrace: limit trace entries	2008-05-23 22:05:14 +02:00
.gitignore	Update kernel/.gitignore with new auto-generated files	2008-02-09 23:27:01 -08:00
acct.c	bsd_acct: using task_struct->tgid is not right in pid-namespaces	2008-03-24 19:22:20 -07:00
audit.c	[patch 1/1] audit_send_reply(): fix error-path memory leak	2008-05-17 03:30:22 -04:00
audit.h	[PATCH 1/2] audit: move extern declarations to audit.h	2008-04-28 06:28:04 -04:00
audit_tree.c	[PATCH] list_for_each_rcu must die: audit	2008-05-17 03:30:23 -04:00
auditfilter.c	Merge branch 'audit.b50' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/audit-current	2008-04-29 11:41:22 -07:00
auditsc.c	[PATCH] new predicate - AUDIT_FILETYPE	2008-04-28 06:28:37 -04:00
backtracetest.c
bounds.c	Add kbuild.h that contains common definitions for kbuild users	2008-04-29 08:06:29 -07:00
capability.c
cgroup.c	mm: bdi: add separate writeback accounting capability	2008-04-30 08:29:50 -07:00
cgroup_debug.c	CGroup API files: move "releasable" to cgroup_debug subsystem	2008-04-29 08:06:09 -07:00
compat.c	ntp: support for TAI	2008-05-01 08:03:59 -07:00
configs.c	kernel: use non-racy method for proc entries creation	2008-04-29 08:06:22 -07:00
cpu.c	kernel: replace remaining __FUNCTION__ occurrences	2008-04-30 08:29:54 -07:00
cpuset.c	Fix cpuset sched_relax_domain_level control file	2008-05-08 10:46:56 -07:00
delayacct.c
dma.c	kernel: use non-racy method for proc entries creation	2008-04-29 08:06:22 -07:00
exec_domain.c
exit.c	[PATCH] split linux/file.h	2008-05-01 13:08:16 -04:00
extable.c
fork.c	ftrace: trace irq disabled critical timings	2008-05-23 20:32:46 +02:00
futex.c	Removal of FUTEX_FD	2008-05-05 08:18:45 -07:00
futex_compat.c	futex_compat __user annotation	2008-03-30 14:18:41 -07:00
hrtimer.c	hrtimer: remove duplicate helper function	2008-05-03 18:11:48 +02:00
itimer.c
kallsyms.c	kernel: use non-racy method for proc entries creation	2008-04-29 08:06:22 -07:00
Kconfig.hz
Kconfig.preempt	rcu: move PREEMPT_RCU config option back under PREEMPT	2008-03-10 18:01:20 -07:00
kexec.c	kexec: make extended crashkernel= syntax less confusing	2008-05-01 08:04:00 -07:00
kfifo.c
kgdb.c	lib: create common ascii hex array	2008-05-14 19:11:14 -07:00
kmod.c	[PATCH] split linux/file.h	2008-05-01 13:08:16 -04:00
kprobes.c	kprobes: add (un)register_jprobes for batch registration	2008-04-28 08:58:32 -07:00
ksysfs.c
kthread.c	Deprecate find_task_by_pid()	2008-04-30 08:29:48 -07:00
latencytop.c	kernel: use non-racy method for proc entries creation	2008-04-29 08:06:22 -07:00
lockdep.c	lockdep: update lockdep_recursion on graph_lock	2008-05-23 21:50:21 +02:00
lockdep_internals.h
lockdep_proc.c	kernel: use non-racy method for proc entries creation	2008-04-29 08:06:22 -07:00
Makefile	ftrace: use Makefile to remove tracing from lockdep	2008-05-23 21:15:14 +02:00
marker.c	Markers - remove extra format argument	2008-05-23 22:25:27 +02:00
module.c	module: don't ignore vermagic string if module doesn't have modversions	2008-05-09 07:45:18 -07:00
mutex-debug.c
mutex-debug.h
mutex.c
mutex.h
notifier.c	ipc: re-enable msgmni automatic recomputing msgmni if set to negative	2008-04-29 08:06:13 -07:00
ns_cgroup.c	cgroups: kernel/ns_cgroup.c should #include <linux/nsproxy.h>	2008-04-29 08:06:07 -07:00
nsproxy.c	ipc: sysvsem: refuse clone(CLONE_SYSVSEM|CLONE_NEWIPC)	2008-04-29 08:06:14 -07:00
panic.c	Taint kernel after WARN_ON(condition)	2008-04-29 08:05:59 -07:00
params.c	Add new string functions strict_strto* and convert kernel params to use them	2008-02-08 09:22:41 -08:00
pid.c	pids: introduce change_pid() helper	2008-04-30 08:29:48 -07:00
pid_namespace.c	pidns: make pid->level and pid_ns->level unsigned	2008-04-30 08:29:49 -07:00
pm_qos_params.c
posix-cpu-timers.c	remove div_long_long_rem	2008-05-01 08:03:58 -07:00
posix-timers.c	signals: join send_sigqueue() with send_group_sigqueue()	2008-04-30 08:29:36 -07:00
printk.c	ftrace: trace irq disabled critical timings	2008-05-23 20:32:46 +02:00
profile.c	kernel: use non-racy method for proc entries creation	2008-04-29 08:06:22 -07:00
ptrace.c	make generic sys_ptrace unconditional	2008-05-01 10:21:54 -07:00
rcuclassic.c
rcupdate.c	rcupdate: fix comment	2008-02-13 16:21:18 -08:00
rcupreempt.c	generic: reduce stack pressure in sched_affinity	2008-04-19 19:44:59 +02:00
rcupreempt_trace.c
rcutorture.c	kernel: explicitly include required header files under kernel/	2008-04-29 08:06:04 -07:00
relay.c	Revert "relay: fix splice problem"	2008-05-08 14:06:19 +02:00
res_counter.c	memcgroup: add the max_usage member on the res_counter	2008-04-29 08:06:10 -07:00
resource.c	kernel: use non-racy method for proc entries creation	2008-04-29 08:06:22 -07:00
rtmutex-debug.c
rtmutex-debug.h
rtmutex-tester.c
rtmutex.c	hrtimer: more hrtimer_init_sleeper() fallout.	2008-02-13 15:45:36 +01:00
rtmutex.h
rtmutex_common.h
rwsem.c
sched.c	ftrace: remove add-hoc code	2008-05-23 21:13:32 +02:00
sched_clock.c	sched: add optional support for CONFIG_HAVE_UNSTABLE_SCHED_CLOCK	2008-05-05 23:56:18 +02:00
sched_debug.c	sched: add optional support for CONFIG_HAVE_UNSTABLE_SCHED_CLOCK	2008-05-05 23:56:18 +02:00
sched_fair.c	ftrace: remove add-hoc code	2008-05-23 21:13:32 +02:00
sched_features.h	sched: /debug/sched_features	2008-04-19 19:45:00 +02:00
sched_idletask.c	sched: make rt_sched_class, idle_sched_class static	2008-05-05 23:56:17 +02:00
sched_rt.c	sched: fix RT task-wakeup logic	2008-05-05 23:56:18 +02:00
sched_stats.h	cpumask: use new cpus_scnprintf function	2008-04-19 19:44:59 +02:00
seccomp.c
semaphore.c	Revert "semaphore: fix"	2008-05-10 20:43:22 -07:00
signal.c	signals: add set_restore_sigmask	2008-04-30 08:29:37 -07:00
softirq.c	Fix cpu hotplug problem in softirq code	2008-05-01 08:03:58 -07:00
softlockup.c	softlockup: fix task state setting	2008-02-29 18:46:53 +01:00
spinlock.c	ftrace: lockdep notrace annotations	2008-05-23 20:39:40 +02:00
srcu.c
stacktrace.c
stop_machine.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/juhl/trivial	2008-04-21 16:36:46 -07:00
sys.c	pids: sys_getpgid: fix unsafe *pid usage, s/tasklist/rcu/	2008-04-30 08:29:49 -07:00
sys_ni.c
sysctl.c	ftrace: add ftrace_enabled sysctl to disable mcount function	2008-05-23 20:33:19 +02:00
sysctl_check.c
taskstats.c	Use find_task_by_vpid in taskstats	2008-04-30 08:29:48 -07:00
test_kprobes.c
time.c	Make constants in kernel/timeconst.h fixed 64 bits	2008-05-02 16:18:42 -07:00
timeconst.pl	Make constants in kernel/timeconst.h fixed 64 bits	2008-05-02 16:18:42 -07:00
timer.c	debugobjects: add timer specific object debugging code	2008-04-30 08:29:53 -07:00
tsacct.c
uid16.c	asmlinkage_protect replaces prevent_tail_call	2008-04-10 17:28:26 -07:00
user.c	alloc_uid: cleanup	2008-04-30 08:29:53 -07:00
user_namespace.c	eCryptfs: make key module subsystem respect namespaces	2008-04-29 08:06:07 -07:00
utsname.c	kernel: explicitly include required header files under kernel/	2008-04-29 08:06:04 -07:00
utsname_sysctl.c
wait.c
workqueue.c	workqueue: remove redundant function invocation	2008-05-01 08:04:02 -07:00