Linus Torvalds
f3359f5fc9
sched_getaffinity: don't assume 'cpumask_size()' is fully initialized ...
[ Upstream commit 6015b1aca1a233379625385feb01dd014aca60b5 ]
The getaffinity() system call uses 'cpumask_size()' to decide how big
the CPU mask is - so far so good. It is indeed the allocation size of a
cpumask.
But the code also assumes that the whole allocation is initialized
without actually doing so itself. That's wrong, because we might have
fixed-size allocations (making copying and clearing more efficient), but
not all of it is then necessarily used if 'nr_cpu_ids' is smaller.
Having checked other users of 'cpumask_size()', they all seem to be ok,
either using it purely for the allocation size, or explicitly zeroing
the cpumask before using the size in bytes to copy it.
See for example the ublk_ctrl_get_queue_affinity() function that uses
the proper 'zalloc_cpumask_var()' to make sure that the whole mask is
cleared, whether the storage is on the stack or if it was an external
allocation.
Fix this by just zeroing the allocation before using it. Do the same
for the compat version of sched_getaffinity(), which had the same logic.
Also, for consistency, make sched_getaffinity() use 'cpumask_bits()' to
access the bits. For a cpumask_var_t, it ends up being a pointer to the
same data either way, but it's just a good idea to treat it like you
would a 'cpumask_t'. The compat case already did that.
Reported-by: Ryan Roberts <ryan.roberts@arm.com>
Link: https://lore.kernel.org/lkml/7d026744-6bd6-6827-0471-b5e8eae0be3f@arm.com/
Cc: Yury Norov <yury.norov@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-04-05 11:16:42 +02:00
bpf: Adjust insufficient default bpf_jit_limit
2023-04-05 11:16:37 +02:00
memcg: fix possible use-after-free in memcg_write_event_control()
2022-12-14 11:30:43 +01:00
treewide: Replace DECLARE_TASKLET() with DECLARE_TASKLET_OLD()
2023-03-11 16:43:42 +01:00
dma-debug: make things less spammy under memory pressure
2022-06-22 14:11:19 +02:00
perf: Fix possible memleak in pmu_dev_alloc()
2023-01-18 11:40:53 +01:00
gcov: add support for checksum field
2023-01-18 11:41:42 +01:00
irqdomain: Fix domain registration race
2023-03-17 08:32:49 +01:00
livepatch: fix race between fork and KLP transition
2022-10-26 13:22:18 +02:00
locking/lockdep: Avoid RCU-induced noinstr fail
2021-11-17 09:48:28 +01:00
PM: hibernate: Fix mistake in kerneldoc comment
2023-01-18 11:40:53 +01:00
printk: fix return value of printk.devkmsg __setup handler
2022-04-15 14:18:08 +02:00
rcu: Suppress smp_processor_id() complaint in synchronize_rcu_expedited_wait()
2023-03-11 16:43:54 +01:00
sched_getaffinity: don't assume 'cpumask_size()' is fully initialized
2023-04-05 11:16:42 +02:00
timers: Prevent union confusion from unexpected restart_syscall()
2023-03-11 16:43:54 +01:00
ftrace: Fix invalid address access in lookup_rec() when index is 0
2023-03-22 13:28:09 +01:00
acct: fix potential integer overflow in encode_comp_t()
2023-01-18 11:41:34 +01:00
Revert "module, async: async_synchronize_full() on module init iff async is used"
2022-02-23 11:59:56 +01:00
audit: improve audit queue handling when "audit=1" on cmdline
2022-02-08 18:24:26 +01:00
audit: log AUDIT_TIME_* records only from rules
2022-04-15 14:18:04 +02:00
audit: fix potential double free on error path from fsnotify_add_inode_mark
2022-09-05 10:27:38 +02:00
audit: move put_tree() to avoid trim_trees refcount underflow and UAF
2021-09-03 10:08:16 +02:00
audit: log AUDIT_TIME_* records only from rules
2022-04-15 14:18:04 +02:00
treewide: Replace DECLARE_TASKLET() with DECLARE_TASKLET_OLD()
2023-03-11 16:43:42 +01:00
sched_getaffinity: don't assume 'cpumask_size()' is fully initialized
2023-04-05 11:16:42 +02:00
random: clear fast pool, crng, and batches in cpuhp bring up
2022-06-22 14:11:12 +02:00
exit: Use READ_ONCE() for all oops/warn limit reads
2023-02-06 07:52:50 +01:00
kernel/fail_function: fix memory leak with using debugfs_lookup()
2023-03-11 16:44:15 +01:00
copy_process(): Move fd_install() out of sighand->siglock critical section
2022-02-23 12:00:00 +01:00
kexec_file: drop weak attribute from arch_kexec_apply_relocations[_add]
2022-07-02 16:28:50 +02:00
x86/kprobes: Fix arch_check_optimized_kprobe check within optimized_kprobe range
2023-03-11 16:44:02 +01:00
kthread: Fix PF_KTHREAD vs to_kthread() race
2021-09-12 08:56:39 +02:00
module: Don't wait for GOING modules
2023-02-06 07:52:43 +01:00
exit: Use READ_ONCE() for all oops/warn limit reads
2023-02-06 07:52:50 +01:00
memcg: enable accounting for pids in nested pid namespaces
2021-09-22 12:26:37 +02:00
profiling: fix shift too large makes kernel panic
2022-08-25 11:18:02 +02:00
ptrace: Reimplement PTRACE_KILL by always sending SIGKILL
2022-06-14 18:11:24 +02:00
relay: fix type mismatch when allocating memory in relay_create_buf()
2023-01-18 11:40:58 +01:00
seccomp: Invalidate seccomp mode to catch death failures
2022-02-16 12:52:53 +01:00
signal handling: don't use BUG_ON() for debugging
2022-07-21 20:59:27 +02:00
smp: Fix offline cpu check in flush_smp_call_function_queue()
2022-04-20 09:19:39 +02:00
prlimit: do_prlimit needs to have a speculation check
2023-01-24 07:17:59 +01:00
kernel/sys_ni: add compat entry for fadvise64_64
2022-09-05 10:27:38 +02:00
proc: proc_skip_spaces() shouldn't think it is working on C strings
2022-12-08 11:23:06 +01:00
taskstats: Cleanup the use of task->exit_code
2022-02-23 11:59:57 +01:00
watchdog: export lockup_detector_reconfigure
2022-08-25 11:18:37 +02:00
workqueue: don't skip lockdep work dependency in cancel_work_sync()
2022-09-28 11:04:09 +02:00
f3359f5fc9