Brian Foster
45a841719f
xfs: drain the buf delwri queue before xfsaild idles ...
commit f376b45e861d8b7b34bf0eceeecfdd00dbe65cde upstream.
xfsaild is racy with respect to transaction abort and shutdown in
that the task can idle or exit with an empty AIL but buffers still
on the delwri queue. This was partly addressed by cancelling the
delwri queue before the task exits to prevent memory leaks, but it's
also possible for xfsaild to empty and idle with buffers on the
delwri queue. For example, a transaction that pins a buffer that
also happens to sit on the AIL delwri queue will explicitly remove
the associated log item from the AIL if the transaction aborts. The
side effect of this is an unmount hang in xfs_wait_buftarg() as the
associated buffers remain held by the delwri queue indefinitely.
This is reproduced on repeated runs of generic/531 with an fs format
(-mrmapbt=1 -bsize=1k) that happens to also reproduce transaction
aborts.
Update xfsaild to not idle until both the AIL and associated delwri
queue are empty and update the push code to continue delwri queue
submission attempts even when the AIL is empty. This allows the AIL
to eventually release aborted buffers stranded on the delwri queue
when they are unlocked by the associated transaction. This should
have no significant effect on normal runtime behavior because the
xfsaild currently idles only when the AIL is empty and in practice
the AIL is rarely empty with a populated delwri queue. The items
must be AIL resident to land in the queue in the first place and
generally aren't removed until writeback completes.
Note that the pre-existing delwri queue cancel logic in the exit
path is retained because task stop is external, could technically
come at any point, and xfsaild is still responsible to release its
buffer references before it exits.
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Acked-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Chandan Babu R <chandan.babu@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-11-25 17:42:03 +01:00
9p: missing chunk of "fs/9p: Don't update file type when updating file attributes"
2022-06-22 14:11:02 +02:00
fs/affs: release old buffer head on error path
2021-03-04 10:26:48 +01:00
afs: Return -EAGAIN, not -EREMOTEIO, when a file already locked
2022-09-28 11:03:59 +02:00
bfs: don't use WARNING: string when it's just info.
2021-01-06 14:48:39 +01:00
btrfs: fix type of parameter generation in btrfs_get_dentry
2022-11-10 17:57:55 +01:00
cachefiles: Handle readpage error correctly
2020-11-05 11:43:36 +01:00
ceph: don't truncate file in atomic_open
2022-10-15 07:54:39 +02:00
cifs: Fix the error length of VALIDATE_NEGOTIATE_INFO message
2022-10-26 13:22:12 +02:00
configfs: fix a race in configfs_{,un}register_subsystem()
2022-03-02 11:41:10 +01:00
fscrypt: add fscrypt_symlink_getattr() for computing st_size
2021-09-12 08:56:38 +02:00
debugfs: add debugfs_lookup_and_remove()
2022-09-15 12:04:54 +02:00
fsnotify: fix fsnotify hooks in pseudo filesystems
2022-02-01 17:24:34 +01:00
fs: dlm: handle -EBUSY first in lock arg validation
2022-10-26 13:22:14 +02:00
Revert "ecryptfs: replace BUG_ON with error handling code"
2021-05-26 12:05:19 +02:00
efivarfs: revert "fix memory leak in efivarfs_create()"
2020-12-02 08:49:53 +01:00
erofs: avoid consecutive detection for Highmem memory
2022-08-25 11:17:36 +02:00
ext2: Add more validity checks for inode counts
2022-08-25 11:17:28 +02:00
ext4: fix BUG_ON() when directory entry has invalid rec_len
2022-11-10 17:57:56 +01:00
f2fs: fix race condition on setting FI_NO_EXTENT flag
2022-10-26 13:22:46 +02:00
fat: add ratelimit to fat*_ent_bread()
2022-06-14 18:11:30 +02:00
fscache: Fix cookie key hashing
2021-09-22 12:26:25 +02:00
fuse: add file_modified() to fallocate
2022-11-10 17:57:55 +01:00
gfs2: Fix filesystem block deallocation for short writes
2022-05-18 09:47:26 +02:00
hfs: add lock nesting notation to hfs_find_init
2021-07-31 08:19:38 +02:00
hfsplus: prevent corruption in shrinking truncate
2021-05-19 10:08:29 +02:00
hostfs: fix memory handling in follow_link()
2021-04-14 08:24:14 +02:00
mm, hugetlb: allow for "high" userspace addresses
2022-05-09 09:03:28 +02:00
iomap: iomap_write_failed fix
2022-06-14 18:11:36 +02:00
isofs: Fix out of bound access for corrupted isofs image
2021-11-12 14:43:03 +01:00
jbd2: wake up journal waiters in FIFO order, not LIFO
2022-10-26 13:22:17 +02:00
jffs2: fix memory leak in jffs2_do_fill_super
2022-06-14 18:11:55 +02:00
fs: jfs: fix possible NULL pointer dereference in dbFree()
2022-06-14 18:11:29 +02:00
kernfs: fix use-after-free in __kernfs_remove
2022-11-03 23:56:54 +09:00
lockd: lockd server-side shouldn't set fl_ops
2021-09-22 12:26:34 +02:00
minix: fix bug when opening a file with O_DIRECT
2022-04-15 14:18:35 +02:00
nfs4: Fix kmemleak when allocate slot failed
2022-11-10 17:57:49 +01:00
nfs_common: need lock during iterate through the list
2020-12-30 11:51:22 +01:00
NFSD: Return nfserr_serverfault if splice_ok but buf->pages have data
2022-10-26 13:22:47 +02:00
nilfs2: fix use-after-free bug of struct nilfs_root
2022-10-26 13:22:17 +02:00
fsnotify: fix wrong lockdep annotations
2022-06-14 18:11:34 +02:00
ntfs: fix BUG_ON in ntfs_lookup_inode_by_name()
2022-10-05 10:37:42 +02:00
ocfs2: fix BUG when iput after ocfs2_mknod fails
2022-10-29 10:20:34 +02:00
orangefs: Fix the size of a memory allocation in orangefs_bufmap_alloc()
2022-01-20 09:19:17 +01:00
ovl: drop WARN_ON() dentry is NULL in ovl_encode_fh()
2022-08-25 11:17:23 +02:00
mm: /proc/pid/smaps_rollup: fix no vma's null-deref
2022-10-29 10:20:36 +02:00
pstore: Fix typo in compression option name
2021-03-04 10:26:45 +01:00
qnx4: work around gcc false positive warning bug
2021-09-30 10:09:26 +02:00
quota: Check next/prev free block number after reading from quota file
2022-10-26 13:22:14 +02:00
ramfs: fix nommu mmap with gaps in the page cache
2020-10-29 09:57:53 +01:00
reiserfs: check directory items on read from disk
2021-08-12 13:21:05 +02:00
romfs: fix uninitialized memory leak in romfs_dev_read()
2020-08-26 10:40:51 +02:00
squashfs: fix divide error in calculate_skip()
2021-05-19 10:08:29 +02:00
sysfs: Add sysfs_emit and sysfs_emit_at to format sysfs output
2021-03-07 12:20:48 +01:00
tracefs: Only clobber mode/uid/gid on remount if asked
2022-09-20 12:28:00 +02:00
ubifs: Rectify space amount budget for mkdir/tmpfile operations
2022-04-15 14:18:31 +02:00
udf: Fix NULL ptr deref when converting from inline format
2022-02-01 17:24:34 +01:00
fs/ufs: avoid potential u32 multiplication overflow
2020-08-21 13:05:37 +02:00
fs-verity: fix signed integer overflow with i_size near S64_MAX
2021-10-06 15:42:30 +02:00
xfs: drain the buf delwri queue before xfsaild idles
2022-11-25 17:42:03 +01:00
aio: fix use-after-free due to missing POLLFREE handling
2021-12-14 14:49:02 +01:00
vfs: Check the truncate maximum size in inode_newsize_ok()
2022-08-25 11:17:21 +02:00
elf: don't use MAP_FIXED_NOREPLACE for elf interpreter mappings
2021-10-06 15:42:35 +02:00
binfmt_flat: do not stop relocating GOT entries prematurely on riscv
2022-06-14 18:11:23 +02:00
binfmt_misc: fix possible deadlock in bm_register_write
2021-03-17 17:03:57 +01:00
block: reexpand iov_iter after read/write
2021-05-22 11:38:29 +02:00
fs: Don't invalidate page buffers in block_write_full_page()
2020-11-05 11:43:24 +01:00
compat_ioctl: remove /dev/random commands
2022-06-22 14:11:03 +02:00
coredump: fix core_pattern parse error
2020-12-11 13:23:30 +01:00
fs: fix NULL dereference due to data race in prepend_path()
2020-10-29 09:57:45 +01:00
dax: fix cache flush on PMD-mapped pages
2022-06-14 18:11:41 +02:00
fix dget_parent() fastpath race
2020-10-01 13:17:19 +02:00
fs: direct-io: fix missing sdio->boundary
2021-04-14 08:24:11 +02:00
epoll: autoremove wakers even more aggressively
2022-08-25 11:17:28 +02:00
exec: Force single empty string when argv is empty
2022-06-06 08:33:50 +02:00
fcntl: fix potential deadlock for &fasync_struct.fa_lock
2021-09-15 09:47:28 +02:00
fget: clarify and improve __fget_files() implementation
2022-03-02 11:41:18 +01:00
SUNRPC: Ensure we flush any closed sockets before xs_xprt_free()
2022-05-25 09:14:34 +02:00
fs/filesystems.c: downgrade user-reachable WARN_ONCE() to pr_warn_once()
2020-04-17 10:50:21 +02:00
fs-writeback: writeback_sb_inodes：Recalculate 'wrote' according skipped pages
2022-06-14 18:11:44 +02:00
memcg: charge fs_context and legacy_fs_context
2022-02-08 18:24:29 +01:00
fs: fix UAF/GPF bug in nilfs_mdt_destroy
2022-10-15 07:54:36 +02:00
cgroup1: fix leaked context root causing sporadic NULL deref in LTP
2021-07-31 08:19:37 +02:00
io_uring/af_unix: defer registered files gc to io_uring release
2022-10-26 13:22:59 +02:00
libfs: fix error cast of negative value in simple_attr_write()
2020-11-24 13:29:19 +01:00
fs: Add missing umask strip in vfs_tmpfile
2022-08-25 11:17:22 +02:00
fs: warn about impending deprecation of mandatory locks
2021-08-26 08:36:22 -04:00
pipe: increase minimum default pipe size to 2 pages
2021-08-12 13:21:02 +02:00
propagate_one(): mnt_set_mountpoint() needs mount_lock
2020-05-02 08:48:44 +02:00
mount: fix mounting of detached mounts onto targets that reside on shared mounts
2021-03-17 17:03:33 +01:00
readdir: make sure to verify directory entry for legacy interfaces too
2021-04-21 12:56:16 +02:00
select: Fix indefinitely sleeping task in poll_schedule_timeout()
2022-01-29 10:25:11 +01:00
seq_file: disallow extremely large seq buffer allocations
2021-07-20 16:10:54 +02:00
io_uring: disable polling pollfree files
2022-09-05 10:27:47 +02:00
Revert "fs: check FMODE_LSEEK to control internal pipe splicing"
2022-10-17 17:24:32 +02:00
stat: fix inconsistency between struct stat and struct compat_stat
2022-04-27 13:50:48 +02:00
vfs: make freeze_super abort when sync_filesystem returns error
2022-02-23 11:59:55 +01:00
userfaultfd: open userfaultfds with O_RDONLY
2022-10-26 13:22:21 +02:00
xattr: break delegations in {set,remove}xattr
2020-08-11 15:33:39 +02:00
45a841719f