Yan Zhai
4482b250c8
ipv6: avoid atomic fragment on GSO packets ...
[ Upstream commit 03d6c848bfb406e9ef6d9846d759e97beaeea113 ]
When the ipv6 stack output a GSO packet, if its gso_size is larger than
dst MTU, then all segments would be fragmented. However, it is possible
for a GSO packet to have a trailing segment with smaller actual size
than both gso_size as well as the MTU, which leads to an "atomic
fragment". Atomic fragments are considered harmful in RFC-8021. An
Existing report from APNIC also shows that atomic fragments are more
likely to be dropped even it is equivalent to a no-op [1].
Add an extra check in the GSO slow output path. For each segment from
the original over-sized packet, if it fits with the path MTU, then avoid
generating an atomic fragment.
Link: https://www.potaroo.net/presentations/2022-03-01-ipv6-frag.pdf [1]
Fixes: b210de4f8c97 ("net: ipv6: Validate GSO SKB before finish IPv6 processing")
Reported-by: David Wragg <dwragg@cloudflare.com>
Signed-off-by: Yan Zhai <yan@cloudflare.com>
Link: https://lore.kernel.org/r/90912e3503a242dca0bc36958b11ed03a2696e5e.1698156966.git.yan@cloudflare.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-11-20 10:30:10 +01:00
9p: virtio: make sure 'offs' is initialized in zc_request
2023-09-23 10:59:37 +02:00
vlan: fix a potential uninit-value in vlan_dev_hard_start_xmit()
2023-05-30 12:44:06 +01:00
atm: hide unused procfs functions
2023-06-09 10:28:59 +02:00
batman-adv: Hold rtnl lock during MTU update via netlink
2023-08-30 16:27:25 +02:00
Bluetooth: hci_sock: Correctly bounds check and pad HCI_MON_NEW_INDEX name
2023-10-25 11:53:25 +02:00
net: bridge: use DEV_STATS_INC()
2023-10-10 21:46:37 +02:00
can: bcm: Fix UAF in bcm_proc_show()
2023-07-27 08:37:40 +02:00
libceph: use kernel_connect()
2023-10-25 11:53:19 +02:00
neighbour: fix various data-races
2023-11-08 11:23:35 +01:00
net: dcb: choose correct policy to parse DCB_ATTR_BCN
2023-08-11 11:53:57 +02:00
dccp: fix dccp_v4_err()/dccp_v6_err() again
2023-10-10 21:46:37 +02:00
Remove DECnet support from kernel
2023-06-21 15:44:10 +02:00
net: dsa: tag_sja1105: fix MAC DA patching from meta frames
2023-07-27 08:37:24 +02:00
tcp: fix cookie_init_timestamp() overflows
2023-11-20 10:30:10 +01:00
ipv6: avoid atomic fragment on GSO packets
2023-11-20 10:30:10 +01:00
kcm: Fix error handling for SOCK_DGRAM in kcm_sendmsg().
2023-09-23 11:00:02 +02:00
net: af_key: fix sadb_x_filter validation
2023-08-30 16:27:16 +02:00
ipv4, ipv6: Fix handling of transhdrlen in __ip{,6}_append_data()
2023-10-10 21:46:44 +02:00
llc: Don't drop packet from non-root netns.
2023-07-27 08:37:44 +02:00
wifi: mac80211: allow transmitting EAPOL frames with tainted key
2023-10-25 11:53:23 +02:00
ncsi: Propagate carrier gain/loss events to the NCSI controller
2023-10-10 21:46:40 +02:00
netfilter: nfnetlink_log: silence bogus compiler warning
2023-11-08 11:23:41 +01:00
netlabel: fix shift wrapping bug in netlbl_catmap_setlong()
2023-09-23 10:59:39 +02:00
netlink: Add __sock_i_ino() for __netlink_diag_dump().
2023-07-27 08:37:12 +02:00
netrom: Deny concurrent connect().
2023-09-23 10:59:43 +02:00
nfc: nci: fix possible NULL pointer dereference in send_acknowledge()
2023-10-25 11:53:20 +02:00
net: nsh: Use correct mac_offset to unwind gso skb in nsh_gso_segment()
2023-05-30 12:44:05 +01:00
net/packet: annotate data-races around tp->status
2023-08-16 18:19:23 +02:00
net: prevent address rewrite in kernel_bind()
2023-10-25 11:53:18 +02:00
net: rfkill: gpio: prevent value glitch during probe
2023-10-25 11:53:21 +02:00
net/sched: sch_hfsc: upgrade 'rt' to 'sc' when it becomes a inner curve
2023-10-25 11:53:21 +02:00
sctp: update hb timer immediately after users change hb_interval
2023-10-10 21:46:45 +02:00
SUNRPC: Mark the cred for revalidation if the server rejects it
2023-10-10 21:46:35 +02:00
net: tipc: resize nlattr array to correct size
2023-06-21 15:44:12 +02:00
net/tls: do not free tls_rec on async operation in bpf_exec_tx_verdict()
2023-09-23 11:00:02 +02:00
af_unix: Fix data-race around unix_tot_inflight.
2023-09-23 10:59:58 +02:00
vsock: avoid to close connected socket after the timeout
2023-05-30 12:44:05 +01:00
wifi: cfg80211: avoid leaking stack data into trace
2023-10-25 11:53:23 +02:00
xsk: Honor SO_BINDTODEVICE on bind
2023-07-27 08:37:23 +02:00
xfrm: interface: use DEV_STATS_INC()
2023-10-25 11:53:21 +02:00
Remove DECnet support from kernel
2023-06-21 15:44:10 +02:00
Remove DECnet support from kernel
2023-06-21 15:44:10 +02:00
net: prevent address rewrite in kernel_bind()
2023-10-25 11:53:18 +02:00
4482b250c8