Repository files (latest commit first)

Filename	Latest commit message	Latest commit date
Yang Yingliang 3e0efc3f3f class: fix possible memory leak in __class_register() ... [ Upstream commit 8c3e8a6bdb5253b97ad532570f8b5db5f7a06407 ] If class_add_groups() returns error, the 'cp->subsys' need be unregister, and the 'cp' need be freed. We can not call kset_unregister() here, because the 'cls' will be freed in callback function class_release() and it's also freed in caller's error path, it will cause double free. So fix this by calling kobject_del() and kfree_const(name) to cleanup kobject. Besides, call kfree() to free the 'cp'. Fault injection test can trigger this: unreferenced object 0xffff888102fa8190 (size 8): comm "modprobe", pid 502, jiffies 4294906074 (age 49.296s) hex dump (first 8 bytes): 70 6b 74 63 64 76 64 00 pktcdvd. backtrace: [<00000000e7c7703d>] __kmalloc_track_caller+0x1ae/0x320 [<000000005e4d70bc>] kstrdup+0x3a/0x70 [<00000000c2e5e85a>] kstrdup_const+0x68/0x80 [<000000000049a8c7>] kvasprintf_const+0x10b/0x190 [<0000000029123163>] kobject_set_name_vargs+0x56/0x150 [<00000000747219c9>] kobject_set_name+0xab/0xe0 [<0000000005f1ea4e>] __class_register+0x15c/0x49a unreferenced object 0xffff888037274000 (size 1024): comm "modprobe", pid 502, jiffies 4294906074 (age 49.296s) hex dump (first 32 bytes): 00 40 27 37 80 88 ff ff 00 40 27 37 80 88 ff ff .@'7.....@'7.... 00 00 00 00 ad 4e ad de ff ff ff ff 00 00 00 00 .....N.......... backtrace: [<00000000151f9600>] kmem_cache_alloc_trace+0x17c/0x2f0 [<00000000ecf3dd95>] __class_register+0x86/0x49a Fixes: ced6473e74 ("driver core: class: add class_groups support") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Link: https://lore.kernel.org/r/20221026082803.3458760-1-yangyingliang@huawei.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-01-18 11:41:21 +01:00
..
firmware_loader	firmware_loader: use kernel credentials when reading firmware	2022-05-25 09:14:38 +02:00
power	PM: runtime: Do not call __rpm_callback() from rpm_idle()	2023-01-18 11:40:57 +01:00
regmap	regmap-irq: Fix a bug in regmap_irq_enable() for type_in_mask chips	2022-06-29 08:58:47 +02:00
test
arch_topology.c	arm64: topology: move store_cpu_topology() to shared code	2022-10-29 10:20:36 +02:00
attribute_container.c
base.h
bus.c	driver: base: fix UAF when driver_attach failed	2022-06-14 18:11:54 +02:00
cacheinfo.c	drivers core: Use sysfs_emit and sysfs_emit_at for show(device *...) functions	2022-01-16 09:15:38 +01:00
class.c	class: fix possible memory leak in __class_register()	2023-01-18 11:41:21 +01:00
component.c
container.c
core.c	drivers core: Use sysfs_emit and sysfs_emit_at for show(device *...) functions	2022-01-16 09:15:38 +01:00
cpu.c	x86/bugs: Report AMD retbleed vulnerability	2022-10-07 09:16:54 +02:00
dd.c	driver core: Don't probe devices after bus_type.match() probe deferral	2022-09-15 12:04:52 +02:00
devcon.c
devcoredump.c
devres.c
devtmpfs.c	devtmpfs regression fix: reconfigure on each mount	2022-01-20 09:19:17 +01:00
driver.c
firmware.c
hypervisor.c
init.c
isa.c
Kconfig
Makefile
map.c
memory.c	drivers core: Use sysfs_emit and sysfs_emit_at for show(device *...) functions	2022-01-16 09:15:38 +01:00
module.c
node.c	drivers/base/node.c: fix compaction sysfs file leak	2022-06-14 18:11:41 +02:00
pinctrl.c
platform-msi.c
platform.c	drivers core: Use sysfs_emit and sysfs_emit_at for show(device *...) functions	2022-01-16 09:15:38 +01:00
property.c
soc.c	drivers core: Use sysfs_emit and sysfs_emit_at for show(device *...) functions	2022-01-16 09:15:38 +01:00
swnode.c
syscore.c
topology.c
transport_class.c