Eric Dumazet
0d2bd44bfe
genetlink: hold RCU in genlmsg_mcast()
[ Upstream commit 56440d7ec28d60f8da3bfa09062b3368ff9b16db ]
While running net selftests with CONFIG_PROVE_RCU_LIST=y I saw
one lockdep splat [1].
genlmsg_mcast() uses for_each_net_rcu(), and must therefore hold RCU.
Instead of letting all callers guard genlmsg_multicast_allns()
with a rcu_read_lock()/rcu_read_unlock() pair, do it in genlmsg_mcast().
This also means the @flags parameter is useless, we need to always use
GFP_ATOMIC.
[1]
[10882.424136] =============================
[10882.424166] WARNING: suspicious RCU usage
[10882.424309] 6.12.0-rc2-virtme #1156 Not tainted
[10882.424400] -----------------------------
[10882.424423] net/netlink/genetlink.c:1940 RCU-list traversed in non-reader section!!
[10882.424469]
other info that might help us debug this:
[10882.424500]
rcu_scheduler_active = 2, debug_locks = 1
[10882.424744] 2 locks held by ip/15677:
[10882.424791] #0: ffffffffb6b491b0 (cb_lock){++++}-{3:3}, at: genl_rcv (net/netlink/genetlink.c:1219)
[10882.426334] #1: ffffffffb6b49248 (genl_mutex){+.+.}-{3:3}, at: genl_rcv_msg (net/netlink/genetlink.c:61 net/netlink/genetlink.c:57 net/netlink/genetlink.c:1209)
[10882.426465]
stack backtrace:
[10882.426805] CPU: 14 UID: 0 PID: 15677 Comm: ip Not tainted 6.12.0-rc2-virtme #1156
[10882.426919] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-debian-1.16.3-2 04/01/2014
[10882.427046] Call Trace:
[10882.427131] <TASK>
[10882.427244] dump_stack_lvl (lib/dump_stack.c:123)
[10882.427335] lockdep_rcu_suspicious (kernel/locking/lockdep.c:6822)
[10882.427387] genlmsg_multicast_allns (net/netlink/genetlink.c:1940 (discriminator 7) net/netlink/genetlink.c:1977 (discriminator 7))
[10882.427436] l2tp_tunnel_notify.constprop.0 (net/l2tp/l2tp_netlink.c:119) l2tp_netlink
[10882.427683] l2tp_nl_cmd_tunnel_create (net/l2tp/l2tp_netlink.c:253) l2tp_netlink
[10882.427748] genl_family_rcv_msg_doit (net/netlink/genetlink.c:1115)
[10882.427834] genl_rcv_msg (net/netlink/genetlink.c:1195 net/netlink/genetlink.c:1210)
[10882.427877] ? __pfx_l2tp_nl_cmd_tunnel_create (net/l2tp/l2tp_netlink.c:186) l2tp_netlink
[10882.427927] ? __pfx_genl_rcv_msg (net/netlink/genetlink.c:1201)
[10882.427959] netlink_rcv_skb (net/netlink/af_netlink.c:2551)
[10882.428069] genl_rcv (net/netlink/genetlink.c:1220)
[10882.428095] netlink_unicast (net/netlink/af_netlink.c:1332 net/netlink/af_netlink.c:1357)
[10882.428140] netlink_sendmsg (net/netlink/af_netlink.c:1901)
[10882.428210] ____sys_sendmsg (net/socket.c:729 (discriminator 1) net/socket.c:744 (discriminator 1) net/socket.c:2607 (discriminator 1))
Fixes: 33f72e6f0c ("l2tp : multicast notification to the registered listeners")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: James Chapman <jchapman@katalix.com>
Cc: Tom Parkin <tparkin@katalix.com>
Cc: Johannes Berg <johannes.berg@intel.com>
Link: https://patch.msgid.link/20241011171217.3166614-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
|
2024-11-08 16:20:50 +01:00 |
| .. |
|
9p
|
|
|
|
bluetooth
|
Bluetooth: L2CAP: Fix rejecting L2CAP_CONN_PARAM_UPDATE_REQ
|
2024-07-05 09:08:17 +02:00 |
|
caif
|
net: caif: add proper error handling
|
2021-06-10 13:37:09 +02:00 |
|
iucv
|
|
|
|
netfilter
|
netfilter: nf_tables: use timestamp to check for set element timeout
|
2024-08-19 05:33:53 +02:00 |
|
netns
|
ipv6: make ip6_rt_gc_expire an atomic_t
|
2024-01-15 18:25:29 +01:00 |
|
nfc
|
nfc: constify several pointers to u8, char and sk_buff
|
2023-07-27 08:37:07 +02:00 |
|
phonet
|
|
|
|
sctp
|
sctp: move hlist_node and hashent out of sctp_ep_common
|
2024-08-19 05:33:46 +02:00 |
|
tc_act
|
net/sched: act_pedit: really ensure the skb is writable
|
2022-05-18 09:47:25 +02:00 |
|
6lowpan.h
|
|
|
|
act_api.h
|
net: sched: fix police ext initialization
|
2021-03-04 10:26:53 +01:00 |
|
addrconf.h
|
ipv6: fix race condition between ipv6_get_ifaddr and ipv6_del_addr
|
2024-05-02 16:18:28 +02:00 |
|
af_ieee802154.h
|
|
|
|
af_rxrpc.h
|
rxrpc: Make rxrpc_kernel_get_srtt() indicate validity
|
2020-09-09 19:12:23 +02:00 |
|
af_unix.h
|
af_unix: Suppress false-positive lockdep splat for spin_lock() in __unix_gc().
|
2024-05-02 16:18:35 +02:00 |
|
af_vsock.h
|
|
|
|
ah.h
|
|
|
|
arp.h
|
ipv4: Invalidate neighbour for broadcast address upon address addition
|
2022-04-15 14:18:33 +02:00 |
|
atmclip.h
|
|
|
|
ax25.h
|
ax25: fix reference count leaks of ax25_dev
|
2022-04-20 09:19:39 +02:00 |
|
ax88796.h
|
|
|
|
bond_3ad.h
|
bonding: fix data-races around agg_select_timer
|
2022-02-23 11:59:58 +01:00 |
|
bond_alb.h
|
bonding (gcc13): synchronize bond_{a,t}lb_xmit() types
|
2023-06-14 10:59:58 +02:00 |
|
bond_options.h
|
|
|
|
bonding.h
|
bonding: fix macvlan over alb bond support
|
2023-08-30 16:27:24 +02:00 |
|
bpf_sk_storage.h
|
|
|
|
busy_poll.h
|
net: busy-poll: use ktime_get_ns() instead of local_clock()
|
2024-09-04 13:15:03 +02:00 |
|
calipso.h
|
|
|
|
cfg80211-wext.h
|
|
|
|
cfg80211.h
|
wifi: cfg80211: fix sband iftype data lookup for AP_VLAN
|
2023-08-16 18:19:24 +02:00 |
|
cfg802154.h
|
|
|
|
checksum.h
|
net: Force inlining of checksum functions in net/checksum.h
|
2022-03-02 11:41:08 +01:00 |
|
cipso_ipv4.h
|
|
|
|
cls_cgroup.h
|
|
|
|
codel.h
|
|
|
|
codel_impl.h
|
|
|
|
codel_qdisc.h
|
|
|
|
compat.h
|
|
|
|
datalink.h
|
|
|
|
dcbevent.h
|
|
|
|
dcbnl.h
|
|
|
|
devlink.h
|
devlink: disallow reload operation during device cleanup
|
2019-11-09 19:38:36 -08:00 |
|
drop_monitor.h
|
net: drop_monitor: use IS_REACHABLE() to guard net_dm_hw_report()
|
2020-05-27 17:46:24 +02:00 |
|
dsa.h
|
|
|
|
dsfield.h
|
|
|
|
dst.h
|
net: Remove unused inline function dst_hold_and_use()
|
2023-06-21 15:44:12 +02:00 |
|
dst_cache.h
|
|
|
|
dst_metadata.h
|
net: fix a memleak when uncloning an skb dst and its metadata
|
2022-02-16 12:52:51 +01:00 |
|
dst_ops.h
|
net: fix __dst_negative_advice() race
|
2024-06-16 13:28:52 +02:00 |
|
erspan.h
|
erspan: Add type I version 0 support.
|
2024-04-13 12:51:36 +02:00 |
|
esp.h
|
esp: limit skb_page_frag_refill use to a single page
|
2022-07-12 16:30:45 +02:00 |
|
ethoc.h
|
|
|
|
failover.h
|
|
|
|
fib_notifier.h
|
|
|
|
fib_rules.h
|
ipv6: fix memory leak in fib6_rule_suppress
|
2021-12-08 09:01:13 +01:00 |
|
firewire.h
|
|
|
|
flow.h
|
inet: shrink struct flowi_common
|
2023-11-20 10:30:15 +01:00 |
|
flow_dissector.h
|
net/sched: flower: fix parsing of ethertype following VLAN header
|
2022-04-20 09:19:34 +02:00 |
|
flow_offload.h
|
net: core: rename indirect block ingress cb function
|
2019-12-18 16:08:47 +01:00 |
|
fou.h
|
|
|
|
fq.h
|
net/flow_dissector: switch to siphash
|
2019-10-23 20:13:22 -07:00 |
|
fq_impl.h
|
net/fq_impl: Switch to kvmalloc() for memory allocation
|
2019-11-08 09:11:49 +01:00 |
|
garp.h
|
|
|
|
gen_stats.h
|
|
|
|
genetlink.h
|
genetlink: hold RCU in genlmsg_mcast()
|
2024-11-08 16:20:50 +01:00 |
|
geneve.h
|
|
|
|
gre.h
|
|
|
|
gro_cells.h
|
|
|
|
gtp.h
|
|
|
|
gue.h
|
|
|
|
hwbm.h
|
net: hwbm: if CONFIG_NET_HWBM unset, make stub functions static
|
2019-10-25 16:24:32 -07:00 |
|
icmp.h
|
net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending
|
2021-03-04 10:26:53 +01:00 |
|
ieee80211_radiotap.h
|
|
|
|
ieee802154_netdev.h
|
net: ieee802154: return -EINVAL for unknown addr type
|
2022-10-26 13:22:59 +02:00 |
|
if_inet6.h
|
net: ipv6: support reporting otherwise unknown prefix flags in RTM_NEWPREFIX
|
2023-12-20 15:41:13 +01:00 |
|
ife.h
|
|
|
|
ila.h
|
|
|
|
inet6_connection_sock.h
|
|
|
|
inet6_hashtables.h
|
|
|
|
inet_common.h
|
|
|
|
inet_connection_sock.h
|
tcp: properly terminate timers for kernel sockets
|
2024-04-13 12:51:33 +02:00 |
|
inet_ecn.h
|
inet_ecn: Fix endianness of checksum update when setting ECT(1)
|
2020-12-08 10:40:25 +01:00 |
|
inet_frag.h
|
inet: frags: annotate races around fqdir->dead and fqdir->high_thresh
|
2022-01-27 09:19:54 +01:00 |
|
inet_hashtables.h
|
secure_seq: use the 64 bits of the siphash for port offset calculation
|
2022-06-06 08:33:49 +02:00 |
|
inet_sock.h
|
tcp/dccp: Fix a data-race around sysctl_tcp_fwmark_accept.
|
2022-07-29 17:14:11 +02:00 |
|
inet_timewait_sock.h
|
tcp: honor SO_PRIORITY in TIME_WAIT state
|
2019-09-27 12:05:02 +02:00 |
|
inetpeer.h
|
|
|
|
ip.h
|
ipv{4,6}/raw: fix output xfrm lookup wrt protocol
|
2023-06-05 08:17:33 +02:00 |
|
ip6_checksum.h
|
|
|
|
ip6_fib.h
|
ipv6: annotate accesses to fn->fn_sernum
|
2022-02-01 17:24:38 +01:00 |
|
ip6_route.h
|
net: ipv6: fix returned variable type in ip6_skb_dst_mtu
|
2021-08-12 13:20:57 +02:00 |
|
ip6_tunnel.h
|
ip_gre, ip6_gre: Fix race condition on o_seqno in collect_md mode
|
2023-05-30 12:44:05 +01:00 |
|
ip_fib.h
|
ipv4: convert fib_num_tclassid_users to atomic_t
|
2021-12-08 09:01:12 +01:00 |
|
ip_tunnels.h
|
geneve: fix header validation in geneve[6]_xmit_skb
|
2024-05-02 16:18:28 +02:00 |
|
ip_vs.h
|
ipvs: allow connection reuse for unconfirmed conntrack
|
2020-08-19 08:16:10 +02:00 |
|
ipcomp.h
|
|
|
|
ipconfig.h
|
|
|
|
ipv6.h
|
tcp: Reduce chance of collisions in inet6_hashfn().
|
2023-08-11 11:53:47 +02:00 |
|
ipv6_frag.h
|
inet: frags: annotate races around fqdir->dead and fqdir->high_thresh
|
2022-01-27 09:19:54 +01:00 |
|
ipv6_stubs.h
|
net: ipv6: add fib6_nh_release_dsts stub
|
2021-12-01 09:23:33 +01:00 |
|
ipx.h
|
bonding/alb: properly access headers in bond_alb_xmit()
|
2020-02-11 04:35:48 -08:00 |
|
iw_handler.h
|
|
|
|
kcm.h
|
kcm: Serialise kcm_sendmsg() for the same socket.
|
2024-09-04 13:14:59 +02:00 |
|
l3mdev.h
|
|
|
|
lag.h
|
|
|
|
lapb.h
|
|
|
|
lib80211.h
|
|
|
|
llc.h
|
llc: fix out-of-bound array index in llc_sk_dev_hash()
|
2021-11-17 09:48:47 +01:00 |
|
llc_c_ac.h
|
|
|
|
llc_c_ev.h
|
|
|
|
llc_c_st.h
|
|
|
|
llc_conn.h
|
llc: fix sk_buff leak in llc_conn_service()
|
2019-10-08 13:23:05 -07:00 |
|
llc_if.h
|
|
|
|
llc_pdu.h
|
llc: Drop support for ETH_P_TR_802_2.
|
2024-02-23 08:24:50 +01:00 |
|
llc_s_ac.h
|
|
|
|
llc_s_ev.h
|
|
|
|
llc_s_st.h
|
|
|
|
llc_sap.h
|
|
|
|
lwtunnel.h
|
lwt: Check LWTUNNEL_XMIT_CONTINUE strictly
|
2023-09-23 10:59:42 +02:00 |
|
mac80211.h
|
mac80211: Fix NULL ptr deref for injected rate info
|
2024-11-08 16:20:49 +01:00 |
|
mac802154.h
|
|
|
|
mip6.h
|
|
|
|
mld.h
|
|
|
|
mpls.h
|
|
|
|
mpls_iptunnel.h
|
|
|
|
mrp.h
|
mrp: introduce active flags to prevent UAF when applicant uninit
|
2023-01-18 11:41:37 +01:00 |
|
ncsi.h
|
|
|
|
ndisc.h
|
net: avoid potential false sharing in neighbor related code
|
2019-12-31 16:45:03 +01:00 |
|
neighbour.h
|
neighbour: delete neigh_lookup_nodev as not used
|
2023-06-21 15:44:12 +02:00 |
|
net_failover.h
|
|
|
|
net_namespace.h
|
net: make get_net_ns return error if NET_NS is disabled
|
2021-06-23 14:41:25 +02:00 |
|
net_ratelimit.h
|
|
|
|
netevent.h
|
|
|
|
netlabel.h
|
|
|
|
netlink.h
|
|
|
|
netprio_cgroup.h
|
|
|
|
netrom.h
|
|
|
|
nexthop.h
|
net: ipv4: Fix rtnexthop len when RTA_FLOW is present
|
2021-10-06 15:42:33 +02:00 |
|
nl802154.h
|
net: ieee802154: handle iftypes as u32
|
2021-12-01 09:23:32 +01:00 |
|
nsh.h
|
|
|
|
p8022.h
|
|
|
|
page_pool.h
|
mm: fix struct page layout on 32-bit systems
|
2021-05-19 10:08:31 +02:00 |
|
ping.h
|
|
|
|
pkt_cls.h
|
net_sched: fix ops->bind_class() implementations
|
2020-02-01 09:34:38 +00:00 |
|
pkt_sched.h
|
net/sched: make psched_mtu() RTNL-less safe
|
2023-07-27 08:37:33 +02:00 |
|
pptp.h
|
|
|
|
protocol.h
|
tcp/udp: Make early_demux back namespacified.
|
2022-11-10 17:57:55 +01:00 |
|
psample.h
|
psample: Add a fwd declaration for skbuff
|
2021-08-18 08:56:59 +02:00 |
|
psnap.h
|
|
|
|
raw.h
|
raw: Fix a data-race around sysctl_raw_l3mdev_accept.
|
2022-07-21 20:59:22 +02:00 |
|
rawv6.h
|
|
|
|
red.h
|
sch_red: fix off-by-one checks in red_check_params()
|
2021-04-14 08:24:14 +02:00 |
|
regulatory.h
|
|
|
|
request_sock.h
|
net: add {READ|WRITE}_ONCE() annotations on ->rskq_accept_head
|
2019-10-09 21:34:31 -07:00 |
|
rose.h
|
|
|
|
route.h
|
ipv4: remove sparse error in ip_neigh_gw4()
|
2022-02-01 17:24:39 +01:00 |
|
rsi_91x.h
|
|
|
|
rtnetlink.h
|
net: validate veth and vxcan peer ifindexes
|
2023-08-30 16:27:24 +02:00 |
|
rtnh.h
|
|
|
|
sch_generic.h
|
net/sched: accept TCA_STAB only for root qdisc
|
2024-11-08 16:20:45 +01:00 |
|
scm.h
|
scm: fix MSG_CTRUNC setting condition for SO_PASSSEC
|
2023-05-17 11:35:41 +02:00 |
|
secure_seq.h
|
secure_seq: use the 64 bits of the siphash for port offset calculation
|
2022-06-06 08:33:49 +02:00 |
|
seg6.h
|
|
|
|
seg6_hmac.h
|
|
|
|
seg6_local.h
|
|
|
|
slhc_vj.h
|
|
|
|
smc.h
|
|
|
|
snmp.h
|
|
|
|
sock.h
|
net: Fix an unsafe loop on the list
|
2024-11-08 16:20:47 +01:00 |
|
sock_reuseport.h
|
|
|
|
Space.h
|
|
|
|
stp.h
|
|
|
|
strparser.h
|
bpf: sockmap, strparser, and tls are reusing qdisc_skb_cb and colliding
|
2021-11-17 09:48:48 +01:00 |
|
switchdev.h
|
|
|
|
tcp.h
|
tcp: check skb is non-NULL in tcp_rto_delta_us()
|
2024-11-08 16:20:33 +01:00 |
|
tcp_states.h
|
|
|
|
timewait_sock.h
|
|
|
|
tipc.h
|
|
|
|
tls.h
|
net/tls: Fix flipped sign in tls_err_abort() calls
|
2021-11-02 19:46:12 +01:00 |
|
transp_v6.h
|
|
|
|
tso.h
|
|
|
|
tun_proto.h
|
|
|
|
udp.h
|
tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().
|
2023-04-26 11:24:05 +02:00 |
|
udp_tunnel.h
|
udp: call udp_encap_enable for v6 sockets when enabling encap
|
2022-04-15 14:18:01 +02:00 |
|
udplite.h
|
tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().
|
2023-04-26 11:24:05 +02:00 |
|
vsock_addr.h
|
|
|
|
vxlan.h
|
vxlan: calculate correct header length for GPE
|
2023-08-11 11:53:47 +02:00 |
|
wext.h
|
|
|
|
wimax.h
|
|
|
|
x25.h
|
|
|
|
x25device.h
|
|
|
|
xdp.h
|
|
|
|
xdp_priv.h
|
page_pool: do not release pool until inflight == 0.
|
2019-12-18 16:09:07 +01:00 |
|
xdp_sock.h
|
|
|
|
xfrm.h
|
xfrm: Preserve vlan tags for transport mode software GRO
|
2024-05-17 11:43:53 +02:00 |