John Garry
f545fda258
libata: Ensure ata_port probe has completed before detach ...
[ Upstream commit 130f4caf145c3562108b245a576db30b916199d2 ]
With CONFIG_DEBUG_TEST_DRIVER_REMOVE set, we may find the following WARN:
[ 23.452574] ------------[ cut here ]------------
[ 23.457190] WARNING: CPU: 59 PID: 1 at drivers/ata/libata-core.c:6676 ata_host_detach+0x15c/0x168
[ 23.466047] Modules linked in:
[ 23.469092] CPU: 59 PID: 1 Comm: swapper/0 Not tainted 5.4.0-rc1-00010-g5b83fd27752b-dirty #296
[ 23.477776] Hardware name: Huawei D06 /D06, BIOS Hisilicon D06 UEFI RC0 - V1.16.01 03/15/2019
[ 23.486286] pstate: a0c00009 (NzCv daif +PAN +UAO)
[ 23.491065] pc : ata_host_detach+0x15c/0x168
[ 23.495322] lr : ata_host_detach+0x88/0x168
[ 23.499491] sp : ffff800011cabb50
[ 23.502792] x29: ffff800011cabb50 x28: 0000000000000007
[ 23.508091] x27: ffff80001137f068 x26: ffff8000112c0c28
[ 23.513390] x25: 0000000000003848 x24: ffff0023ea185300
[ 23.518689] x23: 0000000000000001 x22: 00000000000014c0
[ 23.523987] x21: 0000000000013740 x20: ffff0023bdc20000
[ 23.529286] x19: 0000000000000000 x18: 0000000000000004
[ 23.534584] x17: 0000000000000001 x16: 00000000000000f0
[ 23.539883] x15: ffff0023eac13790 x14: ffff0023eb76c408
[ 23.545181] x13: 0000000000000000 x12: ffff0023eac13790
[ 23.550480] x11: ffff0023eb76c228 x10: 0000000000000000
[ 23.555779] x9 : ffff0023eac13798 x8 : 0000000040000000
[ 23.561077] x7 : 0000000000000002 x6 : 0000000000000001
[ 23.566376] x5 : 0000000000000002 x4 : 0000000000000000
[ 23.571674] x3 : ffff0023bf08a0bc x2 : 0000000000000000
[ 23.576972] x1 : 3099674201f72700 x0 : 0000000000400284
[ 23.582272] Call trace:
[ 23.584706] ata_host_detach+0x15c/0x168
[ 23.588616] ata_pci_remove_one+0x10/0x18
[ 23.592615] ahci_remove_one+0x20/0x40
[ 23.596356] pci_device_remove+0x3c/0xe0
[ 23.600267] really_probe+0xdc/0x3e0
[ 23.603830] driver_probe_device+0x58/0x100
[ 23.608000] device_driver_attach+0x6c/0x90
[ 23.612169] __driver_attach+0x84/0xc8
[ 23.615908] bus_for_each_dev+0x74/0xc8
[ 23.619730] driver_attach+0x20/0x28
[ 23.623292] bus_add_driver+0x148/0x1f0
[ 23.627115] driver_register+0x60/0x110
[ 23.630938] __pci_register_driver+0x40/0x48
[ 23.635199] ahci_pci_driver_init+0x20/0x28
[ 23.639372] do_one_initcall+0x5c/0x1b0
[ 23.643199] kernel_init_freeable+0x1a4/0x24c
[ 23.647546] kernel_init+0x10/0x108
[ 23.651023] ret_from_fork+0x10/0x18
[ 23.654590] ---[ end trace 634a14b675b71c13 ]---
With KASAN also enabled, we may also get many use-after-free reports.
The issue is that when CONFIG_DEBUG_TEST_DRIVER_REMOVE is set, we may
attempt to detach the ata_port before it has been probed.
This is because the ata_ports are async probed, meaning that there is no
guarantee that the ata_port has probed prior to detach. When the ata_port
does probe in this scenario, we get all sorts of issues as the detach may
have already happened.
Fix by ensuring synchronisation with async_synchronize_full(). We could
alternatively use the cookie returned from the ata_port probe
async_schedule() call, but that means managing the cookie, so more
complicated.
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2019-12-31 16:44:31 +01:00
acard_ahci: use dma_set_mask_and_coherent
2019-08-26 13:58:58 -06:00
libata/ahci: Fix PCS quirk application
2019-10-15 14:10:19 -06:00
libata/ahci: Drop PCS quirk for Denverton and beyond
2019-08-30 20:53:42 -06:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 118
2019-05-24 17:39:02 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 201
2019-05-30 11:29:52 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 45
2019-05-24 17:27:12 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 45
2019-05-24 17:27:12 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 201
2019-05-30 11:29:52 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174
2019-05-30 11:26:41 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 45
2019-05-24 17:27:12 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 45
2019-05-24 17:27:12 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 235
2019-06-19 17:09:07 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
drivers: ata: ahci_sunxi: Increased SATA/AHCI DMA TX/RX FIFOs
2019-07-05 10:17:18 -06:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282
2019-06-05 17:36:37 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13
2019-05-21 11:28:45 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
ahci: Do not export local variable ahci_em_messages
2019-08-30 14:25:57 -06:00
ata: libahci_platform: Fix regulator_get_optional() misuse
2019-10-25 14:22:20 -06:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
libata: Ensure ata_port probe has completed before detach
2019-12-31 16:44:31 +01:00
libata: don't request sense data on !ZAC ATA devices
2019-06-25 09:22:45 -06:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 428
2019-06-05 17:37:16 +02:00
Revert "libata, freezer: avoid block device removal while system is frozen"
2019-10-06 09:11:37 -06:00
for-5.4/libata-2019-09-15
2019-09-17 16:54:40 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 209
2019-05-30 11:29:53 -07:00
libata: zpodd: Fix small read overflow in zpodd_get_mech_type()
2019-07-29 16:00:14 -06:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
ata/pata_buddha: Probe via modalias instead of initcall
2019-08-23 06:58:50 -06:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
ata: pata_platform: Add IRQF_SHARED to IRQ flags
2019-02-08 06:42:55 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
ata: rb532_cf: Fix unused variable warning in rb532_pata_driver_probe
2019-08-06 07:44:59 -06:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 300
2019-06-05 17:37:00 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333
2019-06-05 17:37:06 +02:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
pdc_adma: use dma_set_mask_and_coherent
2019-08-26 13:58:58 -06:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 201
2019-05-30 11:29:52 -07:00
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
sata_mv: use dma_set_mask_and_coherent
2019-08-26 13:58:58 -06:00
sata_nv: use dma_set_mask_and_coherent
2019-08-26 13:58:58 -06:00
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
sata_qstor: use dma_set_mask_and_coherent
2019-08-26 13:58:58 -06:00
sata_rcar: Remove ata_host_alloc() error printing
2019-05-09 11:19:32 -06:00
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
sata_sil24: use dma_set_mask_and_coherent
2019-08-26 13:58:58 -06:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
libata: switch remaining drivers to use dma_set_mask_and_coherent
2019-08-26 13:58:59 -06:00
f545fda258