Vlastimil Babka
ebff398017
mm, compaction: pass classzone_idx and alloc_flags to watermark checking ...
Compaction relies on zone watermark checks for decisions such as if it's
worth to start compacting in compaction_suitable() or whether compaction
should stop in compact_finished(). The watermark checks take
classzone_idx and alloc_flags parameters, which are related to the memory
allocation request. But from the context of compaction they are currently
passed as 0, including the direct compaction which is invoked to satisfy
the allocation request, and could therefore know the proper values.
The lack of proper values can lead to mismatch between decisions taken
during compaction and decisions related to the allocation request. Lack
of proper classzone_idx value means that lowmem_reserve is not taken into
account. This has manifested (during recent changes to deferred
compaction) when DMA zone was used as fallback for preferred Normal zone.
compaction_suitable() without proper classzone_idx would think that the
watermarks are already satisfied, but watermark check in
get_page_from_freelist() would fail. Because of this problem, deferring
compaction has extra complexity that can be removed in the following
patch.
The issue (not confirmed in practice) with missing alloc_flags is opposite
in nature. For allocations that include ALLOC_HIGH, ALLOC_HIGHER or
ALLOC_CMA in alloc_flags (the last includes all MOVABLE allocations on
CMA-enabled systems) the watermark checking in compaction with 0 passed
will be stricter than in get_page_from_freelist(). In these cases
compaction might be running for a longer time than is really needed.
Another issue compaction_suitable() is that the check for "does the zone
need compaction at all?" comes only after the check "does the zone have
enough free free pages to succeed compaction". The latter considers extra
pages for migration and can therefore in some situations fail and return
COMPACT_SKIPPED, although the high-order allocation would succeed and we
should return COMPACT_PARTIAL.
This patch fixes these problems by adding alloc_flags and classzone_idx to
struct compact_control and related functions involved in direct compaction
and watermark checking. Where possible, all other callers of
compaction_suitable() pass proper values where those are known. This is
currently limited to classzone_idx, which is sometimes known in kswapd
context. However, the direct reclaim callers should_continue_reclaim()
and compaction_ready() do not currently know the proper values, so the
coordination between reclaim and compaction may still not be as accurate
as it could. This can be fixed later, if it's shown to be an issue.
Additionaly the checks in compact_suitable() are reordered to address the
second issue described above.
The effect of this patch should be slightly better high-order allocation
success rates and/or less compaction overhead, depending on the type of
allocations and presence of CMA. It allows simplifying deferred
compaction code in a followup patch.
When testing with stress-highalloc, there was some slight improvement
(which might be just due to variance) in success rates of non-THP-like
allocations.
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Michal Nazarewicz <mina86@mina86.com>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Christoph Lameter <cl@linux.com>
Acked-by: Rik van Riel <riel@redhat.com>
Cc: David Rientjes <rientjes@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-12-10 17:41:06 -08:00
bcma: register bcma as device tree driver
2014-09-30 13:17:14 -04:00
can: dev: add can_is_canfd_skb() API
2014-11-18 13:23:31 +01:00
libceph: sync osd op definitions in rados.h
2014-10-14 12:57:02 -07:00
ARM: OMAP3: clock: add support for dpll4_set_rate_and_parent
2014-11-13 09:26:33 -07:00
dmaengine: dw: export probe()/remove() and Co to users
2014-10-15 20:31:05 +05:30
fsl /bestcomm
This is the bulk of GPIO changes for the v3.18 development
2014-10-09 14:58:15 -04:00
hwmon: (pmbus) Add regulator support
2014-11-30 20:13:13 -08:00
iio: Fix IIO_EVENT_CODE_EXTRACT_DIR bit mask
2014-11-15 16:04:56 +00:00
Merge branch 'irq-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2014-10-09 06:42:04 -04:00
ARM: SoC platform changes for 3.19
2014-12-09 14:38:28 -08:00
net/mlx4_en: Code cleanups in tx path
2014-10-06 01:04:15 -04:00
Main set of InfiniBand/RDMA updates for 3.18 merge window:
2014-10-19 12:29:23 -07:00
mmc: core: Let mmc_send_tuning() to take struct mmc_host* as parameter
2014-12-08 09:11:04 +01:00
mtd: m25p80,spi-nor: Fix module aliases for m25p80
2014-10-21 13:46:03 -07:00
ARM: SoC non-critical bug fixes for 3.19
2014-12-09 14:14:47 -08:00
power: charger-manager: Fix accessing invalidated power supply after charger unbind
2014-10-28 03:30:21 +01:00
Merge remote-tracking branches 'regulator/topic/sky81452' and 'regulator/topic/stub' into regulator-next
2014-12-05 11:14:43 +00:00
soc /ti
Merge branch 'for-linus' of git://git.infradead.org/users/vkoul/slave-dma
2014-10-18 18:11:04 -07:00
Merge branch 'for-3.18' of git://linux-nfs.org/~bfields/linux
2014-10-08 12:51:44 -04:00
usbnet: add a callback for set_rx_mode
2014-10-28 17:26:19 -04:00
Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux
2014-10-24 11:21:43 -07:00
mmc: host: atmel-mci: Add support for non-removable slots
2014-11-10 12:40:48 +01:00
audit: Remove "weak" from audit_classify_compat_syscall() declaration
2014-10-22 16:14:03 -06:00
mm/balloon_compaction: add vmstat counters and kpageflags bit
2014-10-09 22:26:01 -04:00
block: add bioset_create_nobvec()
2014-10-03 15:28:18 -06:00
bitops: Fix shift overflow in GENMASK macros
2014-11-16 09:55:39 +01:00
blk-mq: add blk_mq_unique_tag()
2014-11-12 11:16:09 +01:00
block: Remove REQ_KERNEL
2014-10-14 09:00:44 -06:00
scsi: add new scsi-command flag for tagged commands
2014-11-12 11:19:40 +01:00
mem-hotplug: reset node managed pages when hot-adding a new pgdat
2014-11-13 16:17:06 -08:00
net: phy: add BCM7425 and BCM7429 PHYs
2014-10-01 22:12:48 -04:00
mm: memcontrol: take a css reference for each charged page
2014-12-10 17:41:05 -08:00
Allwinner Clocks Additions for 3.18
2014-09-27 12:52:33 -07:00
clk-divider: Fix READ_ONLY when divider > 1
2014-11-17 11:13:52 -08:00
The clk tree changes for 3.18 are dominated by clock drivers. Mostly
2014-10-15 07:05:03 +02:00
clocksource: Remove "weak" from clocksource_default_clock() declaration
2014-10-22 16:14:03 -06:00
mm, cma: make parameters order consistent in func declaration and definition
2014-10-27 13:00:55 +01:00
ARCNET: add support for multi interfaces on com20020
2014-09-29 14:36:26 -04:00
mm, compaction: pass classzone_idx and alloc_flags to watermark checking
2014-12-10 17:41:06 -08:00
compiler/gcc4+: Remove inaccurate comment about 'asm goto' miscompiles
2014-10-28 11:03:40 +01:00
compiler/gcc4+: Remove inaccurate comment about 'asm goto' miscompiles
2014-10-28 11:03:40 +01:00
cpufreq: cpufreq-dt: extend with platform_data
2014-10-21 00:51:01 +02:00
cpufreq: allow driver-specific data
2014-10-21 00:51:01 +02:00
Merge branch 'for-3.18' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup
2014-10-10 07:24:40 -04:00
vmcore: Remove "weak" from function declarations
2014-10-22 16:14:04 -06:00
block: Add T10 Protection Information functions
2014-09-27 09:14:59 -06:00
don't need that forward declaration of struct nameidata in dcache.h anymore
2014-10-12 17:09:06 -04:00
dm: add presuspend_undo hook to target_type
2014-11-19 11:24:59 -05:00
IOMMU Updates for Linux v3.18
2014-10-15 07:23:49 +02:00
Merge branch 'for-linus' of git://git.infradead.org/users/vkoul/slave-dma
2014-10-18 18:11:04 -07:00
iommu/vt-d: Store bus information in RMRR PCI device path
2014-10-02 12:12:25 +02:00
dynamic_debug: change __dynamic_<foo>_dbg return types to void
2014-10-03 14:55:48 -07:00
dql: dql_queued() should write first to reduce bus transactions
2014-09-29 00:04:55 -04:00
EDAC: Add DDR3 LRDIMM entries to edac_mem_types
2014-10-20 14:22:22 +02:00
eeprom-93cx6: Add (read-only) support for 8-bit mode
2014-11-25 15:42:53 +01:00
efi: dmi: add support for SMBIOS 3.0 UEFI configuration table
2014-11-05 09:03:16 +01:00
fonts: Add 6x10 font
2014-10-09 11:35:48 +03:00
sched/wait: Remove wait_event_freezekillable()
2014-11-04 07:17:46 +01:00
Return short read or 0 at end of a raw device, not EIO
2014-10-31 06:33:26 -04:00
net: fs_enet: Remove non NAPI RX
2014-10-08 16:01:41 -04:00
dmaengine: freescale: add and export fsl_dma_external_start()
2014-10-15 21:31:27 +05:30
lib/genalloc.c: add genpool range check function
2014-10-09 22:25:52 -04:00
genl_magic: Resolve logical-op warnings
2014-10-14 17:03:53 -04:00
mm: introduce single zone pcplists drain
2014-12-10 17:41:05 -08:00
Merge branches 'for-3.18/always-poll-quirk', 'for-3.18/logitech', 'for-3.18/picolcd', 'for-3.18/rmi', 'for-3.18/sony', 'for-3.18/uhid', 'for-3.18/upstream' and 'for-3.18/wacom' into for-linus
2014-10-06 23:34:40 +02:00
mm: convert a few VM_BUG_ON callers to VM_BUG_ON_VMA
2014-10-09 22:25:57 -04:00
mm: hugetlb_cgroup: convert to lockless page counters
2014-12-10 17:41:04 -08:00
macvlan: add source mode
2014-09-29 15:37:01 -04:00
inetdevice: fixed signed integer overflow
2014-11-14 17:08:58 -05:00
Merge branch 'sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2014-12-09 21:21:34 -08:00
iommu: Add iommu_map_sg() function
2014-11-04 14:53:36 +01:00
Merge branch 'irq-irqdomain-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2014-12-10 09:01:01 -08:00
ACPI and power management updates for 3.18-rc1
2014-10-09 16:07:43 -04:00
irqdomain: Introduce helper function irq_domain_add_hierarchy()
2014-11-23 13:01:46 +01:00
genirq: Split out flow handler typedefs into seperate header file
2014-11-23 13:01:46 +01:00
sched: Exclude cond_resched() from nested sleep test
2014-10-28 10:56:57 +01:00
sched/cputime: Fix cpu_timer_sample_group() double accounting
2014-11-16 10:04:18 +01:00
isdn/capi: correct capi20_manufacturer argument type mismatch
2014-10-14 15:05:34 -04:00
kexec: take the segment adding out of locate_mem_hole functions
2014-10-14 02:18:21 +02:00
kgdb: Remove "weak" from kgdb_arch_pc() declaration
2014-10-22 16:14:04 -06:00
mm, thp: fix collapsing of hugepages on madvise
2014-10-29 16:33:14 -07:00
kvm: fix kvm_is_mmio_pfn() and rename to kvm_is_reserved_pfn()
2014-11-26 14:40:45 +01:00
scsi: drop reason argument from ->change_queue_depth
2014-11-24 14:45:27 +01:00
list: include linux/kernel.h
2014-10-14 02:18:13 +02:00
Merge branch 'locking-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2014-10-13 15:51:40 +02:00
mailbox: Introduce framework for mailbox
2014-10-08 10:39:41 +05:30
mailbox: Introduce framework for mailbox
2014-10-08 10:39:41 +05:30
bus: mvebu-mbus: provide a mechanism to save SDRAM window configuration
2014-11-30 16:40:11 +00:00
mei: remove include to pci header from mei module files
2014-09-29 11:56:02 -04:00
mm: memcontrol: lockless page counters
2014-12-10 17:41:04 -08:00
memory-hotplug: Remove "weak" from memory_block_size_bytes() declaration
2014-10-22 16:14:04 -06:00
memory-hotplug: add sysfs valid_zones attribute
2014-10-09 22:25:52 -04:00
mempolicy: unexport get_vma_policy() and remove its "task" arg
2014-10-09 22:25:56 -04:00
net/phy: micrel: Add clock support for KSZ8021/KSZ8031
2014-10-10 15:35:13 -04:00
mm/balloon_compaction: redesign ballooned pages management
2014-10-09 22:26:01 -04:00
x86, mpx: Introduce VM_MPX to indicate that a VMA is MPX specific
2014-11-18 00:58:53 +01:00
x86, mpx: On-demand kernel allocation of bounds tables
2014-11-18 00:58:53 +01:00
mm: introduce VM_BUG_ON_MM
2014-10-09 22:25:58 -04:00
mm/page_alloc: fix incorrect isolation behavior by rechecking migratetype
2014-11-13 16:17:05 -08:00
kernel/param: consolidate __{start,stop}___param[] in <linux/moduleparam.h>
2014-10-14 02:18:28 +02:00
vfs: introduce clone_private_mount()
2014-10-24 00:14:36 +02:00
PCI/MSI: Allow an msi_controller to be associated to an irq domain
2014-11-23 17:14:43 +01:00
net: Add ndo_gso_check
2014-10-15 12:11:00 -04:00
NFS: Implement SEEK
2014-09-30 16:24:56 -04:00
Merge branch 'for-3.18/core' of git://git.kernel.dk/linux-block
2014-10-18 11:53:51 -07:00
NFS: Implement SEEK
2014-09-30 16:24:56 -04:00
nfs: fix pnfs direct write memory leak
2014-11-12 14:22:51 -05:00
kernel/watchdog.c: control hard lockup detection default
2014-10-14 02:18:27 +02:00
Hi Linus,
2014-12-08 20:02:54 -08:00
of/pci: Fix the conversion of IO ranges into IO resources
2014-09-30 17:08:40 -06:00
PCI/MSI: Rename "struct msi_chip" to "struct msi_controller"
2014-11-12 07:49:38 -07:00
drivers: of: add return value to of_reserved_mem_device_init()
2014-10-29 16:33:14 -07:00
ARM: OMAP2+: Prepare to move GPMC to drivers by platform data header
2014-11-20 12:11:25 -08:00
OOM, PM: OOM killed task shouldn't escape PM suspend
2014-10-21 23:44:21 +02:00
mm/page_alloc: fix incorrect isolation behavior by rechecking migratetype
2014-11-13 16:17:05 -08:00
mm: memcontrol: remove obsolete kmemcg pinning tricks
2014-12-10 17:41:05 -08:00
mm/balloon_compaction: remove balloon mapping and flag AS_BALLOON_MAP
2014-10-09 22:26:01 -04:00
PCI: Don't oops on virtual buses in acpi_pci_get_bridge_handle()
2014-11-05 13:06:16 -07:00
Merge branch 'irq-irqdomain-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2014-12-10 09:01:01 -08:00
pci_ids: Add PCI device IDs for F15h M60h
2014-10-20 14:08:40 +02:00
mm: memcontrol: take a css reference for each charged page
2014-12-10 17:41:05 -08:00
perf: Improve the perf_sample_data struct layout
2014-11-16 11:42:04 +01:00
net: phy: adjust fixed_phy_register() return value
2014-10-07 13:06:45 -04:00
mailbox: rename pl320-ipc specific mailbox.h
2014-10-08 10:39:33 +05:30
Merge branch 'pm-domains'
2014-10-07 01:18:12 +02:00
PM / Domains: Fix initial default state of the need_restore flag
2014-11-11 22:28:44 +01:00
Boaz Harrosh - Fix broken email address
2014-10-19 20:22:32 +03:00
power_supply: Add no_thermal property to prevent recursive get_temp calls
2014-10-28 03:30:19 +01:00
rbtree: add comment to rb_insert_augmented()
2014-10-14 02:18:21 +02:00
Merge branch 'rcu/next' of git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu into core/rcu
2014-11-20 08:57:58 +01:00
rcu: Remove "cpu" argument to rcu_note_context_switch()
2014-11-03 19:20:34 -08:00
rcu: Remove "cpu" argument to rcu_needs_cpu()
2014-11-03 19:20:43 -08:00
regmap: ac97: Add generic AC'97 callbacks
2014-11-19 10:28:14 +00:00
reset: add reset_control_status helper function
2014-10-20 10:11:29 +02:00
reset: add reset_control_status helper function
2014-10-20 10:11:29 +02:00
tracing: Do not busy wait in buffer splice
2014-11-10 16:45:43 -05:00
mm: convert a few VM_BUG_ON callers to VM_BUG_ON_VMA
2014-10-09 22:25:57 -04:00
rtc/lib: Provide y2038 safe rtc_tm_to_time()/rtc_time_to_tm() replacement
2014-11-21 12:00:00 -08:00
Merge branch 'sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2014-12-09 21:21:34 -08:00
include/linux/screen_info.h: remove unused ORIG_* macros
2014-10-09 22:26:04 -04:00
Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security
2014-10-12 10:13:55 -04:00
tty: serial: 8250: use 32bit variable for rpm_tx_active
2014-09-29 18:20:38 -07:00
signal: use BUILD_BUG() instead of _NSIG_WORDS_is_unsupported_size()
2014-10-14 02:18:20 +02:00
net: skb_fclone_busy() needs to detect orphaned skb
2014-10-30 19:58:30 -04:00
mm/sl[ao]b: always track caller in kmalloc_(node_)track_caller()
2014-10-09 22:25:50 -04:00
mm/slab: use percpu allocator for cpu cache
2014-10-09 22:25:51 -04:00
include/linux/socket.h: Fix comment
2014-11-05 15:52:45 -05:00
This adds a memzero_explicit() call which is guaranteed not to be
2014-10-24 12:33:32 -07:00
lib / string_helpers: introduce string_escape_mem()
2014-10-14 02:18:26 +02:00
ACPI / sleep: Rework the handling of ACPI GPE wakeup from suspend-to-idle
2014-09-30 21:06:07 +02:00
mm: memcontrol: fix transparent huge page allocations under pressure
2014-10-09 22:25:59 -04:00
block: Add T10 Protection Information functions
2014-09-27 09:14:59 -06:00
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
2014-10-08 21:40:54 -04:00
Thermal: introduce INT3402 thermal driver
2014-10-10 14:02:25 +08:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux
2014-10-14 03:47:00 +02:00
time: Provide y2038 safe mktime() replacement
2014-11-21 11:59:58 -08:00
timekeeping: Provide fast accessor to the seconds part of CLOCK_MONOTONIC
2014-10-29 15:15:40 +01:00
Merge branch 'timers-2038-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2014-12-10 10:13:28 -08:00
topology: add support for node_to_mem_node() to determine the fallback node
2014-10-09 22:25:51 -04:00
Add copy_to_iter(), copy_from_iter() and iov_iter_zero()
2014-10-09 02:39:03 -04:00
uio: Export definition of struct uio_device
2014-10-02 21:35:54 -07:00
uprobes: Remove "weak" from function declarations
2014-10-22 16:14:04 -06:00
ARM: vexpress: Remove non-DT code
2014-11-28 16:08:16 +01:00
virtio: defer config changed notifications
2014-10-15 10:24:56 +10:30
virtio: add API to enable VQs early
2014-10-15 10:25:01 +10:30
mm/balloon_compaction: add vmstat counters and kpageflags bit
2014-10-09 22:26:01 -04:00
sched/wait: Reimplement wait_event_freezable()
2014-11-04 07:17:45 +01:00
watchdog: simplify definitions of WATCHDOG_NOWAYOUT(_INIT_STATUS)?
2014-10-20 20:46:25 +02:00
zsmalloc: change return value unit of zs_get_total_size_bytes
2014-10-09 22:26:02 -04:00
