Kees Cook
ee8711336c
bug: refactor away warn_slowpath_fmt_taint() ...
Patch series "Clean up WARN() "cut here" handling", v2.
Christophe Leroy noticed that the fix for missing "cut here" in the WARN()
case was adding explicit printk() calls instead of teaching the exception
handler to add it. This refactors the bug/warn infrastructure to pass
this information as a new BUGFLAG.
Longer details repeated from the last patch in the series:
bug: move WARN_ON() "cut here" into exception handler
The original cleanup of "cut here" missed the WARN_ON() case (that does
not have a printk message), which was fixed recently by adding an explicit
printk of "cut here". This had the downside of adding a printk() to every
WARN_ON() caller, which reduces the utility of using an instruction
exception to streamline the resulting code. By making this a new BUGFLAG,
all of these can be removed and "cut here" can be handled by the exception
handler.
This was very pronounced on PowerPC, but the effect can be seen on x86 as
well. The resulting text size of a defconfig build shows some small
savings from this patch:
text data bss dec hex filename
19691167 5134320 1646664 26472151 193eed7 vmlinux.before
19676362 5134260 1663048 26473670 193f4c6 vmlinux.after
This change also opens the door for creating something like BUG_MSG(),
where a custom printk() before issuing BUG(), without confusing the "cut
here" line.
This patch (of 7):
There's no reason to have specialized helpers for passing the warn taint
down to __warn(). Consolidate and refactor helper macros, removing
__WARN_printf() and warn_slowpath_fmt_taint().
Link: http://lkml.kernel.org/r/20190819234111.9019-2-keescook@chromium.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Cc: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Drew Davenport <ddavenport@chromium.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
Cc: Feng Tang <feng.tang@intel.com>
Cc: Petr Mladek <pmladek@suse.com>
Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Cc: Borislav Petkov <bp@suse.de>
Cc: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2019-09-25 17:51:40 -07:00
Merge branch 'work.mount3' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2019-09-24 12:33:34 -07:00
Merge branch 'for-5.4' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup
2019-09-17 15:57:22 -07:00
kgdb: don't use a notifier to enter kgdb at panic; call directly
2019-09-25 17:51:40 -07:00
powerpc updates for 5.4
2019-09-20 11:48:06 -07:00
uprobe: collapse THP pmd after removing all uprobes
2019-09-24 15:54:11 -07:00
um: Enable CONFIG_CONSTRUCTORS
2019-09-15 21:37:13 +02:00
Power management updates for 5.4-rc1
2019-09-17 19:15:14 -07:00
livepatch: Nullify obj->mod in klp_module_coming()'s error path
2019-08-19 13:03:37 +02:00
Merge branch 'sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-09-16 17:25:49 -07:00
Merge branches 'pm-opp', 'pm-qos', 'acpi-pm', 'pm-domains' and 'pm-tools'
2019-09-17 09:49:19 +02:00
Merge branch 'for-5.4' into for-linus
2019-09-16 12:54:25 +02:00
Merge branch 'sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-09-16 17:25:49 -07:00
mm: remove quicklist page table caches
2019-09-24 15:54:09 -07:00
Power management updates for 5.4-rc1
2019-09-17 19:15:14 -07:00
powerpc updates for 5.4
2019-09-20 11:48:06 -07:00
Provide in-kernel headers to make extending kernel easier
2019-04-29 16:48:03 +02:00
acct_on(): don't mess with freeze protection
2019-04-04 21:04:13 -04:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441
2019-06-05 17:37:17 +02:00
audit/stable-5.3 PR 20190702
2019-07-08 18:55:42 -07:00
audit/stable-5.3 PR 20190702
2019-07-08 18:55:42 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157
2019-05-30 11:26:37 -07:00
fsnotify: switch send_to_group() and ->handle_event to const struct qstr *
2019-04-26 13:51:03 -04:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
audit/stable-5.3 PR 20190702
2019-07-08 18:55:42 -07:00
audit: enforce op for string fields
2019-05-28 17:46:43 -04:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441
2019-06-05 17:37:17 +02:00
LSM: add SafeSetID module that gates setid calls
2019-01-25 11:22:43 -08:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
kernel/configs: Replace GPL boilerplate code with SPDX identifier
2019-07-30 18:34:15 +02:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
cpu/hotplug: Cache number of online CPUs
2019-07-25 15:48:01 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282
2019-06-05 17:36:37 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 230
2019-06-19 17:09:06 +02:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
Merge branch 'access-creds'
2019-07-25 08:36:29 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 25
2019-05-21 11:52:39 +02:00
kernel/elfcore.c: include proper prototypes
2019-09-25 17:51:39 -07:00
core-process-v5.4
2019-09-16 09:28:19 -07:00
extable: Add function to search only kernel exception table
2019-08-21 22:23:48 +10:00
fail_function: no need to check return value of debugfs_create functions
2019-06-03 15:49:06 +02:00
fork: improve error message for corrupted page tables
2019-09-25 17:51:40 -07:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
hrtimer/treewide: Use hrtimer_sleeper_start_expires()
2019-08-01 17:43:16 +02:00
kheaders: include only headers into kheaders_data.tar.xz
2019-07-09 10:10:52 +09:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
mm/nvdimm: add is_ioremap_addr and use that to check ioremap address
2019-07-12 11:05:40 -07:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
jump_label: Don't warn on __exit jump entries
2019-08-29 15:10:10 +01:00
kallsyms: Don't let kallsyms_lookup_size_offset() fail on retrieving the first symbol
2019-08-27 16:19:56 +01:00
treewide: Add SPDX license identifier - Makefile/Kconfig
2019-05-21 10:50:46 +02:00
treewide: Add SPDX license identifier - Makefile/Kconfig
2019-05-21 10:50:46 +02:00
treewide: Add SPDX license identifier - Makefile/Kconfig
2019-05-21 10:50:46 +02:00
sched/rt, Kconfig: Unbreak def/oldconfig with CONFIG_PREEMPT=y
2019-07-22 18:05:11 +02:00
kcov: convert kcov.refcount to refcount_t
2019-03-07 18:32:02 -08:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 230
2019-06-19 17:09:06 +02:00
kexec: bail out upon SIGKILL when allocating memory.
2019-09-25 17:51:40 -07:00
kexec_elf: support 32 bit ELF files
2019-09-06 23:58:44 +02:00
Merge branch 'next-integrity' of git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity
2019-07-08 20:28:59 -07:00
kheaders: Move from proc to sysfs
2019-05-24 20:16:01 +02:00
Tracing updates:
2019-09-20 11:19:48 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 170
2019-05-30 11:26:39 -07:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441
2019-06-05 17:37:17 +02:00
Kbuild updates for v5.4
2019-09-20 08:36:47 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 36
2019-05-24 17:27:11 +02:00
module: remove unneeded casts in cmp_name()
2019-09-11 21:41:56 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 36
2019-05-24 17:27:11 +02:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441
2019-06-05 17:37:17 +02:00
padata: remove cpu_index from the parallel_queue
2019-09-13 21:15:41 +10:00
bug: refactor away warn_slowpath_fmt_taint()
2019-09-25 17:51:40 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
kernel/pid.c: convert struct pid count to refcount_t
2019-07-16 19:23:24 -07:00
proc/sysctl: add shared variables for range check
2019-07-18 17:08:07 -07:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
ptrace: add PTRACE_GET_SYSCALL_INFO request
2019-07-16 19:23:24 -07:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2019-03-12 13:27:20 -07:00
mm/memory_hotplug.c: use PFN_UP / PFN_DOWN in walk_system_ram_range()
2019-09-24 15:54:09 -07:00
signal: Remove task parameter from force_sig
2019-05-27 09:36:28 -05:00
signal: Remove the signal number and task parameters from force_sig_info
2019-05-29 09:31:44 -05:00
core-process-v5.4
2019-09-16 09:28:19 -07:00
smp: Warn on function calls from softirq context
2019-07-20 11:27:16 +02:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
Merge branch 'irq-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-07-08 11:01:13 -07:00
stacktrace: Constify 'entries' arguments
2019-07-25 15:43:26 +02:00
stop_machine: Fix stop_cpus_in_progress ordering
2019-08-08 09:09:30 +02:00
Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-09-17 12:35:15 -07:00
arch: handle arches who do not yet define clone3
2019-06-21 01:54:53 +02:00
arm64, mm: move generic mmap layout functions to mm
2019-09-24 15:54:11 -07:00
kernel/sysctl: add panic_print into sysctl
2019-01-04 13:13:47 -08:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157
2019-05-30 11:26:37 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 25
2019-05-21 11:52:39 +02:00
torture: Remove exporting of internal functions
2019-08-01 14:30:22 -07:00
The main changes in this release include:
2019-07-18 11:51:00 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157
2019-05-30 11:26:37 -07:00
proc/sysctl: add shared variables for range check
2019-07-18 17:08:07 -07:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
smp: Remove smp_call_function() and on_each_cpu() return values
2019-06-23 14:26:26 +02:00
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
Keyrings namespacing
2019-07-08 19:36:47 -07:00
Keyrings namespacing
2019-07-08 19:36:47 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441
2019-06-05 17:37:17 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441
2019-06-05 17:37:17 +02:00
watchdog: Mark watchdog_hrtimer to expire in hard interrupt context
2019-08-01 20:51:20 +02:00
kernel/watchdog_hld.c: hard lockup message should end with a newline
2019-04-19 09:46:05 -07:00
workqueue: require CPU hotplug read exclusion for apply_workqueue_attrs
2019-09-13 21:15:40 +10:00
sched/core, workqueues: Distangle worker accounting from rq lock
2019-04-16 16:55:15 +02:00
ee8711336c