android_kernel_motorola_sm6375/tools/perf
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Masami Hiramatsu f182e3e13c perf probe: Avoid searching variables in intermediate scopes
Fix variable searching logic to search one in inner than local scope or
global(CU) scope. In the other words, skip searching in intermediate
scopes.

e.g., in the following code,

int var1;

void inline infunc(int i)
{
    i++;   <--- [A]
}

void func(void)
{
   int var1, var2;
   infunc(var2);
}

At [A], "var1" should point the global variable "var1", however, if user
mis-typed as "var2", variable search should be failed. However, current
logic searches variable infunc() scope, global scope, and then func()
scope. Thus, it can find "var2" variable in func() scope. This may not
be what user expects.

So, it would better not search outer scopes except outermost (compile
unit) scope which contains only global variables, when it failed to find
given variable in local scope.

E.g.

Without this:
$ perf probe -V pre_schedule --externs > without.vars

With this:
$ perf probe -V pre_schedule --externs > with.vars

Check the diff:
$ diff without.vars with.vars
88d87
<               int     cpu
133d131
<               long unsigned int*      switch_count

These vars are actually in the scope of schedule(), the caller of
pre_schedule().

Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: yrl.pp-manager.tt@hitachi.com
Link: http://lkml.kernel.org/r/20110811110305.19900.94374.stgit@fedora15
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
2011-08-12 09:29:34 -03:00
..
arch
bench
config
Documentation
python
scripts
util perf probe: Avoid searching variables in intermediate scopes 2011-08-12 09:29:34 -03:00
.gitignore
builtin-annotate.c
builtin-bench.c
builtin-buildid-cache.c
builtin-buildid-list.c
builtin-diff.c
builtin-evlist.c
builtin-help.c
builtin-inject.c
builtin-kmem.c
builtin-kvm.c
builtin-list.c
builtin-lock.c perf lock: Dropping unsupported ':r' modifier 2011-08-08 09:41:35 -03:00
builtin-probe.c perf probe: Warn when more than one line are given 2011-08-12 09:27:11 -03:00
builtin-record.c perf evlist: Introduce 'disable' method 2011-07-25 11:06:19 -03:00
builtin-report.c perf report: Use ui__warning in some more places 2011-08-03 12:33:24 -03:00
builtin-sched.c perf sched: Usage leftover from trace -> script rename 2011-08-09 13:32:12 -03:00
builtin-script.c
builtin-stat.c perf tools: De-opt the parse_events function 2011-07-21 10:41:11 +02:00
builtin-test.c perf tools: Make test use the preset debugfs path 2011-07-21 10:41:14 +02:00
builtin-timechart.c
builtin-top.c perf tools: De-opt the parse_events function 2011-07-21 10:41:11 +02:00
builtin.h
command-list.txt
CREDITS
design.txt
Makefile perf tools: Add support to install perf python extension 2011-08-08 12:54:26 -03:00
MANIFEST
perf-archive.sh
perf.c
perf.h