jeff.liu
5175a5e76b
RDS: fix rds-ping spinlock recursion
...
This is the revised patch for fixing rds-ping spinlock recursion
according to Venkat's suggestions.
RDS ping/pong over TCP feature has been broken for years(2.6.39 to
3.6.0) since we have to set TCP cork and call kernel_sendmsg() between
ping/pong which both need to lock "struct sock *sk". However, this
lock has already been hold before rds_tcp_data_ready() callback is
triggerred. As a result, we always facing spinlock resursion which
would resulting in system panic.
Given that RDS ping is only used to test the connectivity and not for
serious performance measurements, we can queue the pong transmit to
rds_wq as a delayed response.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
CC: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
CC: David S. Miller <davem@davemloft.net>
CC: James Morris <james.l.morris@oracle.com>
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2012-10-09 13:57:23 -04:00
..
af_rds.c
rds: Make rds_sock_lock BH rather than IRQ safe.
2012-01-24 17:03:44 -05:00
bind.c
cong.c
net: Add export.h for EXPORT_SYMBOL/THIS_MODULE to non-modules
2011-10-31 19:30:30 -04:00
connection.c
net: Add export.h for EXPORT_SYMBOL/THIS_MODULE to non-modules
2011-10-31 19:30:30 -04:00
ib.c
net: Fix files explicitly needing to include module.h
2011-10-31 19:30:28 -04:00
ib.h
rds_rdma: don't assume infiniband device is PCI
2012-05-29 17:30:07 -04:00
ib_cm.c
RDS: use gfp flags from caller in conn_alloc()
2012-03-22 19:29:58 -04:00
ib_rdma.c
ib_recv.c
Merge branch 'kmap_atomic' of git://github.com/congwang/linux
2012-03-21 09:40:26 -07:00
ib_ring.c
ib_send.c
ib_stats.c
ib_sysctl.c
net: Convert all sysctl registrations to register_net_sysctl
2012-04-20 21:22:30 -04:00
info.c
rds: remove the second argument of k[un]map_atomic()
2012-03-20 21:48:28 +08:00
info.h
iw.c
net: Fix files explicitly needing to include module.h
2011-10-31 19:30:28 -04:00
iw.h
iw_cm.c
RDS: use gfp flags from caller in conn_alloc()
2012-03-22 19:29:58 -04:00
iw_rdma.c
RDS: Remove some unused iWARP code
2012-01-12 20:05:28 -08:00
iw_recv.c
Merge branch 'kmap_atomic' of git://github.com/congwang/linux
2012-03-21 09:40:26 -07:00
iw_ring.c
iw_send.c
iw_stats.c
iw_sysctl.c
net: Convert all sysctl registrations to register_net_sysctl
2012-04-20 21:22:30 -04:00
Kconfig
rds: drop "select LLIST"
2011-11-14 00:10:50 -05:00
loop.c
RDS: use gfp flags from caller in conn_alloc()
2012-03-22 19:29:58 -04:00
loop.h
Makefile
message.c
net: Add export.h for EXPORT_SYMBOL/THIS_MODULE to non-modules
2011-10-31 19:30:30 -04:00
page.c
net: Fix (nearly-)kernel-doc comments for various functions
2012-07-10 23:13:45 -07:00
rdma.c
rdma_transport.c
net: Fix files explicitly needing to include module.h
2011-10-31 19:30:28 -04:00
rdma_transport.h
rds.h
rds: remove the second argument of k[un]map_atomic()
2012-03-20 21:48:28 +08:00
recv.c
rds: set correct msg_namelen
2012-07-23 01:01:44 -07:00
send.c
RDS: fix rds-ping spinlock recursion
2012-10-09 13:57:23 -04:00
stats.c
net: Add export.h for EXPORT_SYMBOL/THIS_MODULE to non-modules
2011-10-31 19:30:30 -04:00
sysctl.c
net: Convert all sysctl registrations to register_net_sysctl
2012-04-20 21:22:30 -04:00
tcp.c
net: Fix files explicitly needing to include module.h
2011-10-31 19:30:28 -04:00
tcp.h
tcp_connect.c
rds: Don't disable BH on BH context
2012-08-22 22:52:04 -07:00
tcp_listen.c
rds: Don't disable BH on BH context
2012-08-22 22:52:04 -07:00
tcp_recv.c
rds: Don't disable BH on BH context
2012-08-22 22:52:04 -07:00
tcp_send.c
rds: Don't disable BH on BH context
2012-08-22 22:52:04 -07:00
tcp_stats.c
threads.c
net: Add export.h for EXPORT_SYMBOL/THIS_MODULE to non-modules
2011-10-31 19:30:30 -04:00
transport.c