Lukas Wunner
3e538c536f
spi: Prevent adding devices below an unregistering controller ...
commit ddf75be47ca748f8b12d28ac64d624354fddf189 upstream.
CONFIG_OF_DYNAMIC and CONFIG_ACPI allow adding SPI devices at runtime
using a DeviceTree overlay or DSDT patch. CONFIG_SPI_SLAVE allows the
same via sysfs.
But there are no precautions to prevent adding a device below a
controller that's being removed. Such a device is unusable and may not
even be able to unbind cleanly as it becomes inaccessible once the
controller has been torn down. E.g. it is then impossible to quiesce
the device's interrupt.
of_spi_notify() and acpi_spi_notify() do hold a ref on the controller,
but otherwise run lockless against spi_unregister_controller().
Fix by holding the spi_add_lock in spi_unregister_controller() and
bailing out of spi_add_device() if the controller has been unregistered
concurrently.
Fixes: ce79d54ae4stable@vger.kernel.org # v3.19+
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Octavian Purdila <octavian.purdila@intel.com>
Cc: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Link: https://lore.kernel.org/r/a8c3205088a969dc8410eec1eba9aface60f36af.1596451035.git.lukas@wunner.de
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-08-26 10:40:50 +02:00
ACPICA: Do not increment operation_region reference counts for field units
2020-08-19 08:16:05 +02:00
binder: Prevent context manager from incrementing ref 0
2020-08-11 15:33:35 +02:00
atm: fix atm_dev refcnt leaks in atmtcp_remove_persistent
2020-08-11 15:33:38 +02:00
driver core: Avoid binding drivers to dead devices
2020-08-21 13:05:26 +02:00
loop: be paranoid on exit and prevent new additions / removals
2020-08-19 08:15:59 +02:00
Bluetooth: hci_serdev: Only unregister device if it was registered
2020-08-19 08:16:16 +02:00
bus: ti-sysc: Add missing quirk flags for usb_host_hs
2020-08-19 08:16:00 +02:00
tpm: Unify the mismatching TPM space buffer sizes
2020-08-19 08:16:27 +02:00
clk: bcm2835: Do not use prediv with bcm2711's PLLs
2020-08-21 13:05:35 +02:00
cpufreq: dt: fix oops on armada37xx
2020-08-19 08:16:25 +02:00
crypto: caam - Remove broken arc4 support
2020-08-21 13:05:32 +02:00
dmaengine: ioat setting ioat timeout as module parameter
2020-07-29 10:18:37 +02:00
dmabuf: use spinlock to access dmabuf->name
2020-07-29 10:18:29 +02:00
EDAC: Fix reference count leaks
2020-08-19 08:15:54 +02:00
firmware: arm_scmi: Fix SCMI genpd domain probing
2020-08-19 08:15:55 +02:00
fpga: dfl: fix bug in port reset handshake
2020-07-29 10:18:31 +02:00
gpio: arizona: put pm_runtime in case of failure
2020-07-29 10:18:26 +02:00
drm/vgem: Replace opencoded version of drm_gem_dumb_map_offset()
2020-08-26 10:40:47 +02:00
HID: input: Fix devices that return multiple bytes in battery report
2020-08-19 08:15:53 +02:00
Drivers: hv: vmbus: Ignore CHANNELMSG_TL_CONNECT_RESULT(23)
2020-08-11 15:33:38 +02:00
hwmon: (scmi) Fix potential buffer overflow in scmi_hwmon_probe()
2020-07-29 10:18:39 +02:00
coresight: tmc: Fix TMC mode read in tmc_read_unprepare_etb()
2020-08-19 08:16:14 +02:00
i2c: iproc: fix race between client unreg and isr
2020-08-21 13:05:38 +02:00
iio: dac: ad5592r: fix unbalanced mutex unlocks in ad5592r_read_raw()
2020-08-21 13:05:24 +02:00
RDMA/counter: Allow manually bind QPs with different pids to same counter
2020-08-21 13:05:32 +02:00
Input: sentelic - fix error return when fsp_reg_write fails
2020-08-21 13:05:36 +02:00
iommu/omap: Check for failure of a call to omap_iommu_dump_ctx
2020-08-21 13:05:33 +02:00
genirq/affinity: Make affinity setting if activated opt-in
2020-08-21 13:05:20 +02:00
leds: core: Flush scheduled work for system suspend
2020-08-19 08:16:11 +02:00
macintosh/via-macii: Access autopoll_devs when inside lock
2020-08-19 08:16:15 +02:00
bcache: avoid nr_stripes overflow in bcache_device_init()
2020-08-26 10:40:48 +02:00
media: rockchip: rga: Only set output CSC mode for RGB input
2020-08-21 13:05:31 +02:00
mfd: dln2: Run event handler loop under spinlock
2020-08-21 13:05:38 +02:00
cxl: Fix kobject memleak
2020-08-19 08:16:08 +02:00
mmc: renesas_sdhi_internal_dmac: clean up the code for dma complete
2020-08-21 13:05:32 +02:00
mtd: rawnand: fsl_upm: Remove unused mtd var
2020-08-21 13:05:30 +02:00
net: wan: wanxl: use $(M68KCC) instead of $(M68KAS) for rebuilding firmware
2020-08-26 10:40:46 +02:00
nfc: s3fwrn5: add missing release on skb in s3fwrn5_recv_frame
2020-08-05 09:59:50 +02:00
libnvdimm/security: ensure sysfs poll thread woke up and fetch updated attr
2020-08-21 13:05:35 +02:00
nvme-multipath: do not fall back to __nvme_find_path() for non-optimized paths
2020-08-19 08:15:59 +02:00
of: of_mdio: Correct loop scanning logic
2020-07-22 09:32:55 +02:00
parisc: mask out enable and reserved bits from sba imask
2020-08-19 08:16:26 +02:00
PCI: qcom: Add support for tx term offset for rev 2.1.0
2020-08-21 13:05:20 +02:00
drivers/perf: Prevent forced unbinding of PMU drivers
2020-07-29 10:18:40 +02:00
phy: armada-38x: fix NETA lockup when repeatedly switching speeds
2020-08-19 08:16:14 +02:00
pinctrl: ingenic: Properly detect GPIO direction when configured for IRQ
2020-08-21 13:05:29 +02:00
platform/chrome: cros_ec_ishtp: Fix a double-unlock issue
2020-08-21 13:05:30 +02:00
power: supply: check if calc_soc succeeded in pm860x_init_battery
2020-08-19 08:16:16 +02:00
pwm: bcm-iproc: handle clk_get_rate() return
2020-08-21 13:05:34 +02:00
regulator: fix memory leak on error path of regulator_register()
2020-08-19 08:15:57 +02:00
remoteproc: qcom_q6v5_mss: Validate modem blob firmware size before load
2020-08-21 13:05:29 +02:00
s390/dasd: fix inability to use DASD with DIAG driver
2020-08-19 08:16:29 +02:00
scsi: lpfc: nvmet: Avoid hang / use-after-free again when destroying targetport
2020-08-21 13:05:35 +02:00
slimbus: core: Fix mismatch in of_node_get/put
2020-07-22 09:33:08 +02:00
soc: qcom: rpmh-rsc: Set suppress_bind_attrs flag
2020-08-19 08:15:59 +02:00
soundwire: intel: fix memory leak with devm_kasprintf
2020-07-22 09:33:00 +02:00
spi: Prevent adding devices below an unregistering controller
2020-08-26 10:40:50 +02:00
staging: rtl8192u: fix a dubious looking mask before a shift
2020-08-19 08:16:13 +02:00
thermal: ti-soc-thermal: Fix reversed condition in ti_thermal_expose_sensor()
2020-08-19 08:16:14 +02:00
vt: Reject zero-sized screen buffer size.
2020-07-29 10:18:43 +02:00
uio_pdrv_genirq: fix use without device tree and no interrupt
2020-07-22 09:33:13 +02:00
USB: serial: ftdi_sio: clean up receive processing
2020-08-21 13:05:31 +02:00
vhost/scsi: fix up req type endian-ness
2020-08-05 09:59:42 +02:00
video: pxafb: Fix the function used to balance a 'dma_alloc_coherent()' call
2020-08-19 08:16:06 +02:00
virt: vbox: Fix guest capabilities mask check
2020-07-22 09:33:11 +02:00
virtio_balloon: fix up endian-ness for free cmd id
2020-08-05 09:59:43 +02:00
watchdog: initialize device before misc_register
2020-08-21 13:05:36 +02:00
xen/gntdev: Fix dmabuf import with non-zero sgt offset
2020-08-19 08:16:29 +02:00
3e538c536f