android_kernel_motorola_sm6375/net/bridge
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Gustavo A. R. Silva 9857e028d4 netfilter: Replace zero-length array with flexible-array member
[ Upstream commit 6daf14140129d30207ed6a0a69851fa6a3636bda ]

The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by
this change:

"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]

Lastly, fix checkpatch.pl warning
WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))
in net/bridge/netfilter/ebtables.c

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 7649773293 ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Stable-dep-of: 542ed8145e6f ("netfilter: nft_set_hash: unaligned atomic read on struct nft_set_ext")
Signed-off-by: Sasha Levin <sashal@kernel.org>
2025-01-09 13:23:35 +01:00
..
netfilter netfilter: Replace zero-length array with flexible-array member 2025-01-09 13:23:35 +01:00
br.c
br_arp_nd_proxy.c
br_device.c net: bridge: xmit: make sure we have at least eth header len bytes 2024-11-17 14:58:51 +01:00
br_fdb.c net: bridge: br_fdb_external_learn_add(): always set EXT_LEARN 2024-09-12 11:03:53 +02:00
br_forward.c net: bridge: fix corrupted ethernet header on multicast-to-unicast 2024-05-17 11:43:54 +02:00
br_if.c
br_input.c net: bridge: fdb: convert is_local to bitops 2024-09-12 11:03:53 +02:00
br_ioctl.c
br_mdb.c
br_multicast.c
br_netfilter_hooks.c netfilter: br_netfilter: fix panic with metadata_dst skb 2024-11-08 16:20:45 +01:00
br_netfilter_ipv6.c
br_netlink.c
br_netlink_tunnel.c
br_nf_core.c
br_private.h net: bridge: fdb: convert added_by_external_learn to use bitops 2024-09-12 11:03:53 +02:00
br_private_stp.h
br_private_tunnel.h
br_stp.c
br_stp_bpdu.c
br_stp_if.c
br_stp_timer.c
br_switchdev.c net: bridge: fdb: convert added_by_user to bitops 2024-09-12 11:03:53 +02:00
br_sysfs_br.c
br_sysfs_if.c
br_vlan.c
br_vlan_tunnel.c
Kconfig
Makefile