Eric Sandeen
37f13561de
xfs: recalculate leaf entry pointer after compacting a dir2 block ...
Dave Jones hit this assert when doing a compile on recent git, with
CONFIG_XFS_DEBUG enabled:
XFS: Assertion failed: (char *)dup - (char *)hdr == be16_to_cpu(*xfs_dir2_data_unused_tag_p(dup)), file: fs/xfs/xfs_dir2_data.c, line: 828
Upon further digging, the tag found by xfs_dir2_data_unused_tag_p(dup)
contained "2" and not the proper offset, and I found that this value was
changed after the memmoves under "Use a stale leaf for our new entry."
in xfs_dir2_block_addname(), i.e.
memmove(&blp[mid + 1], &blp[mid],
(highstale - mid) * sizeof(*blp));
overwrote it.
What has happened is that the previous call to xfs_dir2_block_compact()
has rearranged things; it changes btp->count as well as the
blp array. So after we make that call, we must recalculate the
proper pointer to the leaf entries by making another call to
xfs_dir2_block_leaf_p().
Dave provided a metadump image which led to a simple reproducer
(create a particular filename in the affected directory) and this
resolves the testcase as well as the bug on his live system.
Thanks also to dchinner for looking at this one with me.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Tested-by: Dave Jones <davej@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
2013-01-16 16:08:55 -06:00
xfs: add CRC infrastructure
2012-11-19 20:11:24 -06:00
xfs: switch to proper __bitwise type for KM_... flags
2012-05-29 23:28:32 -04:00
xfs: switch to proper __bitwise type for KM_... flags
2012-05-29 23:28:32 -04:00
xfs: remove xfs_flushinval_pages
2012-11-14 15:15:08 -06:00
xfs: add CRC infrastructure
2012-11-19 20:11:24 -06:00
userns: Pass a userns parameter into posix_acl_to_xattr and posix_acl_from_xattr
2012-09-18 01:01:35 -07:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: fix direct IO nested transaction deadlock.
2012-11-29 14:22:56 -06:00
Prefix IO_XX flags with XFS_IO_XX to avoid namespace colision.
2012-07-22 11:00:55 -05:00
xfs: add xfs_da_node verification
2012-11-15 21:34:55 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: move allocation stack switch up to xfs_bmapi_allocate
2012-10-18 17:42:48 -05:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: use b_maps[] for discontiguous buffers
2013-01-16 16:07:11 -06:00
xfs: use b_maps[] for discontiguous buffers
2013-01-16 16:07:11 -06:00
xfs: fix the multi-segment log buffer format
2013-01-16 16:08:08 -06:00
xfs: rename bli_format to avoid confusion with bli_formats
2013-01-16 16:07:37 -06:00
xfs: add CRC infrastructure
2012-11-19 20:11:24 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: remove xfs_flushinval_pages
2012-11-14 15:15:08 -06:00
xfs: fix typo in comment of xfs_dinode_t.
2012-06-14 12:28:26 -05:00
xfs: remove struct xfs_dabuf and infrastructure
2012-07-01 14:50:07 -05:00
xfs: recalculate leaf entry pointer after compacting a dir2 block
2013-01-16 16:08:55 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: remove struct xfs_dabuf and infrastructure
2012-07-01 14:50:07 -05:00
xfs: check for possible overflow in xfs_ioc_trim
2012-08-23 14:48:44 -05:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: remove xfs_iget.c
2012-10-17 13:42:25 -05:00
xfs: byte range granularity for XFS_IOC_ZERO_RANGE
2012-11-29 14:21:46 -06:00
xfs: add minimum file size filtering to eofblocks scan
2012-11-08 15:32:29 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: add background scanning to clear eofblocks inodes
2012-11-08 15:34:59 -06:00
xfs: inode allocation should use unmapped buffers.
2012-11-26 16:01:31 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: add background scanning to clear eofblocks inodes
2012-11-08 15:34:59 -06:00
xfs: add background scanning to clear eofblocks inodes
2012-11-08 15:34:59 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: check for stale inode before acquiring iflock on push
2012-06-21 14:20:06 -05:00
xfs: add inode id filtering to eofblocks scan
2012-11-08 15:29:14 -06:00
xfs: Convert to new freezing code
2012-07-31 09:45:48 +04:00
xfs: add EOFBLOCKS inode tagging/untagging
2012-11-08 14:20:44 -06:00
xfs: remove xfs_flush_pages
2012-11-14 15:12:45 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: add CRC infrastructure
2012-11-19 20:11:24 -06:00
xfs: fix sparse reported log CRC endian issue
2012-12-03 12:10:59 -06:00
xfs: xfs_quiesce_attr() should quiesce the log like unmount
2012-10-17 13:39:14 -05:00
xfs: rename log structure to xlog
2012-06-21 14:21:11 -05:00
xfs: fix sparse reported log CRC endian issue
2012-12-03 12:10:59 -06:00
xfs: fix sparse reported log CRC endian issue
2012-12-03 12:10:59 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: fix stray dquot unlock when reclaiming dquots
2012-11-29 14:24:03 -06:00
xfs: remove int casts from debug dquot soft limit timer asserts
2013-01-16 16:08:40 -06:00
userns: Convert qutoactl
2012-09-18 01:01:39 -07:00
xfs: uncached buffer reads need to return an error
2012-11-15 21:34:05 -06:00
xfs: add CRC infrastructure
2012-11-19 20:11:24 -06:00
xfs: add background scanning to clear eofblocks inodes
2012-11-08 15:34:59 -06:00
xfs: xfs_sync_data is redundant.
2012-10-17 12:01:25 -05:00
xfs: add background scanning to clear eofblocks inodes
2012-11-08 15:34:59 -06:00
xfs: add background scanning to clear eofblocks inodes
2012-11-08 15:34:59 -06:00
xfs: add more attribute tree trace points.
2012-11-13 14:47:00 -06:00
xfs: Convert to new freezing code
2012-07-31 09:45:48 +04:00
xfs: convert buffer verifiers to an ops structure.
2012-11-15 21:35:12 -06:00
xfs: re-enable xfsaild idle mode and fix associated races
2012-07-29 16:27:57 -05:00
xfs: fix the multi-segment log buffer format
2013-01-16 16:08:08 -06:00
userns: Convert quota netlink aka quota_send_warning
2012-09-18 01:01:40 -07:00
xfs: re-enable xfsaild idle mode and fix associated races
2012-07-29 16:27:57 -05:00
xfs: struct xfs_buf_log_format isn't variable sized.
2012-07-01 14:50:04 -05:00
xfs: remove the alloc_done argument to xfs_dialloc
2012-07-29 16:00:31 -05:00
xfs: byte range granularity for XFS_IOC_ZERO_RANGE
2012-11-29 14:21:46 -06:00
xfs: byte range granularity for XFS_IOC_ZERO_RANGE
2012-11-29 14:21:46 -06:00
37f13561de