Yonglong Li
fd35e34ece
tcp: make retransmitted SKB fit into the send window
[ Upstream commit 536a6c8e05f95e3d1118c40ae8b3022ee2d05d52 ]
current code of __tcp_retransmit_skb only check TCP_SKB_CB(skb)->seq
in send window, and TCP_SKB_CB(skb)->seq_end maybe out of send window.
If receiver has shrunk his window, and skb is out of new window, it
should retransmit a smaller portion of the payload.
test packetdrill script:
0 socket(..., SOCK_STREAM, IPPROTO_TCP) = 3
+0 fcntl(3, F_GETFL) = 0x2 (flags O_RDWR)
+0 fcntl(3, F_SETFL, O_RDWR|O_NONBLOCK) = 0
+0 connect(3, ..., ...) = -1 EINPROGRESS (Operation now in progress)
+0 > S 0:0(0) win 65535 <mss 1460,sackOK,TS val 100 ecr 0,nop,wscale 8>
+.05 < S. 0:0(0) ack 1 win 6000 <mss 1000,nop,nop,sackOK>
+0 > . 1:1(0) ack 1
+0 write(3, ..., 10000) = 10000
+0 > . 1:2001(2000) ack 1 win 65535
+0 > . 2001:4001(2000) ack 1 win 65535
+0 > . 4001:6001(2000) ack 1 win 65535
+.05 < . 1:1(0) ack 4001 win 1001
and tcpdump show:
192.168.226.67.55 > 192.0.2.1.8080: Flags [.], seq 1:2001, ack 1, win 65535, length 2000
192.168.226.67.55 > 192.0.2.1.8080: Flags [.], seq 2001:4001, ack 1, win 65535, length 2000
192.168.226.67.55 > 192.0.2.1.8080: Flags [P.], seq 4001:5001, ack 1, win 65535, length 1000
192.168.226.67.55 > 192.0.2.1.8080: Flags [.], seq 5001:6001, ack 1, win 65535, length 1000
192.0.2.1.8080 > 192.168.226.67.55: Flags [.], ack 4001, win 1001, length 0
192.168.226.67.55 > 192.0.2.1.8080: Flags [.], seq 5001:6001, ack 1, win 65535, length 1000
192.168.226.67.55 > 192.0.2.1.8080: Flags [P.], seq 4001:5001, ack 1, win 65535, length 1000
when cient retract window to 1001, send window is [4001,5002],
but TLP send 5001-6001 packet which is out of send window.
Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Signed-off-by: Yonglong Li <liyonglong@chinatelecom.cn>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/1657532838-20200-1-git-send-email-liyonglong@chinatelecom.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
|
2022-08-25 11:17:43 +02:00 |
| .. |
|
6lowpan
|
|
|
|
9p
|
xen/9p: use alloc/free_pages_exact()
|
2022-03-11 11:22:39 +01:00 |
|
802
|
|
|
|
8021q
|
net: vlan: fix underflow for the real_dev refcnt
|
2021-12-01 09:23:34 +01:00 |
|
appletalk
|
|
|
|
atm
|
|
|
|
ax25
|
ax25: Fix UAF bugs in ax25 timers
|
2022-04-20 09:19:40 +02:00 |
|
batman-adv
|
batman-adv: Don't skb_split skbuffs with frag_list
|
2022-05-18 09:47:24 +02:00 |
|
bluetooth
|
Bluetooth: L2CAP: Fix use-after-free caused by l2cap_chan_put
|
2022-08-03 11:59:37 +02:00 |
|
bpf
|
|
|
|
bpfilter
|
|
|
|
bridge
|
netfilter: br_netfilter: do not skip all hooks with 0 priority
|
2022-07-21 20:59:24 +02:00 |
|
caif
|
|
|
|
can
|
can: bcm: use call_rcu() instead of costly synchronize_rcu()
|
2022-07-12 16:30:46 +02:00 |
|
ceph
|
|
|
|
core
|
tcp: Fix data-races around sysctl knobs related to SYN option.
|
2022-07-29 17:14:14 +02:00 |
|
dcb
|
net: dcb: disable softirqs in dcbnl_flush_dev()
|
2022-03-08 19:07:51 +01:00 |
|
dccp
|
tcp: fix race condition when creating child sockets from syncookies
|
2022-04-27 13:50:45 +02:00 |
|
decnet
|
|
|
|
dns_resolver
|
|
|
|
dsa
|
net: dsa: Add missing of_node_put() in dsa_port_parse_of
|
2022-03-23 09:12:07 +01:00 |
|
ethernet
|
|
|
|
hsr
|
|
|
|
ieee802154
|
net: ieee802154: Return meaningful error codes from the netlink helpers
|
2022-02-08 18:24:31 +01:00 |
|
ife
|
|
|
|
ipv4
|
tcp: make retransmitted SKB fit into the send window
|
2022-08-25 11:17:43 +02:00 |
|
ipv6
|
net: ping6: Fix memleak in ipv6_renew_options().
|
2022-08-03 11:59:39 +02:00 |
|
iucv
|
|
|
|
kcm
|
|
|
|
key
|
Revert "net: af_key: add check for pfkey_broadcast in function pfkey_process"
|
2022-06-14 18:12:01 +02:00 |
|
l2tp
|
ipv6: Fix signed integer overflow in l2tp_ip6_sendmsg
|
2022-06-22 14:11:21 +02:00 |
|
l3mdev
|
l3mdev: l3mdev_master_upper_ifindex_by_index_rcu should be using netdev_master_upper_dev_get_rcu
|
2022-04-27 13:50:47 +02:00 |
|
lapb
|
|
|
|
llc
|
llc: only change llc->dev when bind() succeeds
|
2022-03-28 08:46:48 +02:00 |
|
mac80211
|
wifi: mac80211: fix queue selection for mesh/OCB interfaces
|
2022-07-21 20:59:17 +02:00 |
|
mac802154
|
|
|
|
mpls
|
net: mpls: Fix notifications when deleting a device
|
2021-12-08 09:01:12 +01:00 |
|
ncsi
|
net/ncsi: check for error return from call to nla_put_u32
|
2022-01-05 12:37:45 +01:00 |
|
netfilter
|
netfilter: nf_tables: fix null deref due to zeroed list head
|
2022-08-25 11:17:27 +02:00 |
|
netlabel
|
netlabel: fix out-of-bounds memory accesses
|
2022-04-15 14:18:35 +02:00 |
|
netlink
|
netlink: do not reset transport header in netlink_recvmsg()
|
2022-05-18 09:47:25 +02:00 |
|
netrom
|
|
|
|
nfc
|
NFC: NULL out the dev->rfkill to prevent UAF
|
2022-06-14 18:11:33 +02:00 |
|
nsh
|
|
|
|
openvswitch
|
net: openvswitch: fix parsing of nw_proto for IPv6 fragments
|
2022-06-29 08:58:44 +02:00 |
|
packet
|
net/packet: fix packet_sock xmit return value checking
|
2022-04-27 13:50:47 +02:00 |
|
phonet
|
phonet: refcount leak in pep_sock_accep
|
2022-01-11 15:23:33 +01:00 |
|
psample
|
|
|
|
qrtr
|
|
|
|
rds
|
rds: memory leak in __rds_conn_create()
|
2021-12-22 09:29:37 +01:00 |
|
rfkill
|
|
|
|
rose
|
net: rose: fix UAF bug caused by rose_t0timer_expiry
|
2022-07-12 16:30:46 +02:00 |
|
rxrpc
|
rxrpc: Fix decision on when to generate an IDLE ACK
|
2022-06-14 18:11:38 +02:00 |
|
sched
|
net/sched: act_api: Notify user space if any actions were flushed before error
|
2022-07-07 17:36:50 +02:00 |
|
sctp
|
sctp: leave the err path free in sctp_stream_init to sctp_stream_free
|
2022-08-03 11:59:41 +02:00 |
|
smc
|
net/smc: postpone sk_refcnt increment in connect()
|
2022-06-14 18:11:39 +02:00 |
|
strparser
|
|
|
|
sunrpc
|
SUNRPC: Fix READ_PLUS crasher
|
2022-07-07 17:36:48 +02:00 |
|
switchdev
|
|
|
|
tipc
|
net: tipc: fix possible refcount leak in tipc_sk_create()
|
2022-07-21 20:59:25 +02:00 |
|
tls
|
net/tls: Fix race in TLS device down flow
|
2022-07-29 17:14:12 +02:00 |
|
unix
|
af_unix: Fix a data-race in unix_dgram_peer_wake_me().
|
2022-06-14 18:11:57 +02:00 |
|
vmw_vsock
|
vsock: remove vsock from connected table when connect is interrupted by a signal
|
2022-02-23 11:59:57 +01:00 |
|
wimax
|
|
|
|
wireless
|
nl80211: show SSID for P2P_GO interfaces
|
2022-06-14 18:11:32 +02:00 |
|
x25
|
net/x25: Fix null-ptr-deref caused by x25_disconnect
|
2022-04-15 14:18:21 +02:00 |
|
xdp
|
Revert "xsk: Do not sleep in poll() when need_wakeup set"
|
2021-12-22 09:29:40 +01:00 |
|
xfrm
|
ip: Fix data-races around sysctl_ip_no_pmtu_disc.
|
2022-07-29 17:14:10 +02:00 |
|
compat.c
|
|
|
|
Kconfig
|
|
|
|
Makefile
|
|
|
|
socket.c
|
|
|
|
sysctl_net.c
|
|
|