Jarod Wilson
fd867d51f8
net/core: generic support for disabling netdev features down stack ...
There are some netdev features, which when disabled on an upper device,
such as a bonding master or a bridge, must be disabled and cannot be
re-enabled on underlying devices.
This is a rework of an earlier more heavy-handed appraoch, which simply
disables and prevents re-enabling of netdev features listed in a new
define in include/net/netdev_features.h, NETIF_F_UPPER_DISABLES. Any upper
device that disables a flag in that feature mask, the disabling will
propagate down the stack, and any lower device that has any upper device
with one of those flags disabled should not be able to enable said flag.
Initially, only LRO is included for proof of concept, and because this
code effectively does the same thing as dev_disable_lro(), though it will
also activate from the ethtool path, which was one of the goals here.
[root@dell-per730-01 ~]# ethtool -k bond0 |grep large
large-receive-offload: on
[root@dell-per730-01 ~]# ethtool -k p5p1 |grep large
large-receive-offload: on
[root@dell-per730-01 ~]# ethtool -K bond0 lro off
[root@dell-per730-01 ~]# ethtool -k bond0 |grep large
large-receive-offload: off
[root@dell-per730-01 ~]# ethtool -k p5p1 |grep large
large-receive-offload: off
dmesg dump:
[ 1033.277986] bond0: Disabling feature 0x0000000000008000 on lower dev p5p2.
[ 1034.067949] bnx2x 0000:06:00.1 p5p2: using MSI-X IRQs: sp 74 fp[0] 76 ... fp[7] 83
[ 1034.753612] bond0: Disabling feature 0x0000000000008000 on lower dev p5p1.
[ 1035.591019] bnx2x 0000:06:00.0 p5p1: using MSI-X IRQs: sp 62 fp[0] 64 ... fp[7] 71
This has been successfully tested with bnx2x, qlcnic and netxen network
cards as slaves in a bond interface. Turning LRO on or off on the master
also turns it on or off on each of the slaves, new slaves are added with
LRO in the same state as the master, and LRO can't be toggled on the
slaves.
Also, this should largely remove the need for dev_disable_lro(), and most,
if not all, of its call sites can be replaced by simply making sure
NETIF_F_LRO isn't included in the relevant device's feature flags.
Note that this patch is driven by bug reports from users saying it was
confusing that bonds and slaves had different settings for the same
features, and while it won't be 100% in sync if a lower device doesn't
support a feature like LRO, I think this is a good step in the right
direction.
CC: "David S. Miller" <davem@davemloft.net>
CC: Eric Dumazet <edumazet@google.com>
CC: Jay Vosburgh <j.vosburgh@gmail.com>
CC: Veaceslav Falico <vfalico@gmail.com>
CC: Andy Gospodarek <gospo@cumulusnetworks.com>
CC: Jiri Pirko <jiri@resnulli.us>
CC: Nikolay Aleksandrov <razor@blackwall.org>
CC: Michal Kubecek <mkubecek@suse.cz>
CC: Alexander Duyck <alexander.duyck@gmail.com>
CC: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2015-11-02 23:41:31 -05:00
Revert "uart: pl011: Add support to ZTE ZX296702 uart"
2015-09-04 09:14:20 -07:00
brcmfmac: Add support for the BCM4365 and BCM4366 PCIE devices.
2015-09-29 10:56:05 +03:00
net/can: can_dropped_invalid_skb can be boolean
2015-10-09 07:49:01 -07:00
libceph: advertise support for keepalive2
2015-09-17 20:14:27 +03:00
ARM: SoC driver updates for v4.3
2015-09-01 13:00:04 -07:00
fsl /bestcomm
Merge branch 'drm-next' of git://people.freedesktop.org/~airlied/linux
2015-09-04 15:49:32 -07:00
ARM:
2015-09-10 16:42:49 -07:00
sound updates for 4.3-rc1
2015-09-04 11:46:02 -07:00
net/mlx4_core: Replace VF zero mac with random mac in mlx4_core
2015-10-14 19:14:44 -07:00
net/mlx5_core: Wait for FW readiness on startup
2015-10-14 19:14:43 -07:00
net/nfnetlink: lockdep_nfnl_is_held can be boolean
2015-10-09 07:49:00 -07:00
inet netfilter: Remove hook from ip6t_do_table, arp_do_table, ipt_do_table
2015-09-18 21:57:43 +02:00
netfilter: ebtables: Simplify the arguments to ebt_do_table
2015-09-18 21:57:35 +02:00
inet netfilter: Remove hook from ip6t_do_table, arp_do_table, ipt_do_table
2015-09-18 21:57:43 +02:00
inet netfilter: Remove hook from ip6t_do_table, arp_do_table, ipt_do_table
2015-09-18 21:57:43 +02:00
NFC 4.4 pull request
2015-10-30 20:19:43 +09:00
qed: Add statistics support
2015-10-27 19:34:54 -07:00
Merge remote-tracking branches 'regulator/topic/qcom-smd', 'regulator/topic/qcom-spmi', 'regulator/topic/rk808', 'regulator/topic/stub' and 'regulator/topic/tol' into regulator-next
2015-08-30 14:40:11 +01:00
ARM: SoC driver updates for v4.3
2015-09-01 13:00:04 -07:00
spi: fix kernel-doc warnings in spi.h
2015-09-16 20:44:47 +01:00
SUNRPC: Ensure that we wait for connections to complete before retrying
2015-09-17 18:01:28 -04:00
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2015-10-20 06:08:27 -07:00
ACPI, PCI, irq: Do not share PCI IRQ with ISA IRQ
2015-09-26 01:53:07 +02:00
writeback: bdi_writeback iteration must not skip dying ones
2015-10-12 10:31:12 -06:00
block: don't release bdi while request_queue has live references
2015-10-15 09:53:28 -06:00
blkcg: fix incorrect read/write sync/async stat accounting
2015-10-27 15:04:56 +09:00
blk-mq: factor out a helper to iterate all tags for a request_queue
2015-10-01 10:10:57 +02:00
Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs
2015-09-03 12:28:30 -07:00
blk-mq: fix sysfs registration/unregistration race
2015-09-29 11:32:45 -06:00
bpf: add support for persistent maps/progs
2015-11-02 22:48:39 -05:00
net: phy: Broadcom Cygnus internal Etherent PHY driver
2015-10-08 04:45:52 -07:00
Revert "sched, cgroup: replace signal_struct->group_rwsem with a global percpu_rwsem"
2015-09-16 11:51:12 -04:00
Merge branch 'for-4.3/blkcg' of git://git.kernel.dk/linux-block
2015-09-10 18:56:14 -07:00
clockevents: Remove unused set_mode() callback
2015-09-14 11:00:55 +02:00
mm: cma: fix incorrect type conversion for size during dma allocation
2015-10-23 17:55:10 +09:00
Revert "Merge branch 'ipv6-overflow-arith'"
2015-10-29 07:01:48 -07:00
compiler, atomics, kasan: Provide READ_ONCE_NOCHECK()
2015-10-20 11:04:19 +02:00
cpufreq: acpi-cpufreq: Use cpufreq_cpu_get_raw() in ->get()
2015-09-16 02:17:49 +02:00
capabilities: ambient capabilities
2015-09-04 16:54:41 -07:00
dax: add huge page fault support
2015-09-08 15:35:28 -07:00
net/dccp: dccp_list_has_service can be boolean
2015-10-09 07:49:02 -07:00
PM / devfreq: comments for get_dev_status usage updated
2015-09-11 14:23:29 +09:00
Power management and ACPI material for v4.3-rc1
2015-09-01 19:45:46 -07:00
mm: cma: fix incorrect type conversion for size during dma allocation
2015-10-23 17:55:10 +09:00
mm: add dma_pool_zalloc() call to DMA API
2015-09-08 15:35:28 -07:00
bpf: fix cb access in socket filter programs
2015-10-11 04:40:05 -07:00
dax: move DAX-related functions to a new header
2015-09-08 15:35:28 -07:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2015-09-05 20:34:28 -07:00
genalloc: add support of multiple gen_pools per device
2015-09-04 16:54:41 -07:00
net/netlink: lockdep_genl_is_held can be boolean
2015-10-09 07:48:59 -07:00
mm: use numa_mem_id() in alloc_pages_node()
2015-09-08 15:35:28 -07:00
dax: don't use set_huge_zero_page()
2015-09-08 15:35:28 -07:00
hugetlbfs: add hugetlbfs_fallocate()
2015-09-08 15:35:28 -07:00
wireless: add WNM action frame categories
2015-10-13 10:34:46 +02:00
ieee802154: remove unnecessary includes
2015-09-24 20:42:37 +02:00
bridge: define some min/max/default ageing time constants
2015-09-23 14:35:58 -07:00
if_link: Add control trust VF
2015-10-23 05:44:28 -07:00
net/ipv4: Pass proto as u8 instead of u16 in ip_check_mc_rcu
2015-09-29 16:27:47 -07:00
net/inetdevice: bad_mask can be boolean
2015-10-09 07:49:05 -07:00
Revert "sched, cgroup: replace signal_struct->group_rwsem with a global percpu_rwsem"
2015-09-16 11:51:12 -04:00
ipmi: Don't flush messages in sender() in run-to-completion mode
2015-09-03 15:02:28 -05:00
ipv6: inet6_sk() should use sk_fullsock()
2015-10-05 02:45:25 -07:00
genirq: Remove irq argument from irq flow handlers
2015-09-16 15:47:51 +02:00
genirq: Remove irq argument from irq flow handlers
2015-09-16 15:47:51 +02:00
irqdomain: Add an accessor for the of_node field
2015-10-09 17:17:30 +02:00
genirq: Remove irq argument from irq flow handlers
2015-09-16 15:47:51 +02:00
Pretty much all bug fixes and clean ups for 4.3, after a lot of
2015-09-03 12:52:19 -07:00
Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2015-09-01 14:04:50 -07:00
locking/static_keys: Fix up the static keys documentation
2015-09-15 07:12:06 +02:00
kexec: split kexec_load syscall from kexec core code
2015-09-10 13:29:01 -07:00
kmod: use system_unbound_wq instead of khelper
2015-09-10 13:29:01 -07:00
kernel/kthread.c:kthread_create_on_node(): clarify documentation
2015-09-04 16:54:41 -07:00
KVM: make halt_poll_ns per-vCPU
2015-09-06 16:27:10 +02:00
arcnet: com20020-pci: add led trigger support
2015-10-26 09:10:56 +01:00
mem-hotplug: handle node hole when initializing numa_meminfo.
2015-09-08 15:35:28 -07:00
writeback: fix incorrect calculation of available memory for memcg domains
2015-10-12 10:31:13 -06:00
add microchip LAN88xx phy driver
2015-09-09 17:19:14 -07:00
memcg: fix dirty page migration
2015-10-01 21:42:35 -04:00
mm: drop __nocast from vm_flags_t definition
2015-09-08 15:35:28 -07:00
mm: introduce idle page tracking
2015-09-10 13:29:01 -07:00
libnvdimm for 4.3:
2015-09-08 14:35:59 -07:00
net: move net_get_random_once to lib
2015-10-08 05:26:35 -07:00
net/core: generic support for disabling netdev features down stack
2015-11-02 23:41:31 -05:00
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2015-10-24 06:54:12 -07:00
netfilter: turn NF_HOOK into an inline function
2015-10-16 18:45:36 +02:00
netfilter: Pass net into okfn
2015-09-17 17:18:37 -07:00
netfilter: Store net in nf_hook_state
2015-09-17 17:18:32 -07:00
ipv4: Pass struct net into ip_route_me_harder
2015-09-29 20:21:32 +02:00
ipv6: Pass struct net through ip6_fragment
2015-09-30 01:45:03 -05:00
netlink, mmap: fix edge-case leakages in nf queue zero-copy
2015-09-09 21:43:22 -07:00
NFSv4: Express delegation limit in units of pages
2015-09-07 12:36:13 -04:00
Merge branch 'nmi' of git://ftp.arm.linux.org.uk/~rmk/linux-arm
2015-09-08 12:28:10 -07:00
NTB: Fix documentation for ntb_peer_db_clear.
2015-09-07 15:17:09 -04:00
NTB: Add flow control to the ntb_netdev
2015-09-07 15:17:08 -04:00
PKCS#7: Add OIDs for sha224, sha284 and sha512 hash algos and use them
2015-09-01 09:59:20 +10:00
once: make helper generic for calling functions once
2015-10-08 05:26:36 -07:00
mm, oom: add description of struct oom_control
2015-09-08 15:35:28 -07:00
mm: introduce idle page tracking
2015-09-10 13:29:01 -07:00
mm, page_isolation: make set/unset_migratetype_isolate() file-local
2015-09-08 15:35:28 -07:00
mm: introduce idle page tracking
2015-09-10 13:29:01 -07:00
mm: introduce idle page tracking
2015-09-10 13:29:01 -07:00
pci: mm: add pci_pool_zalloc() call
2015-09-08 15:35:28 -07:00
net: phy: Add nested variants of mdiobus read/write
2015-10-23 05:57:43 -07:00
phy: fixed_phy: Add gpio to determine link up/down.
2015-08-31 14:48:02 -07:00
PM / OPP: add dev_pm_opp_get_suspend_opp() helper
2015-09-09 02:20:39 +02:00
include/linux/poison.h: remove not-used poison pointer macros
2015-09-10 13:29:01 -07:00
hexdump: do not print debug dumps for !CONFIG_DEBUG
2015-09-10 13:29:01 -07:00
random32: add prandom_init_once helper for own rngs
2015-10-08 05:26:38 -07:00
rcu: Change _wait_rcu_gp() to work around GCC bug 67055
2015-09-20 20:50:06 -07:00
regmap: Allow installing custom reg_update_bits function
2015-10-06 16:12:34 +01:00
reset: Add (devm_)reset_control_get stub functions
2015-09-01 09:56:58 +02:00
mm: send one IPI per CPU to TLB flush all entries after unmapping pages
2015-09-04 16:54:41 -07:00
net/core: lockdep_rtnl_is_held can be boolean
2015-10-09 07:49:06 -07:00
bpf: charge user for creation of BPF maps and programs
2015-10-12 19:13:36 -07:00
seccomp, ptrace: add support for dumping seccomp filters
2015-10-27 19:55:13 -07:00
security: fix typo in security_task_prctl
2015-09-20 17:00:26 -07:00
fs/seq_file: convert int seq_vprint/seq_printf/etc... returns to void
2015-09-11 15:21:34 -07:00
tcp: skb_mstamp_after helper
2015-10-21 07:00:46 -07:00
slab: infrastructure for bulk object allocation and freeing
2015-09-04 16:54:41 -07:00
smpboot: allow passing the cpumask on per-cpu thread registration
2015-09-04 16:54:41 -07:00
Merge branch 'x86-asm-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2015-09-01 08:40:25 -07:00
string: provide strscpy()
2015-09-10 15:36:59 -04:00
lib/string_helpers: rename "esc" arg to "only"
2015-09-10 13:29:01 -07:00
mm: swap: zswap: maybe_preload & refactoring
2015-09-08 15:35:28 -07:00
mm/hwpoison: fix race between soft_offline_page and unpoison_memory
2015-09-08 15:35:28 -07:00
sys_membarrier(): system-wide memory barrier (generic, x86)
2015-09-11 15:21:34 -07:00
tcp: fastopen: limit max_qlen
2015-10-22 06:22:13 -07:00
thermal: Add a function to get the minimum power
2015-09-14 07:39:46 -07:00
nohz: Affine unpinned timers to housekeepers
2015-09-02 10:33:22 +02:00
userfaultfd: mcopy_atomic|mfill_zeropage: UFFDIO_COPY|UFFDIO_ZEROPAGE preparation
2015-09-04 16:54:41 -07:00
userfaultfd: revert "userfaultfd: waitqueue: add nr wake parameter to __wake_up_locked_key"
2015-09-22 15:09:53 -07:00
kernel/watchdog: move NMI function header declarations from watchdog.h to nmi.h
2015-09-04 16:54:41 -07:00
mm: zbud: constify the zbud_ops
2015-09-08 15:35:28 -07:00
zpool: add zpool_has_pool()
2015-09-10 13:29:01 -07:00
zsmalloc: account the number of compacted pages
2015-09-08 15:35:28 -07:00
