Zhiqiang Liu
f651e94899
bcache: fix potential deadlock problem in btree_gc_coalesce ...
[ Upstream commit be23e837333a914df3f24bf0b32e87b0331ab8d1 ]
coccicheck reports:
drivers/md//bcache/btree.c:1538:1-7: preceding lock on line 1417
In btree_gc_coalesce func, if the coalescing process fails, we will goto
to out_nocoalesce tag directly without releasing new_nodes[i]->write_lock.
Then, it will cause a deadlock when trying to acquire new_nodes[i]->
write_lock for freeing new_nodes[i] before return.
btree_gc_coalesce func details as follows:
if alloc new_nodes[i] fails:
goto out_nocoalesce;
// obtain new_nodes[i]->write_lock
mutex_lock(&new_nodes[i]->write_lock)
// main coalescing process
for (i = nodes - 1; i > 0; --i)
[snipped]
if coalescing process fails:
// Here, directly goto out_nocoalesce
// tag will cause a deadlock
goto out_nocoalesce;
[snipped]
// release new_nodes[i]->write_lock
mutex_unlock(&new_nodes[i]->write_lock)
// coalesing succ, return
return;
out_nocoalesce:
btree_node_free(new_nodes[i]) // free new_nodes[i]
// obtain new_nodes[i]->write_lock
mutex_lock(&new_nodes[i]->write_lock);
// set flag for reuse
clear_bit(BTREE_NODE_dirty, &ew_nodes[i]->flags);
// release new_nodes[i]->write_lock
mutex_unlock(&new_nodes[i]->write_lock);
To fix the problem, we add a new tag 'out_unlock_nocoalesce' for
releasing new_nodes[i]->write_lock before out_nocoalesce tag. If
coalescing process fails, we will go to out_unlock_nocoalesce tag
for releasing new_nodes[i]->write_lock before free new_nodes[i] in
out_nocoalesce tag.
(Coly Li helps to clean up commit log format.)
Fixes: 2a285686c1
2020-06-24 17:50:45 +02:00
bcache: fix potential deadlock problem in btree_gc_coalesce
2020-06-24 17:50:45 +02:00
dm space map common: fix to ensure new block isn't already in use
2020-02-11 04:35:26 -08:00
dm bio record: save/restore bi_end_io and bi_integrity
2020-03-25 08:25:48 +01:00
dm bufio: introduce a global cache replacement
2019-09-13 17:00:21 -04:00
dm cache: fix a crash due to incorrect work item cancelling
2020-03-12 13:00:23 +01:00
dm clone: Fix handling of partial region discards
2020-04-17 10:50:24 +02:00
dm clone: replace spin_lock_irqsave with spin_lock_irq
2020-04-17 10:50:23 +02:00
dm clone: Add missing casts to prevent overflows and data corruption
2020-04-17 10:50:24 +02:00
dm crypt: avoid truncating the logical block size
2020-06-22 09:31:21 +02:00
dm dust: use dust block size for badblocklist index
2019-08-21 11:27:17 -04:00
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
- Improve DM snapshot target's scalability by using finer grained
2019-05-16 15:55:48 -07:00
block: Kill gfp_t argument of blkdev_report_zones()
2019-07-11 20:04:37 -06:00
docs: device-mapper: move it to the admin-guide
2019-07-15 11:03:01 -03:00
dm integrity: fix a crash with unusually large tag size
2020-04-17 10:50:17 +02:00
dm: introduce DM_GET_TARGET_VERSION
2019-09-16 10:18:01 -04:00
dm kcopyd: always complete failed jobs
2019-08-15 15:57:39 -04:00
block: Kill gfp_t argument of blkdev_report_zones()
2019-07-11 20:04:37 -06:00
dm log writes: fix incorrect comment about the logged sequence example
2019-07-09 14:13:33 -04:00
dm mpath: switch paths in dm_blk_ioctl() code path
2020-06-24 17:50:13 +02:00
dm raid: fix updating of max_discard_sectors limit
2019-09-11 16:18:23 -04:00
dm raid1: use struct_size() with kzalloc()
2019-08-26 11:05:32 -04:00
block: Delay default elevator initialization
2019-09-05 19:52:34 -06:00
block: fix an integer overflow in logical block size
2020-01-23 08:22:32 +01:00
dm snapshot: rework COW throttling to fix deadlock
2019-10-10 09:46:05 -04:00
dm stats: use struct_size() helper
2019-09-04 09:39:22 -04:00
dm: make dm_table_find_target return NULL
2019-08-23 10:13:12 -04:00
dm thin metadata: fix lockdep complaint
2020-03-12 13:00:09 +01:00
dm thin metadata: Add support for a pre-commit callback
2019-12-21 11:05:01 +01:00
dm thin: don't allow changing data device during thin-pool reload
2020-02-24 08:36:49 +01:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156
2019-05-30 11:26:35 -07:00
dm verity fec: fix hash block number in verity_fec_decode
2020-05-06 08:15:10 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
dm verity: add root hash pkcs#7 signature verification
2019-08-23 10:13:14 -04:00
dm verity: add root hash pkcs#7 signature verification
2019-08-23 10:13:14 -04:00
dm verity: add root hash pkcs#7 signature verification
2019-08-23 10:13:14 -04:00
dm verity: add root hash pkcs#7 signature verification
2019-08-23 10:13:14 -04:00
dm writecache: fix data corruption when reloading the target
2020-05-06 08:15:10 +02:00
dm zoned: return NULL if dmz_get_zone_for_reclaim() fails to find a zone
2020-06-24 17:50:31 +02:00
dm zoned: return NULL if dmz_get_zone_for_reclaim() fails to find a zone
2020-06-24 17:50:31 +02:00
dm zoned: Fix reference counter initial value of chunk works
2020-03-12 13:00:24 +01:00
dm zoned: reduce overhead of backing device checks
2019-12-17 19:56:12 +01:00
Revert "dm: always call blk_queue_split() in dm_process_bio()"
2020-04-08 09:08:43 +02:00
dm: make dm_table_find_target return NULL
2019-08-23 10:13:12 -04:00
dm: add clone target
2019-09-12 09:32:31 -04:00
dm: add clone target
2019-09-12 09:32:31 -04:00
md/bitmap: avoid race window between md_bitmap_resize and bitmap_file_clear_bit
2019-12-31 16:44:20 +01:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 45
2019-05-24 17:27:12 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 47
2019-05-24 17:27:13 +02:00
md: improve handling of bio with REQ_PREFLUSH in md_flush_request()
2019-12-17 19:56:14 +01:00
md: improve handling of bio with REQ_PREFLUSH in md_flush_request()
2019-12-17 19:56:14 +01:00
md: don't flush workqueue unconditionally in md_open
2020-06-22 09:31:05 +02:00
md: improve handling of bio with REQ_PREFLUSH in md_flush_request()
2019-12-17 19:56:14 +01:00
block: fix an integer overflow in logical block size
2020-01-23 08:22:32 +01:00
md/raid0: avoid RAID0 data corruption due to layout confusion.
2019-09-13 13:10:05 -07:00
md: raid1-10: Unify r{1,10}bio_pool_free
2019-06-15 01:37:35 -06:00
md: raid1: check rdev before reference in raid1_sync_request func
2020-01-09 10:19:48 +01:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 288
2019-06-05 17:36:37 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 288
2019-06-05 17:36:37 +02:00
raid5: remove gfp flags from scribble_alloc()
2020-06-22 09:31:06 +02:00
raid5: use bio_end_sector in r5_next_bio
2019-09-13 13:14:43 -07:00
md: improve handling of bio with REQ_PREFLUSH in md_flush_request()
2019-12-17 19:56:14 +01:00
f651e94899