android_kernel_motorola_sm6375/net/openvswitch
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Ilya Maximets fee500c335 net: openvswitch: don't send internal clone attribute to the userspace.
[ Upstream commit 3f2a3050b4a3e7f32fc0ea3c9b0183090ae00522 ]

'OVS_CLONE_ATTR_EXEC' is an internal attribute that is used for
performance optimization inside the kernel.  It's added by the kernel
while parsing user-provided actions and should not be sent during the
flow dump as it's not part of the uAPI.

The issue doesn't cause any significant problems to the ovs-vswitchd
process, because reported actions are not really used in the
application lifecycle and only supposed to be shown to a human via
ovs-dpctl flow dump.  However, the action list is still incorrect
and causes the following error if the user wants to look at the
datapath flows:

  # ovs-dpctl add-dp system@ovs-system
  # ovs-dpctl add-flow "<flow match>" "clone(ct(commit),0)"
  # ovs-dpctl dump-flows
  <flow match>, packets:0, bytes:0, used:never,
    actions:clone(bad length 4, expected -1 for: action0(01 00 00 00),
                  ct(commit),0)

With the fix:

  # ovs-dpctl dump-flows
  <flow match>, packets:0, bytes:0, used:never,
    actions:clone(ct(commit),0)

Additionally fixed an incorrect attribute name in the comment.

Fixes: b233504033 ("openvswitch: kernel datapath clone action")
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Acked-by: Aaron Conole <aconole@redhat.com>
Link: https://lore.kernel.org/r/20220404104150.2865736-1-i.maximets@ovn.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-04-15 14:18:37 +02:00
..
actions.c net: openvswitch: don't send internal clone attribute to the userspace. 2022-04-15 14:18:37 +02:00
conntrack.c openvswitch: always update flow key after nat 2022-04-15 14:18:17 +02:00
conntrack.h
datapath.c
datapath.h
dp_notify.c
flow.c
flow.h
flow_netlink.c net: openvswitch: don't send internal clone attribute to the userspace. 2022-04-15 14:18:37 +02:00
flow_netlink.h
flow_table.c
flow_table.h
Kconfig
Makefile
meter.c openvswitch: meter: fix race when getting now_ms. 2021-06-03 08:59:13 +02:00
meter.h net: openvswitch: use u64 for meter bucket 2020-10-01 13:17:56 +02:00
vport-geneve.c
vport-gre.c
vport-internal_dev.c
vport-internal_dev.h
vport-netdev.c
vport-netdev.h
vport-vxlan.c
vport.c ovs: clear skb->tstamp in forwarding path 2021-08-26 08:36:19 -04:00
vport.h