Simon Horman
feea6020aa
netfilter: ctnetlink: compile ctnetlink_label_size with CONFIG_NF_CONNTRACK_EVENTS ...
[ Upstream commit e1f1ee0e9ad8cbe660f5c104e791c5f1a7cf4c31 ]
Only provide ctnetlink_label_size when it is used,
which is when CONFIG_NF_CONNTRACK_EVENTS is configured.
Flagged by clang-18 W=1 builds as:
.../nf_conntrack_netlink.c:385:19: warning: unused function 'ctnetlink_label_size' [-Wunused-function]
385 | static inline int ctnetlink_label_size(const struct nf_conn *ct)
| ^~~~~~~~~~~~~~~~~~~~
The condition on CONFIG_NF_CONNTRACK_LABELS being removed by
this patch guards compilation of non-trivial implementations
of ctnetlink_dump_labels() and ctnetlink_label_size().
However, this is not necessary as each of these functions
will always return 0 if CONFIG_NF_CONNTRACK_LABELS is not defined
as each function starts with the equivalent of:
struct nf_conn_labels *labels = nf_ct_labels_find(ct);
if (!labels)
return 0;
And nf_ct_labels_find always returns NULL if CONFIG_NF_CONNTRACK_LABELS
is not enabled. So I believe that the compiler optimises the code away
in such cases anyway.
Found by inspection.
Compile tested only.
Originally splitted in two patches, Pablo Neira Ayuso collapsed them and
added Fixes: tag.
Fixes: 0ceabd8387https://lore.kernel.org/netfilter-devel/20240909151712.GZ2097826@kernel.org/
Signed-off-by: Simon Horman <horms@kernel.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-11-08 16:20:33 +01:00
net/9p: fix uninit-value in p9_client_rpc()
2024-06-16 13:28:51 +02:00
vlan: skip nested type that is not IFLA_VLAN_QOS_MAPPING
2024-02-23 08:24:50 +01:00
batman-adv: Don't accept TT entries for out-of-spec VIDs
2024-07-05 09:08:31 +02:00
Bluetooth: MGMT: Add error handling to pair_device()
2024-09-04 13:15:01 +02:00
net: bridge: br_fdb_external_learn_add(): always set EXT_LEARN
2024-09-12 11:03:53 +02:00
can: bcm: Clear bo->bcm_proc_read after remove_proc_entry().
2024-11-08 16:20:27 +01:00
libceph: fix race between delayed_work() and ceph_monc_stop()
2024-07-18 11:40:55 +02:00
sock_map: Add a cond_resched() in sock_hash_free()
2024-11-08 16:20:27 +01:00
ethernet: Add helper for assigning packet type when dest address does not match device address
2024-05-02 16:18:36 +02:00
hsr: Handle failures in module init
2024-03-26 18:22:25 -04:00
inet: inet_defrag: prevent sk release while still in use
2024-11-08 16:20:26 +01:00
netfilter: nf_reject_ipv6: fix nf_reject_ip6_tcphdr_put()
2024-11-08 16:20:33 +01:00
s390/iucv: fix receive buffer virtual vs physical address confusion
2024-09-04 13:14:57 +02:00
kcm: Serialise kcm_sendmsg() for the same socket.
2024-09-04 13:14:59 +02:00
net l2tp: drop flow hash on forward
2024-05-17 11:43:49 +02:00
llc: call sock_orphan() at release time
2024-02-23 08:25:04 +01:00
wifi: mac80211: use two-phase skb reclamation in ieee80211_do_stop()
2024-11-08 16:20:27 +01:00
net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and DEV_STATS_ADD()
2024-07-27 10:38:31 +02:00
net/ncsi: Fix netlink major/minor version numbers
2024-01-25 14:34:25 -08:00
netfilter: ctnetlink: compile ctnetlink_label_size with CONFIG_NF_CONNTRACK_EVENTS
2024-11-08 16:20:33 +01:00
calipso: fix memory leak in netlbl_calipso_add_pass()
2024-01-25 14:34:23 -08:00
netlink: Fix kernel-infoleak-after-free in __skb_datagram_iter
2024-03-06 14:36:08 +00:00
netrom: Fix a memory leak in nr_heartbeat_expiry()
2024-07-05 09:08:22 +02:00
nfc: nci: Fix handling of zero-length payload packets in nci_rx_work()
2024-06-16 13:28:46 +02:00
nsh: Restore skb->{protocol,data,mac_header} for outer header in nsh_gso_segment().
2024-05-17 11:43:49 +02:00
openvswitch: Set the skbuff pkt_type for proper pmtud support.
2024-06-16 13:28:45 +02:00
af_packet: Handle outgoing VLAN packets without hardware offloading
2024-08-19 05:33:35 +02:00
phonet: fix rtm_phonet_notify() skb allocation
2024-05-17 11:43:54 +02:00
net: qrtr: Update packets cloning when broadcasting
2024-11-08 16:20:33 +01:00
net:rds: Fix possible deadlock in rds_message_put
2024-09-04 13:15:03 +02:00
rxrpc: Fix response to PING RESPONSE ACKs to a dead call
2024-02-23 08:25:07 +01:00
sched: sch_cake: fix bulk flow accounting logic for host fairness
2024-09-12 11:03:51 +02:00
sctp: Fix null-ptr-deref in reuseport_add_sock().
2024-08-19 05:33:46 +02:00
net/smc: set rmb's SG_MAX_SINGLE_ALLOC limitation only when CONFIG_ARCH_NO_SG_CHAIN is defined
2024-08-19 05:33:28 +02:00
net, sunrpc: Remap EPERM in case of connection failure in xs_tcp_setup_socket
2024-09-12 11:03:57 +02:00
net: tipc: avoid possible garbage value
2024-11-08 16:20:27 +01:00
tls: stop recv() if initial process_rx_list gave us non-DATA
2024-03-01 13:13:37 +01:00
af_unix: Remove put_pid()/put_cred() in copy_peercred().
2024-09-12 11:03:52 +02:00
virtio/vsock: fix logic which reduces credit update messages
2024-01-25 14:34:25 -08:00
wifi: cfg80211: fix two more possible UBSAN-detected off-by-one errors
2024-11-08 16:20:27 +01:00
net/x25: fix incorrect parameter validation in the x25_getsockopt() function
2024-03-26 18:22:18 -04:00
xsk: validate user input for XDP_{UMEM|COMPLETION}_FILL_RING
2024-06-16 13:28:52 +02:00
net: fix __dst_negative_advice() race
2024-06-16 13:28:52 +02:00
feea6020aa