bunnypad/android_device_samsung_a20
Watch
1
0
Fork
You've already forked android_device_samsung_a20
 0
mirror of https://github.com/chararomandroid/android_device_samsung_a20 synced 2026-08-23 12:35:33 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

universal7885: parts: Don't code every possible values

Browse source 
* Use static_cast<Enum class>(Value) instead
This commit is contained in:
roynatech2544 2022-04-12 18:19:01 +09:00
commit 006243af7c
No known key found for this signature in database
GPG key ID: 50ABF73F0D19445D
3 changed files with 4 additions and 72 deletions
Download patch file Download diff file Expand all files Collapse all files

35
universal7885-common/apps/SamsungParts/jni/FlashlightBridge.cpp
View file

@ -17,40 +17,7 @@ extern "C" JNIEXPORT void JNICALL
Java_com_eurekateam_samsungextras_interfaces_Flashlight_setFlash( Java_com_eurekateam_samsungextras_interfaces_Flashlight_setFlash(
JNIEnv *env, __unused jobject obj, jint value) { JNIEnv *env, __unused jobject obj, jint value) {
service->setFlashlightEnable(Number::ENABLE); service->setFlashlightEnable(Number::ENABLE);
switch (value) { service->setFlashlightWritable(static_cast<Value>(value));
case 1:
service->setFlashlightWritable(Value::ONEUI);
break;
case 2:
service->setFlashlightWritable(Value::TWOUI);
break;
case 3:
service->setFlashlightWritable(Value::THREEUI);
break;
case 4:
service->setFlashlightWritable(Value::FOURUI);
break;
case 5:
service->setFlashlightWritable(Value::FIVEUI);
break;
case 6:
service->setFlashlightWritable(Value::SIXUI);
break;
case 7:
service->setFlashlightWritable(Value::SEVENUI);
break;
case 8:
service->setFlashlightWritable(Value::EIGHTUI);
break;
case 9:
service->setFlashlightWritable(Value::NINEUI);
break;
case 10:
service->setFlashlightWritable(Value::TENUI);
break;
default:
break;
}
} }
extern "C" JNIEXPORT jint JNICALL extern "C" JNIEXPORT jint JNICALL
Java_com_eurekateam_samsungextras_interfaces_Flashlight_getFlash(JNIEnv *env, Java_com_eurekateam_samsungextras_interfaces_Flashlight_getFlash(JNIEnv *env,

37
universal7885-common/hardware/interfaces/hardware/parts/1.0/default/FlashLight.cpp
View file

@ -41,42 +41,7 @@ Return<void> FlashBrightness::setFlashlightEnable(parts::V1_0::Number enable) {
Return<void> FlashBrightness::setFlashlightWritable(parts::V1_0::Value value) { Return<void> FlashBrightness::setFlashlightWritable(parts::V1_0::Value value) {
std::ofstream file; std::ofstream file;
std::string writevalue; std::string writevalue = std::to_string((int) value);
switch (value) {
case Value::ONEUI:
writevalue = "1";
break;
case Value::TWOUI:
writevalue = "2";
break;
case Value::THREEUI:
writevalue = "3";
break;
case Value::FOURUI:
writevalue = "4";
break;
case Value::FIVEUI:
writevalue = "5";
break;
case Value::SIXUI:
writevalue = "6";
break;
case Value::SEVENUI:
writevalue = "7";
break;
case Value::EIGHTUI:
writevalue = "8";
break;
case Value::NINEUI:
writevalue = "9";
break;
case Value::TENUI:
writevalue = "10";
break;
default:
writevalue = "";
break;
}
file.open("/sys/class/camera/flash/torch_brightness_lvl"); file.open("/sys/class/camera/flash/torch_brightness_lvl");
file << writevalue; file << writevalue;
file.close(); file.close();

4
universal7885-common/hardware/interfaces/hardware/parts/1.0/types.hal
View file

@ -39,7 +39,7 @@ enum Device : int32_t {
}; };
enum Value : int32_t { enum Value : int32_t {
ONEUI, ONEUI = 1,
TWOUI, TWOUI,
THREEUI, THREEUI,
FOURUI, FOURUI,
@ -48,5 +48,5 @@ enum Value : int32_t {
SEVENUI, SEVENUI,
EIGHTUI, EIGHTUI,
NINEUI, NINEUI,
TENUI, TENUI = 10,
}; };